From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4590C3DA4A for ; Thu, 22 Aug 2024 16:31:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 793A86B0274; Thu, 22 Aug 2024 12:31:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 720C06B0276; Thu, 22 Aug 2024 12:31:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 590286B0277; Thu, 22 Aug 2024 12:31:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 30A296B0274 for ; Thu, 22 Aug 2024 12:31:30 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B3EA8A9D11 for ; Thu, 22 Aug 2024 16:31:29 +0000 (UTC) X-FDA: 82480421898.02.B839409 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf21.hostedemail.com (Postfix) with ESMTP id 61EDA1C002B for ; Thu, 22 Aug 2024 16:31:26 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=F2sb31TT; spf=pass (imf21.hostedemail.com: domain of broonie@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724344247; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=06wKynbK/RGgk9AIFhpckcWPyf7w2IWJYkc/1KfX3+U=; b=AZ4Oi0IADY6N2KSfij6P0LngFsBNh8mBuELnwG+lNddUmFNStI21jO8a4dDP374lOvfk/t k0TCaDaTjdm5lDy8lgbDNawIJQiLJhp09ZctmwYLVTNemR3jmCwcAHUkYeJh6C0AgZ3IVq MX1Tes+UbBDLkm3+1R1sU+5dNIgqviI= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=F2sb31TT; spf=pass (imf21.hostedemail.com: domain of broonie@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724344247; a=rsa-sha256; cv=none; b=pYbevR1yjtZa/KbrnIkpQL2qMQkkMhvbpuC5BGHLeGMweQKZOBlp9/taJAwS3hcf18sJ/c 7oHSvOc9wkEQchqYZgNF/+kZtxbuwBNBOW/fkOkAjpzChuPkiqQYaM0ZOu7OCCpGsOPFK7 jjia7yJzqhUYkem5q8tDIEESgTUsj64= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 08F14CE1009; Thu, 22 Aug 2024 16:31:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE19BC32782; Thu, 22 Aug 2024 16:31:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724344281; bh=VUg12QjX/BWOxsree9EbeHZn9D5q4/HlKniQvKwsUbU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=F2sb31TT5g+PjzoVukTl5h2JEC2kDVdeg7nBVbMScaaOxvPYuZaHoYkcfKlUrUN6P AsOCA9l6P8infkmm70iBiMvW5dIOERWTQ8DWgNjEJ1ThbqA6Fv7I1JwDLV62zQTukR uIUy7TwBZwgBqDx4i5WNaOdUnD5Ns5bWM3tkoJsQxPJn+hwFrG1SCONKmCCEv46TzE fs6z5etBnMVissxaHq0/baQA6bOcLp3UsqAnuPSFdRIY8bItuV+mwfw3Wdd9CpGsq2 yFY4RK6kS2DDKBKyuZ2JhCcjro00ziexgiXQX3Afzbgxj66BCLhebdtOhVlwV3XTrI yyU+GaGQKLbuQ== Date: Thu, 22 Aug 2024 17:31:17 +0100 From: Mark Brown To: Catalin Marinas Cc: Will Deacon , Jonathan Corbet , Andrew Morton , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Arnd Bergmann , Oleg Nesterov , Eric Biederman , Shuah Khan , "Rick P. Edgecombe" , Deepak Gupta , Ard Biesheuvel , Szabolcs Nagy , Kees Cook , "H.J. Lu" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Florian Weimer , Christian Brauner , Thiago Jung Bauermann , Ross Burton , Yury Khrustalev , Wilco Dijkstra , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v11 18/39] arm64/traps: Handle GCS exceptions Message-ID: References: <20240822-arm64-gcs-v11-0-41b81947ecb5@kernel.org> <20240822-arm64-gcs-v11-18-41b81947ecb5@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ewesK6QkmZD/wpzC" Content-Disposition: inline In-Reply-To: X-Cookie: Your love life will be... interesting. X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 61EDA1C002B X-Stat-Signature: 93c8sj1yc434jwii7cp5r63gmzsqigpo X-HE-Tag: 1724344286-229819 X-HE-Meta: U2FsdGVkX19Ow6Md9L0yr8FMXz0S0HZFXTNDAIEtpcEvmFzFzgR7QkL6OlGH3yTY3v9hK2SnAfov3hE77/zLKmKVvkgqNzeFU/KyyJQGpwLl4RgiCDk5VglJBwaO7fBgr8vh37LGk6SoqoqqBzkgB11gBNfQwUY1/1RZhjR8guZkqCydvYVqvUB8kCGpkPrXcgkP/rmPBJVvwGitZWU94sqbHozmaccUuAzZD9P1q1q6Bj2PJVFRumcP5nLwBUTMH+c4UcIHTF6YqhcJ3jWZKZT84872XoV5A5vPe7sBsntrPTPtDwNEPfbMkefuBq3SLsxH1ohJ5PqWXaxPurXKG9QWtkOAhdMamKAeieoJ6TPrm9JAOfWWd9cYFIOhhGK2rsa/PTkU8wKch4Ej9BkVQY4qRGR//xxRS3zfalf9Zfc6wU4ebsiUMelirF6h99DcJu8tF6XzZ6JfbE1J01krr3YaKbDJt8rATtqL2Hm276T3C8wviU+DY0u2lisjjvDZDJtLIhnCZeoRJ4FZWMxmzu+N6FTsFHQ6pzwWtWBlcb6KwK0dUagtZoie8hOt0e34KuOBBVpJrgCb+f3RMAkhk9qEfRmQmPXmrSkhlSyG5/XA/bzCN0B8kH8Foy+OQ1JGvrEsdMQxR5BIwNNhEv8I9ZaFEPZa+QNlQnnvvzzOIb/vlz4ytGE8EcyNOsAcEQSTLKjdqXZhLGluU+oM5iztcsgUsVe2BlYWyKr7mznXFtVYY23jMiZgGL64yd6+77JLys2I6hbSSjSA5k/iYfpvmhvSJ3JkedB2feMyKQO+9jTB8BCCvvV8S8aMgE357EIz+w97BT/CnDFsLnpiT6NE3yCuraP46z+AFgTdWyQPaL4VdtVy75vPpB5GIuQZOQ4mLRQ/T/7omSL3pRwONRfgrnyAuNfx7DhstUY19a7GyS6Kdeigh0dRZnNDfOLGbsxWB8Wvy7nzgKABJX3DJf3 x4EC2+YL /CnJJwPJbabFAvzkYA7ke2wvK11+MOcJETj84TNq1fA7BCMk20/SVA0VpWaOeGrTrkpIppRg2aKIVfEC1rbDOYE5DVmPbbiMwfC525FH4E+YSxHWe/91QoDMlc7TwiZNxkCq6wwS6cgHwcP+r+SWT9kV90Lfe0iivp7Nlg3KFeBcn8Lli/BWnozx8RBRQkVt9CNB1NFjRviEb7Up0xK5yGDwXkXvJX7pgHQ76IqEjrjYCLL+L4D8epzer8U6LXAYq4fTGcqtCAxQXt0OAvqRz3dAJGL6ytdH6e+6Yn0sKHMoJuHkmIk1yN88FnKA4z58fkwnliV57Zx0pPt0Jga9Tyhn04cSZAX3hI/69ftlymkUNQO8O07HC6KnBB5NgLAXjixwd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --ewesK6QkmZD/wpzC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Aug 22, 2024 at 04:44:12PM +0100, Catalin Marinas wrote: > On Thu, Aug 22, 2024 at 02:15:21AM +0100, Mark Brown wrote: > > +void do_el0_gcs(struct pt_regs *regs, unsigned long esr) > > +{ > > + force_signal_inject(SIGSEGV, SEGV_CPERR, regs->pc, 0); > > +} > Just double checking: a GCSPOPM (for example, it can be a RET) from a > non-GCS page would generate a classic permission fault with ISS2.GCS set > rather than a GCS exception. That's my reading from the Arm ARM > pseudocode, the text isn't clear to me. Yes, we only generate GCS exceptions on checking values that have successfully been loaded from memory or other GCS logic errors - memory accesses generate data aborts. --ewesK6QkmZD/wpzC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmbHZ9UACgkQJNaLcl1U h9D9lQf/RHcsNQy/AveAnVZZzgRTxMTttaUD1tUEFeexMusqT2Ar0MqopzgIKpam lu4zjPI6W5uKaH9xBTV9Rpx//q9HIzraNH4NL9kJNl4NiY+04Y2QMew5hXyC4Qlb bRkNLFpOdr3kWhYEizRFaoZoT/A3mk/Hml4UOB8SVQmGkXmizkEPy+z48sUlWHfQ VsDqfKBBnFOkIz5rYVMZP9g/Q6uYE5meFpo/sTWSP9X8S9XUL4GOLpassoZA6vPq quUdPJfme+jeZI0gN9Rpuktzc6etbvVb5I/pf71dk+Zqr/hbgAaa+gmdQQsOpYdU K9DAZ5xndPmiuX7YI36ktz2o2+0STQ== =iVqg -----END PGP SIGNATURE----- --ewesK6QkmZD/wpzC--