From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21E73C52D7C for ; Thu, 22 Aug 2024 16:24:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 873836B02BD; Thu, 22 Aug 2024 12:24:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 823176B02BE; Thu, 22 Aug 2024 12:24:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C3956B02BF; Thu, 22 Aug 2024 12:24:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4A87D6B02BD for ; Thu, 22 Aug 2024 12:24:44 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C11C4A18D7 for ; Thu, 22 Aug 2024 16:24:43 +0000 (UTC) X-FDA: 82480404846.04.9740DC6 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id 0F801120018 for ; Thu, 22 Aug 2024 16:24:41 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Q5mqUunk; spf=pass (imf29.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724343841; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g1AG56iorEU9dRH4UCfaeroiMPe3vT6TyomWC8CiwkE=; b=ANCWDIzH/afJqD5n+Y6R8JTtHyLLA5yeMeLaT2B+OWcagrXOWVsjRcWsGvuFqWfk7xHKtP uYwGG2A8rzE2wxJ6BsfwbnjRTGVNUm7igSpO/9LApdi+YsFn3IUZYnHfKKzJD7reISDYF/ GKU0N2N5+vwnyvUStWfDy0PLX7NeWpM= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Q5mqUunk; spf=pass (imf29.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724343841; a=rsa-sha256; cv=none; b=r1GwNF6E9aLxjy41/sJxEBD6K1+CwfOiWA/8GPE4U66TjMKBB3z1RRx9AzC+RhqGfCr8ym nO4hEr53965LIdT/E3WCyK02vT29aHsUWqazVhjB1eg4qGtGGBC7/5A2RlzyCiEeDZAfAx dpVLifojV98L0oidlTvK6zllNGUk7DI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id F0522611C5; Thu, 22 Aug 2024 16:24:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21BE0C4AF10; Thu, 22 Aug 2024 16:24:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724343880; bh=+UYr1EMbxmQcwL8f+aGCf7y/v2m/OChUZcEGlURHIO8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Q5mqUunkkDfgxKkhsWSbZZ4bvlykv/a1Lf0TVH7BJZZL2anFRHs6IiIw4LSR+MngM UwhWBH53191BOM4l76kFFpFjR+yNjnHX5b9U60zH9p5m3yL5wTLwKAXccT7v8Xj/4m GE7T5BSenuI1dBEd38ZHv0OGdnbzWIYt8/lvkd9xnedhTNcEzQIGO4vavP16xmZVoM pdOP1dObNGxQh4/QJ3zP/rRFw+yAaqk3mCkPvi4wP2eYdGyZ560g7HhU+ja2mq6Iu7 KOJBS96PBxgSr+B9/o7wIywbdg6B5nYDnjWYDe3qZWoawc/ydUnvuuafFbZuvNvr13 6aiGRQw3qejfg== Date: Thu, 22 Aug 2024 17:24:36 +0100 From: Mark Brown To: Catalin Marinas Cc: Will Deacon , Jonathan Corbet , Andrew Morton , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Arnd Bergmann , Oleg Nesterov , Eric Biederman , Shuah Khan , "Rick P. Edgecombe" , Deepak Gupta , Ard Biesheuvel , Szabolcs Nagy , Kees Cook , "H.J. Lu" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Florian Weimer , Christian Brauner , Thiago Jung Bauermann , Ross Burton , Yury Khrustalev , Wilco Dijkstra , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v11 21/39] arm64/gcs: Ensure that new threads have a GCS Message-ID: References: <20240822-arm64-gcs-v11-0-41b81947ecb5@kernel.org> <20240822-arm64-gcs-v11-21-41b81947ecb5@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cphCPo7ma/MLqBWq" Content-Disposition: inline In-Reply-To: X-Cookie: Your love life will be... interesting. X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 0F801120018 X-Stat-Signature: gnfz8i3rtjwzti6a9wxrzz5rhrk31s1u X-HE-Tag: 1724343881-925643 X-HE-Meta: U2FsdGVkX1/5hYSZ+DY1rRTNXoUHzhBLxgIhXCD4OPnrEsiaFHX9v75c6nXw+L59VgoaTsY2zVlm8pciroU5vy3sQ176BiRq5FocxRrSH1vk7GYLHOmrwIACRVXFc3+WbLDrn3TW6+OmFCyszZjIc/AvbxcuB3qPJN6/lmkoO5+UEBpIeiASNSUxK1OOoReh9B7Q8z+vtSAkbf29ENaTi5PWRTo05lFc84IFfKunRvB8TE+8MIzTZaqGfDV/zuTzDO6EXfdCD4nlx3hjB777owFaSGc0MxrONICtUH4NRUu0Ua5MbakdZuyD8gqmvNNaVawFqXJ8296IuYuk+Gk6kkd57ulpXsY7zmMZiBjFqluGS5P7SiFsjmH2PE/ndGrMUdPDFMWTApbJ7DRfLuI70UU7ymQ/YiMQJ5LSILXn/JxaK4WXlcLlu27zK3ncWbTruvt6wxdfA8WT01GJqnqYgzsp8B/bZlLsKBF6wdroWRwaPnjh/kKS9yhOavHT3rVGz9Cg82kdLiCuM9oVaND7ar0cAS/VCjzsNgzzV+6tgL2+HVRovUIxWaolFuWzOrH3tWO9Gxea0PudRz2kecI1sqbQPfwCR1CydgGNM/v2SE1EB9lXj10m+lzaP/tGVawaH5R7ZsLnrBPgXWckxhiM4mY3WGJcOeRCmlTXu/DvxcmJxO598m+4DH4rnwQtjF7PlM9wRTYv9/JTOeJbX+fr7Obz9ERxYbkhq+M2dm6Jg6rsEB1ooc2vLFjS4JGc62oN3fqRM6MOdwHTAkLRxy9xXjZHbGr7Gf4KWZ/tbKh52TmO09+lEFhE3257TpYaFm+NDMYr56MGXKilhGsI+2hJ1vvwi0qD0fT13ZY41M5Y9qB5m16MyDRFe0DI/eLi56b+3VA8t5iy3kgKy00l4lq+S4oK30KvS3ta8bOQwl3FQiYuJOwjNe11zj8vVqoktTSc55t5ODmEbhbWa6iohf7 BWMx1Vbd OQQhg03j3Hli4zxTMuH2byfJoopkS9IbxhzgAErUBMTVsxtGS3rGpd15SeHDy+bQgGpcqJoh2g3v4bs0sO6clWlWd/nS2jmK5Js5WpLlq1wruBh6X8PLsJiPACHc2OvHi2U6WwklP77NwVmV6jDMhtSr5jKpgKaxF/vYJPqUjG2ymXAX4xed88WHXmE2ZFwiUvSLy6eyj9LZkjz5zti+l8Z37WbjAjeHG7b4XECNK7aQSVjjQl5p3DBD7WVw8vJyDriErfTPX1Chu2fgMiIqusmLl1eR60/O2D9R6JefF1UNOJil9leJJy6TOoxgnLrZ3Y5+l12ukjF2p6lwiDU3YEnfCPl1PHZ928YFHEdKD7R6zf5k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --cphCPo7ma/MLqBWq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Aug 22, 2024 at 05:17:14PM +0100, Catalin Marinas wrote: > > /* > > - * Ensure that GCS changes are observable by/from other PEs in > > - * case of migration. > > + * Ensure that GCS memory effects of the 'prev' thread are > > + * ordered before other memory accesses with release semantics > > + * (or preceded by a DMB) on the current PE. In addition, any > > + * memory accesses with acquire semantics (or succeeded by a > > + * DMB) are ordered before GCS memory effects of the 'next' > > + * thread. This will ensure that the GCS memory effects are > > + * visible to other PEs in case of migration. > > */ > > - gcsb_dsync(); > > + if (task_gcs_el0_enabled(current) || task_gcs_el0_enabled(next)) > > + gcsb_dsync(); > Ah, the comment turned up in this patch. It looks fine. Oh, sorry - I should probably just pull this hunk into the other patch. --cphCPo7ma/MLqBWq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmbHZkMACgkQJNaLcl1U h9AXTQf6AzdK45ja4zPd6pOLOLIMS6ytyzho0mtx63LPWkg3eGQA4Jllqqgf/Kpt lhMuC4Cc1DJw0Flz6uHop/VNpp/EqYDexQY9oKRVaMjgndRtvYUnX5FdleS0/gjd V6Ap8KdW5YZjNzm8Z1n7LE0g0TySfxVXr7Dwlo+e9XiB+Jp502hXQoRw+W7BCmio VpYUTnm+gt05lzMZEo9ps1iOOzTfYOmwEjiCRuq0fzFrgW2hN4AWoG+ooxmG1YJc BWl2k7dfQSfHFv7y+1ywHglWgFzkWYN1QwQY00OatFCf9MPIYGiTj1Oml5+UTP+o HWP0UgIWgVuH85MHHUY67CCKtRcS4w== =N19k -----END PGP SIGNATURE----- --cphCPo7ma/MLqBWq--