From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3D8EC5320E for ; Thu, 22 Aug 2024 09:28:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7CF4D80024; Thu, 22 Aug 2024 05:28:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 753958001E; Thu, 22 Aug 2024 05:28:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C72C80023; Thu, 22 Aug 2024 05:28:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 388E18001E for ; Thu, 22 Aug 2024 05:28:10 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B0872414A8 for ; Thu, 22 Aug 2024 09:28:09 +0000 (UTC) X-FDA: 82479355098.17.F682C82 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by imf07.hostedemail.com (Postfix) with ESMTP id D81004001E for ; Thu, 22 Aug 2024 09:28:07 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of breno.debian@gmail.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=breno.debian@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724318806; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VN9jzH0UPOapT4tC7UETUW4m0uJSfV3eGL/eBKYPOfY=; b=1mHs7yGqYF0Ize8dE9GeKKVUZwWTm9HB4fKQDX8z2liIhAkBOYDAzIWxvKlysQxAWV67t1 iDkCsN8xL+O23n41Rf6PcTUgYh5g0XWz6oEFd99uEipL3Ybi9Zr+gZSO9s0CFfdTqFDRSo X6/lx5GRVMHpu2IlHFb6dcqcsITJLOA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724318806; a=rsa-sha256; cv=none; b=wiNdfUIk1xz2WKDHbqYvI3v75BCZ6yw1diXYpKURTRWlIzPk+g4Oo4ozvyV5mEpQGTrnpA VPwr2bl5HrkgMluE5a0ftW7KffdwbWyZ427cPg7bj7hG4t/UPOgD1WTMbQfIfibDFLMvX0 EqD63Cf+qOFbl3HiVC1P1FtqkgLVKe0= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of breno.debian@gmail.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=breno.debian@gmail.com; dmarc=none Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-5beb6ea9ed6so840785a12.1 for ; Thu, 22 Aug 2024 02:28:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724318886; x=1724923686; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VN9jzH0UPOapT4tC7UETUW4m0uJSfV3eGL/eBKYPOfY=; b=po75Oq6C5tMndU+NOp8b20g5oCm+7nb/i0OwYOIciYoOckDriqLL27oBNuoOYVTH0j wK5hrKmQpenHqkqpGaYVIVgbc3rA37IE0g2Msro/0vuKv4gkTuUCwn847g6v0wsbUiv3 j+7b9zodYspPfRxK18pcuiYbu+yvPrUAQrWZeSnZmdD9EdEsmgUDGDU7sLnC/MOS6GXk 9GKVE90s+1JuLrVA8MRyeKV8LdzWP9iSiyCxwy/X2ePW818qVfEKg391qgfd76Ca7fas DLtkMlNnHZKXJ0H5Qy0v5xJZw0S+mUUuI/kUGAsdSvdggpdjxaQwRkOu9GBWXEC9X8tM B6jA== X-Forwarded-Encrypted: i=1; AJvYcCWLopp0zmyb+QzZL4fKvCMPWRnCh9+tclO18fsPOe20rSs2KDc7sjhxXWLd0JY8EwlTBDu8f91WVw==@kvack.org X-Gm-Message-State: AOJu0YyNG1mlRIbHf+uGSQdhHvYtrcQ7PUoytgF/tvdhQTnvpmvfTiRU 06nr2cPFbB4G0RHuJGCeAmOz57Ujj+8ZJDJBngMU2/HR2j3vuqxj X-Google-Smtp-Source: AGHT+IFEITUubqeCKs3SGRzcXStT+gGxDCeUKCXqb+5lEZiNZgwZx4Kc4+rknA3R/wvV1KzdEn9Mww== X-Received: by 2002:a05:6402:354c:b0:5be:ccde:c433 with SMTP id 4fb4d7f45d1cf-5bf1f25e4bdmr3098395a12.34.1724318885778; Thu, 22 Aug 2024 02:28:05 -0700 (PDT) Received: from gmail.com (fwdproxy-lla-008.fbsv.net. [2a03:2880:30ff:8::face:b00c]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c044ddbef7sm675537a12.16.2024.08.22.02.28.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Aug 2024 02:28:05 -0700 (PDT) Date: Thu, 22 Aug 2024 02:28:03 -0700 From: Breno Leitao To: Will Deacon Cc: Mark Rutland , Rob Herring , kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, catalin.marinas@arm.com, rmikey@meta.com Subject: Re: arm64: Kexec: Warning: virt_to_phys used for non-linear address Message-ID: References: <20240624113614.GA8361@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240624113614.GA8361@willie-the-truck> X-Stat-Signature: j166zzmkb9m5myrsw9zfdsb6cqhk146p X-Rspamd-Queue-Id: D81004001E X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1724318887-888733 X-HE-Meta: U2FsdGVkX18tNQrGwmaP5FPnEqttZkeuhHSdqrARcu5gOdibZTuLY98nDmGezYjWW3X7+d45V9m85OuetnpEcN7n2HVx2jUkyUm6LGNv+IPwkpOINd/aB3Yx4Nxfcb/uQjfxG5UMuOPocsaTNUXqysaI3pMOPdBP0wCrRtFoBHXVd44fguC5MdIp+ySZ9vwHRvNqkkFSvhJAI/7bs2qW5Bn8LDMxulMl4N4l1vG15KbzolANaXnyv1hwFoN8zkWcmyF9hDcOhQLnui8KvnIwuymxKSjwIZ+wyWb/aAES70Md6s7NTnI/Omokpi9O2a7/H+5vQ+GyDl2cl0qk+2XtvziIZP7gOkV/BfIeyk4FMXvKqsHYyvBo3gxcG3H3GRcy+LV/Mb9L/aOG0GNZZZ52+dMXK0Ujo9JWFvrILSteaWC0E+NKtONdrIxJ1jw7DkcvXsKa9ZMsQrOkeAGXOcrpwrYziZ2/dBX8VvYC+8wpKTr/6Wz5qC0YRecKOlIjI1gaS7SjYw/Hb4IsJjElFewnkIxotRZ2pEx9DD2q7n2M25F/nxqkQSP2yehJZnEvp3GEx3y5nJlk/qJbk1YEjca5wzLDYxFAAEQRontNw2YrTfteBXJtXCHLDIlDkqJ8ZNRCje+IUasOLYIReLqnsri6ZQ/ROIH8/wf6QKgaJzonhH5oLxxL7GiwBdCdXF9Q3w/nt8glU+LtBep3sa1I0Ojlo6BM3T9TRQHqdeK9fYxqENPT8MbA1NZXPyPwYWjAlmW9zefl+pdOapegmd1HKu9b8/3mq+g/8Zz3dt9glayc1CWfeSDZ8EXp438ME55p446Kw8cXpJAeJYJxZ+qscalXq0uVkqbIOXMSA0F9F5Y3UUHAMe+BJ5UiAGI5v2JbGpIhpgoySrHSEoGNBOefXJAjyUNVqxFFVlW0fZecpEiVMlPmNKwe5xXA2hb/6gBz6UHmyUVguXHbx1vqpbLzGxX UDlRBhOX u3R246RBSpPbAzPLJxbOUVGIcU2lDSSIUJx1RTQzJsJKkRHaRsAF+3ewkX5FoXEjJSkZ4XyVtgpgRjswopI273KjaHc/f5ROsJNK7mbqsQDW7TxsW0wEEwBZ8aIcHaDL5VcbS+uQcpFl+jA5JPp3tknVTPcOStQcoQ4rtcyX0kFaeWrmK0kP9SMz6CUBzNFNnW9bRM98TFusSPV/oBwR706yB3UOw9X0+1rJAx547rfusWtwTaRb4yRXgX42ZxTyvHHtQPKzTKgL4s8RIvWrZvuZZtc0FEfgf7WijQ5mf1cvnkWuA20unZGqucwfAvSHZvs8+0OKHK6JWkE6CFfOQd0YaLcdlh36VLneP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 24, 2024 at 12:36:14PM +0100, Will Deacon wrote: > On Tue, Jun 18, 2024 at 12:36:03PM +0100, Mark Rutland wrote: > > On Tue, Jun 18, 2024 at 01:49:22AM -0700, Breno Leitao wrote: > > > Since __pa() is a macro to __virt_to_phys(): > > > > > > #define __pa(x) __virt_to_phys((unsigned long)(x)) > > > > > > I am curious why this address is special that makes __virt_to_phys() > > > unhappy. > > > > It's a fixmap address rather than a linear-map address. Confusingly > > 'virt' generally means the linear map rather than any virtual address, > > and usually virt_to_*() only work on linear map addresses. > > > > I'm not sure how to fix this; the major reason we fixmap the FDT is so > > that it can be anywhere in memory (and e.g. may not be in the linear map > > at all), so we can't always generate a linear map VA. > > > > We could stash the PA at boot time, and pass this as an argument to > > of_kexec_alloc_and_setup_fdt(). > > Yeah, if it was passed as an additional argument to early_init_dt_scan(), > then the core could could track it. Alternatively, we'd need a helper > macro to get the PA and have an arm64-variant for the fixmap (everybody > else could use __pa()). > > > Rob, any thoughts? I couldn't see a neat way of doing this, but maybe we > > could initialise an initial_boot_params_phys at setup time, with a bit > > of churn to early_init_dt_verify() and friends? > > Rob? Hello, is there anything I can do or test to have this moving? Thanks