From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D098C3DA4A for ; Thu, 22 Aug 2024 06:14:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 40A686B0261; Thu, 22 Aug 2024 02:14:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3BABF6B026A; Thu, 22 Aug 2024 02:14:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 282DC6B0266; Thu, 22 Aug 2024 02:14:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0BA4A6B028F for ; Thu, 22 Aug 2024 02:14:38 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8052D1C06B0 for ; Thu, 22 Aug 2024 06:14:37 +0000 (UTC) X-FDA: 82478867394.18.DCAD3D2 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) by imf11.hostedemail.com (Postfix) with ESMTP id 85E5B40002 for ; Thu, 22 Aug 2024 06:14:34 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=UKHhvGx2; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf11.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.43 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724307215; a=rsa-sha256; cv=none; b=r1OIhR2o+4U6CEx/+keNmppU4zb+ADx4zB1QETJMgEAjNiwJiJnfZw8sJQwrlyQoaOx+h3 h4rD1RSaSwLSRdWs2mcu5FINbbXMcUr3z8uiVHrblIL+cwtSoztpIKcpTNeOGcj7ru6dt2 OX3a6j7wwyAnlgiEHI4gcB7hmRiaTXE= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=UKHhvGx2; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf11.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.43 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724307215; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZPEC44IJXWEDzAV+m0lCiYSNN0EEVhCrFU2ANliNvBA=; b=wIHfwsf6LWUdKm9L4LfCDUWyQjgy93C73RH3qupaDckQ1wtNnWHoyj9e3mCHDQB70RACHK 9DP4d+RP4KBBgR+0gqDK0VTlROGj43X4rF0MZwosvX5IJXqZfczxb3t6+4cgSKu8aCbSTY vjb8zAzolix2UIm3NVVZAMqBDZogpC0= Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-5bebd3b7c22so2477325a12.0 for ; Wed, 21 Aug 2024 23:14:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1724307273; x=1724912073; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=ZPEC44IJXWEDzAV+m0lCiYSNN0EEVhCrFU2ANliNvBA=; b=UKHhvGx2RwM2MdW1LFo3129PzlXIGQvVLof5hVIrmwB78BskSuGXNG0vmnFFUwTc2u S4AlH4mqgqmVHZWQxEeV40fljTtPeGsERHE39i+qVngh51XGefxML0WaFpvid30VhfZe k3SR3xXOVSkA4acoJy9VDV2M2slOTknhGPic26ba+yETvuqvYBi/+gBKA8jZuIUC7lS6 jRun681ng6OuSAqGJBS1fiYSLb/ab3fSfN0BL5Ed1LWSSzhO8sdmyZUPD3edPso7hsiA IsmKR4Hq34zDAS11MyUuRRnxxXW9BaqbEDxgGa+O+0X0PXlZvqxMJIw3zZ1TUL0H43Sv lH8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724307273; x=1724912073; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZPEC44IJXWEDzAV+m0lCiYSNN0EEVhCrFU2ANliNvBA=; b=F1dJ1v6D0+d9/t6AwUgTC1hc1AryJGH+Id7bhLugheZL+PiPEamMIcm/o61UI0Am0B ruSP3Ttf9dlOWxXYSsSaQXcMf4mH4rhlyseqwFFeYirnGaYhM6qdrRdYrzGiwbQkTdPp VVUv2TUo/N4Wi4dGfv/OJK3w8DV8D4gtzH3vQqnVy3nWjfiqP+rE1KGSzQt4TMFQOs1V txkz3rFXI+jhUb8wulYDwT8nti4fK4OSarOg0r+21TFoqL6hYr3j/QbFm9YD8xp2THuP Ldd5BB0WQC851kjSVRpD28xfhEBnaQ+Yp7EvbvJz3TsHV7OUb8Jd9Dx1UPnUar6g04Vx XOYQ== X-Forwarded-Encrypted: i=1; AJvYcCWJSagq7BVdaoF9/DdVIJa9ls9B1dLPuMQMkyI48T6XMan25E6UeeoQChea6XVN7vfOi6lmtsX5pA==@kvack.org X-Gm-Message-State: AOJu0Yx7u8Sya0jaEaOic5otLxK4NTwh942xnRMq3qDBOk/2NgRu9y9u TFEzVud7pFhqmlxZvXAbnilnwImEBAZ3bHYH84v8ReKIhuJ0PkL8uaGp/+Sk7XI= X-Google-Smtp-Source: AGHT+IGoLzPDcFTYqAS6S4eK/IBENCXHYmzic40/YCA5fIAJ5izoag2uuC/jERmcYTsVI2KRI/6zOw== X-Received: by 2002:a17:907:7f25:b0:a80:c0ed:2145 with SMTP id a640c23a62f3a-a868a7dd834mr186424866b.2.1724307272752; Wed, 21 Aug 2024 23:14:32 -0700 (PDT) Received: from localhost (109-81-92-13.rct.o2.cz. [109.81.92.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a868f48a5d0sm65466566b.159.2024.08.21.23.14.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Aug 2024 23:14:32 -0700 (PDT) Date: Thu, 22 Aug 2024 08:14:31 +0200 From: Michal Hocko To: "Sridhar, Kanchana P" Cc: Nhat Pham , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "hannes@cmpxchg.org" , "yosryahmed@google.com" , "ryan.roberts@arm.com" , "Huang, Ying" , "21cnbao@gmail.com" <21cnbao@gmail.com>, "akpm@linux-foundation.org" , "Zou, Nanhai" , "Feghali, Wajdi K" , "Gopal, Vinodh" Subject: Re: [PATCH v1] mm: Defines obj_cgroup_get() if CONFIG_MEMCG is not defined. Message-ID: References: <20240820195005.5941-1-kanchana.p.sridhar@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 85E5B40002 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: m6dagqqjkfb98smknektzjhkoi373tgy X-HE-Tag: 1724307274-887238 X-HE-Meta: U2FsdGVkX19DufoOfI6aDMHaXfPRBU710jrJMKNPQQ/OfVMCvnSgdyde8zfXVMf6/zmZx+l236UjsahaUF8+xdhKQXpAMxRdOWY9eQirU7IXzz3mPb/q13apCihOBV1R+6NCwBk85Cau5Qn4LOky0aSlSVW6zYN0ZsgwZaAvsNNGQOUEfTnlGQpG4JGfaOkBerYUli7poSNjtG7iA8taMBh7k+mCHrRlaEAkEjC2l0Km5G7W6Od1mgTephenKZ1lvhmRnkH+HL3Fkgf1EyNZzVFvS0MH+YlMypIfLpEXkgwi4spfiuPUZwhEONQdV7pvT0CehkpAfp5W3J4CNjtBRQPOEgB68YHgWoKYl9V7dNAM/NBh/mxhVbTgroOj7JMPvv1A+AZ+A0rApJHafjZ+0F1AyEfTH6+I32kqMqo4XCvF+q/oB4RmuouUejvz3B3RPEy82jQDwbNyX5c5a+ZJzg1RDclniO3QHtbeComPSuk8Ic5b/T1OMYy0titaajA1u/MK0YynlQ8esvaIc/+n402LBFSKxwtlOxeHuYvSKm9Uy9gwcp0V5OwdPqhW+NBLuwFtZxYHVk5kBL1gbA1bJd4wN80V/fvmGsmTY+2fgN9MBzCe4khOVRgFFs+iCjHWUnInKyQryiiggEbr1fJxvfS8PTGEpjMVVAvPQFtAPasVlE9DGXlGeSXZuk5NkJhq9O6gxUcxuTro69fOGH6TMwH6jJYEU8DaEv3rXoySO+qgLj1jrrS4jvPBaF8u75mefMTpk/3UJdnLBlAMJDXLu3vInBhBVuPghy/ZRbDMAf2HShV2KE4cPIDZilz7+xK/WqejmtcnKV4Ce4KHlHo9+Ja7Rq94DtDqT0kJg59RT76S99FiOJFas2B0ndXJ6Z3R7S+W6WlV2mQMqCkupETtjzxyH9ckRlN8JDYJNjwxHXnx/q3b27HB8IxDAZVPsSP6eVt75pF04kcRo+GdbYC QRxHi53O wvMbQALBdWivml3eMNh/X4rL92i+GROyWUZbnRqaujiMi7/XMOrEZpiDXEVNGrsWb7/Vz/W40p+gam1YtSFpO/iUZFTNYLvvdbkBTAai2TuJpw2Os4WC8ZSWn5AFqV5ZAgU4T2F+N0zPruYDdZXFkUC/E3j7ZNXCsDD6bpIfWIGZEGBg6Xh5jX49Mq5P3DAiFNYhaZ9on0zG9554xvS4O+F3wKREeaW1vvL41ULKOjyPaeDI1IwOQ+k7iVQNSFBc+5NhXgaEH/WyRWnqI8uF3AQiygXkogIoEsDVfMSdugHDJA2rhhOkoMgC62C21lmHnkkyeE+FLy5UWJJgD7D+4+++eVHPlV6w65CbbuPK6Sgsx4UsE91fGOENqnwvID2YUcOHR4ZdYrKLFnnZZI3ZP4/ROkPt4SrLZ4DI2I5fmQvvLkSQRO8tH4oVWqadQ91zf6v8xyIFBZtQuONPIQa3K3WAuDuvyBLmT6RJBnAieP8Q0Frro56tGqX8auFFpoNDHI7eWCqSvHKMyFUSrhTmJYEk2UNSSwPTHy37jSSOTRGEJJMy6ODTH8ududbjLM+mclqkeKN4VFZoD3TVlYQDXZoCRCg8/jBE7C2rnK/lNharDgGmXy7PdSSoQ+wwb+gcgc1GjEc0ZcVdyyfGPo5hZexXyydcavJSx4UbRfRMmnGOlW0XiFqqGKhesznOmKc3LTAZVjEapzPQvVtNUreoA49pzSbk+ahNFmhd13X0Pig1d/GcuZP5eNhmA17l1qtlZsZ6x X-Bogosity: Ham, tests=bogofilter, spamicity=0.001568, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 21-08-24 19:40:42, Sridhar, Kanchana P wrote: > > > -----Original Message----- > > From: Nhat Pham > > Sent: Wednesday, August 21, 2024 12:24 PM > > To: Sridhar, Kanchana P > > Cc: linux-kernel@vger.kernel.org; linux-mm@kvack.org; > > hannes@cmpxchg.org; yosryahmed@google.com; ryan.roberts@arm.com; > > Huang, Ying ; 21cnbao@gmail.com; akpm@linux- > > foundation.org; Zou, Nanhai ; Feghali, Wajdi K > > ; Gopal, Vinodh > > Subject: Re: [PATCH v1] mm: Defines obj_cgroup_get() if CONFIG_MEMCG is > > not defined. > > > > On Tue, Aug 20, 2024 at 3:50 PM Kanchana P Sridhar > > wrote: > > > > > > This resolves an issue with obj_cgroup_get() not being defined > > > if CONFIG_MEMCG is not defined. This causes build errors if > > > obj_cgroup_get() is called from code that is agnostic of CONFIG_MEMCG. > > > > > > The patch resolves this. > > > > > > Signed-off-by: Kanchana P Sridhar > > > --- > > > > This is only exposed because of your zswap mTHP patch series right? > > Could you include this patch as part of that series (since we don't > > need this without that patch series), or make it clear in the change > > log? > > That's correct, Nhat. Although, it might be useful to have obj_cgroup_get() > defined in the case where CONFIG_MEMCG is not defined. memcontrol.h > handles obj_cgroup_put() similarly. Would it be Ok if I included a reference > to the zswap mTHP patch series in the change log? I would just fold it into the patch which exposes use without CONFIG_MEMCG. We currently do not have any such user. That's why I've asked what is this patch based on. -- Michal Hocko SUSE Labs