From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 877C4C52D6F for ; Wed, 21 Aug 2024 15:11:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF6CC6B0107; Wed, 21 Aug 2024 11:11:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EA6726B010B; Wed, 21 Aug 2024 11:11:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D6DA56B0124; Wed, 21 Aug 2024 11:11:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BA81C6B0107 for ; Wed, 21 Aug 2024 11:11:35 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5975140E75 for ; Wed, 21 Aug 2024 15:11:35 +0000 (UTC) X-FDA: 82476591750.24.86D1191 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by imf10.hostedemail.com (Postfix) with ESMTP id 3FF62C000A for ; Wed, 21 Aug 2024 15:11:32 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=NUv0j91v; spf=pass (imf10.hostedemail.com: domain of mhocko@suse.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724253030; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pWqVOnOMPwf1aUFvCVrFf4VPqF69Ewf7zmbruNVrIBw=; b=aIG+jRVRHTuzOATFPlQejS2K/JcOfJIi2KPv7jJ+jF8dHvuXQtQ2m/ipxgmhrMGerChjMx DAuqDqlAdo/UMzjswnCbNvaKZtDFdGyqon3Hs4H8P1Dc2Z81pcK8vwp5rY/TduO6zb8A6F tKUGgW1M1mW+Ssgkp5TqZwfRcNQPQZA= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=NUv0j91v; spf=pass (imf10.hostedemail.com: domain of mhocko@suse.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724253030; a=rsa-sha256; cv=none; b=Sonce6E+NT1GLhnq/FaVdG80+WWeCAkVZEEATbPjeOFeZExJ725haWf+PupekECM7XI3OT W5ORTKmsynWEVGaPKn6FHvuaKtv3SXS3gRy1uqbkg9d1Oi4pOkVIG1H1QANr5nW6P9loKl O/F32KKdCojQnlpjn93/eEYvOHgTiGU= Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-52efdf02d13so9123471e87.2 for ; Wed, 21 Aug 2024 08:11:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1724253091; x=1724857891; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pWqVOnOMPwf1aUFvCVrFf4VPqF69Ewf7zmbruNVrIBw=; b=NUv0j91vK4hMj/CbXnC/GfISgykbZRo9/NiPMvkVYF4sKzu7nHedWVpaMoMmzpq+tJ RzanmuEFOJqBJP8mMY6ZztQEQB9hjgqKs0vWVtmpTtVRPgksR30VJKecPMF64X7gbHUF Xiu0e8iWX3rmtzZd3baJkiY5T/a7ov/xtE1sSB/UWWwnXepVzp/yDSi2/S4eFyB5ewmY laFfobFRWHtJTB6Jf7w8qtWEmPxPtMhP1IzXZ4uhNGp26XoTB/zE3bURnyTJLnaBj1Gx 9sjA2iIIR6xnBHV5iGDxYxJf2nLjfu+NLlxlvaJ1TDNn0WHuxkGDloyXx0qs41vT1SRG 0FeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724253091; x=1724857891; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pWqVOnOMPwf1aUFvCVrFf4VPqF69Ewf7zmbruNVrIBw=; b=xCIBTuuQbq1tnvUoQotF8Azgj9HE88Z5ESeiTRepfD2cIUy70/V934REI2lDuiLr9i 0hp0yHJq/m+c2Gf7zRFb22PDfuCqM/xJP+tB8TwHpEnLVSSP1z2VPvL6L5BCy5TmRLOo BX+92YR7HpcFdoiwW3cnFzHb/HogT2Y8C9yujOTMMuW8XE/WMfhQHKYeynl4V0F8TEtM 5D/1TnuK4gmlqnz4SKW4G1Q/6GK9NI9d3Fg4cvK6f/3nR0ysVFIV5R6xt6ymzQ+dVZMq IzTh0DFVcRRUw2FmGFcLCEUDCo7Ll0aFzUnCRHnrT7f34e7z2W8RSovdIwBtmHlirrNr 6qfg== X-Forwarded-Encrypted: i=1; AJvYcCX4n/0CAwZibD9sFuXokxeKnN3bVRfestRmWS6npm0Yz0fU4fQUyXl/C2j3RMc7Ff/gxy6Z+1Kv9A==@kvack.org X-Gm-Message-State: AOJu0YwqwFhZRULXb1y9B+Nz9UsplGVgNDE1p4KTSUpC7lete+ExxfbP 6CYOz1O3CVuBp3XLn4RK8ayUKSiptE1uNFQpzJ45jFmoR3Kk0WgPnlNtYZMAycM= X-Google-Smtp-Source: AGHT+IEBZc1XpipYGfwXvetKTPV5HGydbAotLpSgJ5YV7sPRC7Xfol3C+JOCL0qbpYT3+Do239Fwcw== X-Received: by 2002:a05:6512:3b8a:b0:532:ec7d:9c67 with SMTP id 2adb3069b0e04-533485d6a4dmr2079937e87.47.1724253091045; Wed, 21 Aug 2024 08:11:31 -0700 (PDT) Received: from localhost (109-81-81-250.rct.o2.cz. [109.81.81.250]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a867babbe22sm82370266b.183.2024.08.21.08.11.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Aug 2024 08:11:30 -0700 (PDT) Date: Wed, 21 Aug 2024 17:11:29 +0200 From: Michal Hocko To: Kanchana P Sridhar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, yosryahmed@google.com, nphamcs@gmail.com, ryan.roberts@arm.com, ying.huang@intel.com, 21cnbao@gmail.com, akpm@linux-foundation.org, nanhai.zou@intel.com, wajdi.k.feghali@intel.com, vinodh.gopal@intel.com Subject: Re: [PATCH v1] mm: Defines obj_cgroup_get() if CONFIG_MEMCG is not defined. Message-ID: References: <20240820195005.5941-1-kanchana.p.sridhar@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240820195005.5941-1-kanchana.p.sridhar@intel.com> X-Stat-Signature: fgc35xrtgirde6t4fgcbbaa7gny6a8sc X-Rspam-User: X-Rspamd-Queue-Id: 3FF62C000A X-Rspamd-Server: rspam02 X-HE-Tag: 1724253092-591274 X-HE-Meta: U2FsdGVkX18/xTpbE+eMAcBgPfqs5awZ5RGytuSHYULrCgkgVsRk29wDIbq/TWAUYKHVlReI3xcfkyQFgomS69J0m9LtvIojhrAK7VpaiLUOBcJg48MbuNYLpdg++pcROFGPzrYdfzrJk7aFyqwwArJkqDDgLTs55yQmHanUKehdp88AYDJgGhgYwLqFt39Yjh0h3QNm1MFxTc6n0QmjqeLTKMcRykRFOJSPPS/FjUtH4ao8gIWhJ4lIU5bcdP+e3LLhbeJn5ogIWTVUayycjroJzYOjGpZpo+aC4uri7MVwNr5XVlSu+AdBsZQQ0iG2N7wx6M61h/zzyPOIkWU7zpF2GimJzyoXeAbjALItvA2ztCwL6HhWFfzW8PIEzLzK4+/1TFT7rwxpjLrLuXfjJ+cvd/D5LDhyKj+BXEk0HU55dNn/fRmUUH1VJmbU965xfd1bjHhShVmaeuqdz72u0/MaG/R5L7zcts9KGgpyOb6IsDGOx5FOxBO0JyqKY5t9eXFOLrCyrVV4UY7GB+EEOGwYdfHeFZs68Y60xGxu7ZYoRdsl3TGK12PBvluLarvPGwUdyZ2gvwNic78lYAYzs9/CdZt7odyqLL1p018udy6uA+pcQcA6uVGnmb5Ad3u7YQmRvuH1ptvk8Dm5bawv1uE74mIWGcFX8hRx/ZxVJHT/RM8btuCyazbYpYk43SmS9BkxYG+KtfKKiRw87ef7A9y4LGexWjZrRBXrc9Wii9XbfqvCKm3ihWBJsS17Od9clTwkrXhU8twxnXvUOwfZ0SxP81HzrFu+xbp0OrWVEMcM3bzvr+ys5kygxfsVaolTvjNUEcB6aYvX7xAvZnUuLvkGe6OAMaH8rMH+lekqa44BIXeQ1lcIF/aCdG0aDlsp9gwwsaeLP8s7Ioo+xm9qx0Lzn1Css41dnpvQgAdp1UWKsUy4SP6WW7myDe1hiqei4iObPfLqzlTRmq4dXYl xS3rw/cD 696dMNaDedhBbBXhKZV0R9tojIcX2pIp23y7BM0jKDJp9RMepYxvR2ILbmKwB8C3Xjwmud82/gLHisc7vm4PdZVQSFEg+2+tSBVohKIj9GrJgAUi5iQCOKqi/2MfH/erD6ZnYNptPB0kbGj2k1dME5Q9HEikA1Zv2maK1eVlA2/dpUmCPZUiuNNBMc15999kdfXzSI2GaxAL0Y3gBTwsjAYCHnN4j6adOSxFtoPM6HvprnaDLvcCP+IN6ulDOS6OcYoQRkIrq5HM2bDVYO15H4iaPw5OCJgo2WwMVkjRJj+ZnaQNe6+5Auwy7nAfXFK4v+Yxurp2YRLsAX7Nwu7g8MnEnYvKCAfo36qlWXAgplP6i/ZQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue 20-08-24 12:50:05, Kanchana P Sridhar wrote: > This resolves an issue with obj_cgroup_get() not being defined > if CONFIG_MEMCG is not defined. Could you paste the compilation error and which tree this is based on? > This causes build errors if > obj_cgroup_get() is called from code that is agnostic of CONFIG_MEMCG. > > The patch resolves this. > > Signed-off-by: Kanchana P Sridhar > --- > include/linux/memcontrol.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index fe05fdb92779..f693d254ab2a 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -1281,6 +1281,10 @@ struct mem_cgroup *mem_cgroup_from_css(struct cgroup_subsys_state *css) > return NULL; > } > > +static inline void obj_cgroup_get(struct obj_cgroup *objcg) > +{ > +} > + > static inline void obj_cgroup_put(struct obj_cgroup *objcg) > { > } > > base-commit: 7d0b0d4b77b368b2111fc8b4449e33dfb3c34087 > -- > 2.27.0 > -- Michal Hocko SUSE Labs