From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A52A4C3DA4A for ; Tue, 20 Aug 2024 03:25:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 043E86B007B; Mon, 19 Aug 2024 23:25:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F0ED76B0082; Mon, 19 Aug 2024 23:25:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DAFB26B0083; Mon, 19 Aug 2024 23:25:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BD0D96B007B for ; Mon, 19 Aug 2024 23:25:02 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 426481C5134 for ; Tue, 20 Aug 2024 03:25:02 +0000 (UTC) X-FDA: 82471182444.06.7CAF0C1 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf10.hostedemail.com (Postfix) with ESMTP id DF580C001F for ; Tue, 20 Aug 2024 03:24:59 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="p/pkFhuX"; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724124222; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Nvbw6T3DHbjL6k7DOKePSmd0g8wcKwt1FQH0RB9ZfvY=; b=NfQptJMdF8Van5U6LzyTrPhUyMrsiFKhCSN0iH+TTeNjM3uNunRcdp4FPngjDGsNGWIj3n qTFprltHqyp9exlFnZeIk0K/HFo9icaKB2hmDiTGb79gNmF4bCG14XzuP5FnPHjoM4unvV l8zvD2vyIZYmgv6buaxiWVkSRrgc4Vg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724124222; a=rsa-sha256; cv=none; b=j7EHrD63LOo5DPDvhrLsoD6BLlqK4pgdmJnNeSexrhKidy82YMcT3QId5v8edEgfuKT1jR 8FuabqzPBq3EaCoDjMdyr7oqZHjdTWjv9FLm7ccNp4vLXb9N9wp8akAaTPFQZHWNxZxokD BcGHVXnAoatzK0fXlSEZf9SMeNx6Jsg= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="p/pkFhuX"; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Nvbw6T3DHbjL6k7DOKePSmd0g8wcKwt1FQH0RB9ZfvY=; b=p/pkFhuXddW6T5hNsXhXpuibLT wpdM9/dtWA0by58UJBoAxxlHGDmwUtvA7SPFOVN7Rfp4qzSQJN9p2xTxxWTzuo+5MXj7qGyRmzbUW sVhj7IL+F8Kp2aVlYmQzM3RA0j3muuF1U2KUecH/R2127fD40FeHpoyImL+pbNihoWoiAlXDpk488 Lqy7efenSaS0QgCynOAVPSwqr/9KmyxmamZf9EVCQ7pV05bFL50K/kXb3mY464G87c8BdDUgxA7Y5 E+0tuyulqyInQvYwG4rq/9U0X6I14DV7gzwyLXtT7P/XK68OAwzhUdwDgOzECFdCmZXI5+GIQ/20N oq/W+LJw==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgFUI-00000007TaO-2fUY; Tue, 20 Aug 2024 03:24:50 +0000 Date: Tue, 20 Aug 2024 04:24:50 +0100 From: Matthew Wilcox To: zhangchun Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, jiaoxupo@h3c.com, shaohaojize@126.com Subject: Re: [PATCH] use might_sleep check if kmap_high is called from atomic context Message-ID: References: <1724118791-51554-1-git-send-email-zhang.chuna@h3c.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1724118791-51554-1-git-send-email-zhang.chuna@h3c.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: DF580C001F X-Stat-Signature: 64t7bwc1n8si8hwef1ffeeybzm4bshd4 X-HE-Tag: 1724124299-611342 X-HE-Meta: U2FsdGVkX188K4xhi5XYEKMdsiDCL1V7ZBVaokg+1cbXSt4qUVOQ3HO5+bYEbeBbZNJpbk+NlznicWvSz6cZxq/6NQ38Wryr79fbd6Vm8FmQS3E+33oKfwNK1IP9l7QGsur8MSRrCEZYNdvq+OUogASiFE8MNBF2E9C9dcv4Wi780pgWRiVEgaKCeV10VC/tAmQKBefNdMieeYyHeACohUk3W+i7wU8r+VDJ6kN4vomZzp3FF838gz4TLEmZTG6cNnGLVhskJyVaJaNMDOOSlaoAqS0ybGpL7ll09GlPCWIfUxrrMLn9+pYIPeEqF19ZDcs6YNJLep8+9tq/FeAOGVxGMhnxmh0lt8OASbtLdcdfDfmrd6RwXsg4lbYtzcuyM53jrQ9WLt9Ks4MH+/9l3y6ozQscsJJUjckI7DxaxYkAQvN35obMTFJfhOYx+ChX9PHyh0e//KPSVvVCt0zkKqybj7Bg/wvOechrRu6OSC0wS7yI5UJZo6DoquED9NbPxjGG+M7kCMG68/ygQgR8QnK2MckKC+tldLz0wkaTUIr42b4vY9Qic8HSAm6o9IFnbTL58Vfm5zlhUuWiNd/r2EmwIpAWmMYaqH1Cb8dmVSYoXIwwpmpuFrMKz9WdIVk9SXovSmeo8xDd/Cc3luMGK0mwbZ8GvBMwb7xXVU/JjgCEEcNMlRBKURrXQIT6v8l9OpVHU/1MFf0pR6oYssLtRawO3rOXzDJy6kFQuP8/kbnW0goOAA1UBJpFtjR0AKzcxIIm5syL/YYVsSEyousOkjiMIMtUGo5rP91QmPkyinIwdkgsxzCCkv6M3fdb9XefqpZKfyQXnItmCgyhHRPujHSz15eoABW/P9TI/4H2oHGRuTYwSdyTv1cJFZkL7syOAv1nGY4MUWdJXH1VWSY1dkmRRU2y+VqX4HLgUiq3RxVO6uwkWYbAoJIUKjgUSciGQwmFiwGV7303xzaG6Sn lGVg4+a2 zU7cITy/a7LBcO3t7mjR6LxFvbFjD8uXYxtzFSA8qiiCb/gRxxSEe1QAPetOP9NZ3ifBQXrIVux6tE+c0X+x/hIgpD1MtRFBiU5vgJQFNav5Y85rfVe/FeXbyYNxipLwTCemrWFlfrZC+wB93Y0Iha1BUm4yWcU+Qs/vpQjHZoOzJ5F/hUxGU05iizhKPZV1Y8rlboLzslSrfwPH72aJwxr2bA+oYsdPdJjZ0HTk60yjbBprHZi2mOJR4WQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000015, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Aug 20, 2024 at 09:53:11AM +0800, zhangchun wrote: > kmap_high is defined as EXPORT_SYMBOL, and cannot be called from atomic > context. Add might_sleep check is necessary. No. Nobody should be calling kmap_high() directly. There's already a might_sleep() in kmap(). No need to add one in kmap_high().