linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: zhangchun <zhang.chuna@h3c.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, jiaoxupo@h3c.com, shaohaojize@126.com
Subject: Re: [PATCH] use might_sleep check if kmap_high is called from atomic context
Date: Tue, 20 Aug 2024 04:24:50 +0100	[thread overview]
Message-ID: <ZsQMgpZpx4oo_a9b@casper.infradead.org> (raw)
In-Reply-To: <1724118791-51554-1-git-send-email-zhang.chuna@h3c.com>

On Tue, Aug 20, 2024 at 09:53:11AM +0800, zhangchun wrote:
> kmap_high is defined as EXPORT_SYMBOL, and cannot be called from atomic
> context. Add might_sleep check is necessary.

No.  Nobody should be calling kmap_high() directly.  There's already a
might_sleep() in kmap().  No need to add one in kmap_high().


  reply	other threads:[~2024-08-20  3:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-20  1:53 zhangchun
2024-08-20  3:24 ` Matthew Wilcox [this message]
2024-08-20  6:33   ` zhangchun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZsQMgpZpx4oo_a9b@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=jiaoxupo@h3c.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=shaohaojize@126.com \
    --cc=zhang.chuna@h3c.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox