From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8395C3DA4A for ; Mon, 19 Aug 2024 13:38:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 223556B0083; Mon, 19 Aug 2024 09:38:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1ADA86B0085; Mon, 19 Aug 2024 09:38:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0262D6B0088; Mon, 19 Aug 2024 09:38:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D81666B0083 for ; Mon, 19 Aug 2024 09:38:58 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 706B31C2BF5 for ; Mon, 19 Aug 2024 13:38:58 +0000 (UTC) X-FDA: 82469100756.16.8F74892 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by imf21.hostedemail.com (Postfix) with ESMTP id 80CB31C0021 for ; Mon, 19 Aug 2024 13:38:56 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TPNZn2L8; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724074650; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dchi+d1FigESowVeyACaqiWkyTYVXfwbBg371ZQ0xUM=; b=qXZp1eaKNe8v1YpPTkEXZFD5vv/RPTedSMoFUOh8ijJz4dH6dp/zUJPjWGXebgKEFH1ZqP Ace193Zt9fKcVu45ibpxxLnFE5kX1PoRcrimKgXtf8lK5CElklR6iQpe3hVLc7TpbXPwzY vWcKjoQn6gmg+ccW/RzbiCpO2tdqcIs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724074650; a=rsa-sha256; cv=none; b=5V0BW5aCxrxZh5uzvB4/+z1a5QUS7c/ThyBBHefffSzPKY1KEagBdOUWVntPhViDZWnjqA FzQyK9gQR4ORWltVRQtmSa5i7Dq140xAni8wkgYmEPbLEOfajHYLmMrv2fOa5usw1OakSx BwOZzh1BzH4RosfCcH5CaQmy9Q19LEQ= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TPNZn2L8; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=urezki@gmail.com Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-52efd08e6d9so5193875e87.1 for ; Mon, 19 Aug 2024 06:38:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724074735; x=1724679535; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=dchi+d1FigESowVeyACaqiWkyTYVXfwbBg371ZQ0xUM=; b=TPNZn2L87ceFVFyLWvmN7F6fBtkr2682CxeDScnkQ1zSchDdH0A3DH7/DRXdPU6Pph 8vgw82ZsZzrTs+4WJ90GcOdBZUR0q0u7ToRcSl5WtlZcukq6dQPQ2KgOnHYbiVZ2uMbk Brw9Rps5w2fcJgn/kKXcEfLVMz91HgQ1jeNGjgNcaePVthYxGoH3eBKzy4T3TpWXYuOv 6VPe64ZGv2SLuywsk5zQoXEHYjdkjwV2wLfGWgUb+90Pndz+AXWEI45c7ip72C5fQKUz Vgaml0PA/3cZkTqGHU5tsdnXSh7jWWNVQZWpZ297qbjuZSaVnOvAG/A9H/LUw7iDE1Ju xuYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724074735; x=1724679535; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dchi+d1FigESowVeyACaqiWkyTYVXfwbBg371ZQ0xUM=; b=e+hicgQrh9LeAdtSA7m5bBsrkwYXo+Shfsh5M5lg5lmBnxYwfNub/PoyFq6e85B7ee dSTeGVGIxuV9M2f4wI/LFUWlQTDyNnH3KYkEIoHFrevwUl4CjjRl+3ozqGPDz2/PJ9HG TtjEH7K+g2bUePJHnUO/+f5mOklhohY0n8c79rbZtRTatj1mLexcoJ8yPFVvgzofTQJo eGDtfrh2x/U35GrmICAbDGlNLc0VqyuofC8ez4K64NpDW/UGr6UshQEC9b/Bg4xNito1 lIaA3N+VVZGNlUhCp8wRX2gkpkbyUuIr+7mBdL2rcfV1dYoAXb+IJ/amiOjXBLg/KJky XzUw== X-Forwarded-Encrypted: i=1; AJvYcCWFS7kl1y5hDEq43opHiEtiErUhREj6K8/GtTFp4QLxixjA72J4/pr8b11GLKEPzEZvlUkyUWa8ngPR81IuxujXFR8= X-Gm-Message-State: AOJu0YzjaIvlQybLD2Z1olrMfb4g+j+gktYnSpJP8F3cnoaJ+Acb1H2B c8DNOb2d0zTuD39Rv9R0iHxl/nJbSJK/9Sj8TgtznV5lTaucSrp/ X-Google-Smtp-Source: AGHT+IGgCQ8QlkxeXJHiSTrcYm/QwMl+Mxc8eXrDm08JIav0nCmzCnuSlbcUT4umnCnAre8gxyGPTw== X-Received: by 2002:a05:6512:b20:b0:52c:86d7:fa62 with SMTP id 2adb3069b0e04-5331c6aedd0mr9099225e87.23.1724074734287; Mon, 19 Aug 2024 06:38:54 -0700 (PDT) Received: from pc636 (host-90-233-222-199.mobileonline.telia.com. [90.233.222.199]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5330d424b31sm1529318e87.274.2024.08.19.06.38.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Aug 2024 06:38:53 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Mon, 19 Aug 2024 15:38:51 +0200 To: Hailong Liu Cc: Uladzislau Rezki , Michal Hocko , Andrew Morton , Barry Song <21cnbao@gmail.com>, Christoph Hellwig , Vlastimil Babka , Tangquan Zheng , stable@vger.kernel.org, Baoquan He , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH v1] mm/vmalloc: fix page mapping if vm_area_alloc_pages() with high order fallback to order 0 Message-ID: References: <20240808122019.3361-1-hailong.liu@oppo.com> <20240815220709.47f66f200fd0a072777cc348@linux-foundation.org> <20240816091232.fsliktqgza5o5x6t@oppo.com> <20240816114626.jmhqh5ducbk7qeur@oppo.com> <20240819125738.vbjlw3qbv2v2rj57@oppo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240819125738.vbjlw3qbv2v2rj57@oppo.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 80CB31C0021 X-Stat-Signature: 5et5hzmj9odckw7bz6iwphiw9adeqgzs X-Rspam-User: X-HE-Tag: 1724074736-471901 X-HE-Meta: U2FsdGVkX19hCjh3ci4Vf+IBDvIpH5pHjLL6EZcURRyXFgmZIstdSVCGTwqFhD//NSqiSdnfrK9RnVIREB4crZLfirHQvZuWxTD+2JJtCriMPEDkYkF07R02bbl6lconSsaojH2s1EotVJ2ozeUpUBr5Kkz4T3k/LxUPSoopVDFtNBil20Ehmjz79B53MgrZYFfZbGpuvgx4hCdoVdNHtKvdftlk5YHJpDadrqKtgPZyMCH6dKZvs6GNXKOXXojjE6U+a2yoKhcvkT/GeYeNEFS5yvCjLr/Ncib4/eAf8g6g9GW59z1oESkqJYOu7C+KFuYj5HS4cLKRhzGNzZap4WW6jOkyqzTAgRPo6mMjMyiB5O852hHO5NC4ulcjSnNdrabf7u24rBIw+o1B/DxoPtNSIvTPr7orfYrUIJ7nzhp2ItUTvH3qNxNlQMdkZnzH73IrWpSHxX6a3jT575G/6j6HxObO4AbyIN7U/DtD3apShg4ZNJTlxotDmewnlOfcbPCdNGG4+UYVEGCn45amLAKaRYc9q+v7ByWy0aYU1JE/IK2odO+7obAL8RbiwMbfl8rZGVdj7SVMij7usnATSDdBVcHzbw38cWyVjv2t1hV7rb+U0ZHdhy4+cZoQuUyHkA1dmHL9qV3IAs80oE1v2OKFTrNZI2krv2UKVFkKEOHclVr4upJsH0sX3/lsZl+i84+Kt7MoNeOn+qO4UMWAC6gElTMh8j3rSruu60YL1zjWR/l3GXhw8SSUKPg2uKYNs1/oMiz3Jt7OhFW8AhbVaMp1sv4zXxQsnNpByStPxoLQdTBkvpj4NAHhca87fJ0OeK0URpGHlQ6FkL+8wdIJtQzZ/WA3+wCTud/zv6ITQQiQwYtotrjNFORAxECay72rEWW3PlMl/uHRsXWyIVkvLn4lJiTFH79geuE7Dp1PVzRGLS4vjzgQAUbuUpNCDcyMB5mPi4Q+fxxHHHHJ5/K ePp8GH7p dFvB6TeROdE2c7mXAVbfQ9DzSYy7xDSMiCElVK4Mz5ax3ZiOL5okhO9GMvqsMKJzdmKx20kApmLxIeo+EEx7o64vj6HHUyUKZG5ghllZMtdOkJgehx3upOAU3h1HNIN0jkX9LteqQh499sW/ogB0876GNrr1zcC1kZaCzUb9jyCysJkz7ZM3PeQut+GDyYFzROXCndVfB+aM7bGrZ2o3Y/mou4vqpcKhzPJ1vBerUflvfpxSR3VLv5uutv3s19aPFnjDRTsFGmqERYcoIMKEEwCBoW3dhLGZLJODYkeeY48fc9t2LQuGF8BqqsBVOq++N8cszO55/JZksH+giQa3J97PRJJRgqBSpSL3kJugl89RwuTQhNJ2PPJGR2DFa6sxrY9lz7/NvsBtyT5OGvPOSssyPaIwAqq86ke92GvSRV2IgT+bursngdKe5ZeUEqgHkkzf5RQG1CwJy7iJr+Bh3OpcbniiIdGwLvvfQc1i9KpNaPFGht0mbAIJYSNrGsf3DWJPn2d1TYuswYrpI/TH6jxx7NBFEX14NihzOdBDKOb7HWDSiguJ1k0HnBQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 19, 2024 at 08:57:38PM +0800, Hailong Liu wrote: > On Mon, 19. Aug 13:59, Uladzislau Rezki wrote: > > On Fri, Aug 16, 2024 at 07:46:26PM +0800, Hailong Liu wrote: > > > On Fri, 16. Aug 12:13, Uladzislau Rezki wrote: > > > > On Fri, Aug 16, 2024 at 05:12:32PM +0800, Hailong Liu wrote: > > > > > On Thu, 15. Aug 22:07, Andrew Morton wrote: > > > > > > On Fri, 9 Aug 2024 11:41:42 +0200 Uladzislau Rezki wrote: > > > > > > > > > > > > > > > Acked-by: Barry Song > > > > > > > > > > > > > > > > > > because we already have a fallback here: > > > > > > > > > > > > > > > > > > void *__vmalloc_node_range_noprof : > > > > > > > > > > > > > > > > > > fail: > > > > > > > > > if (shift > PAGE_SHIFT) { > > > > > > > > > shift = PAGE_SHIFT; > > > > > > > > > align = real_align; > > > > > > > > > size = real_size; > > > > > > > > > goto again; > > > > > > > > > } > > > > > > > > > > > > > > > > This really deserves a comment because this is not really clear at all. > > > > > > > > The code is also fragile and it would benefit from some re-org. > > > > > > > > > > > > > > > > Thanks for the fix. > > > > > > > > > > > > > > > > Acked-by: Michal Hocko > > > > > > > > > > > > > > > I agree. This is only clear for people who know the code. A "fallback" > > > > > > > to order-0 should be commented. > > > > > > > > > > > > It's been a week. Could someone please propose a fixup patch to add > > > > > > this comment? > > > > > > > > > > Hi Andrew: > > > > > > > > > > Do you mean that I need to send a v2 patch with the the comments included? > > > > > > > > > It is better to post v2. > > > Got it. > > > > > > > > > > > But before, could you please comment on: > > > > > > > > in case of order-0, bulk path may easily fail and fallback to the single > > > > page allocator. If an request is marked as NO_FAIL, i am talking about > > > > order-0 request, your change breaks GFP_NOFAIL for !order. > > > > > > > > Am i missing something obvious? > > > For order-0, alloc_pages(GFP_X | __GFP_NOFAIL, 0), buddy allocator will handle > > > the flag correctly. IMO we don't need to handle the flag here. > > > > > Agree. As for comment, i meant to comment the below fallback: > Michal send a craft that make nofail logic more clearer and I check the branch > found Andrew already merged in -stable branch. So we can include these with a > new patch. > Just to confirm. Will you send an extra patch with the comment? -- Uladzislau Rezki