From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCD96C5320E for ; Mon, 19 Aug 2024 11:59:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4755C6B0085; Mon, 19 Aug 2024 07:59:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 425376B0089; Mon, 19 Aug 2024 07:59:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C5936B008A; Mon, 19 Aug 2024 07:59:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0DE6B6B0085 for ; Mon, 19 Aug 2024 07:59:47 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id ADE5D411A6 for ; Mon, 19 Aug 2024 11:59:46 +0000 (UTC) X-FDA: 82468850772.12.A927C5B Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by imf05.hostedemail.com (Postfix) with ESMTP id AFF7C10000A for ; Mon, 19 Aug 2024 11:59:44 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TaX3XlmI; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.52 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724068727; a=rsa-sha256; cv=none; b=WSeKLWrbGHNsYn+gP8mCwwQLcvXK3bo2XMDvC/JMBGjvxEi2HNpRWoMVoP9pDRUHNHLAVV jmNFE8qbMtO8SnJNjDuxic3OG1Rb54CbNcecFnjQJcrBmPPgSj87dmfwStKyfGM7SLB11M /9xC3LHpuNRXANKrirl63JSSeguWLr0= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TaX3XlmI; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.52 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724068727; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=11BaiIrZqK6uC9f6mo5FUMGk8lscaJMZdcTKC0DE5Gw=; b=acyFWFBEgl5Q057gJhtwtAvUw9ZfSVFlQWz7X8wOAa+In4aqeKQ07gjXkfOugyeZPAo8VX vc+lEBlWJvRtZYCBQdHOpTixRrHcOX8OK7PKzQsKOp2U68EwtNk9sLPCA6ZBjzZCRaAz2O z1eHXr3h0WeqYo95FepQKSuESNpJg9I= Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-53310b07267so5578069e87.3 for ; Mon, 19 Aug 2024 04:59:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724068783; x=1724673583; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=11BaiIrZqK6uC9f6mo5FUMGk8lscaJMZdcTKC0DE5Gw=; b=TaX3XlmIQ+6f0sBKwXdOSyvNbj0UQfhcm2wve/oKy+CNukknqGyTRVP+ET3dtuPz6N vMzofrGq5C+bDFx9Ysvfv+2jhSEj76PngcGTlIHuZZ5Y8YytM8hSvFMLZO4FiA6vBfof rCI67PwMwoiQcvhjYKc7RMNzhqWlujOYwLbkQtLl23vRW97jeYWp1aIfZ87J6pTlmH3V ZGqeoGINx+UFA+CZFlKOQZYCwDBkmcWHehl4W46gb9XB+g2HgMeafIHmf2O++3wuynuG AX4QA6cGMESab4yz2zNeeU2Emu5FW5q3TN1nMGJrRz6w81tD6umg8Nkg92LhwfLztFv0 CQvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724068783; x=1724673583; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=11BaiIrZqK6uC9f6mo5FUMGk8lscaJMZdcTKC0DE5Gw=; b=iC4j1277Y7AHu4UZswzwY8EB95EqlYlsoz801chTCFmYbd0+h+fzdjHIUkuan0GBBU zG0KAfkM630JPRHlWGPtDyE3s9Ndaw2UsoD+mUE4Bgd3nGPQi+qDEauOM0i/3fEBLvyL DkxgRPnRH28nCWYtg/tmp09XGnPw/Xde45CLIitssLEOu2iYFa/H8+CgPtHL2dW8guNf uKHPuohkjxiU0XAv2744mjPQgHzWtFADqKoQYKs9EZjUITujiIMTHEj4miLP+NT48uZR T5dbhCFWeH707HPlj5n/t1ft52Hmm03NkBl+kq7mGnIAdr16Q4WvuS5tXrY28DTET62+ cTkw== X-Forwarded-Encrypted: i=1; AJvYcCXJJM83+1TDUbYNSwJVlXZ2ewE6gnPqxgwsOH5WbOzsr4OzBMGFJ75wZETVmABgVVX9nJbcNyBhHRjpsrvN7xVNADk= X-Gm-Message-State: AOJu0Ywgvq1AuVRYp+lh3+iiDms/y6MYwWv0TYa7ecqyDh/c0Hc/Z5jM vVW+2Ai9ML9ep2CENBHBflBb5Vyy4kFhmlstBKTyuRl1g5sHKQCg X-Google-Smtp-Source: AGHT+IHZcVhAZ8nSbzw84gbFmvs+SpnOwYZjzUxnOnvuu+EHF8HwpuzZOmAF90sj/Kck0Tf9+mSA1Q== X-Received: by 2002:a05:6512:3a82:b0:530:da96:a990 with SMTP id 2adb3069b0e04-5331c6bbefcmr9002028e87.32.1724068782130; Mon, 19 Aug 2024 04:59:42 -0700 (PDT) Received: from pc636 (host-90-233-222-226.mobileonline.telia.com. [90.233.222.226]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5330d3afb37sm1476875e87.20.2024.08.19.04.59.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Aug 2024 04:59:41 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Mon, 19 Aug 2024 13:59:39 +0200 To: Hailong Liu , Michal Hocko Cc: Uladzislau Rezki , Andrew Morton , Michal Hocko , Barry Song <21cnbao@gmail.com>, Christoph Hellwig , Vlastimil Babka , Tangquan Zheng , stable@vger.kernel.org, Baoquan He , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH v1] mm/vmalloc: fix page mapping if vm_area_alloc_pages() with high order fallback to order 0 Message-ID: References: <20240808122019.3361-1-hailong.liu@oppo.com> <20240815220709.47f66f200fd0a072777cc348@linux-foundation.org> <20240816091232.fsliktqgza5o5x6t@oppo.com> <20240816114626.jmhqh5ducbk7qeur@oppo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240816114626.jmhqh5ducbk7qeur@oppo.com> X-Rspamd-Queue-Id: AFF7C10000A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 6bo4ugaeh35e93omf74tedc3nrpjkaf6 X-HE-Tag: 1724068784-400459 X-HE-Meta: U2FsdGVkX1+QdWq28uDRIY1GUWJClG3jjVhDAcEO0sIMCxT3dA089YgsYsuaeuYzsn9CwLkOkiT3yucjgc84TVebJGkY4ZIjVFeRIYEkv4BAcBUwX0PCVKVtsMxYW0jDQ+zO5QSA/oX718BDRGshRmNqp/zoqe1OSj+oadr5/rv8QGhDCM2P3zTWeCQcKrchQekMmp3TUqrosjSLNDcjj+qxkZjcVXvvuYQjCJnjhNJ/V+AXqlcTPeLmt2ULxy7iU4RTzTtPEz26sUqyW0hpMPlUPsvkZn+VZdy5L4b6Pztmurs/Twn8iSSrxzfsoQyVCOsuYqdTjmdjj9gWyiiHWCM1pAlsuKnP/XeKM976/pCfzW1kvsAx8GmNyRC8WpY1GbEbxVuMbCtYGfq91KDeT3BkrzQ1vaQMhCphZDDIAqCUiEn34y0b43/00tWzso+3HnJrWQaxM5ju4PlvamGu5mvsWkyUxmspNrjI5psgkI5j18KNuS2bJ5VYeWRfLhH53VE8pHF//fri1KqO6J7fjUAynKnd6a9Kd6V2M1NZs6GgKPYAeGjzn/vs5Nm+lnI7qWxUoz3KF8FD+J1FZSJqYj5wWBrkOkJ3XpwEHyCyVGkroClI3FwO2+Z0sfC6oUVpDQAuPm++eYzkTaRtnAGZmnvDhnvR54ASolEn085copHL0f/am5oZ+pYBNqry2O96+ZlgvKmvsTKex61xNvRmZJFhtRSzpHeSYg27d8SYxrrvjnlUOI1XI3HpGJpBRMGtYvZZnse3GaIxexwGomaN7ZpJ8EYgkZhuYuWdWwaFPn3ZX7bSteBVHjB0hg2r9wMG57OvFVk5DtK04BmwU8o9gNkIQuq5QzSXcNNnspR3tU+wvpifE24KBujmAKzHnBarYbdZ55fNSo+CeH8uuSAcc20cXIUmOLrb5v1csomX1SJ106GDodEcAIGPvmbHMQ28an9Q6xkH4gKDlEhRkxo ULCT0PNN /wBErQWZEblpGaushwY2GEMWgQi99/Y0sevDficQ/q67+90IurHG2XwOC2zF4Jluw5X1Ke/w0HDbhvoZYxHnqkyzXte8aEgVFa69X4crxRHpHGGuD2iQqsMUbi7FfUk46mY+glxeC33pP7jqoEL2sqSsshI+rDm9XiAqsXiXP8CsJeH/ue7F/li1x+EE/IRSPjpqqnQEPPtx+n6XGnkefAeNOXvcZ+mqQKCwju97sQOkjebRBh9mseNi7+XiQMEYZgt8f+3zV/XiLdC38WdFY1u7+x7WJVNcmtg0mE+0HGeUr8yu8UTNoqTfJ3QplQ/02IS5jTfoqw06VPDGytse5f7luHhUDKp4WG0ljD0JF545I7Ldc13qd5TKFO8+g9wfLRFV6iRauLyIxlsSUcpA6+QDx3athk/mZIxTzBcYXZ1cBZHw5noF0ANRQNk9dW4EAUir0hnmuPfu6/U96uX47Epom8d4sO+8vuJY3eoTlH2AosEn6Qh4goifDOnwk3AzqR1t/hLFQOOA0VGnfUQGAZRLZFb4S9IL2if+H5PvNDKwCJ6mDJUVEPKEhdQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Aug 16, 2024 at 07:46:26PM +0800, Hailong Liu wrote: > On Fri, 16. Aug 12:13, Uladzislau Rezki wrote: > > On Fri, Aug 16, 2024 at 05:12:32PM +0800, Hailong Liu wrote: > > > On Thu, 15. Aug 22:07, Andrew Morton wrote: > > > > On Fri, 9 Aug 2024 11:41:42 +0200 Uladzislau Rezki wrote: > > > > > > > > > > > Acked-by: Barry Song > > > > > > > > > > > > > > because we already have a fallback here: > > > > > > > > > > > > > > void *__vmalloc_node_range_noprof : > > > > > > > > > > > > > > fail: > > > > > > > if (shift > PAGE_SHIFT) { > > > > > > > shift = PAGE_SHIFT; > > > > > > > align = real_align; > > > > > > > size = real_size; > > > > > > > goto again; > > > > > > > } > > > > > > > > > > > > This really deserves a comment because this is not really clear at all. > > > > > > The code is also fragile and it would benefit from some re-org. > > > > > > > > > > > > Thanks for the fix. > > > > > > > > > > > > Acked-by: Michal Hocko > > > > > > > > > > > I agree. This is only clear for people who know the code. A "fallback" > > > > > to order-0 should be commented. > > > > > > > > It's been a week. Could someone please propose a fixup patch to add > > > > this comment? > > > > > > Hi Andrew: > > > > > > Do you mean that I need to send a v2 patch with the the comments included? > > > > > It is better to post v2. > Got it. > > > > > But before, could you please comment on: > > > > in case of order-0, bulk path may easily fail and fallback to the single > > page allocator. If an request is marked as NO_FAIL, i am talking about > > order-0 request, your change breaks GFP_NOFAIL for !order. > > > > Am i missing something obvious? > For order-0, alloc_pages(GFP_X | __GFP_NOFAIL, 0), buddy allocator will handle > the flag correctly. IMO we don't need to handle the flag here. > Agree. As for comment, i meant to comment the below fallback: fail: if (shift > PAGE_SHIFT) { shift = PAGE_SHIFT; align = real_align; size = real_size; goto again; } -- Uladzislau Rezki