From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A218AC636F0 for ; Wed, 28 Aug 2024 18:48:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 32F1B6B0083; Wed, 28 Aug 2024 14:48:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2DEFB6B0088; Wed, 28 Aug 2024 14:48:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1CE876B0089; Wed, 28 Aug 2024 14:48:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id F24076B0083 for ; Wed, 28 Aug 2024 14:48:51 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A00E61A06BE for ; Wed, 28 Aug 2024 18:48:51 +0000 (UTC) X-FDA: 82502540862.16.4A82C1E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf24.hostedemail.com (Postfix) with ESMTP id B28E618001F for ; Wed, 28 Aug 2024 18:48:48 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=V2bzXaw1; dmarc=none; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724870909; a=rsa-sha256; cv=none; b=mJ2lSUwHwkMkuI8iDtVMMl7VWz6cOLDzLhKZ4FogQ6853HSnr0xsao/PWEd9swnRW4QSjQ CG8UDM2eD3KzSYpeOtJ7/tkcE2UcJDQ+tCDyk3xrrqT1Nuk4r2XwO+Ds/dT6v4fle14UNI egnR0a5qUG7MVeaIL4kiSXGjkIylBcc= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=V2bzXaw1; dmarc=none; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724870909; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bYmPY0rKFJuPGAn1AckR/tTLn/x55fhHVXd1MAfjtxQ=; b=p1+VX8q7qh+Ru3UhmdeU9aJzGrAS7gZ4ZUPGedyCYaBeRTeK/ekE+rqDj8sQ6EmQsB9mQA Qliki2DAgoEqf8cXp721yOEFPRt3arstEyCJfY9eObpI8rWFO2DDUXYxh78m3mldVSJv1A XoO4CX/zwDIQ5OKs62M8E9hDpv260ew= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=bYmPY0rKFJuPGAn1AckR/tTLn/x55fhHVXd1MAfjtxQ=; b=V2bzXaw1DbwNI/PeKRLEef84yH FcQF39DV/xoQw3r3t5vYxSjvXkUpn9Vq/XeCBgo/K9VRDiq1v0bdKlwoWSxW6WwMMEdagO2Bbc2tz Wrajfl+ySLju5Du6u5NK9ZYDvPOm0KgJ8mCGxJSla3qg8416DG29czGU2mgY+bP+O5h4mXvz1urn9 GHtsbESiUizW3+4nkdQcGMaiQM9EO/qsqlmtPBcH1+McyL9pYRGqP4kT7qgb9pM9qm1ol3L19VRjr +3fv2CLP4odsJZ1+l7lBqBignUNvp1CKDjA04tkOud3Xqa9vIZgmd7vY/mt+bgbACS0W7URQcyBrN YC7ITMhg==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1sjNil-00000000uoY-3xVC; Wed, 28 Aug 2024 18:48:43 +0000 Date: Wed, 28 Aug 2024 19:48:43 +0100 From: Matthew Wilcox To: Kent Overstreet Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko , Dave Chinner Subject: Re: [PATCH] bcachefs: Switch to memalloc_flags_do() for vmalloc allocations Message-ID: References: <20240828140638.3204253-1-kent.overstreet@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240828140638.3204253-1-kent.overstreet@linux.dev> X-Rspam-User: X-Rspamd-Queue-Id: B28E618001F X-Rspamd-Server: rspam01 X-Stat-Signature: pf18uk5ujfjy7nxq6ap65yq3cfnzu5dm X-HE-Tag: 1724870928-332921 X-HE-Meta: U2FsdGVkX1//7L2HsisfdHqKEIdgXFfbO714Lu7fp1bQ7cUeygGnahRY9QtGPS3FGp4dDUb3wKNdgOKl3HQSwkGq6LtCIMjbQnQ7fUKzBjToUUtwe5cj7+1Vgrd6v3VGmOl0JtyGX2h0YTObz0ZyTnvFevVwcCCBebWOySSOt2XE6EGe/bRfpXK6E4FFbzoN78chVhn2kpSMEnQazBhLekAH5p8DfATUXWc4NtouiWl7s63s7clohbOtEn8oRpkYJXpXF7KptY+1Jz4bhrYVInzaqd81Lt1iO7AJRR6qeGwLnAo0YCqEVlNwXojEOMnR7cS7lvqGtyaFXJoBABYuyHyIIRqPy6RxYMjUBaz6DsIgEU5vV5OmqAtuPHb1ZiSPCm7PIuEmNWyIO5uxbnME4ClVBCUKQlHBwg2tuRVT5LivBf8GF2oFEoTQMheJ/a9S3VockgTxUMpipz4kzpej2O/0d4lUh55+8bVBTlkGqGgaTSuuQAjjPDyQGQjn3xe0b77aBZ1Jth+dXNp1UTQuejdL9viwXVK1oe7hRNLsf6zO0IIeUmn0AmZLNQr4NHY3GVYYRTYV/KZVuRjcIA474nbFCTffN7dbib+fwRO+lyi6h/vzvFVZeOeNGyt1IEqzbp9m/PJvqTHicxokJ5we+Ne2SejIKHm6ZvK4/ixKLh2WTYMVZ5nXMygvcDfpQo++S/QLvEcq0xECgiX+zDsaxxiGhJX7RTGht7RgvWqaZGnegsG/+nwPGR76tZJwBu+a5z2r5yRwYadCPqxFLFZO2rwKLi8dhLGBGv7Xyu6A8pQgQPW2WyFTEYj/EmZYL00keQTHjorB2HxCCilwprNM6foFuPFeCdrsrh5lfH4LGi1fPOo97NxVaN3UTZGM5iAVSCUbmNwSCsH+v2pg5+7VwHLlufHxee4y0L8tF+Sj58Wk1Qz9Y/P0b6tGYs5HoDB9Gr2nhzXtoesdWaDsLUz BTR6maAL zgKxIXxnjui2XmX0dP979jAwIpSb9KCklAJB6onNhKcw0DlOHbQb0IzBfeQAzRXYL4fuHmNHhRY6nTJA8d61zEI+kN7H1A0cpXPqgETRqZ5C06zzORuocQeZ7xrb09j0oEp2h9zqZQsb2Qjjfw1TJVbAGQcfEgSBzWo78iDzmF26E9G/goFybinqxZtHfed5thGMgeiiUwCRpiftPd/jdEihuvFvFi92qMFa9KI1OKk7BJP4C/AV79jw/fMRo6CAW2Lqo8p8PTd8VufdyPUpnKNpnxQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 28, 2024 at 10:06:36AM -0400, Kent Overstreet wrote: > vmalloc doesn't correctly respect gfp flags - gfp flags aren't used for > pte allocation, so doing vmalloc/kvmalloc allocations with reclaim > unsafe locks is a potential deadlock. Kent, the approach you've taken with this was NACKed. You merged it anyway (!). Now you're spreading this crap further, presumably in an effort to make it harder to remove. Stop it. Work with us to come up with an acceptable approach. I think there is one that will work, but you need to listen to the people who're giving you feedback because Linux is too big of a code-base for you to understand everything.