From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 520E5C636ED for ; Wed, 28 Aug 2024 18:13:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A7196B0082; Wed, 28 Aug 2024 14:13:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 757906B0083; Wed, 28 Aug 2024 14:13:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F8306B0085; Wed, 28 Aug 2024 14:13:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4563D6B0082 for ; Wed, 28 Aug 2024 14:13:21 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BE568A0591 for ; Wed, 28 Aug 2024 18:13:20 +0000 (UTC) X-FDA: 82502451360.28.14FCB88 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf19.hostedemail.com (Postfix) with ESMTP id D378B1A0005 for ; Wed, 28 Aug 2024 18:13:18 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=gNQ6ZXJq; dmarc=none; spf=pass (imf19.hostedemail.com: domain of charlie@rivosinc.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=charlie@rivosinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724868727; a=rsa-sha256; cv=none; b=kNZCQmq1DQk4LJdXXegk8NgTaMoMIidAPOWEV3CyUZpC3cV2Hh9WmN59J0P94O2OBGPq+P 4T1BUc4d85tI7xUyFNHr6NXaldsxgQutUujH97SMIPEtyiKIuGMlm0mHprEPpyQrriPa42 iK104fELKQu1El4+FUz2QaiOjCUTAbs= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=gNQ6ZXJq; dmarc=none; spf=pass (imf19.hostedemail.com: domain of charlie@rivosinc.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=charlie@rivosinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724868727; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LALoI8v52A4/X4uxJhIa0heHcwoa9eC5vLoHkCEA7Ac=; b=TEIA1mAMQjdzyER64/CqamAhuSoMorX371ySUbk/IxktxLo1IMoH7rS7y8bOAwul86Agac /ObhncCx1ngI7woemBO9ADaTZWOd9w7SjrrAXT3t/29OIxrg8HH4ePyifgR2JkeRlguyz5 iCORBJofJscEKFWek5TWZPeUysL+UKQ= Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2020b730049so56023995ad.3 for ; Wed, 28 Aug 2024 11:13:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1724868797; x=1725473597; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LALoI8v52A4/X4uxJhIa0heHcwoa9eC5vLoHkCEA7Ac=; b=gNQ6ZXJq/VYjpKBrB8idKaVdlu5xya8IG3TCJ7k3SFiYzldqCDeNM7Zesh8/3nHlNR M1zi/hMyh2IJcJfnvmo798bfjJlIstfGzMV/a+BXNwWweACarctZr9We9MDWr1EI3QWG rTvigYM18Uuo1iukbXTsHehECiAi/YAsPzlQNR2HoQFOyXRVuoex+/YUJSQ+vPNc+NYS mYIYr0CPG3GDlNR/o3aKQXvfiZFiiNjoJc9aLYjgC6lTxK0PYCV4lwSac1LE0QbG5UU4 OgOp6GPtOC1KO02UHEc9TZS2759bgdxxnW2AWgIBKUa2Ip2/cSalgJvmyYkzmAnGRlTV qHeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724868797; x=1725473597; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LALoI8v52A4/X4uxJhIa0heHcwoa9eC5vLoHkCEA7Ac=; b=McUoinSRr8FkKcEC3kdSG5gvknTuq6NlQ/jwkByLTI1nO7U/ITceToJB5BZPd4DD4U rOp1GH//jJtFul29cKK6S96NpDQgp6cl1PEg85EhWxxk8zIXH77j08ZGdWUWoYcsumdF f5BVf3nAmy10c6ox/VMapbT1tpr9Vs7s7FQrBsK3z/TmrjCxhzA1Gx+VNJtLTWGG2Sfp GgSSqXWHbblC2K23upDY7fUhiC8YezQONo5mJiyrGYZPpgMLcazTV16lTS+1JmECmpKV WIlL9fN04dwKNL41cRvxbkM4EtzJuJ7Uxp8wDX14B/UjTwNsu8plNcO5MvvKVR8rwyYT dmHg== X-Forwarded-Encrypted: i=1; AJvYcCXPi4LGbkyucgG8O6quNY8SnDnCm50Psj+dpeG1Q9X7WO759hHv4g+5/xAzTZW69UbRw1nJxXY3Bg==@kvack.org X-Gm-Message-State: AOJu0YwPj92Pu3pHWWSSlGupaTWhX0VZLffJiKs3npww1+ELbgJjDx89 /lnUrcSnA7u78QhuQ8cS/+HucAiWxGAzrawby8CQK+CgfmdCMnORYGEaHCSuJ1c= X-Google-Smtp-Source: AGHT+IGuZvjR8n1DEJgaREJ89Ekx33Df2TcjSjzsxg5aNNIN6dSl+M4/n8ZHA/SWHFgBiHe+4H0WZQ== X-Received: by 2002:a17:902:f78c:b0:1fd:9269:72c6 with SMTP id d9443c01a7336-2050c4a5b8fmr3765425ad.62.1724868797179; Wed, 28 Aug 2024 11:13:17 -0700 (PDT) Received: from ghost ([50.145.13.30]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-203855df88esm101966005ad.152.2024.08.28.11.13.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2024 11:13:16 -0700 (PDT) Date: Wed, 28 Aug 2024 11:13:11 -0700 From: Charlie Jenkins To: Lorenzo Stoakes Cc: Arnd Bergmann , Paul Walmsley , Palmer Dabbelt , Albert Ou , Catalin Marinas , Will Deacon , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Muchun Song , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Huacai Chen , WANG Xuerui , Russell King , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Andreas Larsson , Shuah Khan , Alexandre Ghiti , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Palmer Dabbelt , linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 16/16] selftests/mm: Create MAP_BELOW_HINT test Message-ID: References: <20240827-patches-below_hint_mmap-v1-0-46ff2eb9022d@rivosinc.com> <20240827-patches-below_hint_mmap-v1-16-46ff2eb9022d@rivosinc.com> <71528354-4884-41e4-a4a9-318e26187f86@lucifer.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <71528354-4884-41e4-a4a9-318e26187f86@lucifer.local> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: D378B1A0005 X-Stat-Signature: kx7dnkc68b1644g9gqtndodnte6g4kb3 X-Rspam-User: X-HE-Tag: 1724868798-506282 X-HE-Meta: U2FsdGVkX18RHG+zS223G0rd1Ft6MXslhQBdDu6YrFJivU7oWgvnNWYA4PBtjIxBc1ciPf4hk5oaKIOtq2Uz8qr/M1dXruIwob+21JFNeRE6mbRxbw+Ao5P1Il8dZBImRiiggw/WQxl9YXEHemtM0i89NnsdPvS8F5q+QqSDYODdtKcHFG9tEHt+5rNIgyR6lmZ4oEMB6u4E8+i7Er2jAkyOnhAIjksNjhTtd9+G1TMkey4qaMJfXO0xKNyy1dwN+foFivqedLYB3lNKMntfSiPRbCpZrvrW1FHmbqMYOo0GH/IzH3Kdw8Np1zQTSgvKjaViuoowELvkM6iRMHT6+QYS7lppYUoveX9jE67gc8u78r8klQvzTwJKqeJxeWLTl++7f0IZK86nUoU3UrA9bIglCs+v3k/7Hi7dWqxhtUFbWfWyH3s1abL3RFCyiX86QFT90cIBPnm/jR0TXZwYhjR7QlT/VrzTJ435aX5XjXgWQGxzMBDVgxBOYMl5sWAtam2i/rUYfk+NS2mmUE+Hdc0XIf+37LdcB4MMXJinoVwJGP+HcFlVpMFTzJvxbFAIgHv+hffT3/ZBw4vA0sM//OhAa8ZwCYRRsoDLFx01G7KOJKeu8qVlxWyGqOsuMppowUkZVCQ+Di7J+ycI5JJk5fTuyY7K+cV/k9BEQn6uL/Pi7ZNyJgYSl0iaOELF/cFwR51dB4+Ey821q2uqOBhz5BDPCvDF40n3Ft33b6HL8r9HUpm9x3xG/fxVHdd1InTPKqVKyDMv5jNOgF5hXErCOOdXGx9s9LE+P7zmSkpg+AY4baEEFlfAgYCdFiP9CU4cY6+bTFFfCY3cxOnExhSW7lhUKkhG6j3XwHuZ211D+s41eOigSEnTOYMdptPXenV4TXc/5a6SeWHCrMi+KEl4CCAXSjqTeZBzJA46OmkiKCazu54e3SLPAIBgG3ztejeqpSd7R72ygqfE3k+k75n 5cd6Vbf+ FZvP7y0fqgTybRAiORQxfe3LmktC94IPnT95/HGbLNg8oDR3q0H92q/i3sbyth8OsitoMefqS3JkCwCv3vzvWdq84xsaxsn8ve627W+9je4ihwyqlx/HxKEGjTheXAJBPiHgtolfa7zmCfqqDKRLmA8JU3UCMnzkkY+Z4Tmy4RPYaPhRnQ0x+P7aSBA91pSYjX8enj9OPAtT90KfHNzeVQmr+rt+tpSbJcnFIqIBcmnUNRxlRZCrT6pxozjgZb3bi3XBBQ+Be9wcGPJFEY+L8HflbUuj4ZsMSt0PL7TgwNjbjE4e1OXrAZAkmhRn9bwJQRJxO+HRugLnPkSUv1ApBO3wn6AqmWxxfYoCE1m7yzIN/KJIyNIMPehZvqeAJkY/G+ujOjDS0MMKs4y3QTN+LschjlePD4cYZlXxdd7O2401P45G+6UaLayw5U/w8WsNd/6JH2LhHqcXNqFAAww4zYMKW7Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 28, 2024 at 06:48:33PM +0100, Lorenzo Stoakes wrote: > On Tue, Aug 27, 2024 at 10:49:22PM GMT, Charlie Jenkins wrote: > > Add a selftest for MAP_BELOW_HINT that maps until it runs out of space > > below the hint address. > > > > Signed-off-by: Charlie Jenkins > > --- > > tools/testing/selftests/mm/Makefile | 1 + > > tools/testing/selftests/mm/map_below_hint.c | 29 +++++++++++++++++++++++++++++ > > 2 files changed, 30 insertions(+) > > > > diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/mm/Makefile > > index cfad627e8d94..4e2de85267b5 100644 > > --- a/tools/testing/selftests/mm/Makefile > > +++ b/tools/testing/selftests/mm/Makefile > > @@ -50,6 +50,7 @@ TEST_GEN_FILES += hugepage-shm > > TEST_GEN_FILES += hugepage-vmemmap > > TEST_GEN_FILES += khugepaged > > TEST_GEN_FILES += madv_populate > > +TEST_GEN_FILES += map_below_hint > > TEST_GEN_FILES += map_fixed_noreplace > > TEST_GEN_FILES += map_hugetlb > > TEST_GEN_FILES += map_populate > > diff --git a/tools/testing/selftests/mm/map_below_hint.c b/tools/testing/selftests/mm/map_below_hint.c > > new file mode 100644 > > index 000000000000..305274c5af49 > > --- /dev/null > > +++ b/tools/testing/selftests/mm/map_below_hint.c > > @@ -0,0 +1,29 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Test the MAP_BELOW_HINT mmap flag. > > + */ > > +#include > > +#include "../kselftest.h" > > + > > +#define ADDR 0x1000000UL > > +#define LENGTH (ADDR / 100) > > + > > +#define MAP_BELOW_HINT 0x8000000 /* Not defined in all libc */ > > + > > +/* > > + * Map memory with MAP_BELOW_HINT until no memory left. Ensure that all returned > > + * addresses are below the hint. > > + */ > > +int main(int argc, char **argv) > > +{ > > + void *addr; > > + > > + do { > > + addr = mmap((void *)ADDR, LENGTH, MAP_ANONYMOUS, MAP_BELOW_HINT, -1, 0); > > How can this be correct? mmap() has parameters: > > void *mmap(void addr[.length], size_t length, int prot, int flags, > int fd, off_t offset); > > You'r setting prot = MAP_ANONYMOUS, flags = MAP_BELOW_HINT... > > This surely should be: > > mmap(..., PROT_READ | PROT_WRITE, MAP_ANON | MAP_PRIVATE | MAP_BELOW_HINT, -1, 0); > > > + } while (addr == MAP_FAILED && (unsigned long)addr <= ADDR); > > How can addr == MAP_FAILED (i.e. ~0) and addr <= ADDR? This will just loop > through once... > > If you want to make sure you're getting mappings only below the hint until > you start getting MAP_FAILED's you'll need to handle this more robustly. > > > + > > + if (addr != MAP_FAILED && (unsigned long)addr > ADDR) > > + ksft_exit_fail_msg("mmap returned address above hint with MAP_BELOW_HINT\n"); > > This is just going to fail because your flags are wrong then wrongly claim > to have passed... I obviously didn't spend enough time thinking about this test case... You are correct that I wrote this incorrectly. I will make a proper test case and send out a new version. - Charlie > > > + > > + ksft_test_result_pass("MAP_BELOW_HINT works\n"); > > +} > > > > -- > > 2.45.0 > >