From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31881C636ED for ; Wed, 28 Aug 2024 17:30:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 987D26B0082; Wed, 28 Aug 2024 13:30:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9107C6B0083; Wed, 28 Aug 2024 13:30:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 78A8E6B0089; Wed, 28 Aug 2024 13:30:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5747F6B0082 for ; Wed, 28 Aug 2024 13:30:05 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B80B480448 for ; Wed, 28 Aug 2024 17:30:04 +0000 (UTC) X-FDA: 82502342328.11.CD2C384 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by imf13.hostedemail.com (Postfix) with ESMTP id B704A20011 for ; Wed, 28 Aug 2024 17:30:02 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=qaf3YAIn; dmarc=none; spf=pass (imf13.hostedemail.com: domain of charlie@rivosinc.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=charlie@rivosinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724866104; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=izEx2iGerEnX7WB/2Mpvv+y1MVG/tbs1FdX9CKEIcSg=; b=rLIUcaJDfmJNGDa7MuQ7r9KXm1BVetRQYxPWeWrO/o9J6Du96r5+blBy7QtM/nhunIjwTL wkllEzDQNqs47UXTo9ucKjyOcnPvf2VVThz1nLmm6AmingGubQk19sV4xzsydjbfcqUiWH I+OE31w3YP8imDGnrvF/Y9GNxKq4zKk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724866104; a=rsa-sha256; cv=none; b=xvep9QVniMAeFqgLhJ/3JGYFKTuWdfOtxGtRegV0fHcPWysQkbsLHIFEIe9o9NvJ70Hsyo rEbN3w+0Y0lhO27p9+ZJYEheE7tz586YRq7DsLh5K/e9YmyReh6GAUlUumUhIcARjMM/vw igTW9yX2iEUX7L+G9DM8SSEHiAxiUKY= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=qaf3YAIn; dmarc=none; spf=pass (imf13.hostedemail.com: domain of charlie@rivosinc.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=charlie@rivosinc.com Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-202089e57d8so6019945ad.0 for ; Wed, 28 Aug 2024 10:30:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1724866201; x=1725471001; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=izEx2iGerEnX7WB/2Mpvv+y1MVG/tbs1FdX9CKEIcSg=; b=qaf3YAInlRm/Z77cO+QvTps82SntT4PcKA+403403MzLXBReL3Que8kKPhSxq5+F9E 3Z8pGcutzcXJu9m/QOA8zFDLYbk3QqNVBv5oTgHu1O+Q3YEXtb9lp+x/kr2Q6aBHP4gF Ogwi5dP4jmZ11/Kg/aPjIMmW2kfcIqAo/uttFyBC0CeOiMKXNBmTqVruYYmX/wLj1vy1 H3pTHkc5F1j2SylyNbLDxHn10GuZqw2P+IiIK9GR7ux1n4AnhpNJ/Z3hD8VCmok80kuf nL8TpgJP2mGjhht7pcfZ6GO5+4jwOB94NHU1jWE+NQ4ZebOfwmM8VUZrCK6BjqTUPDl9 SdJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724866201; x=1725471001; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=izEx2iGerEnX7WB/2Mpvv+y1MVG/tbs1FdX9CKEIcSg=; b=MpxpilSxDXxCA8Ft/DUsnn1tXHkhhRulLt36X01x9KPpfwTEo6d8yAFMc4up/DNwgC 85WYc33+4L8Nobn7KJwmu9RptHUlYjPzuO/VHh4I66J/3VaNGM6XOzOly2kXQVp2EKnq EoeTJKmTGZxL3g/PccMIHy55GoyOtpBfTEqKlvE9HJSsYqo9Jq8yOH5adiX9/sJa7d+j LdyqdgKuTnLectMzendirK+aYAcYnY3bxKNvflq1yahop/pigiVu8PSNkvp8vk/ooD5E RiglNDTvmM8znjnDktIOTlFeqHENWbO5+DSzLv1OwK6VS/Pwf9HqZqg6SnMwNsHhUUl8 0svQ== X-Forwarded-Encrypted: i=1; AJvYcCXsY1ENfOteyGTZSzKqQKOlGW1sn+DbGcWQWO3S/VpYMF6+/Np1mgL5EvRf481jI6m4PEAqiz6j3Q==@kvack.org X-Gm-Message-State: AOJu0YwNg2s5fTXLi3xzcSy8SZqE5mKJxaKR/8y6l3/da06zLqk1jBLy qaawkCMVucWx1f5lurQsWgp1TF5fISUz6/9Q0KYoJJqVuZV7M8EY/gfhyvmh690= X-Google-Smtp-Source: AGHT+IHMsuvXLfTW+bLvG1ZAGccaibo4i2N0hBI/JcHNn1qd40DIOjpRRFBts/vAK3nn3l/ntjAfHA== X-Received: by 2002:a17:903:1210:b0:1fb:2ebc:d16b with SMTP id d9443c01a7336-204f9bb4194mr38041435ad.7.1724866201061; Wed, 28 Aug 2024 10:30:01 -0700 (PDT) Received: from ghost ([50.145.13.30]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20385581393sm101427625ad.102.2024.08.28.10.29.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2024 10:30:00 -0700 (PDT) Date: Wed, 28 Aug 2024 10:29:55 -0700 From: Charlie Jenkins To: Christophe Leroy Cc: Arnd Bergmann , Paul Walmsley , Palmer Dabbelt , Albert Ou , Catalin Marinas , Will Deacon , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Muchun Song , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Lorenzo Stoakes , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Huacai Chen , WANG Xuerui , Russell King , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Andreas Larsson , Shuah Khan , Alexandre Ghiti , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Palmer Dabbelt , linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 07/16] powerpc: mm: Support MAP_BELOW_HINT Message-ID: References: <20240827-patches-below_hint_mmap-v1-0-46ff2eb9022d@rivosinc.com> <20240827-patches-below_hint_mmap-v1-7-46ff2eb9022d@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B704A20011 X-Stat-Signature: 41syf5wfipmiqeoq3gsjgg19gdyzxbz3 X-Rspam-User: X-HE-Tag: 1724866202-756772 X-HE-Meta: U2FsdGVkX1+rctER0PXjOp+eIrdlQ5aHVMr+QDDeh7OgOSqoTxic+fBjII+ugiPD9lS6/83+jzFMorn9MPd/nQsZOGhoaceG3P4e6sZfNliGl4e1Jzio7Hm81vEIn2XMUExYBklFNr4qRwkz1JvAqBomjrCtcdIbUULv9YQg8t4m1abQ01HJVv1u9a8w4+9kxofqc8zLYiAqW1JE1MllFqoW0VmCnoGNxaphma6DQKPm0VTIHWVOEhNik6gm9QX1gh+daym7bzKqjfTqkTcoOPqZqW3qq/v3YzQFp6OyGiKejYwi103pv9+Src4H/SdezO50VUF5K2xJf/AGPWHqcz7hcrkCNGz7niqrLSaCNM5DeuLcjAWoQAg29cCacRZOd+tUlG+Rx8vua5WAMY9/f1mJTXxTvHBO3sOH4iCnDogx0h0d4eD8D+C5hpS84bNMZPVAIHNHZMP2EAgebYG6DkkiEoOgbKWWCHFDh/K0oa0ZRvlDNIUTgqr+6C2J3Ww+RkkqilTzXh1qmAI4mbXHU5NGrPf5k6tMhfBde1Ru9qll9VXki8+umKaPg77usdJ09aBWBR+QeFDgXMAucy1NF1JJUP1FgU1j8+OWcvrONIiAC6zT20qP7bDwp+XwbXjnbqzdsupmUm0SZoxzk2Qwd23yG3pky+J2lNDtn73mtjxKMUm/I9dhu6Z1ZfgGg+fSgj59rMHQE4FbSBWWt4GulTkbNvR+5QSSd4fLnmJGxPusEaLy+/gfl8Co4azCJP2lVOBA91bdl8EF2SExhAC1DfFr6ZYjs289Ig+8q6GIuzxEmSmLcoggVVbqTYtF1gq85eQTp2G5JPq9K+aqZNWBemFLEvcMJJ+UFp6PoKy7B8g/gP47Gcn+NH02pAn9HfDYhGGys7mUeSYPva1KwS4lzw4zwK2JTlbk4CdHpA6IMuGBwRVBXKNMhsz1w/lXnWouLhNu/m8zBFuIfQXS/uO qT8IGgNO Z6ekiUtdtXGjXm8NI3oYxYJmKS627LSOO9WFZE0UjuoBS0SDGz5PNKvniZ/oJQ4OwtVC+MO23atCm9pmLbCy2Nh0TGA7BFtd7wrf09f/ZpZwU+p8sqTPb77eq6go/pd5n7Qq4LBHGK8rOiUMGBNq77eUI9QAK/+F14rSTVJY7pvBvHaui1rrQ8rm1XNSnbETTQsvGwEPXom2Zz5FijtMWtmB7eB7eD1wptXmhyDUjpcU7+OEGBqeMHu3VjwTTj6wZjpDErm/Daw1AmcydX6kXQWxfTQdzmnE9weWim3UNVhtfJ1B9mVwWT4wxBEFrigNE8Hzxyp+YmVx+KbUWOzcaXxSFc0eZI+QP4hb9mVK6q935NDuFKdaUChGoshE99pd7663dT5SaaDYrVog31p37ubL0ZzQN42yU9b8lcBkm/sVBIVZ8+2TnO/VhlCGdcABKnZHWEU5R4qxEitxDvohZLYdAfA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 28, 2024 at 08:34:49AM +0200, Christophe Leroy wrote: > Hi Charlie, > > Le 28/08/2024 à 07:49, Charlie Jenkins a écrit : > > Add support for MAP_BELOW_HINT to arch_get_mmap_base() and > > arch_get_mmap_end(). > > > > Signed-off-by: Charlie Jenkins > > --- > > arch/powerpc/include/asm/task_size_64.h | 36 +++++++++++++++++++++++++++------ > > 1 file changed, 30 insertions(+), 6 deletions(-) > > > > diff --git a/arch/powerpc/include/asm/task_size_64.h b/arch/powerpc/include/asm/task_size_64.h > > index 239b363841aa..a37a5a81365d 100644 > > --- a/arch/powerpc/include/asm/task_size_64.h > > +++ b/arch/powerpc/include/asm/task_size_64.h > > @@ -72,12 +72,36 @@ > > #define STACK_TOP_MAX TASK_SIZE_USER64 > > #define STACK_TOP (is_32bit_task() ? STACK_TOP_USER32 : STACK_TOP_USER64) > > -#define arch_get_mmap_base(addr, len, base, flags) \ > > - (((addr) > DEFAULT_MAP_WINDOW) ? (base) + TASK_SIZE - DEFAULT_MAP_WINDOW : (base)) > > +#define arch_get_mmap_base(addr, len, base, flags) \ > > This macro looks quite big for a macro, can it be a static inline function > instead ? Same for the other macro below. > I had overlooked that possibility, I think that's a great solution, I will change that. > > +({ \ > > + unsigned long mmap_base; \ > > + typeof(flags) _flags = (flags); \ > > + typeof(addr) _addr = (addr); \ > > + typeof(base) _base = (base); \ > > + typeof(len) _len = (len); \ > > + unsigned long rnd_gap = DEFAULT_MAP_WINDOW - (_base); \ > > + if (_flags & MAP_BELOW_HINT && _addr != 0 && ((_addr + _len) > BIT(VA_BITS - 1)))\ > > + mmap_base = (_addr + _len) - rnd_gap; \ > > + else \ > > + mmap_end = ((_addr > DEFAULT_MAP_WINDOW) ? \ > > + _base + TASK_SIZE - DEFAULT_MAP_WINDOW : \ > > + _base); \ > > + mmap_end; \ > > mmap_end doesn't exist, did you mean mmap_base ? Oh whoops, thank you! - Charlie > > > +}) > > -#define arch_get_mmap_end(addr, len, flags) \ > > - (((addr) > DEFAULT_MAP_WINDOW) || \ > > - (((flags) & MAP_FIXED) && ((addr) + (len) > DEFAULT_MAP_WINDOW)) ? TASK_SIZE : \ > > - DEFAULT_MAP_WINDOW) > > +#define arch_get_mmap_end(addr, len, flags) \ > > +({ \ > > + unsigned long mmap_end; \ > > + typeof(flags) _flags = (flags); \ > > + typeof(addr) _addr = (addr); \ > > + typeof(len) _len = (len); \ > > + if (_flags & MAP_BELOW_HINT && _addr != 0 && ((_addr + _len) > BIT(VA_BITS - 1))) \ > > + mmap_end = (_addr + _len); \ > > + else \ > > + mmap_end = (((_addr) > DEFAULT_MAP_WINDOW) || \ > > + (((_flags) & MAP_FIXED) && ((_addr) + (_len) > DEFAULT_MAP_WINDOW))\ > > + ? TASK_SIZE : DEFAULT_MAP_WINDOW) \ > > + mmap_end; \ > > +}) > > #endif /* _ASM_POWERPC_TASK_SIZE_64_H */ > >