From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F35D7C636ED for ; Wed, 28 Aug 2024 17:24:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6EA166B0085; Wed, 28 Aug 2024 13:24:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 69A696B0088; Wed, 28 Aug 2024 13:24:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 589096B0089; Wed, 28 Aug 2024 13:24:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3C8FA6B0085 for ; Wed, 28 Aug 2024 13:24:06 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E6436A044C for ; Wed, 28 Aug 2024 17:24:05 +0000 (UTC) X-FDA: 82502327250.16.82C3EFE Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) by imf17.hostedemail.com (Postfix) with ESMTP id B84A140015 for ; Wed, 28 Aug 2024 17:24:03 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fj+k05aH; spf=pass (imf17.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.173 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724865799; a=rsa-sha256; cv=none; b=BjN6SOFT+8igQ/CMUCpzsvLQjD7NltvXm+o/STjpovd+fJL7BLz2GslBD41Ib11KtW3kiR jysxB+UjaPsXDQlV3Y3OOe7BAg2eDMsp1j0ZiKX/MKhTzkyuZUgMn6UVk2E5gLCQSJWp9y 9+PBlvlA0oKtiB5ya6yHZkjNxC1WL4s= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fj+k05aH; spf=pass (imf17.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.173 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724865799; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wKSf7KHGE8x6jvVOVqxv8wQa+Jwbt0tqgqyGwouit5E=; b=Q5aTbh0i8AhQkmwGaXMwgxjy46cGvhLhX6bMgAq2z36t9MbXEBWK78V+LsP4To7+q5NoDU b4VUfqC96xAwaTzhzZ46opdN8mPjROKypzO8WL0igSoGi47Vlx0jVGLzgocbcSn87USSQV o5YJsvM4xq3bemQ2xGQx1ut++dWnYAY= Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-2f3eabcd293so78611741fa.2 for ; Wed, 28 Aug 2024 10:24:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724865842; x=1725470642; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=wKSf7KHGE8x6jvVOVqxv8wQa+Jwbt0tqgqyGwouit5E=; b=fj+k05aHfhVY9uOuYm2VOAoHNEKbfOqMPhhZRyDtLBeKYdQ/TzB+pEizk3ANkYFiC4 J69/mQc8AT3naucQguiBBvh0ZGRgISJhqrUvNWiGwk2wSeGX8cjvGRLnqc1yWNoo8iTb LmID5CUY5mjOj1l+WtQcT8vFTHqMeGxp09/B9A4hIr1pYyw9dnyY4P/lDsWoRZu8A3m/ ysNYV780tTD6T4UKhIOAjhRQuR+zunec9655vG2bS4//THC3mlU8eE9nA4NmSeyzsF9n hkNkx/pyUvJQpxlACzhWuwzx3zbZAHT0oRNxAxSSYfCDcd+0Dya9wrLQjLEgnWU0oQA6 PtQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724865842; x=1725470642; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wKSf7KHGE8x6jvVOVqxv8wQa+Jwbt0tqgqyGwouit5E=; b=AhpCh+vTVfVztyyp7ibOlCCuio5i1O9OxNqmdc7O+0yNNNnx6NG0TuamzkjRycp0fv 7N2ik4OzHXckmVFQPYufrC83DkdjhFsq9lh26WYVPSIpXfLr6YpjSquZDU9WC+UTjxj2 oC0ZnWlrJH/ClL6kFfJ2Ubc++dX4NStAXdjt2NBKpzdpimo/xwTcaiFUos/kHV2CoeQb Yk79UfBX2ph8ro4drlVg0ju+oPcEFCnQJezQQR5yrbuDAgIst5FDAzDmb4toxxD13xI/ cRRTh3+lNeVCMIuSPlSlSMRirLGF6cgkxVWNYv/s+Iyu/nrcz7yIqlckBwLqkMBE3p3U PR+A== X-Forwarded-Encrypted: i=1; AJvYcCX+WlqChJT5oPz0nJLW5ITzuR3pTvByOy+T8idi0UfIVP67qr0CT65b6y818xlHn1uBwZobb/iDbg==@kvack.org X-Gm-Message-State: AOJu0YypkeXZmLS4b+zVbEMTVmHCTUWhUWO2wiubTEbW5/PKVGRVYEdv Okpif7f4lDwBvLcgjQPrOEJ1fakEi9iJuWHzovVKclBL3VKrDFO0 X-Google-Smtp-Source: AGHT+IGsw/F5hC5DWs12E3b4scBC2HyWOsUKn1a0W2LDOS1mCJtNnBGRm4CD71rylVT8vnXP8/sAgg== X-Received: by 2002:a2e:4e11:0:b0:2ec:55b5:ed45 with SMTP id 38308e7fff4ca-2f6103f62cemr2492661fa.24.1724865841293; Wed, 28 Aug 2024 10:24:01 -0700 (PDT) Received: from pc636 (host-90-233-206-146.mobileonline.telia.com. [90.233.206.146]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2f40487f80csm19726941fa.107.2024.08.28.10.23.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2024 10:24:00 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Wed, 28 Aug 2024 19:23:58 +0200 To: Michal Hocko Cc: Uladzislau Rezki , Hailong Liu , Andrew Morton , Barry Song <21cnbao@gmail.com>, Christoph Hellwig , Vlastimil Babka , Tangquan Zheng , stable@vger.kernel.org, Baoquan He , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH v1] mm/vmalloc: fix page mapping if vm_area_alloc_pages() with high order fallback to order 0 Message-ID: References: <20240816114626.jmhqh5ducbk7qeur@oppo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: 163481wm19dkzubabz7kxusdnfa4uc4g X-Rspamd-Queue-Id: B84A140015 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1724865843-127280 X-HE-Meta: U2FsdGVkX18XebC6oQdkoyYRc2wkvwizHWee6aRK2yJxYeCycCYukJXzP9e5JpgeRzMldIrpAaWg+s6GEkdomKOMRxZA1HbCvJIbev4CJbGoCdLB+eqlq6huj2ufizS6x2tbgjvPOjS9gXj0+4k6ZsNK35yyEFzj37/nGS+p99LF75mCd12BZ7rU229dzkb+jN89c6P+r1MKC0Lje3LoHvQFRQyLdE7cswOozk35u1UdDXGY4wQLBLhBHOxrT7Tmpo4t5wkuzlAsFcBnr/Yq7FcsQGTrw2uXwP9DJmaV3aPOBpCz+r4on0naUXVL67xFEhOZqSPCtK05TEHWWmMXvkmDMzL9vfGqWzjI5bKspxIxSlf3RfeDn89W+ODpelLROCOtWeQPNDpAtqWPD4nFD+4+8lolrMcuCe3WZz6YH/IcgkoXrLyh07cIIgHFVYEc2+h5bzHhKzZCb43sWgfQqcB2o+XAJOMO5tM0qQMPo6sSeZH+D2KpzJtI3c+eYf9VwtLpUnvXNAxpQaPYvGHmwKSRtviadQAnq6zULsLPyb5i87MsXIfrcjPXZnSDVTONS+RkhOhodMo4F2C37Xqao3oMW0MOE6fIb9vWD7EkUbqdnPXE9u1EieBVXqdYleY8pT8mH8tt0LQ60p9NlkLK04IVAxaxyhdvB7c/uKAh34eSVgad8Qc5whUmFEiEy+3q9r35iH6GKTpHhvcM0UfnJhVaIOY3/wcUbco0jjQg0A4ZfcHd4a8FiYj+nuFzUgSuDNJZlPB05CKzQi4AtdGovdc+NCxcfEI2GuMmGK1W07sJmCQqqL3ALg57RodCG8MIVf3pS0mY052Dz4kbRg4BBzXvlAxofz9fY7TVRyn90iL0PPwmyKHevo20Uz1DzCBqpKzHmVHAPa+yyiInBsB4yf+7ezTwuEm0U663ISCs8FuVz9iiEgXva8wyYYys9yEQncWt3vadZRLd/rXnGB+ p29TyR32 7AgfMXyrLNBa2eiwzgI+EkU9X34FoZ4dY3tEL6Uu7SFY+tpUPHq+YJ9Ed1wpsUsBGLJYlYi2Isb5LwmjrtzBhzYyrAkQ4lBSPaAn+lcXV27cfz+UwTDglDIoquI/mjf81MWwVk5tXHSYxOQla64/cjLwoYVQp6VJPxG1O4ZtjzPmgcJOcd5K7R7d3g/VNddx6cCNwEGR7Dn8pzCgFtCITTZawg2pYQ3lMkJQ+GisgN9nnk8FB8PkAdJt9g98GhJObfMD6jSee193P0cCJyDJ5tz/Z7NTyrILLiGV3PQhwI3XSGn6frNHWwzTt6yKRgpSwThhli5XL/GhLLl/kWYeWRjBtaFaa44vHz7M0D3sIK9+ePedZFE1OF7YQ2221PGIij2zJrAqxnRemub3vqNDW3YvD8QUKJY4vMU6aMe/ZNWXmRrpNQnhBBp4KfJiFz13OC0g3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 28, 2024 at 09:14:53AM +0200, Michal Hocko wrote: > On Tue 27-08-24 17:29:34, Uladzislau Rezki wrote: > > On Tue, Aug 27, 2024 at 03:37:38PM +0200, Michal Hocko wrote: > > > On Tue 27-08-24 14:47:30, Uladzislau Rezki wrote: > > > > On Tue, Aug 26, 2024 at 08:49:35AM +0200, Michal Hocko wrote: > > > [...] > > > > > > 2. High-order allocations. Do you think we should not care much about > > > > > > it when __GFP_NOFAIL is set? Same here, there is a fallback for order-0 > > > > > > if "high" fails, it is more likely NO_FAIL succeed for order-0. Thus > > > > > > keeping NOFAIL for high-order sounds like not a good approach to me. > > > > > > > > > > We should avoid high order allocations with GFP_NOFAIL at all cost. > > > > > > > > > What do you propose here? Fail such request? > > > > > > We shouldn't have any hard requirements for higher order allocations in the vmalloc > > > right? In other words we can always fallback to base pages. > > > > > We always drop NOFAIL for high-order, if it fails we fall-back to > > order-0. I got the feeling that you wanted just bail-out fully if > > high-order and NOFAIL. > > Nope. We should always fall back to order 0 for both NOFAIL and regular > vmalloc allocations. > Good. Thanks for the ACK! -- Uladzislau Rezki