From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A0D2C54FA6 for ; Wed, 28 Aug 2024 12:32:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E69A66B0093; Wed, 28 Aug 2024 08:32:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E19CF6B0095; Wed, 28 Aug 2024 08:32:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CBA8F6B0096; Wed, 28 Aug 2024 08:32:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AB6266B0093 for ; Wed, 28 Aug 2024 08:32:11 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 31798141F02 for ; Wed, 28 Aug 2024 12:32:11 +0000 (UTC) X-FDA: 82501591662.14.73E72AE Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf16.hostedemail.com (Postfix) with ESMTP id D971018000A for ; Wed, 28 Aug 2024 12:32:08 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Ylhitnry; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9ef2ohah; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Ylhitnry; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9ef2ohah; spf=pass (imf16.hostedemail.com: domain of chrubis@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=chrubis@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724848212; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fmPSln6c5B+FV+YUNh0QDolNKs8XpaxC/uEPxFy87D8=; b=K9UJIGcNkiHdKgBKh/NixwnYiJ8n3qdqZVJbjzmcwIeUFruNmFmpJtgjm24nF/D3Ec5SkM ZnleJB6CQq7DZfigUNsQDUwn5jpue6XzvfXDk7JeHLUwEN0ROG2/1KZyK3MNVozDpf6wBP lKpOE+6mcGnjdA9k/spGGDU5Qzdlxvg= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Ylhitnry; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9ef2ohah; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Ylhitnry; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9ef2ohah; spf=pass (imf16.hostedemail.com: domain of chrubis@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=chrubis@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724848212; a=rsa-sha256; cv=none; b=a47rrotnFOlEG0yl1xGcpZaPPNE9i+AwYWQR6GT/V5+akoSbgT6KDlv5pOtEOInwoikyX8 vBx7YBLmo/v62+5GlsHb3fOCrtUcKDKTJqgVbkUfS2dd7olelEHmij5PyBUZRCINzWonmF e+z0f2breLBBAbNFtKIXrVck3bhTIgY= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2FC9721AA5; Wed, 28 Aug 2024 12:32:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1724848327; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fmPSln6c5B+FV+YUNh0QDolNKs8XpaxC/uEPxFy87D8=; b=Ylhitnryifo8LAVgCa+OweNjUUR5/KR2VsKOOOxJlqqrhpHXBohEpF7eTUPdRb9LQqlnDM sxSLrU5dPf/fYsWu3cNIhV4dNnhuB+cIYKBwmPrdmfweG8QjjL6X/vx+Y2rNmkGnLATNkc vB3VWDWCVfFQZWhs3PSaBLqZr1BVZnM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1724848327; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fmPSln6c5B+FV+YUNh0QDolNKs8XpaxC/uEPxFy87D8=; b=9ef2ohahONxCCPMSHlrSjUbWygEYmBLoGzhfsHrLo50wEmdJ1WhOMp09WAcAwD+FphmEa9 CCqva0Y2oB9bbZBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1724848327; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fmPSln6c5B+FV+YUNh0QDolNKs8XpaxC/uEPxFy87D8=; b=Ylhitnryifo8LAVgCa+OweNjUUR5/KR2VsKOOOxJlqqrhpHXBohEpF7eTUPdRb9LQqlnDM sxSLrU5dPf/fYsWu3cNIhV4dNnhuB+cIYKBwmPrdmfweG8QjjL6X/vx+Y2rNmkGnLATNkc vB3VWDWCVfFQZWhs3PSaBLqZr1BVZnM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1724848327; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fmPSln6c5B+FV+YUNh0QDolNKs8XpaxC/uEPxFy87D8=; b=9ef2ohahONxCCPMSHlrSjUbWygEYmBLoGzhfsHrLo50wEmdJ1WhOMp09WAcAwD+FphmEa9 CCqva0Y2oB9bbZBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 1763C1398F; Wed, 28 Aug 2024 12:32:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id K3xFBMcYz2ZWFAAAD6G6ig (envelope-from ); Wed, 28 Aug 2024 12:32:07 +0000 Date: Wed, 28 Aug 2024 14:30:59 +0200 From: Cyril Hrubis To: David Hildenbrand Cc: kernel test robot , Claudio Imbrenda , Ryan Roberts , lkp@intel.com, Vasily Gorbik , Jonathan Corbet , "Kirill A. Shutemov" , Matthew Wilcox , Linux Memory Management List , Sven Schnelle , Zi Yan , Gerald Schaefer , oe-lkp@lists.linux.dev, Andrew Morton , Christian Borntraeger , Alexander Gordeev , ltp@lists.linux.it, Janosch Frank Subject: Re: [LTP] [linux-next:master] [mm/migrate] b28dd7507f: ltp.move_pages04.fail Message-ID: References: <202408211026.636ade1a-oliver.sang@intel.com> <767d1908-dc30-42ae-9a8a-d2ad42a4d491@redhat.com> <8bde28af-3401-4d72-b821-d8cf01bbcd64@redhat.com> <4c190c79-401e-43a9-a4d1-e64f78110e0b@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4c190c79-401e-43a9-a4d1-e64f78110e0b@redhat.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D971018000A X-Stat-Signature: zyoz9dny3nnnyg3x7muys7wh5esi4hkt X-Rspam-User: X-HE-Tag: 1724848328-985442 X-HE-Meta: U2FsdGVkX1/iNtdZYt/yITHdklcai89UELf9Bs4oyKyU75mBd4HAFoE7lKmHyL/5OpAnaTjXcUuXGqY3LqvKKLZQPvS0DJjETZmnljQasWdIDH0uGRxISZ2KUQkfFn7OBY1BOO5EtBwy9sw06xs7XvruKE0BV9kzB6EiUG1WFxpkMz1S+N7UNJBeqMddQ2dUSku25lHxojXfeAaFrIWjNOoraBhBQOjZZ79Ur/jSJXNxJUqMruqtD7xSWp97fg/9KnRAqbFF4t6dU0aoNF0xtPz3JWvwRe38suBPofx/EkwprThzjh3IEmC6Iq6G+QsmV8OkVQ6jzvYjbj9oP/CZftAPFKaO9HbV6iceJwTTcP9jX/wOdng0U39wMewD5zy1yDpnHyLCQkXjGCcGIocVn8oGPMLrx6ARjfwQFTeuVpX3hxCdVvngSOqtKlznKpJfCM/b0MW1OlCJhHZggEQ+A3RJtibME1ktHDz/g+K6yc2EZmzTn1un4loxbSNZAMaHrfgnGTKr/J+OdbUAnB8WxJIo4d0Vm7ZiFJsBQAVSe+o4P22z1coCYOvf3umzzs/AVB3pgg07KsxeECeYElaVqzzWQf9Z81+3c3cKpS9M4qnhio6qCjsYLuvR560YEPjYujSc/309Q1D0XsGT2UexbubFke2Qk0ctrurGboilwS7QJRRJ124uwuhae5XwnTTRQ+ZqPgwGthOFlisykwZaLoAoIa7YICc2Ngr98Bz1L7ig87wxTiC70DP5JayQhl2Wqu6JI9tSeK2RrQrvi0+dQMjU4LwvBjhfN5YfNZfaGBDsJNwsk/jOzUbairB0nIjZYz6I5d08u9Q2xId0Lhhuol1nokx8q9m5/WcDayqmsAmt7DDjREl3LEFvQaIO0olojmna7TSoW2mUOLH28r3jrQ0GiAza6PsoziaHs4HW7OwT7Ug0o2aMx+s0tEeHUwqb1e5PlM5joRuRqrq9DiD ThNd2WAu tUO3DdWM06KFooEg9EN+7LyL2azkJFgIT77c1j0jBY5Hxs97+ipA0SAreSl34yKOPS503BQQ0FjFXlrsOnJC3cck0J71lfVyErgka3pR2fjep+Ln1B2b4MDWB+kMaeViXF4Y5JZ73VxoWIuGE3C4mdrSIUfbJa6fQBaxkoUMuTHFvdJM1pXBY5j+4tVX6L3uDaect7zo8VO2cz2Vit9RHd8GKolSYJvPZxSyudGsc1dNKk/ISWq837vZDKRKpGG3PJ3hY8hIfOn8PzeySBDyBxNE1lXTGRi+NN+ln X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi! > > If we are going to stick to ENOENT for page that wasn't faulted in the > > kernel from now on we should stick to it in the test as well. > > Right, it will make kernels >= 4.3 fail, though, until this series is > upstream. I mean, it highlights a BUG, but we had a similar condition > with the zeropage and worked around it in the test to keep it passing. What we do in this case is that you are free to send a patch, we will do review but the final merge will happen once the code has been released in the upstream kernel. > > Also I think there is a third case that we do not cover either, what > > happens when we pass an address that is not mapped at all, e.g. NULL? Do > > we get EFAULT as well? > > Yes, that's documented as EFAULT and should behave that way. I can > extend the test to handle that as well. Ideally the test should be ported to the new test API as well, but I can do that later on the top of your work. -- Cyril Hrubis chrubis@suse.cz