From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 421F1C54FA6 for ; Wed, 28 Aug 2024 12:25:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D040A6B0085; Wed, 28 Aug 2024 08:25:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C8D336B0088; Wed, 28 Aug 2024 08:25:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B07346B0089; Wed, 28 Aug 2024 08:25:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8E1016B0085 for ; Wed, 28 Aug 2024 08:25:11 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3956C121F79 for ; Wed, 28 Aug 2024 12:25:11 +0000 (UTC) X-FDA: 82501574022.29.079AAE7 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf13.hostedemail.com (Postfix) with ESMTP id 02DC12001F for ; Wed, 28 Aug 2024 12:25:07 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=vAX10Aeg; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=OS1o7Xbj; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=vAX10Aeg; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=OS1o7Xbj; dmarc=none; spf=pass (imf13.hostedemail.com: domain of chrubis@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=chrubis@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724847843; a=rsa-sha256; cv=none; b=BmL+5CA4BfETdpI57U05rnm9QQnyg5ve+OovzPbMlVZIUuzJXaSIDqLr0xO6j0ayOPXe49 +HdBNePZRgqpkhpUP1XZsVFVUQ6Pa4hpU6Wxkckn7eOORzB1BaWdDMdpGOWfMJik/NCru0 hB6fEaxypuTf0ni9wajGIrlL0giEwOk= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=vAX10Aeg; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=OS1o7Xbj; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=vAX10Aeg; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=OS1o7Xbj; dmarc=none; spf=pass (imf13.hostedemail.com: domain of chrubis@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=chrubis@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724847843; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9XE2b54FEL2svPWeuarIeaLeQ+ZaYjLgKlUTER71GnU=; b=aBoHmsQuWlHDBKGIVEsq92ECfIAclXmfIVzttu7jgkY+y5DTmIZPQc5/jWBpVbRI15Dexx 0hv9hjn8lKwkszR/jz51/08kOg200KlrMUlgjsyqo0X+LQ+CHbEHZYNI+xAliggML1vaI9 b3jwdqaX6Pzik67/PDW6u8wPpGjY83E= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 27A501FBB5; Wed, 28 Aug 2024 12:25:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1724847906; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9XE2b54FEL2svPWeuarIeaLeQ+ZaYjLgKlUTER71GnU=; b=vAX10Aeg3n/LRdv7XkGFCL29I+7WC1NoXxDIhrSClOeFmWU2JBEAT9xxkXA4V7HI8OpMvf r1bCyPOb2zNNfHPZq3LbEAUgFyrP42gKx3WhvalrvdkItafFUKWUOmjG2BHqh731/w053M yFQlXtlU14wcIX3/k7PGulslS6P0iZE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1724847906; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9XE2b54FEL2svPWeuarIeaLeQ+ZaYjLgKlUTER71GnU=; b=OS1o7Xbjd1E4Sw8OfTLxXr5S0C37EDFEExcxziAGhkEAW+wMzrXwnwkoStldu+NCUXDn/6 URhZaZSMih7XpVBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1724847906; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9XE2b54FEL2svPWeuarIeaLeQ+ZaYjLgKlUTER71GnU=; b=vAX10Aeg3n/LRdv7XkGFCL29I+7WC1NoXxDIhrSClOeFmWU2JBEAT9xxkXA4V7HI8OpMvf r1bCyPOb2zNNfHPZq3LbEAUgFyrP42gKx3WhvalrvdkItafFUKWUOmjG2BHqh731/w053M yFQlXtlU14wcIX3/k7PGulslS6P0iZE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1724847906; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9XE2b54FEL2svPWeuarIeaLeQ+ZaYjLgKlUTER71GnU=; b=OS1o7Xbjd1E4Sw8OfTLxXr5S0C37EDFEExcxziAGhkEAW+wMzrXwnwkoStldu+NCUXDn/6 URhZaZSMih7XpVBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 15B1E1398F; Wed, 28 Aug 2024 12:25:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id zxRXBCIXz2b8EQAAD6G6ig (envelope-from ); Wed, 28 Aug 2024 12:25:06 +0000 Date: Wed, 28 Aug 2024 14:23:58 +0200 From: Cyril Hrubis To: David Hildenbrand Cc: kernel test robot , Claudio Imbrenda , Ryan Roberts , lkp@intel.com, Vasily Gorbik , Jonathan Corbet , "Kirill A. Shutemov" , Matthew Wilcox , Linux Memory Management List , Sven Schnelle , Zi Yan , Gerald Schaefer , oe-lkp@lists.linux.dev, Andrew Morton , Christian Borntraeger , Alexander Gordeev , ltp@lists.linux.it, Janosch Frank Subject: Re: [LTP] [linux-next:master] [mm/migrate] b28dd7507f: ltp.move_pages04.fail Message-ID: References: <202408211026.636ade1a-oliver.sang@intel.com> <767d1908-dc30-42ae-9a8a-d2ad42a4d491@redhat.com> <8bde28af-3401-4d72-b821-d8cf01bbcd64@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 02DC12001F X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: zi5ds1y8ps3pqrnpdofbyugfimokp6h5 X-HE-Tag: 1724847907-676726 X-HE-Meta: U2FsdGVkX1+x6VNIP+oSssj1Opn2x7rPPBACBeHqGb0t9sEMLpHtIAYPjcHCWxqChq/P6/xWKSf6B/4LKNx6NvUFlsY74GuLvS+COw4/xDDdWhCM6+TsSaVIVwbhpLFWu/532lfJqH1H7yI6NqENrQxYBnOATgjyBVLnJg6keNIF+14lkXvA6LDRHt05em+7RuI8WoydUtgB9RcK/VbqKbQ0dAcVnpHvKbUchzhorOEf9DGAVX2nPr/aDnb3sWkig8F3Or+ufRyUv0/72vuKPQSOTANHgcHNt9o/nF4O6k45BWKHY0yJgPMl5Kk5jF7bK8h6+9VCzQlpR4+2a73nKGR9x0CfXm7ByagFxKEaYtAA0kWXSZNkk0gqhCDYzT7RTK0qF707fTzF4dJQnYYpo89lr1E5mwfxKSN8xnv9KQ1VxiX9X1WW3W/FK4YvKHxIIUVQtJaO85Bwiy/VDaNi3NgeuTv/CMGJDI+90wmP5RyfvNizHEM09dFYNZuPWLxX/gp9YDos9W2rFZfwdVvZvu5GwbhxuoBMpCqRdEQN01d/LTn8QeMDIs6Fq5suEzqwSvIOm0Klwn7SnbTa2AHUoSh/C1bdDSRGQchjk0i/EeGd7LocfRFl9IQoRFpSYOyH4e4/lWtINYg2RTpilQqNhTvjJ3vZIlbeCUCDAUvO2RrKVFRozF15MYIU2879zmGq9MoFnJrnjgSRHPSvhOINNBTXUQ6rPdAFRdqJl5cgs7vd6LK2pInzg8gNQ4NO3ftohbC586abxwejH1yFd17qr9HFBmYWSRR3fjurm/k7wBulTu3ZbjZjGiUj07B/BMrbQjYeWU1zU5Pbd7Q5G2rwxfGX4jXtlVnCdUTXlO8KB6S/vwz69Xu+p8j3vIK/etZclyyK++cdYjJGa7jK6BUNsbeo95lVbdOx9JeI7iEIAisrFGjXE1TVHcPl66DeYkykY7Zkg7TXurEJCHP2dZm yl4XsVPo z2YWuHn78mMOqA6RiMZHRDmSQWs51xWkkOkS4pUZYHJ/RvZQUAnh4fTp7ZEYT1/khntPF5ht+P19eYX549WKRYiYvnics6SVqDG2Vee2M/lVgOe5H3pCRHesFqzj42tV7FR2Pen56ygh512sxX00+or/TuzJEUHO17bF8rQ46GzsI17EHu6eFXPEvR7mUGD1KxWeZBKB+rhBBYoPS32ramjRIFkgkQ8KQBlhkeqIK5683uHf3J32svOJ1JZKTaLqKD4TudgkADTOcj4ZOuIk08Y9dLowR9h8rW2ce X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi! > I am not yet sure if we should simply allow either -EFAULT or -ENOENT for > the "nothing mapped" case in the check (below). > > Alternatively, I agree, wee need to have this in the kernel so we can > check for versions. > > What would be your preference? If we are going to stick to ENOENT for page that wasn't faulted in the kernel from now on we should stick to it in the test as well. Also I think there is a third case that we do not cover either, what happens when we pass an address that is not mapped at all, e.g. NULL? Do we get EFAULT as well? -- Cyril Hrubis chrubis@suse.cz