From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F204C54757 for ; Wed, 28 Aug 2024 09:22:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E58CF6B008A; Wed, 28 Aug 2024 05:22:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DE25E6B008C; Wed, 28 Aug 2024 05:22:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C5AA16B0093; Wed, 28 Aug 2024 05:22:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A6A6F6B008A for ; Wed, 28 Aug 2024 05:22:45 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 254811C4A46 for ; Wed, 28 Aug 2024 09:22:45 +0000 (UTC) X-FDA: 82501114290.04.2F2444A Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) by imf28.hostedemail.com (Postfix) with ESMTP id 17254C001D for ; Wed, 28 Aug 2024 09:22:42 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CZwdnz52; spf=pass (imf28.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.179 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724836876; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h2AH3ekAvrtakcd1TBHkdkleAxugEjTYmpcEnIOMybE=; b=oKW4Q10P3W1NnWPd2SCmWtBSvLyDCjltnxJiNUEGHnm/igAP9BkjUVGH/btH1fRIu81qVB YzAVRP58B06I+PnOzsDCZyRl55f1iw9HC8/EecY3GFTvlCjpUbbQ4K0El7sOHi2GMY1G5j xeUCDmSxw6t0xyO5f4R0LYJ8//1SVqo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724836876; a=rsa-sha256; cv=none; b=mf2u31B0xDJMfZVKI9zB/NcMne+8AxKKRC8ReyhXpm+RjJKT9HRDyUpnrwuLCgHAyqug1t TZkeIgYEEe2o8EbcoUwgJwLsztlksh89C3jlO3pOEVczTxVv7SIPDyO0WvxVy99rxdryHY aRucUiWcbQIw5SJs1u/OySHNudXeMtI= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CZwdnz52; spf=pass (imf28.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.179 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-2f50f1d864fso30594101fa.1 for ; Wed, 28 Aug 2024 02:22:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724836961; x=1725441761; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=h2AH3ekAvrtakcd1TBHkdkleAxugEjTYmpcEnIOMybE=; b=CZwdnz52Lb3LyVcMq91mIeMk1PRDjdKIF/mfePiFJvcVN49wSmH0aDOXNJwyVw7Yjz Sh8CiUEYfHoPyrHN3vilQ+leEeBDn3f81mxRXiDvX9IqnLghcCIf2jSP8q9HfP7Q+31f 3ZV/2SJaW6W4ippLO+0GIAZrf8L9uD6PKQT5p9O81K+UQ6h1VQxLHQMBMPn+m3VDYduh rxGbf1+5lfRmJJK595eEiBg0t/l2dktoBvCRytWnAW+mxqUTKg6VQ2B23miwiJFEdylD Xt9n4G6HnLjesCdA8PlEldeicolaGFdFLjXTOPeLpYQbQzZRPpO/sAN2RQSOFBwAlZ+r d9Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724836961; x=1725441761; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=h2AH3ekAvrtakcd1TBHkdkleAxugEjTYmpcEnIOMybE=; b=LKTE4Im8K3OK8b9pepEBVAWFOcSH5mCOvEyy4Lz646lPZF8tLcnKNMTGNNn7DEu1a6 NRBR0yCycrzcFE95TnYzKfHFYuyd2Y+EcnNboQ7G3LeIBFCBCFuZjPTdfyYxNTOnY7WG 2Kko87JoOLsmK9tgV5HuEmpRmq8UqR5btNs9hGfipOLd2vZGCdBLMDRf23Xz5qlKd6PE /EewnLXCcG3oBfoYe9EEvJCDV2KQwftcQw6/NAsOtdx1ysD6eUDy7CjT0KPyTghYP3W4 ujGwEXIKqeqqrq6UfmaqatMtALHU6XkosaKgnYb9IgksdLdPvqTWtMI8IjnBm9DzI1tF 1Srw== X-Forwarded-Encrypted: i=1; AJvYcCWfq2jE/+P4pbaisRQjQzKq9ts/oIMLmU52oybrnzftH4OIQ+JIOeNPG4r3nfAFkWhzFGb8UnQ06w==@kvack.org X-Gm-Message-State: AOJu0YyxZVX5/AcDpcHsPjA4yJwvSTNrQVmlougtv7oeOb/+V4BSJusv R4Lu43gDnykquOqnU5rHw9q1hKBXv+X/X3qppDobRNwFM7EH0kDQ X-Google-Smtp-Source: AGHT+IHzRcxAoOvhKp9xpsyJkulv0UbPkQBBSiYcOjzVM7wFwu2h9hBwOx4YUlrqW7g8/Wy1DGSd6w== X-Received: by 2002:a2e:95cb:0:b0:2ef:2f9e:dd1b with SMTP id 38308e7fff4ca-2f4f5758193mr88985581fa.14.1724836960391; Wed, 28 Aug 2024 02:22:40 -0700 (PDT) Received: from pc636 (host-90-233-206-146.mobileonline.telia.com. [90.233.206.146]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2f4047a4c30sm19067001fa.19.2024.08.28.02.22.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2024 02:22:39 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Wed, 28 Aug 2024 11:22:37 +0200 To: Hongbo Li Cc: akpm@linux-foundation.org, urezki@gmail.com, hch@infradead.org, linux-mm@kvack.org Subject: Re: [PATCH -next v2] mm: make use of the helper macro LIST_HEAD() Message-ID: References: <20240828041216.1222582-1-lihongbo22@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240828041216.1222582-1-lihongbo22@huawei.com> X-Rspamd-Queue-Id: 17254C001D X-Stat-Signature: a8c58g7y9epqggmfgqa31etw5cdok8ih X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1724836962-447151 X-HE-Meta: U2FsdGVkX18aP0bA+43qloURog/76ABRxXJrHHJ7Ag2xzal26gy6L8yEqHcMctterqIvDQWZaiTWUWswewkV5Sku22Vfr9350i2FL3DJ4gSeAx37w1ObC3K1XwVjomeMbSzTwqULEV+PfO8hCbc97I+MboL3Ev797EL+heCXNnJvm+xQxuv0pUYJU8z15RCjGsfGP9R3ZN0g98BAAja7vXGWr+Cw9atiUOjJ3bpm2uyrlrXAHezKraf4Ft6jk3fQ0o8N0JQQCwcIcgZPD4I9dgHBMaeGXbH1aBfCAtP+5+BOMXds+eIXO7+KA1VWFJm4LvNC+qYQ2gV/sjcj2FHB/qS5/Ohog1QcxbQ+lLvoxPe0QXEyfSvGSYG/Ogi/X42sYIwhffivhT0iiSkPq0MX452JAkRyiO41v2xO8YrE94VDQzRIahbxjKDumAJ5UKz2j/P8MiVrCYiZgaAv1fD8UK4ThOXaluYRbmI8qo0DI6lx7px6UCjy69wvaHypk3SPbs7XpGNqLmuY2Ei/IO7yyFMs4/hkrBzIFbNCfPbGWjBK8L2WBYCXgq/EwlgXarS39DUluyaYhJK2qS9B8UTD9W+wv+aLRu+WSP5kHVPQTdFXingZ1FpktrdGIYR0/Z+4D9HZ3crWTF7gRLz31le0jK4uPAKrCzCv4vy8sKCEwAjpQhFdWYmAPq6lFUlEYvs62yrxjbNdQ9lye6lHAPD01Gfh9LJi0WvlHKggFOmjDOcwYYIXFKKv5CR/mUYwjhPAarGVevgKeJexm8R/i9DHbydQpGF/DCijoWBOom3wRtLKwUcFm7vCPDd79Xl1UgR4pjCyEKdJsoRC6cmOP2xObOJv+eHptZ/Rx1/zdoAXf2hH510hiFDQON7Ir7e3P6lMCVpwj2fbzQtJVgjP8cdvG8a91aNbPr4JCjqopCf6TVUE/ZN4ouygTnJVJL6IRsZP4P36CQ10Jr51cbd6AsT zd8v0NaS wwhUkBCMHpiGXKXbvLfuXHFDE/ms6OuOGSE9+NLbJUjpmipcINiOHijtIlOMCZrxYSCrm91yzp8fvctTkNx3GHSQGUTySBOOn2Y1h3fuVkuK50q5APHHGzUrvhAydR5L5jyCDVrhh8kneg76zfQgIqAqgnwpQHstrP47aR4NO8I/ElNXXShrc5gP7wNQ45YhR42M0cNIfcM9UPgCp86llOtqzQzMz0Rtz/wb6OoWLderHOq6lylnnc3c17gS44etOOqRmxvizTU+nD0ccD/yAM3MWRTCT3pdvyU5By5Z4sYO7KioB3RvFpR1yLGLuWrrn2UbNzGzyol5wFbwSb+1KMPpPPlbVsSCKw1nQDM7Iin1tuDmaWWHu0sod3e70mb5bNK/ZwViIQ5XQpB8msyCL23bxaIT2ZJUF1reENcBnWZnT8XSOIgTHgFWqyXJNQpasgD9bEH+V819Kd1jB2GWgz4NgOf1tnimizAHkUrsM3kDEL4+NPvbyk+35szbrkCbg/jY1X/pstErc2RUJcGr5AJMpl+YgKK4x6wQVwC6TTpIajgs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 28, 2024 at 12:12:16PM +0800, Hongbo Li wrote: > list_head can be initialized automatically with LIST_HEAD() > instead of calling INIT_LIST_HEAD(). Here we can simplify > the code. > > Signed-off-by: Hongbo Li > > --- > - v2: > - Also adjust decay_list according to Uladzislau's suggestion. > > - v1: https://lore.kernel.org/linux-mm/20240827015724.620110-1-lihongbo22@huawei.com/T/ > --- > mm/vmalloc.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 3f9b6bd707d2..6fc736f74ae7 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2131,23 +2131,18 @@ reclaim_list_global(struct list_head *head) > static void > decay_va_pool_node(struct vmap_node *vn, bool full_decay) > { > + LIST_HEAD(decay_list); > + struct rb_root decay_root = RB_ROOT; > struct vmap_area *va, *nva; > - struct list_head decay_list; > - struct rb_root decay_root; > unsigned long n_decay; > int i; > > - decay_root = RB_ROOT; > - INIT_LIST_HEAD(&decay_list); > - > for (i = 0; i < MAX_VA_SIZE_PAGES; i++) { > - struct list_head tmp_list; > + LIST_HEAD(tmp_list); > > if (list_empty(&vn->pool[i].head)) > continue; > > - INIT_LIST_HEAD(&tmp_list); > - > /* Detach the pool, so no-one can access it. */ > spin_lock(&vn->pool_lock); > list_replace_init(&vn->pool[i].head, &tmp_list); > -- > 2.34.1 > Reviewed-by: Uladzislau Rezki (Sony) -- Uladzislau Rezki