From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C9ECC5472D for ; Wed, 28 Aug 2024 07:40:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F412F6B00AC; Wed, 28 Aug 2024 03:40:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EC8136B00AE; Wed, 28 Aug 2024 03:40:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D90B46B00AF; Wed, 28 Aug 2024 03:40:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id BA56B6B00AC for ; Wed, 28 Aug 2024 03:40:53 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6373B41D3F for ; Wed, 28 Aug 2024 07:40:53 +0000 (UTC) X-FDA: 82500857586.14.1CB4BEB Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by imf26.hostedemail.com (Postfix) with ESMTP id 2D18114001E for ; Wed, 28 Aug 2024 07:40:50 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=L6bvpbgL; spf=pass (imf26.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724830763; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8/HO53IZjem6ZqZU/Q133oXW+yDPYhQPPqizV4xDaYc=; b=nIiUfyck+H7X5MRA25gsMXousO582kh3O9ZHNyxnYodA2Eq0Ib3RkiRZZEc+kM8Wj+Qk7z 2kx1nMthFkaXapRj4bKnA2VnAEF/y3HB1hazDgarBNR1i0/dGXfBuzEVnSRjjX1EU1Lw7u eZq3w63e0oTliLk+8tpjl1ODBzbo8po= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724830763; a=rsa-sha256; cv=none; b=w+cBM7dN7HycALvkHJi1QkpN/UdoFK73kAH7ofHmgpHySeM8GxaBU2Ulmp8pOiK9Gj2oqg JJza0sjUINkB1QnnhRGI6iq9qIdy3WnAc+BQZC9mTW15/2peJdXJhEz/dw5fySXVNLZ0MB xpoj5UNB21S4VEUBvgrm/hbZhXlnz7I= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=L6bvpbgL; spf=pass (imf26.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a86910caf9cso60370166b.1 for ; Wed, 28 Aug 2024 00:40:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1724830849; x=1725435649; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8/HO53IZjem6ZqZU/Q133oXW+yDPYhQPPqizV4xDaYc=; b=L6bvpbgLnfqkGbcS6m1vhYKWJhw1TcRviRJD7G+2FipbHd5qI2YqNobFMCrtNpyLYV 4MGEKvW39ujfgr3QXHJShRZZzz8FhKKVY2lrVdJ0EysdU5VW6cO3rv82drCR12nf8ThY kVSeLQMVfdhAdrpwVNzjqICTrEPpQE8PfGpSHrrxRUyO+tHwZDndr1WHVTlh8yOmzY1J Sh7jN5zQ/f6QabpsWXWjL4lgVP6czB4WyBJZJV5XQAwBtfDaCKQSmqeGqv2Rr2I7I44P LMx5kAzet3qzefQqUFiEpdlRY22lola31GF1JkJHcHf1JjyAChRXIuX9UHn70wBw/aLE 5g7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724830849; x=1725435649; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8/HO53IZjem6ZqZU/Q133oXW+yDPYhQPPqizV4xDaYc=; b=Zv+QodnvCKYP4GW+X6SFCvlQheBvXYIXNr5S2gbT3rcVMcVghTYakKfG7E/zwEkxam /l7Ct+EaWKWngFnr6ON1UK6MqCy5zYvz9L/dhrMhJHk0BHWcrymIvevd/nbvpgC61li7 mPBsnsuSFYCLc9VBqmYRkH6RdzVa2ezZWw2DKNl3r8M2wdhGjk68X7k/ZwyyhLKJCLT4 k+B6IBQE/Ta7CxPd/HIdyj4IpXWhkSyLVebttvnPcx1qMqh+hYEdIWyfFe6+woVB/1E7 OZNA/I8C8shj3SK5AzylX3Jw37BKFvtkz6On/Mssf8xJgBG5bFVijCLKBRnG9ojQq1gr WkVQ== X-Gm-Message-State: AOJu0YzvTfxFmTZq7Vqrjtgt2GC6JzLXBP6cFzfT0zeLp/7+9hfT0gCE Yva35ObzIDNl0SXx4Gx9AFJvnUokrhko415x6H5dTSsLL91Q2jvq6sQlz9Hya60= X-Google-Smtp-Source: AGHT+IE9N33ZMb4zsUqXVziFRv2ddNM4ps7FAJMZxETN2W+HFqAa5MPv1xddujaLEs5wnqGN8cBZqg== X-Received: by 2002:a17:906:6a01:b0:a86:b9c4:a439 with SMTP id a640c23a62f3a-a870aade09amr129904666b.21.1724830849421; Wed, 28 Aug 2024 00:40:49 -0700 (PDT) Received: from localhost (109-81-92-122.rct.o2.cz. [109.81.92.122]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a86e591c015sm203103066b.191.2024.08.28.00.40.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2024 00:40:49 -0700 (PDT) Date: Wed, 28 Aug 2024 09:40:48 +0200 From: Michal Hocko To: "Uladzislau Rezki (Sony)" Cc: linux-mm@kvack.org, Andrew Morton , LKML , Baoquan He , Christoph Hellwig , Oleksiy Avramchenko Subject: Re: [PATCH] mm: vmalloc: Refactor vm_area_alloc_pages() function Message-ID: References: <20240827190916.34242-1-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240827190916.34242-1-urezki@gmail.com> X-Stat-Signature: uhwyysjky93eqw178bzyahr5ud8zng67 X-Rspamd-Queue-Id: 2D18114001E X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1724830850-144408 X-HE-Meta: U2FsdGVkX1+e5Y6BXxcWdqs2PWxWyjvzREmV5sbwx7/qOBiQq3KZaE61KdyvkLHSqBU8iVAqXHCMDw8z3W/3kI1RvVYtRyiLZFd0YXC4FEgm+lFi7GDVk/dVNrXKzbEI+j61OSMq/Fx745rWw29MSfgUM/qAr4z70PxVbp8XFqnH2LHhDnyXvoh6dXTaA+4j2qYFDjYaBhQsh+mBj3NJ3ht1gSqBZ94oxWwqDid+SP2o+cMv7CuxToUNUTdJ3S39INKgv4Pty3+eRjjYeD+jh5yWwyMTiUhGu23re6Jh+Y8ipjvFpC/JiTjgV9xRxjEDhgKDXhvwgf6T8GtIS/1oJytyKJ9p6qh+WhLPS2hJQQHNH14H8UfLRrR1vW06gIMv0CliVc8mFiUGU3dVLRDA6cSLKF0QXiY9/LNoEaGowgR6hyng+n/scgYSu0uwY16aR7Ot0d6MSXdPW77RoZ7OjpW3uP/BXecctp9qS3etdXwNVIU6+vjU9mHJv7dFVA7+IYxRt7OBkBpW5UnS84PloroO+PiZmpSUdJpsTFmxmMH1I6jPiesZoWBdUTst9Wco4Bx11TfigVacjw4M9GmTWfXtipRd9/mJUFKAfp2bXWvDXategJgvt2YT/RRAOTnx84ksu03cVbbyzfc9C1iyN8BUXo60B5UlCfjivLI+G978NCJIeV8uWL3dqaEXGqfNmr9uJ7qnGnJBQSDIB8NgenKFOpqfKetjm5POJJsPEl3cJnIlKI8GR+qBtmhF6XSd724BuBJAb2gp+11AZ33tdaNHHcE76niOmHTazJkEa5P83mdTlxiKr05EZOusmV4Q0/IT545zHXPUPnlcb+eUDqvaXu8iEJFJ4UgSHlacF0yLw3Qk4ikiZDFHRXt64m22hHBU6KxmDYmolR1Pe/odPWGp8TlvXrDgqnY+nIxDNyp6Yby58LSjioqFUtyFhEnNfQevEuge3bZl4cjWmzU 2ATKa1AV 3Vu5mRanJuaPuz5N6VJaMrNmpd3MjRSg8QpRtNwTgl2pcvFMyp9aSb/kRnKt4ugZqLUlU6DoYPJjZIZe5x/mwuHAcLRm+hiOEEqD941zrWKO+5tnShetichIxJ6QRNLhrLs2lBGC3BnB4bmtTHeP9UAbv31AZhji6s/j3/fxaO7OoImyLQ8zdUoKGircrNy7xNpkn0kZIXodGOKjDrTljLc378iG+R6dhz/11GWzh7m+4GU1XRXxHhBQYLhYmHgIKTCC9SlF7NbuJDbHRPCW7QzEdtj47hmA+AcEmV0ykWY1c6ckjL+cDTzg/YD5/VDvuy+XOPymHf7OizWlA91b8ilIMYoEBabDCKPak+5+OXGTZITKSFhRN1bvFCrwDj77mWwkB89ueAZx1JA2XKfMTTRMj/NofEGyVJ+U6cVqZvVusPAVRivtfT8upug== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue 27-08-24 21:09:16, Uladzislau Rezki wrote: > The aim is to simplify and making the vm_area_alloc_pages() > function less confusing as it became more clogged nowadays: > > - eliminate a "bulk_gfp" variable and do not overwrite a gfp > flag for bulk allocator; > - drop __GFP_NOFAIL flag for high-order-page requests on upper > layer. It becomes less spread between levels when it comes to > __GFP_NOFAIL allocations; > - add a comment about a fallback path if high-order attempt is > unsuccessful because for such cases __GFP_NOFAIL is dropped; > - fix a typo in a commit message. > > Signed-off-by: Uladzislau Rezki (Sony) Acked-by: Michal Hocko Thanks! > --- > mm/vmalloc.c | 37 +++++++++++++++++-------------------- > 1 file changed, 17 insertions(+), 20 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 3f9b6bd707d2..57862865e808 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3531,8 +3531,6 @@ vm_area_alloc_pages(gfp_t gfp, int nid, > unsigned int order, unsigned int nr_pages, struct page **pages) > { > unsigned int nr_allocated = 0; > - gfp_t alloc_gfp = gfp; > - bool nofail = gfp & __GFP_NOFAIL; > struct page *page; > int i; > > @@ -3543,9 +3541,6 @@ vm_area_alloc_pages(gfp_t gfp, int nid, > * more permissive. > */ > if (!order) { > - /* bulk allocator doesn't support nofail req. officially */ > - gfp_t bulk_gfp = gfp & ~__GFP_NOFAIL; > - > while (nr_allocated < nr_pages) { > unsigned int nr, nr_pages_request; > > @@ -3563,12 +3558,11 @@ vm_area_alloc_pages(gfp_t gfp, int nid, > * but mempolicy wants to alloc memory by interleaving. > */ > if (IS_ENABLED(CONFIG_NUMA) && nid == NUMA_NO_NODE) > - nr = alloc_pages_bulk_array_mempolicy_noprof(bulk_gfp, > + nr = alloc_pages_bulk_array_mempolicy_noprof(gfp, > nr_pages_request, > pages + nr_allocated); > - > else > - nr = alloc_pages_bulk_array_node_noprof(bulk_gfp, nid, > + nr = alloc_pages_bulk_array_node_noprof(gfp, nid, > nr_pages_request, > pages + nr_allocated); > > @@ -3582,30 +3576,24 @@ vm_area_alloc_pages(gfp_t gfp, int nid, > if (nr != nr_pages_request) > break; > } > - } else if (gfp & __GFP_NOFAIL) { > - /* > - * Higher order nofail allocations are really expensive and > - * potentially dangerous (pre-mature OOM, disruptive reclaim > - * and compaction etc. > - */ > - alloc_gfp &= ~__GFP_NOFAIL; > } > > /* High-order pages or fallback path if "bulk" fails. */ > while (nr_allocated < nr_pages) { > - if (!nofail && fatal_signal_pending(current)) > + if (!(gfp & __GFP_NOFAIL) && fatal_signal_pending(current)) > break; > > if (nid == NUMA_NO_NODE) > - page = alloc_pages_noprof(alloc_gfp, order); > + page = alloc_pages_noprof(gfp, order); > else > - page = alloc_pages_node_noprof(nid, alloc_gfp, order); > + page = alloc_pages_node_noprof(nid, gfp, order); > + > if (unlikely(!page)) > break; > > /* > * Higher order allocations must be able to be treated as > - * indepdenent small pages by callers (as they can with > + * independent small pages by callers (as they can with > * small-page vmallocs). Some drivers do their own refcounting > * on vmalloc_to_page() pages, some use page->mapping, > * page->lru, etc. > @@ -3666,7 +3654,16 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask, > set_vm_area_page_order(area, page_shift - PAGE_SHIFT); > page_order = vm_area_page_order(area); > > - area->nr_pages = vm_area_alloc_pages(gfp_mask | __GFP_NOWARN, > + /* > + * Higher order nofail allocations are really expensive and > + * potentially dangerous (pre-mature OOM, disruptive reclaim > + * and compaction etc. > + * > + * Please note, the __vmalloc_node_range_noprof() falls-back > + * to order-0 pages if high-order attempt is unsuccessful. > + */ > + area->nr_pages = vm_area_alloc_pages((page_order ? > + gfp_mask & ~__GFP_NOFAIL : gfp_mask) | __GFP_NOWARN, > node, page_order, nr_small_pages, area->pages); > > atomic_long_add(area->nr_pages, &nr_vmalloc_pages); > -- > 2.39.2 -- Michal Hocko SUSE Labs