From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06134C5474A for ; Wed, 28 Aug 2024 07:14:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 287ED6B00AC; Wed, 28 Aug 2024 03:14:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 237E16B00AE; Wed, 28 Aug 2024 03:14:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0FFF06B00AF; Wed, 28 Aug 2024 03:14:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E6A556B00AC for ; Wed, 28 Aug 2024 03:14:58 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5D34BAAD5E for ; Wed, 28 Aug 2024 07:14:58 +0000 (UTC) X-FDA: 82500792276.25.C0FA456 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) by imf15.hostedemail.com (Postfix) with ESMTP id 5CAA9A0012 for ; Wed, 28 Aug 2024 07:14:56 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b="W8L+dRD/"; spf=pass (imf15.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.43 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724829227; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PG+Y+iPEJrhNPEqaAwHaY0bOaMvK21xV21Vun1ew9Is=; b=BEbscwsdl1/SxPDqF3uc1kt+qXiE9PynkTL59axS85A/cdgG3ciwXr9LV3XUN2Ro/o7IOp vbJlWL05Q74uRLJhCvv4+89RhE65OmBo+vsc1oO38Rm6tlCN4m7O3+DmhOU0EnGAqxVbvc 79JqaYfSQib6/HyeoYQWLEqJG98ErCw= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b="W8L+dRD/"; spf=pass (imf15.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.43 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724829227; a=rsa-sha256; cv=none; b=rBWalLpZMNap0LbDMroz6OozUKPvcxT/wOa+Npl3OM+s7uPUxoBCELRnY9TBIc7rOY1CDY isVFmHkpl9SdS3WsOWL6Lsa5evCV2Kn9HvqBG6sWZU7eMUGKWXE8fi55BTke4kCN1vPA2p JN2iZ+vONnCQH7dUmIVPBSOYhghLJcg= Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-5bebd3b7c22so542335a12.0 for ; Wed, 28 Aug 2024 00:14:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1724829294; x=1725434094; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PG+Y+iPEJrhNPEqaAwHaY0bOaMvK21xV21Vun1ew9Is=; b=W8L+dRD/nBuPWNRYtp1QPiXRpLcVjPD3QiPgR2BH8/mXgu7uVrETPZGy7mwqqmlyRt Xs+oC0QcKBMz5FgqvK4Ci8Xy+Qbk+Skim+TCUO3YA/4MehPf7jr1URAC7C17Ri5QPt7N QTJB0F9yujwFv9HCS+7B2wSZ0AX1fPAlsTvZwzTHuox+DlKnjC2vh1pJFU8aEaiv7Hzf /4wNzNIP9i9YO3TR2+o32o+/4YmoEVHiVGwsv+ucwEI13RvON169f5MmNsMIOtjPMHm0 S2fhLeMQKuVWnGmHJYLDXAdqr2v7Mv95L3JEROb6ovLDXVjtXo8vsey/Rx4zowyiT7K1 3Ndg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724829294; x=1725434094; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PG+Y+iPEJrhNPEqaAwHaY0bOaMvK21xV21Vun1ew9Is=; b=XwoihpcRoPryu5oNChd317OMSDB+jHN7JnlbO+shjdd4vfGTl2sxJ0FYInzpXN+Kzv 4XEunM6/wLDetNIPl3VYqqkyhbzbIBEHJr9Nd19hPRENIgG9qSa0BnqVjJmwn+3eabIP 6athddl/TVjyNsDj+0OXKIGoP7QkKIaLmp6Y14yfacQyy6nJtArbUeZpZt1V9GzBWv+v QH+r6n2kzeYkkyziIbdjKqtXrAUzrkYegPT4qTO73GMN3z7LD9GoUKop0UWZ+QKNtmaI JE7SBjzYlogcz6Bsnmqxfo3aCXshHHVIuAnDuVKifVGX1q6Uv9t42FFonEBsC/VoXalf IGVw== X-Forwarded-Encrypted: i=1; AJvYcCXcdYRqlwzPLl6GSArVMH077/H1UGXvmkdjli3z2F2yOUA50ajliRHmKkIySsjrVhToYkts/4dMfg==@kvack.org X-Gm-Message-State: AOJu0YyWaeswv3M4bCRlYQ8qebkAcL5OqMjxt/yLcIzv0X3wmSni8WLl tukFtIyjtogUjQk71gQMmtQ6JW2R2LhxLs3s67VNTvPvrrGDOqSW3Qak8F/8Bi4= X-Google-Smtp-Source: AGHT+IHFQn+2dk85m69kJ8Wp6sfOI9yrSVVvMx2xqX2Nlpk3qlQRXfnHV1pIvevTbCDASqx1v9/IJQ== X-Received: by 2002:a17:907:1b1d:b0:a86:b5ac:e22a with SMTP id a640c23a62f3a-a870ab0c6f6mr143124766b.34.1724829294499; Wed, 28 Aug 2024 00:14:54 -0700 (PDT) Received: from localhost (109-81-92-122.rct.o2.cz. [109.81.92.122]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a86e549ca7bsm203208866b.52.2024.08.28.00.14.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2024 00:14:54 -0700 (PDT) Date: Wed, 28 Aug 2024 09:14:53 +0200 From: Michal Hocko To: Uladzislau Rezki Cc: Hailong Liu , Andrew Morton , Barry Song <21cnbao@gmail.com>, Christoph Hellwig , Vlastimil Babka , Tangquan Zheng , stable@vger.kernel.org, Baoquan He , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH v1] mm/vmalloc: fix page mapping if vm_area_alloc_pages() with high order fallback to order 0 Message-ID: References: <20240816114626.jmhqh5ducbk7qeur@oppo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: kpq18sg73a9phg9fi1qg4h8rzmmjgfky X-Rspam-User: X-Rspamd-Queue-Id: 5CAA9A0012 X-Rspamd-Server: rspam02 X-HE-Tag: 1724829296-312896 X-HE-Meta: U2FsdGVkX18fFWUbq/pjuyzUHy/71Ux4F6PV1A4qPHLk/xqQBeC6HOkxt4X8C3jnRx55wzhGVa1PhRp9KRDeU5TqKfAcXN6Zq/lzIvd8ckSH9gFHecseuKjjBvltth4kkfP9VaX0Ji+P9TkVsS5dPzGYt3s7SI8RMu+m6OHdk15Q/LB2s7zFGBjCJY5VYIBHOoIRs3LobqUy7ytNM4C9ljypoj3dHPup5M8lof1InZNlPKZ0oYkHSpnrgFLK0xwlgFj2+/ag1AWE77uziWb7J7PiUDumbMDDi9Qb1RsJHZol+LDsJVLFGAbexn/s7uhDywEUnoIGOLSkdUhtiSwS7zqMxjNUeaPhpxCrTU/VDHqX5GzdoQVOAYvnUMDlTF4909wgfammyvs8HLCoXneR7CkVCNeJUGZvVoaUnpXOURWvaj5sJOrFRj6Bm+GjefsAfENwtHWiEwqHGr6br5b42EdcgK28+vkRVOEnV3eYBLimq8KnSi+eOh3hV/D8qyalSZO3tJhTiMIsFvisnMQp+SyGE+SRKeu0A1ghpIjTKDX09WRPom2S6XXoJTZi47oFQUyDDpOjgunUh6XSKc11F0RPNTJMgGGFQoZ1i6aYD9bMHK4yiXtjonQwo6y/kQH8ydxpz4M8zRRdDEIxsbOH8unepkFr4RcVUlQ5F1MH1cS1usj5fyZt2UwxSY589CRURcCdAmS8++vWoJVkgecA2u5rC9/dTCunjENQPpvp6+Rg9A0X/g5ZONy6Gq+u7Clx1INbRWD2AOEmZHaZgkD2/K+V0sFoRkILTrGWz4chmZD6UKz6XZz8h/IMT6VmL0yBJ0Iiein6xuKWeRxBmDqPkC3WbXhEPrWMR8vRimZjOA6QsLDG6OanMpwYcD7CS+PK+94hMHj0E97op8u+CIzlUKFNYBM87yCtiRTIm6w7fu3nzrfpjL8iuc534tUpis7IgGfCXjs27kiSp3YufF9 cKHLYm1Y ptAaNnnk3lvmhc4XaU+ij1QII5qSzBaHAFSz+5l6ttk1xRVxMr5MAHADLr/Jrjk47wZQT6nSgcZcmbXaN2f5FdYWtTUF2RE9r7lgjvsPv5Iq+qaniQe06wIU2NHOCsSzmKhB3O6Ygee/0KppZE7gZYBwwb45OERqGg7qSVQBldZPsjT4oahnyYLyBNTaVSSHmZb+rTxe39qty9dkbg8nzbOAxKFaL8hCDmMB/iVxvYO2/fYfAt/g4g4IH51AFu+Xh/Xgx5VedhUfmotw44p70oZlK1gZEU6DH/U7Iq+3+fNIzHeTiqXnVit/dmHtKzJ2B7CCQNkHOx00QQgXGJr7vo6NBQ33v9imNY13sr8rm0l6Bo3o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue 27-08-24 17:29:34, Uladzislau Rezki wrote: > On Tue, Aug 27, 2024 at 03:37:38PM +0200, Michal Hocko wrote: > > On Tue 27-08-24 14:47:30, Uladzislau Rezki wrote: > > > On Tue, Aug 26, 2024 at 08:49:35AM +0200, Michal Hocko wrote: > > [...] > > > > > 2. High-order allocations. Do you think we should not care much about > > > > > it when __GFP_NOFAIL is set? Same here, there is a fallback for order-0 > > > > > if "high" fails, it is more likely NO_FAIL succeed for order-0. Thus > > > > > keeping NOFAIL for high-order sounds like not a good approach to me. > > > > > > > > We should avoid high order allocations with GFP_NOFAIL at all cost. > > > > > > > What do you propose here? Fail such request? > > > > We shouldn't have any hard requirements for higher order allocations in the vmalloc > > right? In other words we can always fallback to base pages. > > > We always drop NOFAIL for high-order, if it fails we fall-back to > order-0. I got the feeling that you wanted just bail-out fully if > high-order and NOFAIL. Nope. We should always fall back to order 0 for both NOFAIL and regular vmalloc allocations. -- Michal Hocko SUSE Labs