From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56617C5474A for ; Wed, 28 Aug 2024 03:43:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF5D86B0088; Tue, 27 Aug 2024 23:43:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DA6B26B0089; Tue, 27 Aug 2024 23:43:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C6D816B008A; Tue, 27 Aug 2024 23:43:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A7F1B6B0088 for ; Tue, 27 Aug 2024 23:43:21 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4514681CE8 for ; Wed, 28 Aug 2024 03:43:21 +0000 (UTC) X-FDA: 82500259002.22.9E6D87B Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by imf25.hostedemail.com (Postfix) with ESMTP id 56715A000C for ; Wed, 28 Aug 2024 03:43:19 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b="l/nftFni"; spf=pass (imf25.hostedemail.com: domain of david@fromorbit.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724816530; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3gcUZ1E5jMHxcb+3WwyGJu9jgAZgzxZf/U+LqyUjPCQ=; b=suntyEidOReWJFq/R+XTBXjuQRv6KaBhpwyGJheJki8gatK06ogHx7mTfS6Hr4k8ubyc+q Fu4yOm1rlPjTQoIBXsu+Oa6XRsIb9/onBkICCdi2jMaAR5xWpuLBs2fPice3oTLAGkcG+i DbXYfepHYkjBvl7RoEE4Za2yfsuLmBU= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b="l/nftFni"; spf=pass (imf25.hostedemail.com: domain of david@fromorbit.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724816530; a=rsa-sha256; cv=none; b=jE8HVTfJf8dfNY1+q2d12Ilu/JALQfiEnhlCl3Nz7b/i7Xbwj6L9stomqT+IfyrQN79g/P 5JMWkQY8GrpA7r/K+PgyAMu1ekC+ofXNSQLYA9v4ZYdgkp7VvGge8OcB0GtVYV5wmN4gPh 6ORqM9+AtDdAk6vNIfsrXEYY/BUHF+M= Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-715abede256so2068588b3a.3 for ; Tue, 27 Aug 2024 20:43:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1724816598; x=1725421398; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3gcUZ1E5jMHxcb+3WwyGJu9jgAZgzxZf/U+LqyUjPCQ=; b=l/nftFni5JjnBrIqJM7b8KJr12eJtYzL3ekJ8PBzNfhu3HAesvWucCw2ZylwHJyG8E Ak3UGCaOL54BaJRopHfkjruAFxxufm6IFwUMzwD3A+QEOP5hMGJK72jLg42zQJB68j75 u+QPPAi05pQzlLmCwMJs0cP5ZGxtOEohQBV6KnnQ/SL1ZdojDNw8wOWUTwOqjt1MUS+Z /s8JpagFBJpjJsNlgyLrVs7G7FbIY03vCLqSK+kFP0tJKclOjbnzUDYH1AzeCCbQovWz v/CSOp9DIgemfnRSsY0mNX8rIKVD9Lju+ZcZcqJw62jXwgpPOFU1wXlJMAdEHgmJDX4d 4f+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724816598; x=1725421398; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3gcUZ1E5jMHxcb+3WwyGJu9jgAZgzxZf/U+LqyUjPCQ=; b=fyINzBDaYe929JBNO8J14VxFhwyVnlyRb+PYONhuF103g8YNNKQEPp76xuwPCvCuZP 19b80pRZcsGjTnOZTerGLEd3jcsIlaDbYoiWd4/qi3il/yJhOQKGRdxqRfahEjkp/y0w 81Chwp3KdzhcTJz9CrJwReEwJHDn5ogux3lU/6d0xPM7W8xdil2qfd8UXI9XhBqdeOkw t8B0c0cZd2XKmbVovlpNQXVmQzzhnFdv3j/bBhWr7QCMsG02iMb3x7vm05/6RYCb/Alk lmW0FDj+5o/AGSGNtXR7g9V9XgY2js7j44OE2WaHYALKW3E3tVbRi2tILWHo6XOaKjvK CoqQ== X-Forwarded-Encrypted: i=1; AJvYcCXgR4PjcRtmkYcsdqpPaMXL7hNJM+D99o7OCr4cImMKjx8q3A9S/D7MgX+lxUmOQ+hfwYx8uMjp+Q==@kvack.org X-Gm-Message-State: AOJu0Yx23XogZO0aPrJC/wXvZ5uYoAxjsP5XJdM6BzrdWM8K/bgXelzQ MYJz12SRMb05jP/gsSPGAxl5IoarUZGxD8nqLMM4cDg1H/k+UFsGFyTvrPHFmT2p3lHaQmhHjnE j X-Google-Smtp-Source: AGHT+IG6kQZeI9NbtLZWTvUhFsTxQi88npVwo77efHV7cZ8AlR8vpP3boDhXVMWim2DvAlGjyUTESw== X-Received: by 2002:a05:6a21:9614:b0:1c2:8cf4:7656 with SMTP id adf61e73a8af0-1cc8b41ff12mr15414408637.10.1724816597889; Tue, 27 Aug 2024 20:43:17 -0700 (PDT) Received: from dread.disaster.area (pa49-179-0-65.pa.nsw.optusnet.com.au. [49.179.0.65]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2d8445fa589sm383406a91.17.2024.08.27.20.43.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Aug 2024 20:43:17 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1sj9aT-00FIY6-1J; Wed, 28 Aug 2024 13:43:13 +1000 Date: Wed, 28 Aug 2024 13:43:13 +1000 From: Dave Chinner To: Kent Overstreet Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Alexander Viro , Christian Brauner Subject: Re: [PATCH 10/10] fs: super_cache_to_text() Message-ID: References: <20240824191020.3170516-1-kent.overstreet@linux.dev> <20240824191020.3170516-11-kent.overstreet@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240824191020.3170516-11-kent.overstreet@linux.dev> X-Stat-Signature: ap5x5mjxw8nq341yqz85h4o3z6zwthn7 X-Rspam-User: X-Rspamd-Queue-Id: 56715A000C X-Rspamd-Server: rspam02 X-HE-Tag: 1724816599-136342 X-HE-Meta: U2FsdGVkX1+Fv/EJCZHlDrW4zyXbxUZja307eIkfto4Q16U0ykbkFO9DhFS3bIv4rdAiyXC9eSdTQPbTN2fpQqpSyhDmN28EhckSp1Ovmy4NCD0Ts15WmAUkZYpbr1OmOrYfcYeEzLWXkysZIaOEsGjIu/RWCtABd/eplmgv5HIKV1M0zIqFqsT1Z77/9foSk+UOVFJ9ri61J2bVmbA5MptTDZ3YhPnS2uLZ2gJzFCiSGvNefVbFA92EYxKvm0UZePYZtfJR6FghfWrAmgzVsb1kku5VLeO9IbmXwsL80k+xbY0IJhBs72sl0rUhA7kqIgR3Vhd3aKOQ/YrwnnDMZUWhkDhzgHhZE6YIgiP/B17/1mmdGDScoG/OxMG5KoiFdlXYV6GWDwkboFsZy7Xt/eyxNjXjpI0NtKF29WK5y75K++JTGFONP/q2iI9LNQUtYZfXE4FbJEOxP86A0zOlk801IbJf0UgGCtWp3fVKh18lXj+YJvADM0XKtgy1Lp7ywjP43kOrh2bZeu2nonYUE7mFC6C0rWfZwg6sI1dU2JQ23LJuUv7H88aXJex/WF6g4pWWA2S4OakUf+mgoLQIOPrSgCukuD9jnAwWMI1yXga/RIr8SvXODp4kdlMXp5FtmF7eCnx79q3OfktiE4JVCrWt7dxQsTouTVr3BxldMmzcbLsTIjsuebVjvrOT6dyBtvvsXze30D5CggIlBPsmMhHyBa03q2hhgfySxLVOcdMwindlOalOi1ozGa+hMUGiijZ5ocVavRQa0CZJNcrCoX+uii/oOZbJ4Er0Q3Fj+B9BbUETXkdJBIPa5QUfOp6F/DdSGvWGb/fM5FCNa2wdwIiw8dNOCa8QLZbR2dyD6ly9wTLxygKGWsgh+4oigbkXWVne/71JYXUe3udieqxvhnmlrrV6qWxvtshjDiM/0WxHbm/M3jjN5ReNYXpTidcO3SAVf6WoBTyV53rmdmC NyvKdU6c 74l2ZK6m5bcfHWOzCsdTn3fQeRnnrG5bzo2vJUUYdAJ5vucB1aoMqFrYXJk4r9LjeZ2GEAybUoQo80gj4KbuHFs8iuD8d8Y7nGZX42TXcxVhsPH6UUWlk4FtmzBD8SosJSjxTIMpMHIJ5MSHpGoDlShlExD1FTbs3BsJu+SZNtCCegyP0bnjQAgumPPSXxYO92MouVrJ8Z2Ly38qmDNWl+Rk880DwU1zCzwZ1/84ZgCWQDBkv4ctpz9KV+6+tt7dMk9ijRiiC/CWIqxVKkwOCzCBGLJcqIPBPT6Y54J9NXMGW7quVdQLtpIpgNg3D06aB1KRhzT1WvuWtZ9QB55le2knF05VDOyNbP3vfeyuAf5ZFWkae2W77ifAmMO0nXlDZsuO9BZI9WIRQ+QHmWa06qptLUHSOR5xk5sAQtQrgR2gOYxOru1eIT+oSFjTxgqtiU6vf/snxcKIqW5m0TJ/y5gnbrBYsLSRHkaMPYF8YSmyXO0oruNdE3bZxnynnzAq+Z9AAVpNDfmmZLy78dS3z8Pkzlz0IZhAnW5jKLFGC18H01wZ5n2CDDxoQo3LYjlgh0rboLZG5W5k0fTg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Aug 24, 2024 at 03:10:17PM -0400, Kent Overstreet wrote: > Implement shrinker.to_text() for the superblock shrinker: print out nr > of dentries and inodes, total and shrinkable. > > Cc: Alexander Viro > Cc: Christian Brauner > Cc: Dave Chinner > Signed-off-by: Kent Overstreet > --- > fs/super.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/fs/super.c b/fs/super.c > index 5b0fea6ff1cd..d3e43127e311 100644 > --- a/fs/super.c > +++ b/fs/super.c > @@ -36,6 +36,7 @@ > #include > #include > #include > +#include > #include > #include "internal.h" > > @@ -270,6 +271,16 @@ static unsigned long super_cache_count(struct shrinker *shrink, > return total_objects; > } > > +static void super_cache_to_text(struct seq_buf *out, struct shrinker *shrink) > +{ > + struct super_block *sb = shrink->private_data; > + > + seq_buf_printf(out, "inodes: total %zu shrinkable %lu\n", > + per_cpu_sum(sb->s_inodes_nr), list_lru_count(&sb->s_inode_lru)); > + seq_buf_printf(out, "dentries: toal %zu shrinkbale %lu\n", > + per_cpu_sum(sb->s_dentry_nr), list_lru_count(&sb->s_dentry_lru)); There's no superblock identification in this output - how are we supposed to take this information and relate it to the filesystems that are mounted on the system? Also, list_lru_count() only counts root memcg objects, so any inodes and dentries accounted to memcgs and are freeable will not be included in this output. For systems with lots of memcgs, that will result in the superblock reporting lots of inodes and dentries, but almost nothing being freeable. hence to do this correctly, there needs to be per-node, per-memcg list_lru_count_one() iteration here... -Dave. -- Dave Chinner david@fromorbit.com