From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7088C54731 for ; Tue, 27 Aug 2024 19:22:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A0586B007B; Tue, 27 Aug 2024 15:22:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 329CB6B0083; Tue, 27 Aug 2024 15:22:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1CA416B0085; Tue, 27 Aug 2024 15:22:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 013896B007B for ; Tue, 27 Aug 2024 15:22:33 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 7D7AA1A17D0 for ; Tue, 27 Aug 2024 19:22:33 +0000 (UTC) X-FDA: 82498996986.09.B3294D6 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by imf22.hostedemail.com (Postfix) with ESMTP id 8CC86C001D for ; Tue, 27 Aug 2024 19:22:31 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dVXJNRfG; spf=pass (imf22.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.45 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724786464; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wMo2i5BksKOtn/Bq+5iS9/jKBd11ATF0ir8T/D/Z1w8=; b=vEMZLefQG54r/ai6qX7eSElSKZ2EJVmHZ0MxP1Ar25MPeVB4wG5XifjHniYgxkx2LINnLn dmb/cWsmilsSSDX0do87eIsaT21K/cQBMXeNx0wQzQ6ITalDHyTUdteXAq9/R5WfR+FjhM G87zr0QkMUALTyJR/FhqST4yev4poH4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724786464; a=rsa-sha256; cv=none; b=q744t/aXCfLRKpFbnknmpCSvOZKSCkvEvyMGbu5h7sB6e4QOCzltHUvob6TLa1wXQpiMIE fAOnRxGQ8368Yt6X14R1vO2tY8Gr/IHu3EyHwKNk7iLHNResHJaUxjKYteX336catsbnZB HNLL9QvmR/FkwCmfZOss9UU4c/ZOMG8= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dVXJNRfG; spf=pass (imf22.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.45 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-533461323cdso6724050e87.2 for ; Tue, 27 Aug 2024 12:22:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724786550; x=1725391350; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=wMo2i5BksKOtn/Bq+5iS9/jKBd11ATF0ir8T/D/Z1w8=; b=dVXJNRfG5Awdhw9YkxLRQU9Mk4qYIz7+rL6fDKg7O1c/3Pubc6c+Ip1mu3Gk5uK13H XXxgXW5CrEPos/s5zZW5/E1DKub8DUpo0U5pP63wTTyraV3QSy7Z3NmLAazDO/pgg9XL 8GdlI78tQziDtLjVusUV4igGgwe5QrB7JIfp4XKhJ2JLItRjw3ZItGIgediqLH7pvdNk YwERHfe57id+MKS7NC/WVTOeRTP9UXrkrD240yq3mixjXkJXAe6mWonkJGvS3aRZ2Dw5 T/eM0ygXJGnO2qf/3UzOXZNFLIrvGxR6fOzlNj3lHFNcklySP2/bjod5mu/2wjF02ARy 4YFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724786550; x=1725391350; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wMo2i5BksKOtn/Bq+5iS9/jKBd11ATF0ir8T/D/Z1w8=; b=POReYct7PWS4WRVJ2kGFp5O5F5+wZeSM5U1UHggDWoQj6W+fTSMAlZlLRFb88VPvaE K+FKKx2wthYxfy+ZJQ+3OmqarQho+ZX/eocYCTQfWFYr0wQ/XHbcyhQYhgRIdROXYlPn 6CWplSRwUI4PXnQfiWlPn1a+B0s9nFFtBb5d/D3N6oRBUTpSiFgE2T/gAJzVhSgHer4I GmE0Bd1BRnMPPdatw1J8zbq64pL/cUu03xktqPDn2TeJpXOW09pFlMXNZGeFop6RZtJs /3LggRuYgGErX7YZZqaIQwKIjZe1o4N89MpN/duRnGyJjXj0gkqFt4qjQWO/niT8BF0o bgKg== X-Forwarded-Encrypted: i=1; AJvYcCWAeQbBaPPNtcvbzNlVWH0AfBxcTc0zz8iBG8oDOMst+p2SVLq8hI18jttVOX0iVFFN2E4A0gKl9Q==@kvack.org X-Gm-Message-State: AOJu0YwRm9LRdbvIdFSoqFf8mmz+uI++kdT473/Hw/8hkgyhGMpnb9NW qDJLsJN461IUBDNJf3VJS1waQTob3oa1pPmCP9w8B7gxKib7RrwioSVH0w== X-Google-Smtp-Source: AGHT+IE+6wa6iV7uUjFY4/59RM9Ul6vrs8jnZh3CJNbzIzxYCUMoqNlZW5jtTHEshvbpnHl/9T0EhQ== X-Received: by 2002:a05:6512:33c8:b0:530:ea6a:de42 with SMTP id 2adb3069b0e04-5343883a11dmr9398067e87.26.1724786548957; Tue, 27 Aug 2024 12:22:28 -0700 (PDT) Received: from pc638.lan (84-217-131-213.customers.ownit.se. [84.217.131.213]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53453d29aa6sm115952e87.232.2024.08.27.12.22.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Aug 2024 12:22:28 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 27 Aug 2024 21:22:27 +0200 To: Hongbo Li Cc: akpm@linux-foundation.org, urezki@gmail.com, hch@infradead.org, linux-mm@kvack.org Subject: Re: [PATCH -next] mm: make use of the helper macro LIST_HEAD() Message-ID: References: <20240827015724.620110-1-lihongbo22@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240827015724.620110-1-lihongbo22@huawei.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8CC86C001D X-Stat-Signature: yzeaobipph71y6pr6o4dys47nqqgyy34 X-HE-Tag: 1724786551-856657 X-HE-Meta: U2FsdGVkX1/Rwu5H8n4O8wtCkTGjH9ESSOhtgblTH7cLXPYy8ljFhkuPGh9QsZsyiy94Y4scsjm0GLouMsSZWSpSNQhRQ/KEJoOgq2wSlWopgFuArQSWKvDMMYCtkIuVL29eWYamFN3fxQKZ8zCLTn0tQaCSwK3yo5/vudRcT55SwNVI8jKEuNvT83AvCVVC/tx4ES9aYAqpJzMkGO4RjGxVJcLces52QeKDqPWkoChQ5WZj2mssP9mPq0+kus5c5azBYzXiqvgzoC4Uch6UIXHKslZGO1+ZLr2b8e034iiJTh9yH6iPPzlvFblsyX49+ON4ERzRJPVEoV5NGQsKQIRQ5qUjRl8HtEuCOS7vO/p75LtAUy4PxNmuJ8nuLHFNhGmc5rGn6jQrb6KGhf1LQY5lDfUwcbg7HBR784blvA0j0Njm5iry46Ijxiq9gBqfA31S6XTzYKUX0hhH+s9mPYGCJG8OMqATHoMKs0aku9CG8h7hfZ2Ss6ncH/wo95ZiTfMvR4x2BRxoZk6k2pJp7y8jrSgCFZ2oxGRiNrGHWKF7qg8TvKSMkBQ43d4lIAooi55HimYdmOUiSP66tS5PYjKW6ikVHhUfp+J6UD9y2FdJ0P0iD50+qphAcnN5IRUusUvT2ZZ8pVXhVzieUpnO7aXNDKtGIk9uyra72GKR0Vcrfp1OdB9odDZhRpVL0uCGlwTVy/WSaKxvapRH3hwxMNzzi8GcGjEg7ikYpa0xDoqBJ3E7G7ToM7KphZK8abq6uzhO4sdE/1CzEIxREBiF6/PTmr+ylLD9st8yVZ5jU7U0ewAno8AfilqAdsxoX7JQzzdTD22BbWL6NLQ90L73fitu0HesJeh8YWDE6aghKgwpI8F8mnwKcZEc594Tsc/pWjwGLW6F727ENm6F9JN+oOymk7HZJP3Cpg0J1afLp0Kuip8Dyiti8vKy84u+tO66cYPYGny9hMQuxG6Q6HT WLHysrj1 b4IorYOA9N22rUN1PwyhVrHo39/ULhBNldCkm0b9goGDsWVDF8uHpTrdEGqPJWbBtwJJcMLo+LJg2olSeMvIutMZNYh/zfpDmk9ms6Z8Hns07Szj5rLKNLz3vl0Qc8SXP+DUSW6g1WRsUcFbmGwjk85k/YwLjPztc0CqTqL6zf1pP1RY5VQkgJoEB9BOfteEEDp4vrKOLAaDZNYDmnbAbAO0uHzyP5smVfrw7CBoOyw8O18GvVj1R6Dza/Srw7wyI6/9SUX4ZOu8JLh1kDB/ZXo4+WzbQ4+t5C8pXzoR8AVMswVVnCnrFIbk+MKMFTbWzhPpWsMmPtHapjwtaN5BrzSRzasPwNponNENAygJbYSNoEnyygBjEow9WgRRe/ww1vCn1B9mPyR65X4YtPDwYmILhmqW1ECcgSphsK3QZOqvJKu0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Aug 27, 2024 at 09:57:24AM +0800, Hongbo Li wrote: > list_head can be initialized automatically with LIST_HEAD() > instead of calling INIT_LIST_HEAD(). Here we can simplify > the code. > > Signed-off-by: Hongbo Li > --- > mm/vmalloc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 3f9b6bd707d2..3f7b38481fcc 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2141,13 +2141,11 @@ decay_va_pool_node(struct vmap_node *vn, bool full_decay) > INIT_LIST_HEAD(&decay_list); > > for (i = 0; i < MAX_VA_SIZE_PAGES; i++) { > - struct list_head tmp_list; > + LIST_HEAD(tmp_list); > > if (list_empty(&vn->pool[i].head)) > continue; > > - INIT_LIST_HEAD(&tmp_list); > - > /* Detach the pool, so no-one can access it. */ > spin_lock(&vn->pool_lock); > list_replace_init(&vn->pool[i].head, &tmp_list); > -- > 2.34.1 > Maybe extend it to: diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 57862865e808..e9c6f29a46ad 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -2131,23 +2131,18 @@ reclaim_list_global(struct list_head *head) static void decay_va_pool_node(struct vmap_node *vn, bool full_decay) { + struct rb_root decay_root = RB_ROOT; + LIST_HEAD(decay_list); struct vmap_area *va, *nva; - struct list_head decay_list; - struct rb_root decay_root; unsigned long n_decay; int i; - decay_root = RB_ROOT; - INIT_LIST_HEAD(&decay_list); - for (i = 0; i < MAX_VA_SIZE_PAGES; i++) { - struct list_head tmp_list; + LIST_HEAD(tmp_list); if (list_empty(&vn->pool[i].head)) continue; - INIT_LIST_HEAD(&tmp_list); - /* Detach the pool, so no-one can access it. */ spin_lock(&vn->pool_lock); list_replace_init(&vn->pool[i].head, &tmp_list); ? -- Uladzislau Rezki