From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03537C52D6F for ; Tue, 27 Aug 2024 03:33:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9419A6B0096; Mon, 26 Aug 2024 23:33:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F1816B0099; Mon, 26 Aug 2024 23:33:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E03B6B009A; Mon, 26 Aug 2024 23:33:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5EF8D6B0096 for ; Mon, 26 Aug 2024 23:33:29 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D026F1C5965 for ; Tue, 27 Aug 2024 03:33:28 +0000 (UTC) X-FDA: 82496605296.29.E9A86D9 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf04.hostedemail.com (Postfix) with ESMTP id 40DBB4000E for ; Tue, 27 Aug 2024 03:33:26 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=fnDQ7Grv; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724729563; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NU1cB0bm9+5+AnigtBB6FgsC6ItxiV1eaE/bQA93zmk=; b=SwX8mDMrbjG6BMrW47WSDW7Hzm4xqEOPYI2ktJrtJPEZB08PI+1e88C9wo+8dkvTJtmKW4 Zy1hh1/mD8i5oCloJaTm82dKNrEuOW9jybpimzme5l2yRy6aDDlvwZtADuG0mGbzyIOdGf wI8bCa5QwD8LnkanEVQpeKVEVZqgsrg= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=fnDQ7Grv; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724729563; a=rsa-sha256; cv=none; b=Az0AJ/SRO84qt0HAWEpOYZgLCNOiiIRL/UHgLWm0Z8dLAXBAUDnXudqT9gID+K8tOYmLP+ TNfNIsIv9P3hxW+hd0oD+k3vnD94QgdywAGZ/R/YAB88I7Oi9VSM1j2mXO/gxoijc32Stj ltjgHLoRHh7ci/r2mfGbA/OkAhHBMvo= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NU1cB0bm9+5+AnigtBB6FgsC6ItxiV1eaE/bQA93zmk=; b=fnDQ7Grvw+WZwRewFPWS/1Z4Ln 3US/Lw0slAVAWlbW+48FxNcnQn3wl3fRkzoVxo0kWcajcVMhw4oyKxxjkmAM7yIlNJhtXbwBKBwux VJuUw44ZQQs5GSriT3vnM530i/Zs91Y6smbbXFCWjE/IZA97ExYxzXEYLr+5kzNTMB+f82+X/d8c7 GUkNfufPKEiFrguQJI2j1taL2auDCz27XrdWL7RkJrAj7eTwpfqe8+1sIJ4HH/A20kkC3xB3CsFOQ tSdrTHY4HLKyb1spQ3lDIU2/zhKDImTJQzzTR5SHOOtwuFsKYP4vdCzXB99BiRAawtQ3b/ae5tJ5g gbI3YM8A==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1simxN-0000000GKhn-10lI; Tue, 27 Aug 2024 03:33:21 +0000 Date: Tue, 27 Aug 2024 04:33:21 +0100 From: Matthew Wilcox To: Hongbo Li Cc: kees@kernel.org, andy@kernel.org, akpm@linux-foundation.org, trondmy@kernel.org, anna@kernel.org, gregkh@linuxfoundation.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH -next v3 3/3] nfs make use of str_false_true helper Message-ID: References: <20240827024517.914100-1-lihongbo22@huawei.com> <20240827024517.914100-4-lihongbo22@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240827024517.914100-4-lihongbo22@huawei.com> X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 40DBB4000E X-Stat-Signature: c6cgjfk7e1ha538tprskp544rmib1db1 X-HE-Tag: 1724729606-80291 X-HE-Meta: U2FsdGVkX1/gPJuXdsdgFnKaRzNxYfQqUyEpbZBwMryaNArhlUZow99SiDjezGTOcKKq5n3WC07UgUrR6SfpLV/B8XaY+tm67GtYyDO20O/44ZDCYK9htloYty3R7z+JM1v0Kd3daApc+TA4YcYPhxxxAhUsNg96NepYiKehuxgGRSm/K4GquqQSF8GCi9Ek2155skdLTnBvrxjcwEAcxBxJF7nx4hjarFn9vEW1IXC2I4D/ZkTZ0PPXiPVUou5192M5rSJvgaUi+eEq+dTyj9HCXGrEIl7UvFMcV42WDe6ZPcVRNeMXNn81KLUjzayQK6zacXIOtDpvarp4+OVmdzvtLRIQt+PIodn1RzI5efPiC2bfpcjH0ca3mQbL9R6yiCn4hgWq9rgiTB9FJjUDOmzoB3t40GWNNpcc/iqzggjTR5aE08HPhMFI+wyWGRKxf39iPZ6tX1LgL141o4m9uQopTIzgzeT00F9jHZqNWWAhLdlzyuMB8H1wL+rgO0xMpC8K1OGCoyasQn2yxzVIYb8y2iTMvfDiiUs1tF+KSfG/79SOvw/S+B8ZdEkm/sm6XTPgcBbm3iqzA5P57Na1vpq1KbIxb6a1pCrP1TuvoM7MbFKa7eMMC4CBgIwWhZg3LfKzWnJMGyMNe9LhBp3UKtfDoSaAVqG39HO+UdFqHgL/MOOMJWFIOpg/iuUgumPkqf8AHKSL4W7fN5tgOviI19k/biV2nIjK7CTgJkiaGT+wMMWbqfIrm7wVoI8mTVhM+GbdDdzEWWaafCVv6wkZHHWWvY7fk6n58JTFBDPSng3yvC+uQEhI+5TFttamgIUKLuQfAjLlU9qi7b4EIi/gY23Rh1RKhLHlaht3N6741Ik/mtfbzUVSXoOckvx5mgIka5JIJyJ8+4o5/PwJu5X8UVVVGI2e7Zqs46z4qATiZlDFJTRA84niRnMQ9pr/nwT2XEFKa7BMgQBq9jiZyC3 qjiwpuQQ ztZZiVpQajuRr5Jk387RkycS31FrTpbdK15iXK2da+XUlz+5y/sQIZpnZVlnzDHL+Pn0qgSl1zw2HmbFnVtCNZkI7csChFi+hAv6WinLfk6s92dm5DtHNKJl69Rfrx6Uyn5UU6um0nXS8pkd0z57+TVTZ6y6D0rknq3ReJ2tP7McHCqQun6LMVmx5IjZaApCwFnnG6Z2TeN8neJNqeCKl+KhrGr8EJQwZQ0OINMVUpjFBf4saq5aW43JfIiY/Ra/LNcBz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Aug 27, 2024 at 10:45:17AM +0800, Hongbo Li wrote: > The helper str_false_true is introduced to reback "false/true" > string literal. We can simplify this format by str_false_true. This seems unnecessarily verbose & complex. How about: dprintk("%s: link support=%s\n", __func__, strbool(*res != 0)); > - dprintk("%s: link support=%s\n", __func__, *res == 0 ? "false" : "true"); > + dprintk("%s: link support=%s\n", __func__, str_false_true(*res == 0)); (do we have a convention for the antonym of kstrtoX?)