From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 890C5C7112B for ; Wed, 28 Aug 2024 20:15:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E7D96B0085; Wed, 28 Aug 2024 16:15:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1989E6B0088; Wed, 28 Aug 2024 16:15:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 05F916B0089; Wed, 28 Aug 2024 16:15:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DD45A6B0085 for ; Wed, 28 Aug 2024 16:15:38 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 966958070E for ; Wed, 28 Aug 2024 20:15:38 +0000 (UTC) X-FDA: 82502759556.08.84D7F7D Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by imf19.hostedemail.com (Postfix) with ESMTP id 92E1B1A0005 for ; Wed, 28 Aug 2024 20:15:36 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=2tV+VGsd; spf=pass (imf19.hostedemail.com: domain of charlie@rivosinc.com designates 209.85.210.181 as permitted sender) smtp.mailfrom=charlie@rivosinc.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724876048; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DYouNjU8LVMpXKc1rxZ9hcDgJ8HQG0MfeaXtb0VLyGI=; b=10bUQj5CwEbgh2AZa5/+CIpGSAICth1UNUcpEY2LJZWRaVD1Drz93YRSHMbRooUYxXLwQS LbCfgc/HbQgi3TGzmhLjdirETb9AgndYB3yNzcnbLIsvZ/+z2elgIf1zG/y9nHxSjj0A/t u2eBPCNx85B7l5ghGCyTQokoFSuiisk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724876048; a=rsa-sha256; cv=none; b=cPdh9WAIhRXRzdAvfwte5nx7uYip0oqjc3IOxSY3qLkDWGtHxUJa5tXMH/4y9fGnXjB9s6 oyjgbEOl8qEsW3RXCjlYv1wwERxtM+rRqqM6Tnxcup16Rwn7tS2SQ4v54SjeQwVV4Vzlgd mLbMkUnqNNt7YlqfFB1+ivORJcB2l1o= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=2tV+VGsd; spf=pass (imf19.hostedemail.com: domain of charlie@rivosinc.com designates 209.85.210.181 as permitted sender) smtp.mailfrom=charlie@rivosinc.com; dmarc=none Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-715c160e231so2282802b3a.0 for ; Wed, 28 Aug 2024 13:15:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1724876135; x=1725480935; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DYouNjU8LVMpXKc1rxZ9hcDgJ8HQG0MfeaXtb0VLyGI=; b=2tV+VGsdICM6VzLHwXwnkVCTaTf7p0T5jIhGc/Q/bmG/zo3a0V/7M1kRVIjTsfKqUg qUZaqI/b0eFU3RJzV+N3sa+sbE0wq+fa4GsTFVDTlp1qN1/8d4UsKWl3yXXawe+b01lv dakp/0FnLmZaRZ/WmzQzM6OHYmkr2BrVVoEEdfVWuA5o/t0z0llAjUDAlb5MlNp8tT9F NHGSAtz1IsDtm+L87ES2AWArf3yGz3q5rQcQDrUe+USyL3Ve3FubskpPqBryFIOrpXrS M4V8ztfTARYeOgaOJsCBdNjAX808sZCfc4Di5kcm6S0A/jD1fpM/CnKfE2GVIjUIFdyj DKdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724876135; x=1725480935; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DYouNjU8LVMpXKc1rxZ9hcDgJ8HQG0MfeaXtb0VLyGI=; b=YtStUGrD5oW/P758B+sKIgzb5IXX0LwQm0vOmfN0VHqiGD6ztlyhn2cDv9PBATwfSn Zr0ATcaExnoXwKp2aXYRM2NStG4QYV7PwP0ov4gHtgacJGL91saau7Cm6KDG3Hing6yz j8g+LaA02iC5MHiou3uX0fYatsxCZSA+ULKpLMeR1Ejm1uJZAwuofzsU7BA8yVviclBy e/5K0/IgJ9iUg7UBcluOgQ7lSEFM4jlJRYk/UQlvlCQJdcvLf6RztPHhxJMEcNDzF3XQ CS8xc/rJrKfQwJXJ3z7ZQjbnHr4nX5vCvK1iyLcRYpdQjJdPKBLGJy5JASNuTWSduyzI 0pDA== X-Forwarded-Encrypted: i=1; AJvYcCUZyUzNfyLTQuu0hUqlZ1PUIOMz+bKHma53mrdDZnqbM7MAtaqkkUPkRWve1uAF8OO40rLuXq5S7Q==@kvack.org X-Gm-Message-State: AOJu0Yy3Ckus4/GuLGup9kyldLHrwoEwSkYD4khzw88+2lXv4ODE8o59 PmHmw37iZMEuTqeYGamXfF95gva479uebRFvxR61wKrAReeebYT/5ockZY5a4cU= X-Google-Smtp-Source: AGHT+IHnVszzxRV7qQ07aFqnxjDB7ZJDRj+3FpzGhCxnl0U0Ndnw3gA3qfk5sipB0cB/w/7yeJxxIA== X-Received: by 2002:aa7:88cf:0:b0:714:15ff:a2a4 with SMTP id d2e1a72fcca58-715dfc042a7mr734410b3a.13.1724876134994; Wed, 28 Aug 2024 13:15:34 -0700 (PDT) Received: from ghost ([50.145.13.30]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-714343097fasm10850305b3a.173.2024.08.28.13.15.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2024 13:15:34 -0700 (PDT) Date: Wed, 28 Aug 2024 13:15:29 -0700 From: Charlie Jenkins To: Dave Hansen Cc: Arnd Bergmann , Paul Walmsley , Palmer Dabbelt , Albert Ou , Catalin Marinas , Will Deacon , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Muchun Song , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Lorenzo Stoakes , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Huacai Chen , WANG Xuerui , Russell King , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Andreas Larsson , Shuah Khan , Alexandre Ghiti , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Palmer Dabbelt , linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 00/16] mm: Introduce MAP_BELOW_HINT Message-ID: References: <20240827-patches-below_hint_mmap-v1-0-46ff2eb9022d@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: y8axsneamx55yujshci1pmio19f34s8q X-Rspamd-Queue-Id: 92E1B1A0005 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1724876136-403632 X-HE-Meta: U2FsdGVkX1/j7BAtVmztqujmKOrkS+qhTcAeHAeb3MatBHXbLWVl5ENTc2S/OA1MchkK3sLWtAaZrquexPoiFiiIHlP0Z55WtfO3SdNveV9VnRWKdZq+resJFAWnVcoWnxTNEmAoAUnbJf8ua9oU09Gva/RVqU0KpPVIXvKeKXHyUVyyLTtcnHaUnWcRRRb/1kKANFUqfHsQprgo0nbnRopYc2QuZcdC/0xKP8P26lsi8/cY5ZR6qWHdIxjRo8hxttD4w6ssbn7flKdrBjFmi4eHEyj1wAWsehEQNX/XG/C7ZreOKBU8eZW6ApG1rPm7gw/aTbefQFIsc+L+XUZcP5IhiPPs1Ra5tfxyREXzcSGCp6XlNTbhJKxi1/0k9H3Lnijh/1gRpAPGPjfOUEP3bfFgMCG9nAht6gnzYI/LI32hkPfOp4z1OBQMAlumgbc1L2tDnKNE+bEIUCeS536Ajn2q3Eo35aIEAeD+A7474R3NzExWaBD+kptKQQnfmergyoao1gCyOcZHlEEbzm6SQnSb2Iikpp0oQKZKKvC/awk4lnPrKue14ip41JUsuhhXCS9X0PqAB9fgTHv/nhEkrMCRPHbBxgM0B/GBe+DHWT3jT16gT3Nb4/4qkrFVia/ROZX3AntHnkJm9zagKObsd07mneKwUbxIvop3l/z8joOvDNTj8Jy/aGjE6XpMmVNFP12amTBi9obmLeVDGzxqncBsFQuv6jBBB5oAWjovxjeV1nZE5JvBSUU+prFTDIAzl5lfnsa2q5aw2mSDZWUfmi5IhOdiOkKI/S5+dqauXzC8wwRAsG5lpnauMEkkFWF3vc/5Hnesvoh598bJtJvFwFwmoADTGyXF0JlJVF2n/Ix3Z/iVhg1xQO5gWU22fFUGeTHYzabOO4iIvZko1nOWG1gnAhHFCKnw6CstByMJQoi4r8nqZVKb5OPTmU9+Vsu9mQRXP1KEeTQafIVOJz5 DKKNDzAO G/mF3ECJiTARvH7G9+mvRQOHnjiNyD/VeT/XcwpQRXHoXG6JOXHc7h3OfzaXrbVu01OY2JS1juuOxvCnkIX956/yShC9kfSrmxBQ1iT0hwRH2SkjHMfcbxFHY3G1CRNk5jZWH2/wQeNO5XaSBKYRCNISqDcPTGNQwrRdyNxIR1iZancB8aat1JWj8b2U6Sfl9/m1KW9Z3bK2XwOje7OTsaAbifLxzlr/NpwXNHy+ebJjpIxLZSRv/Tk1e6JcNVrWFsqADCOTpBLpuw89+JaWFoIPgxDMfrEMDCD0f2UoCgV75MlLPtT4Hvdlb0iQIeLGtbosTSK/pxDg2lmHgDZ8s0mKPwb3jNxFI49PEL/WoadhQ2DwMjVX7910NTGf13V/d+3oTLY5l3I4ba0shuMSmxdUFzw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 28, 2024 at 11:29:56AM -0700, Dave Hansen wrote: > On 8/27/24 22:49, Charlie Jenkins wrote: > > Some applications rely on placing data in free bits addresses allocated > > by mmap. Various architectures (eg. x86, arm64, powerpc) restrict the > > address returned by mmap to be less than the maximum address space, > > unless the hint address is greater than this value. > > Which applications are these, btw? Java and Go require this feature. These applications store flags that represent the type of data a pointer holds in the upper bits of the pointer itself. > > Is this the same crowd as the folks who are using the address tagging > features like X86_FEATURE_LAM? Yes it is. LAM helps to mask the bits out on x86, and this feature could be used to ensure that mmap() doesn't return an address with bits that would be masked out. I chose not to tie this feature to x86 LAM which only has masking boundaries at 57 and 48 bits to allow it to be independent of architecture specific address masking. > > Even if they are different, I also wonder if a per-mmap() thing > MAP_BELOW_HINT is really what we want. Or should the applications > you're trying to service here use a similar mechanism to how LAM affects > the *whole* address space as opposed to an individual mmap(). LAM is required to be enabled for entire address spaces because the hardware needs to be configured to mask out the bits. It is not possible to influence the granularity of LAM in the current implementation. However mmap() does not require any of this hardware configuration so it is possible to have finer granularity. A way to restrict mmap() to return LAM compliant addresses in an entire address space also doesn't have to be mutually exclusive with this flag. This flag allows for the greatest degree of control from applications. I don't believe there is additionally performance saving that could be achieved by having this be on a per address space basis. Link: https://cdrdv2.intel.com/v1/dl/getContent/671368 [1] - Charlie