From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85CC0C3DA4A for ; Wed, 14 Aug 2024 16:57:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E216C6B0096; Wed, 14 Aug 2024 12:57:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DD1366B0098; Wed, 14 Aug 2024 12:57:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C99026B009C; Wed, 14 Aug 2024 12:57:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A3B2F6B0096 for ; Wed, 14 Aug 2024 12:57:09 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5F902A82C0 for ; Wed, 14 Aug 2024 16:57:09 +0000 (UTC) X-FDA: 82451456178.28.A3AE280 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id 9B29F14001C for ; Wed, 14 Aug 2024 16:57:07 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=RZBQo54L; spf=pass (imf09.hostedemail.com: domain of dakr@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723654532; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3t7X86RREkF1adPYhHPhunYForkxDLyS2k5AWYE6Un4=; b=kSxauIwzsQpekVVLX/m13Amb1zrEPmXnfO1PqrgsUjAZijoWtI6N6IELtQmvYlVZDQozy9 29TTZyUtJAKrUp0+B14lViQDuFsx5bd/DIOzzWyBv95KYJjnM1HoKtzQFU6OvALfrZuObN gzfuTWWhEnp10YJ34HLtW2fA+h599Jg= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=RZBQo54L; spf=pass (imf09.hostedemail.com: domain of dakr@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723654532; a=rsa-sha256; cv=none; b=TbOjCnLqIQcn9fG7ESH4p9SlLLeBfks2M+K5rrdWDpsw9JyOIfL4Mt30nADBLBcL5AyM/M eDkgGVZk3ienMsvJbQSgUcXcVP4NfrIXZJm/vecPHi5wMg84w/qE50n+P7n6LBW8WV0GSo 2PMkhCqJ5ptLOSy3NRaj5hO8eQrEE9Y= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 89F6E61AED; Wed, 14 Aug 2024 16:57:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52417C116B1; Wed, 14 Aug 2024 16:57:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723654626; bh=7qQlTpMuGngTf5mDhK/HSkbSaWAoRr/xpzL3hhsR3ZU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RZBQo54Ldmxg87PkvleJ+POeP8Y6RZUQ2mkXVHmobhrQD65DrnnWvK4Cb4aFa4S5N cIS+BStvKnBa1Olj3PHcE1We1HWsBgxaLJgBINGPxmNwSQL3i8OM1XdiXCSSWKWUir keafaRtrdrgs8YFjRpVqWpUm1mSePfNn66Fndpqqbk63iVoTKZKPfgfvu2nzw491QW POylZySURYJJLBBMsfh7dyxs3uDosjV3iAdGDcfJgm+n+crKhcSxZQC9WUj7Xibyaw MDmpfPsUNBplRRLDz9hCfLMmEmJfdnpRHh7f6e+1LbNKw9g5K429dMwzjUxsomDCAC r0KVLEV3Vydbw== Date: Wed, 14 Aug 2024 18:56:58 +0200 From: Danilo Krummrich To: Miguel Ojeda Cc: Alice Ryhl , ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@samsung.com, akpm@linux-foundation.org, daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v5 04/26] rust: alloc: implement `Allocator` for `Kmalloc` Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 9B29F14001C X-Stat-Signature: hnnkru81fkdff3pxnzuuw898np3s4ra8 X-Rspam-User: X-HE-Tag: 1723654627-264125 X-HE-Meta: U2FsdGVkX19i1IrqQ552N+tdQOWsrnU+FfVKYq5NIhvwoWQYiStOSXWQeKwTRN21kewz0PVLDj6XbFPSz75vimit3TpYN9DRI6URpJOWOAQqV6qTua0O6HfZjIR84G/utm4Fa9uyLnQmJsvYuUYUoWj2DIHVVaktiNvmYFVS2dMCGnJD3msp4shRyau2voYJI4K2x0WJzOj0dB4sS1BTzUwXpDTTaxbbJf7P9tLP6SDnKFG4Nc9w3Kix36DYb4Yolhz4Fxbv4pxwXI/39qaGOL/Uruv5MgYDbNsnM/vlM0xj8oL65lWHAtM2ek8ruqFiAguqj4fgK1bmTuqsk/YeETbOW7AN/MJQZZ/PwwASnYs5BuaRKzMhy2HuflrLedZrwXiThdxk9VxpUNBY2fU1m0VmVnx5QsoIQ/6he2cHgjwmbq8YgswLmo1CI6EF7qjdURptEYgrbjKjTIsnUKZ2LT0aRbZuaX9A3sYfZgEb+XbF39sX2aIdPAA95UApfpPXOt2JNcyccg+kzi0HUX5+WnZTeOnK7vUHhHs/zYblEak1RW6ylXcqpU9GiZ6ecopizyC8yfpbbVCX7Zu0RB6XR9GT0h/aLK9erJu0ujQ8gJhIVPpptj1qMLsjFVK3hTQ3lzmB+BSYTgJbG81xU/X6jtpPOntd6MGL4XlgTyL+tzEAP2uPDciRXT+im8SHKrKofV3sNt1Sg6+D4oVgcMJ6n1jx3Yg4lZ27VEEIcV4kWnST46fyCnymYQeHa/qHrFVlD6hTB1MGeGwKpHXETWpABx9tjlgW5C9R6KPVt3icOqa9oQmKqaNQQJClxPbr8Q+WMfpLyLWJr1zCw/I4rVEZvBZ5PjU/ckXv1/kHOs6IBewHe6yqlUInvpJp8gVk0UI+r8OPKnWZBu6KR6hi8Q93Mha8jwYS76gAbsydF8Q9cptFmY11K38Y+j33x2lIY3aafqEPHAO6TcRIrBl6jW/ 9u+FJ13T 1deHPhQSQ6sFHio//E/sFT4DkEbycyhnOBB2LNjHk/+qsyACe4I409qL98KRqhXuMqX4EC0Z9BRYBLaxICg0RoIFlL1FwjIbhDk79DVzrFrf4W9uhz6UAddqHXE0jEXQXYFk1oNRdg/Nha0aRNspTcHwC/lEJFvsBJEzBIFhN9k+VpZ2hoyma72XmuH/mpRzsNVyPYX4jawnRZ9j4ZtYHknw+2ptlU1pGpOgWEI/M0VUzz39wft5VFor4fSbgNew9tqTZF7B4CoNDil2OzfcjwOsvam6LrZyrK+tjKAIjEvLX/i5ykOUKgJW4v0rYO8N4WOowrLhJ3Csm/bGKDQ2TuQ2S6g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 14, 2024 at 06:16:34PM +0200, Miguel Ojeda wrote: > On Wed, Aug 14, 2024 at 6:02 PM Miguel Ojeda > wrote: > > > > I checked about `__must_check`, because it would be nice if it is used > > by `bindgen`, and it turns out it already does, but behind > > `--enable-function-attribute-detection` (apparently for performance > > reasons): > > I just tried, and the flag seems to work, gives us a bunch of > `#[must_use]`s which are nice, and apparently no other change (in > usual x86_64 config at least). Cool! That's even better then. > > I don't notice any significant performance difference in our case, so > I will send a quick patch to see if others find an issue with it. > > Cheers, > Miguel >