From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3062AC3DA4A for ; Wed, 14 Aug 2024 16:09:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B8B916B008C; Wed, 14 Aug 2024 12:09:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B14A76B008A; Wed, 14 Aug 2024 12:09:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B5106B008C; Wed, 14 Aug 2024 12:09:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 789AA6B0089 for ; Wed, 14 Aug 2024 12:09:47 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9256A1C481B for ; Wed, 14 Aug 2024 16:09:46 +0000 (UTC) X-FDA: 82451336772.04.B980D4A Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) by imf06.hostedemail.com (Postfix) with ESMTP id A1F5518000E for ; Wed, 14 Aug 2024 16:09:44 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=msdemGCR; spf=pass (imf06.hostedemail.com: domain of gourry@gourry.net designates 209.85.219.48 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723651713; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UTMAfZwm52SQ0m/pN9TkblWdNOlu11wMpD/MjyARKoU=; b=ruNUh0J9jCW3siZb8512zAE59Cl9U3WYdC0tis9goqGfH6hj5f5WwsEjnICIr/7sL2eHKs efdXmR5If24+Ia2Yg4qaHReHVJGE4JB8VaucCdnNIMjtbkJuIAcyX9CY2WMIyGbIqty04W RQm3GgsVBxWVNbw8Lpzz2rWZOjzxkFg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723651713; a=rsa-sha256; cv=none; b=tgzuUzgcqs+t9CT86RqZweNIgKPizW3fhDUa4B+1rEAWMhCifb3zKwO2eHEWaqM7UIr79N AUwnnKwDRBcM4m82UCzbLAoAiHga//DCwG69/MlS0DGkwmWxfBcyCCfbLpsHU/aPxYeg36 ewcMF3OZ4AEV/8Ppk0ySxMMoUwp+ZuY= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=msdemGCR; spf=pass (imf06.hostedemail.com: domain of gourry@gourry.net designates 209.85.219.48 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none Received: by mail-qv1-f48.google.com with SMTP id 6a1803df08f44-6b79fc76d03so38943926d6.1 for ; Wed, 14 Aug 2024 09:09:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1723651783; x=1724256583; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UTMAfZwm52SQ0m/pN9TkblWdNOlu11wMpD/MjyARKoU=; b=msdemGCRQLlMAI7NcM+NS0HEutcpOCnaz/OOmd2o574YL12wqq4LmAF07b2M4G1Uud mw2Fp7Em3x0mGu6GLg7PriStzIPvcnIA7+kxa6UIpIAwS/+N81x9M2m6mQ1JbuKcMRKB iwtX2fwrMedMD3aN0x0UqKnGuMJtxBbQ0MfnqNcrXkuw83GNrqvKKpt8WZ9PngI4822y qRHeXe2tP6Jpjvte86+9CPe6z3lrIoi1nRQrc+N5yQfeQoyqfESwBMLW6prSCfZvEyix WPoqmDQGaCpviTIubLtwkHPkaggy3XtbmGfiCF/3MUduObFXy1ZZuZtd3MtzH9jgtbN1 ErtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723651783; x=1724256583; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UTMAfZwm52SQ0m/pN9TkblWdNOlu11wMpD/MjyARKoU=; b=hFF01sDXZd+fVIZDFXrLavEZCAMegOiUfBIk+ctqVm6QavRHtd6a/b/w06DPnq/uVA nLehlHeQHSsXrZPff8tJnROwqP/noLy9IN+g8yAmOD+UsHzBzV7sgWsz7ScyVBP8Q18+ r0dBTj9fy1dA7JmMJIhPQhB+XtVyRBy3sFGPy2VWskfWeGS9tDPJfMPxLmBJr3IHyIK3 GJPG0SNZ0evXzEVhV4yF8HLOkX3o/6Drv62+CVowv4+mQqMjoN9mrzQXGUAS8SvlwfQ4 WDI4PzIjfgEByyfn7/CktfEpenwVUCQplNSodeKWdfxJLpNWEK/9lYGouBWbpZEA13M8 hHbw== X-Gm-Message-State: AOJu0Yz5OXTqupWcW7ncgfFFe1OEDmf1KnPJKJ+ZFFV9eeWCyGvG+m4t cdNRxDt05p4MDq6Ja1rQt7BMwMV0dU/lh1QaQjyNtiW1RVzODrkfOF/5Le7zNuI= X-Google-Smtp-Source: AGHT+IE7AlYD/pYIIDdg/E83v8kL4zBTJBowCqme1T2/5fVYs0E/hfviepietgGJNo2cAKRMQTu2yw== X-Received: by 2002:a05:6214:4303:b0:6bb:b478:a614 with SMTP id 6a1803df08f44-6bf5d165b59mr43701136d6.10.1723651783190; Wed, 14 Aug 2024 09:09:43 -0700 (PDT) Received: from PC2K9PVX.TheFacebook.com (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6bd82ca73c5sm44900366d6.69.2024.08.14.09.09.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Aug 2024 09:09:42 -0700 (PDT) Date: Wed, 14 Aug 2024 12:09:01 -0400 From: Gregory Price To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, david@redhat.com, ying.huang@intel.com, nphamcs@gmail.com, nehagholkar@meta.com, abhishekd@meta.com Subject: Re: [PATCH 0/3] mm,TPP: Enable promotion of unmapped pagecache Message-ID: References: <20240803094715.23900-1-gourry@gourry.net> <20240808162011.0492099266ac47e7b84eacd0@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: A1F5518000E X-Stat-Signature: cw5gx1xgassz8pymximg3r5c7rfx1464 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1723651784-78899 X-HE-Meta: U2FsdGVkX19+c/a1RWGFjC9z0/S3yVM/WlYQ9HbKCGVyM0850rF3EVarTIHKWHs5fW+7Qx3dXi15YXFWaPzPtfu/lPwIyi0u7D7+WjkIE87jQHYkkMyLtmnB/97D3KfyfPNimAVWToBvpoC0/S8Q136+QyNwHJ2XaAlFCZvvKv2OdeUY8WXhkXo7AfKEw2BLHwj1SuEoAe7gpwHTWNQgL9AS+dwCDrDk8Wzh33bCkZTAspNSutQ7bRhKFhNhcWqxbrOPjnRQawfM1vpetg2TD/hM+eHr2O7aDys4kYpM7K1hDFDzMLHfC9Bx0kwMaZXtXguzyR9DxmScd7OciW7KuWrXDEnbjTU4uS5wW9z7a+ehqUWVQV/iOgTj/NxzMgySEHCXNayc6JWzO1YTor2zLrRBkpYzhKZDF/XUputUbHiPVz2SlZP8g7jVholAiWyCjMNVRqNhOjbrpTY9cZmBnml0uGBQiFK1h5noMAxxozPP84fpOl+/uDGUk6Wht0EVPhztqdkXWmwbA2x+7+XPYFi1LZJKzO8L7OBogKEU7l7GntHXUHDdArh7Dy9eMQaEGFcs9Kk322xl8PhrroC3BLuSfkwL4PHuvq5008Tv2XtPPVO2aAJxinm1F8k6adrSz6MuIZ8yxMM3sIFBFlsBk0N6SdM3GM05xCHH9Xt5VSbxE2RiHH9yqPNKcSWLRSuihfWDTskCLc7EtTpr7CHJhweplJwfyJ+ed8+v3mc+sbeDib7fPbeKyLPJ4jZ5WY5+f/Lyf8Yfh75ELEweLAfbZCvuOVAm4u2mIr//LmzAvmfd4AHogOHijiOWGo3a36u08Jy3iylUL5yd6OaZM0NHMbJzL8c9ggHEXsmEpUWPGLJjj7J6anm11SmxC70D3HC0OwPGBPFYUjBD/NyPWvoppwKUY1PzsBzGNWnqSdhrAPjjsMf3CKHjA0hA6g5POsW85IDBGnETp0793FIIqz6 s/cXsmux KA6f4Tg4ebp7QYdV6rTCbblXmY5qZXo1rTeFiJ+/BbSBxfKiBOiLyDIpbCv4vw9EolTg9I+KjhGnCC4m7BihniEHt5Fnhuv4B3CNKVNaGYR5K/vv8pLhiG4Kup0lQ/wxRf/33ttILwG+UukC64NUh64PeonHbDVgpdtRvKKrzdWIvkpPfh/wBw/uCRjFLQlC0PoMvPMwW3RC0H0WzIrfN5y2svjgaB+HtvFktDsXVlNQrMHyAH9cw+saDGNih9wQq7PpXg9Bsxndq8qYpY9l+DOT0sn9zc5uKpryrLDBwvpQ+LN+giyEjYOA7SX27sMrz2ggz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Aug 13, 2024 at 11:04:59AM -0400, Gregory Price wrote: > On Thu, Aug 08, 2024 at 04:20:11PM -0700, Andrew Morton wrote: > > On Sat, 3 Aug 2024 05:47:12 -0400 Gregory Price wrote: > > > > > Unmapped pagecache pages can be demoted to low-tier memory, but > > > they can only be promoted if a process maps the pages into the > > > memory space (so that NUMA hint faults can be caught). This can > > > cause significant performance degradation as the pagecache ages > > > and unmapped, cached files are accessed. > > > > It would be helpful to share some testing results so the magnitude of > > this degradation can be understood. > > Apologies, this should have been an RFC - testing results forthcoming. > > > > > What is the potential downside to this change? The local node now gets > > stuffed full of pagecache and other things get evicted? > > > > That is one possible degenerate case if there exists a large amount of > free memory in the local node. We're testing it now against TPP demotion > logic, but the expectation should be that if the local node is already > pressured the pagecache would be trapped on CXL until TPP frees up local > node pages. > > > > This patch series enables the pagecache to request a promotion of > > > a folio when it is accessed via the pagecache. > > > > > > We add a new `numa_hint_page_cache` counter in vmstat to capture > > > information on when these migrations occur. Worth noting for interested parties: This patch is not stable. After some extended testing, we find some soft locks. So please disregard until v2+. ~Gregory