From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC9A9C3DA4A for ; Wed, 14 Aug 2024 15:43:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4EE106B0083; Wed, 14 Aug 2024 11:43:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 470386B0085; Wed, 14 Aug 2024 11:43:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2EA396B0089; Wed, 14 Aug 2024 11:43:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0B3776B0083 for ; Wed, 14 Aug 2024 11:43:16 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B93B7C0FD3 for ; Wed, 14 Aug 2024 15:43:15 +0000 (UTC) X-FDA: 82451269950.24.A108C39 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id A14B51A0020 for ; Wed, 14 Aug 2024 15:43:13 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VSSCxUt6; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723650181; a=rsa-sha256; cv=none; b=wjHClCMS0zslUL1oQbNH9EAr12xDvHbKvS/KpCvxVbJGa2hVhSR/FWADBl8OSdNva00svu eBCSO8hvbkGX6u/jvQC5kgmNHwll7bNeOG9+X0CBNgjD8Zad3Y5mqZ6O29gxnZsENWQec0 7QELTN+9xP5wNpV1qATAFOPY4ygIb2E= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VSSCxUt6; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723650181; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Wp3RgWPkdUCFzuPHgIrGTTZ3GUOXugzLWnj/fmKQBpI=; b=ozqGSsVMOcxuwBA5YAQv0VmBDDX1zUMBeVV5wB+codkeoxkxLNJ0yg0scD/KEhlVgupIU0 Bs+4Zo9gxCfuWY1k5wmDJb1PzgZDh0xkw0QMXFpVsU2bxnRU18N/qGS9fDphfc+dAfvG25 ctkRmVus5XfcUWVOd2jBxLj6qdlQ4sQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723650193; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Wp3RgWPkdUCFzuPHgIrGTTZ3GUOXugzLWnj/fmKQBpI=; b=VSSCxUt6kYVUzTuNOtkNhAfXN7yYuht3eA5DCg3j2Yfis2XalayQ4WwPITTP/xgSZLi0dT OMuSTXujYgrQWjrNR3yjw29mc2LKh/2q410YKTjX80Xb0XL3dVpLFEi2F8gY//qU5+VJFR 0m2LgBTni7UtMNYvuYSrAvQ8ROk7+sQ= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-157-TWAHQ1lgMBuw0hLJOZL0yw-1; Wed, 14 Aug 2024 11:43:11 -0400 X-MC-Unique: TWAHQ1lgMBuw0hLJOZL0yw-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6bf6a978302so723956d6.1 for ; Wed, 14 Aug 2024 08:43:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723650191; x=1724254991; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Wp3RgWPkdUCFzuPHgIrGTTZ3GUOXugzLWnj/fmKQBpI=; b=NUhMFkSB4/WTBx3VpkrXbzwvMkQvgRMi5/7q/VzZH2J5O2Q9/G6lfgMIZpQ9odDX4E ZBEZUdrL2LVOMw9UMDmoGgW/BYN0IsmhC3ZvBhoeziI4NeV3PUQ3XvnRbKwOF7Vf7DPv OMZU7vMvyVBLxlwKPqduaYEO6PhwW05kwRewcxBqy4Lnx8s4dwzIUv9GX+ZLDcyuL5uS N14a2wA8jNkhb/uyNDI98O1uM5RE/tvuJw1wOFx3wlXtjw5OaX6xXMGdk4hA+1bQU2F+ j+oyI5LO8za6B4YC2WOp3+/d4oEGSLQVABLsCLmXvALEZSSprBjELSj0fXou+dmqWu1r Fftg== X-Gm-Message-State: AOJu0Yzb6RdjaqlQ1SqiFM6B2FTLCpj9mBTQufnbZsr9Zmrgo8Dg4dBt mwyoukRN6IKG/6BcooNovxiND/zYvlhe2QDWap0av+rmE9Ly77B2G3Gm3FdZrFA4CvdrLoc72oD VIzdlFlWWa3jaHThItKM+hus0T8dmeG5Ypfnxy1mSkKwCX4fu X-Received: by 2002:a05:620a:3704:b0:79f:44d:2b8a with SMTP id af79cd13be357-7a4ee3907bdmr238903085a.5.1723650191071; Wed, 14 Aug 2024 08:43:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGYXNGxrMlqiMBIZ5ST7AxhHtA/FbXaG+GaqvRqPuCV6WzqEPOJp/I4t+RerfXsa1wlbiNflw== X-Received: by 2002:a05:620a:3704:b0:79f:44d:2b8a with SMTP id af79cd13be357-7a4ee3907bdmr238901485a.5.1723650190692; Wed, 14 Aug 2024 08:43:10 -0700 (PDT) Received: from x1n (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7a4c7e051d4sm448353485a.123.2024.08.14.08.43.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Aug 2024 08:43:10 -0700 (PDT) Date: Wed, 14 Aug 2024 11:43:08 -0400 From: Peter Xu To: Jason Gunthorpe Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sean Christopherson , Oscar Salvador , Axel Rasmussen , linux-arm-kernel@lists.infradead.org, x86@kernel.org, Will Deacon , Gavin Shan , Paolo Bonzini , Zi Yan , Andrew Morton , Catalin Marinas , Ingo Molnar , Alistair Popple , Borislav Petkov , David Hildenbrand , Thomas Gleixner , kvm@vger.kernel.org, Dave Hansen , Alex Williamson , Yan Zhao Subject: Re: [PATCH 08/19] mm: Always define pxx_pgprot() Message-ID: References: <20240809160909.1023470-1-peterx@redhat.com> <20240809160909.1023470-9-peterx@redhat.com> <20240814130915.GI2032816@nvidia.com> MIME-Version: 1.0 In-Reply-To: <20240814130915.GI2032816@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Queue-Id: A14B51A0020 X-Rspamd-Server: rspam01 X-Stat-Signature: fm39x4izbzqoc6bbtppaop83azmjtc4g X-HE-Tag: 1723650193-367165 X-HE-Meta: U2FsdGVkX1+SpZwtgj1Jyrod8KL4pZMQoG0brglHbp2qMd8necJykPvbm1BxDUSn4+G9jCLyhitW1YkDQ+zTIttcr3h6HaAZJl/8zom/3m5ZvnePjSOGQswr4S9oZuP1Pz+z70t8qC3jx2Af85Wx6hK6KqL06mX9d6jIBEwEIE2suFtrjGjOMrKzegPcxpeDlX9MHi94jwybLgCRKkJNK9jG9jn2gI5E9JT169lHkRLRVyY1Q2L3pG8F17JaJhnDIhFruW0OxqQSMNWQtisW19RrmhwzZAoHjmlZzuAZ4v3QMEWtu3MEHOHeezdB9Bi25BSOziLkBK+wTgEOLdsKpiw92dxwI2Y73MaxT6sPW6lbXfzqVL1LRsVmp4pg6+pn31IWjXipAhvH8nqm0f9tJM43wITF7jTIlThsG3Sca5BKIuwpgnMmZzGnJjxK0XB9i2E9odFV1RmfCHKMFgXiwtEkuv8o7Kbm39pxyG75vLYSZcTW4pDQNp5RofesdpnUkoAu+Jg80HcnxH8B7SgJZwcHzSNR1yEvKqHvL4XhqUYMqNIc6TThTO6mtrQH6zew5lE6dJdcQ3kBfrmsgiBizBlMvqLOd2qEoKuFOOY/zkjuQEv5faPnbGWoQOac1o0e8wlWiVl57OvKNmWftvfJ3jcmANWCMvCgMQkDNdfGYOyM6ssLw8iWtgE+qEuKrWRZzFmTwQBPunoxjz9YiCz8iOxVszjvy27hhPWjiqPLrq+u1jT/a8lkE68aLXL5dv9bxCj9CGiGRi2IhiEYvYaP2Y2H+YMtPJ+N8oVBqdVVq0bvnSLq5aUQfwfRxHSM8B1oqEkr6wAcQhG0YBqUEepg6Zh42RTE+Sq3HfE7TETsbhbTyRLjABciu4sibCILGEsReEfGZEtSQLhfeLYiGg1ONukJHmbrZoTA0yHwzaH+cj+d3GbrSlZTmrTmlpaR/AnYHLyEjt+fSnoVUueCKP4 Y1BwLaCx RUI60sndmvF2VMSuld8eGRiaJRESZNmTXfdrCFJ8j91CGItGIKfyNG8lR2P1tdYC5QtIonjd+GcBdmlDe1q+kDm+1lryOH98BxfZyjeJ9Na1YzrbhT1pRcNWdaGK5M9MmCcYL7mKg9J38lQYhf7Fz/S6G7dziE9d+WqFKLp1whs8CId4EAMIoNA784G2Xu54o60HTtwbaZg42HN8TrX8PPum3ij/CETnxXIqcgNujXidFOkn3jGPICYgVIFVFQV3tjlh+yf5tAKgcZRFopBt7R36ZRMUar0GFxgVX1/DnvK6T3lqM7f5eYCjeeLuZc5nXJbqPibiS6uXlspirpZzr3Vvbi3gDV448b7y+08U1gRDtDBlGiWtFW82ftQh/PPjLny6aeQ+zWsOih6a3qHimde6p/y2XiGpcVPsuFdyHWmLuSKRkuu9pqLv3MhOVy0PGiuO7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 14, 2024 at 10:09:15AM -0300, Jason Gunthorpe wrote: > On Fri, Aug 09, 2024 at 12:08:58PM -0400, Peter Xu wrote: > > There're: > > > > - 8 archs (arc, arm64, include, mips, powerpc, s390, sh, x86) that > > support pte_pgprot(). > > > > - 2 archs (x86, sparc) that support pmd_pgprot(). > > > > - 1 arch (x86) that support pud_pgprot(). > > > > Always define them to be used in generic code, and then we don't need to > > fiddle with "#ifdef"s when doing so. > > > > Signed-off-by: Peter Xu > > --- > > arch/arm64/include/asm/pgtable.h | 1 + > > arch/powerpc/include/asm/pgtable.h | 1 + > > arch/s390/include/asm/pgtable.h | 1 + > > arch/sparc/include/asm/pgtable_64.h | 1 + > > include/linux/pgtable.h | 12 ++++++++++++ > > 5 files changed, 16 insertions(+) > > Reviewed-by: Jason Gunthorpe > > > diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h > > index 7a4f5604be3f..b78cc4a6758b 100644 > > --- a/arch/arm64/include/asm/pgtable.h > > +++ b/arch/arm64/include/asm/pgtable.h > > @@ -384,6 +384,7 @@ static inline void __sync_cache_and_tags(pte_t pte, unsigned int nr_pages) > > /* > > * Select all bits except the pfn > > */ > > +#define pte_pgprot pte_pgprot > > static inline pgprot_t pte_pgprot(pte_t pte) > > { > > unsigned long pfn = pte_pfn(pte); > > Stylistically I've been putting the #defines after the function body, > I wonder if there is a common pattern.. Right, I see both happening in tree right now and I don't know which is better. Personally I preferred "before function" as it makes spell checks easy to match macro/func names, and also cscope indexes both macro and func, so a jump to any of them would make me look at the entry of func. I'll keep it as-is for now just to make it easy for me.. but please comment if we do have a preferred pattern the other way round, then I'll follow. Thanks, -- Peter Xu