From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E437C3DA4A for ; Wed, 14 Aug 2024 15:34:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 221606B008C; Wed, 14 Aug 2024 11:34:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D1C76B0092; Wed, 14 Aug 2024 11:34:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 073AC6B0093; Wed, 14 Aug 2024 11:34:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DC5DF6B008C for ; Wed, 14 Aug 2024 11:34:43 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 88FA6A0FB7 for ; Wed, 14 Aug 2024 15:34:43 +0000 (UTC) X-FDA: 82451248446.16.EE556EA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 6280040002 for ; Wed, 14 Aug 2024 15:34:41 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="TS5uH/UV"; spf=pass (imf07.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723649610; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Qd3L17EBGdmTNYKdWop5YhqCOAOZ9OC4Gj60Xq+yFMc=; b=YAaGOChhKGaloA3How0z1zfUM9Xh8u4yrPRIIcbXs0nwmM9jmhf5ZnEBrZp+Qj7YwcE5yl K1i33+8bmpyQI4r+NY3wA7HvymsDMXJaOkuCqgwSCHiwcYA/xpwmPlnCWghL1yRQIr8jiS 4YFMoq/tTpnusQrCBube4xOmSKXP3wo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723649610; a=rsa-sha256; cv=none; b=eN/3Bi6KgRVH2f5M0OhlyiX9V7HOTtn8+wgX21B1l+L63jimgPIDqwN6MSwMMfDPhtMVkm LEQZFWuNC343aiPK08Tnspm/6O9mqSHAp5Gf7R4dS4lCQ1dX14D8EdQoDhRIlRrlUT/y9H 0QNZv6V8DCev7mpmXxNX8YElq2FqiVo= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="TS5uH/UV"; spf=pass (imf07.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723649680; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Qd3L17EBGdmTNYKdWop5YhqCOAOZ9OC4Gj60Xq+yFMc=; b=TS5uH/UVIhoo1xsqIjyOL1re6F/m4Da5tENHeu/ao6NsoX1NVgYvVklrnNkrJrA+Sh9cQQ hg0XhPjOwdvIVtIIhyYGkYcQAQrLHzUwP+fmTL9Ctc7s4Ntvp9DeGvRbwFQa6B69DfY/mX aaHoutqs5Gz924JaptRFV98x46DJ6sY= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-414-ijly_EyOPiCL5OV0EQJ3IQ-1; Wed, 14 Aug 2024 11:34:38 -0400 X-MC-Unique: ijly_EyOPiCL5OV0EQJ3IQ-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-6b79ccc1504so708486d6.3 for ; Wed, 14 Aug 2024 08:34:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723649678; x=1724254478; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Qd3L17EBGdmTNYKdWop5YhqCOAOZ9OC4Gj60Xq+yFMc=; b=kap5m7uilTVcIJqw/L1Ovtqd737H9BdioczkAraGWHNwx3mhvkIhY8LybR+IIe+o9H K52awUwqtPtJYsTwHNKRS3sbWzHN8X8bcBO3gjuov/rbNfvGpRTYHYF1XvWPwciGpAHs cwMt4eyU3UNIo532f0W7R8pmcnk/YaZ2/bgFhZ95NU374Y2FiH1hxt287lTKaxD/KpqP +KF5yiJyYmrulAY+4mIiHfV9BC72aSom9mPXS8E4HMRudYa2QH9GQ0QhyugAZoVZ0l5B xOX8+NRIlPMWt70O25/80bFRYG81lqWH/zthP6Rw1Wrs1AlzsytmJt4hD8r+gHW284PH 0FXQ== X-Forwarded-Encrypted: i=1; AJvYcCWuWBg/biN6pOdh7CVnibROIvGUOa8AkpAt+KSFg50tdg1R/86SYjxyIDX9M6JcbYdIeauUt63+aoadg6qsgTC0/ug= X-Gm-Message-State: AOJu0Yw4eC3oT3HH2byKtDQMyu20DrpXdihV1oWV/2JNo7DyXh4XH4bd wos+2zM/0wlfQESaTDGzao5AsbTZ19ic/9MBglZAMjxAelCUaIvr/xdBgs59l1PER5+df3pVJ2K tJ2nX1w9naFMysrDf0LsN+/zOdbr2mzW+zIH5DX3QRQzu9gzA X-Received: by 2002:ad4:5fc8:0:b0:6b9:5c25:c41e with SMTP id 6a1803df08f44-6bf5d1751admr20508886d6.3.1723649677982; Wed, 14 Aug 2024 08:34:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHYJFXpQReML2ilodNHAhAn+3jsYwBR7OSYAxKuBRWJs3Oa71h5lhZj6qtdRaoMOC1R9brKfg== X-Received: by 2002:ad4:5fc8:0:b0:6b9:5c25:c41e with SMTP id 6a1803df08f44-6bf5d1751admr20508656d6.3.1723649677661; Wed, 14 Aug 2024 08:34:37 -0700 (PDT) Received: from x1n (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6bd82ca73c5sm44588296d6.69.2024.08.14.08.34.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Aug 2024 08:34:37 -0700 (PDT) Date: Wed, 14 Aug 2024 11:34:35 -0400 From: Peter Xu To: Jason Gunthorpe Cc: David Hildenbrand , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sean Christopherson , Oscar Salvador , Axel Rasmussen , linux-arm-kernel@lists.infradead.org, x86@kernel.org, Will Deacon , Gavin Shan , Paolo Bonzini , Zi Yan , Andrew Morton , Catalin Marinas , Ingo Molnar , Alistair Popple , Borislav Petkov , Thomas Gleixner , kvm@vger.kernel.org, Dave Hansen , Alex Williamson , Yan Zhao Subject: Re: [PATCH 05/19] mm/gup: Detect huge pfnmap entries in gup-fast Message-ID: References: <20240809160909.1023470-1-peterx@redhat.com> <20240809160909.1023470-6-peterx@redhat.com> <67d734e4-86ea-462b-b389-6dc14c0b66f9@redhat.com> <20240814124228.GG2032816@nvidia.com> MIME-Version: 1.0 In-Reply-To: <20240814124228.GG2032816@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: 6280040002 X-Stat-Signature: 3tpcew3x9r935arbpwdpdse7y4uquirf X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1723649681-347199 X-HE-Meta: U2FsdGVkX186e90s0bNFRBBQjDJuRKRTYsXhlzkXFgLTA1memLLRIHy2Nm+oIPbeTKl71wBPmXFze2u+eWu6W7DzpFHErgCAl4dlvNgkkR+WYa1d+yUQNdpGGK+Yfbc5udHVgq5bxNon7ODhCfiDDpDLO8c6LKTqZ+DuGj767/oDvvUDs4lz0nTqMrfStoUmZGq8sajBJW3bH1GeLDWJdJVkw2uWr/ffiDvVZ2NTNgzoEuKdBpmJB/98Qi5GY6ZkLthi9J5hMaszGi19C8vQ12/b0dJ7dal3q8QnYrlKIT1G8boxMCFnBHyFIic82y7C6ROUESZrmiAwel5MQt503hBZwP0ir7ARd2aPICu17ie9ZYcrkuU4g/xJ34C4PQe8goRxGPMWaV8YQr0RuHtE8AyNrtoWjP9Pdm7Ta5l6Dk+OEuasHtsXo4kL8fxW2LuTQvRYEyRVMC316IwrAEbGxNi97y7g8regHVbFtl4COQHVTjmwNP31K1eAUabAwSgjwvHlWtjyjzIXc7yqYcmoiSHXK5Fy/j0WUV40n+cLDJg25uhYnBgnxXumCLyk/rAhnTrBiM8sTo0suiDLejeea+kuUfZzUxTMXte6btxKxB9RfCEp5K7Ep5fWPGZJ+Ln26RRKbLUG3xpRzyKipUb4SSsbZKMErq5VVTe1wHvqM8znvfOrta514yyTnreloh11/adYPl/JhtftntQWJYiP69ETPpwMQs5aRFQ8/l1s81Ot7ROjX+orvClulgiZuNFbuuas/YfduKf94X3jBAjRM+fYdblETaI1LpoGc1sPBAkETpSBnKacMCAVA6UpnT50cyeH9XjAEuau7FUhD/FGRowatl8v5k/E4RYKw3EaQjghCT5LsAIA5yJ9Nm5beN0nAmLDbB7DbV3OnA0WmCJEBvvTtW2qWuDhGUxp4dc3doiauKGHxiLLR+hhnOC8avKP08dk+7GMYxEYXVTBNC9 /hpmilAq viehsy4QwPtGXkuechhUKDJNByIYZV4haDuAfy0iYWer4DfB3+cz8nqYKl03OyeEa0BS7qnOeBAsaenO4bGFLZbti1lFHyx7Vq9uoF/TWeTYVuIgg1KPA6jX+IA0EaVXKecB5QWcTReYEA9C2plLRq11gKocpwqQIW52dYONhoLZZh+dzYhsy9/jSHOqjs3wCDvGHG+7TVzjpXXsOhXF+fbTUaiL/XmT+m49ykriRkQM5pljo3iCKKkrdrsIB/U+VDV+/wUlrCfc+NFCGDo30JgWHL3xIQ/rKlhPceh4EKncXI0mY+4GU8tLnnpoahUzCQUnc8RetXR4ehjqDaruuIhrVvJvSEo8QcnXA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 14, 2024 at 09:42:28AM -0300, Jason Gunthorpe wrote: > On Fri, Aug 09, 2024 at 12:59:40PM -0400, Peter Xu wrote: > > > In gup_fast_pte_range() we check after checking pte_devmap(). Do we want to > > > do it in a similar fashion here, or is there a reason to do it differently? > > > > IIUC they should behave the same, as the two should be mutual exclusive so > > far. E.g. see insert_pfn(): > > Yes, agree no functional difference, but David has a point to try to > keep the logic structurally the same in all pte/pmd/pud copies. OK, let me reorder them if that helps. > > > if (pfn_t_devmap(pfn)) > > entry = pte_mkdevmap(pfn_t_pte(pfn, prot)); > > else > > entry = pte_mkspecial(pfn_t_pte(pfn, prot)); > > > > It might change for sure if Alistair move on with the devmap work, though.. > > these two always are processed together now, so I hope that won't add much > > burden which series will land first, then we may need some care on merging > > them. I don't expect anything too tricky in merge if that was about > > removal of the devmap bits. > > Removing pte_mkdevmap can only make things simpler :) Yep. :) Thanks, -- Peter Xu