From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22385C52D7B for ; Wed, 14 Aug 2024 15:23:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 685A86B0085; Wed, 14 Aug 2024 11:23:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6358E6B0088; Wed, 14 Aug 2024 11:23:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FDBA6B0089; Wed, 14 Aug 2024 11:23:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 30EB06B0085 for ; Wed, 14 Aug 2024 11:23:51 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CD3AA121071 for ; Wed, 14 Aug 2024 15:23:50 +0000 (UTC) X-FDA: 82451221020.01.9C1BC97 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 9C98780032 for ; Wed, 14 Aug 2024 15:23:48 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FXJ3VaJM; spf=pass (imf30.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723648972; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rj2ZyeWKjea3ZB5hLuY/mn/YSKMmrc3bYlHWoh9tPIo=; b=yD5mKd57GHyTpAI7zVU9cW8Lqkyihh7ilXNSfmyQyymg+4LSbi4LVQL0GbQ1bM2GBBNmjR 4txiMEhSIWKYvgUyOh8hJ0eunv0ao6AnhAKLKkzBYg11p2G5Plb4H1bO8oLFQswCB/o0eV tdZIz/rMxD95sTPN944wWBea+AmSZPE= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FXJ3VaJM; spf=pass (imf30.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723648972; a=rsa-sha256; cv=none; b=jwxNpSpMHupCidmsXufQdebTqapnEiDJXEdZt15DXvL9Zgp32Jm6dXOjKwSlB9Y22BFz4e WBt/PaqAQzCjnpZSkwwimkI83H6/oATHogYGjIV1a5uDcg1P2t7f3Qjr4JbalFeBdCwaYg dj1os0d9FZoFhZD8PhI6uZqS/R9jTrM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723649027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rj2ZyeWKjea3ZB5hLuY/mn/YSKMmrc3bYlHWoh9tPIo=; b=FXJ3VaJM2gPLM/lHc3sMt/yAam4jDygN34xbHfSDgywcDVbctCIt4EU8yKoXwoiZJTAhXf iZESJ3VZUlSusEvf9mxgKCnw+dzm/PUU3TBqEDMJfSAkLy101+43ofhbqSzO0QktWJ7WNE mMTnFDUV4gOO3THPQ04WktN07wgF4fY= Received: from mail-oi1-f199.google.com (mail-oi1-f199.google.com [209.85.167.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-696-4O60gyUyNrKM5IHmehP5Bw-1; Wed, 14 Aug 2024 11:23:45 -0400 X-MC-Unique: 4O60gyUyNrKM5IHmehP5Bw-1 Received: by mail-oi1-f199.google.com with SMTP id 5614622812f47-3db2030c1a5so839037b6e.1 for ; Wed, 14 Aug 2024 08:23:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723649024; x=1724253824; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rj2ZyeWKjea3ZB5hLuY/mn/YSKMmrc3bYlHWoh9tPIo=; b=E1ggc+aI9slshZnRXSH1dwnTvmzJge9iPo3Ky9ONh90rKODd/egb/QbOyrDczj2s9L 5Baofq2mwn3ZiZ5kl+8n7UqR0WGZkuibUGOragdBprP7LqEPbWb868CqxH+Jmb/zcCTM UrXAP1fLHfr5+uFsOA3NSCQDaSAEukfREXKSOZQlQ5M3IHO3WkrjOpVrOruaWC0WngMP rgmS1XEXrv1LrGhKBlfu5gJ2/oaBlRDDpTEyGcyf+KH80Le6DI3KlLAxsmm5grg6a1vb ZWKXa6bruOc4dCrYlQ84vR8kZfogRnPXcJH9NGrvMNppszOvURN4GEohwrOkvGB3+c5c J8LA== X-Gm-Message-State: AOJu0Yw9dTGlEpC6hLC5lFdEl4CXt9y3hU/pKGTRp2VQ0Mw87JKFJjSo PF8pzXKGzw0HjXQUTovNyTuYxig2s+EbyMHxqx/WjCLdqALprPBw541aBl8W/BlQ8ROH3JnuM5S 3NgWurgpgVYwrcqMnpxStjOw3l4cZE0hkh4L/mB+7UOy9Iull X-Received: by 2002:a05:6830:90d:b0:703:5c3e:c134 with SMTP id 46e09a7af769-70c9d982a41mr2127152a34.2.1723649024476; Wed, 14 Aug 2024 08:23:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFGKA0i3nrg2nuMRX62k+dnMOQIF1k4Xa29cLk2aSCaOULEklqxi3Psl4Me7eY1Bt4qi3az3A== X-Received: by 2002:a05:6830:90d:b0:703:5c3e:c134 with SMTP id 46e09a7af769-70c9d982a41mr2127112a34.2.1723649024175; Wed, 14 Aug 2024 08:23:44 -0700 (PDT) Received: from x1n (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6bd82c7eb2fsm45155866d6.40.2024.08.14.08.23.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Aug 2024 08:23:43 -0700 (PDT) Date: Wed, 14 Aug 2024 11:23:41 -0400 From: Peter Xu To: Jason Gunthorpe Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sean Christopherson , Oscar Salvador , Axel Rasmussen , linux-arm-kernel@lists.infradead.org, x86@kernel.org, Will Deacon , Gavin Shan , Paolo Bonzini , Zi Yan , Andrew Morton , Catalin Marinas , Ingo Molnar , Alistair Popple , Borislav Petkov , David Hildenbrand , Thomas Gleixner , kvm@vger.kernel.org, Dave Hansen , Alex Williamson , Yan Zhao Subject: Re: [PATCH 03/19] mm: Mark special bits for huge pfn mappings when inject Message-ID: References: <20240809160909.1023470-1-peterx@redhat.com> <20240809160909.1023470-4-peterx@redhat.com> <20240814124000.GD2032816@nvidia.com> MIME-Version: 1.0 In-Reply-To: <20240814124000.GD2032816@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Stat-Signature: 5iko9acpb66ghfb3kugm63s4xik4dw3t X-Rspam-User: X-Rspamd-Queue-Id: 9C98780032 X-Rspamd-Server: rspam02 X-HE-Tag: 1723649028-105691 X-HE-Meta: U2FsdGVkX192IyLoP7av8WToNfQUPm70fZNiguwgoIEWkxKIdjKP8t3J5Vzp5FskPZH0JBKteH/Myds3OX1Hp3l3cCM+QzyXauVlu6NMtFRclFOT+JN/nihY6pde5mtF3QyT5o2a5f3m4QlPj4a14uPyihIUkyVZdNg+eq03Kt+x0VcuyWOpww/bC3eWo3rA+hbRSlOG2sKeRMSwBk31QGjMirl+ZiNDoIKV2xSCCm5zEJ9xjnoziYSfbaOX/NNiHh4ZpMgdC+tR5JyLQmRcXKUHEN+H2n4uUibO7oTSQIPsFDRg5SDgwlKHYVbvK7ViirhMYppQsLSs3XtA/xETyXJmNeJaqD6Nys1Y6em23mjhzOOKSZ0Ge6tOsPbixrRl3vZRuggqv/6zkZXW3McY8Ut/ODLz5wzIIRpsn3GFIE+VCmY3qFQuRu50RcjdoDptVSQnhMoGqIZqH+grZv1kszNpyhZo2TN9VNS0cqJ5RhA9eEAhC5fpkzL0VgD5hpf44/G3gsSIsPPQq/YbYL2ohqTGlgWyNCoTM4ylXQ8YM51LzzdKbga15aWtRDET3o5SOjgfTzJ1ssTRfkAE57WXwS88u1CiFyxIv+5fbeSdFV/4tbrYjvhcQHXslytSPWJrw8rR7loex7xaZgdZpt7nyzB2tgZw621pdSOPFbECc01px7ol+Sc4gfGpE3WrT/s2GazbJT4snfZwSwS7Gyqosip0/5MhYoUyuWCfKOK/wAAsWh0Kk30w8Btza/uf58mYubgWIBDV+QAYgTvKwr20UkcOJAJ1++uGQ07NUWKe2D6hMNgv6fV6zlHdPFGE5+7XCxhpYMFA8JZa/326t0B8XtnzflClFbxyiIcCoM/QDO3saN+ZHFv5KrO0ZbxZkgnRQ8U0wa5wO6f0NmYX6+0l+yef0SMdD1Y2pZd8vSETzwVzZPxZFJckr1SgU5SCvUL8ia8un5HAcIDTgLn8Z5s +NsYPHP0 IkiVwFGv56Ans0tv4RgxvugeInZb0UrX84j1pfB4VKBRLJceCEoQyAaUTLEVdO9B9PDOrUhoYwEfeb0Q2Z4JOTwKG0Uf1CLh1Tkkn0UXy7TrmJs888qorzXjKMlRqAg2Xb0MrOLAbm72fIPDHA9Tjx2LSIT03PkBg9hBiI6ow+LFdwp4HRcxVOz/2SogrMdjJXHfYjWGIalMYtZrjU9XyN+A9JZt1PIfCa7XF9vdRcLeyudmAPDaghgXUBoUJZTK2/cPOXm2tdOumMriIp9M4m43AJxxKsAiWKFOJURfnjYK2C9LMyXAJLCu+LVcO5IFUWe5brgor66hzc2bgebXgDcPwsY4ME0bySNjt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 14, 2024 at 09:40:00AM -0300, Jason Gunthorpe wrote: > On Fri, Aug 09, 2024 at 12:08:53PM -0400, Peter Xu wrote: > > We need these special bits to be around to enable gup-fast on pfnmaps. > > It is not gup-fast you are after but follow_pfn/etc for KVM usage > right? Gup-fast needs it to make sure we don't pmd_page() it and fail early. So still needed in some sort.. But yeah, this comment is ambiguous and not describing the whole picture, as multiple places will so far rely this bit, e.g. fork() to identify a private page or pfnmap. Similarly we'll do that in folio_walk_start(), and follow_pfnmap. I plan to simplify that to: We need these special bits to be around on pfnmaps. Mark properly for !devmap case, reflecting that there's no page struct backing the entry. > > GUP family of functions should all fail on pfnmaps. > > > Mark properly for !devmap case, reflecting that there's no page struct > > backing the entry. > > > > Signed-off-by: Peter Xu > > --- > > mm/huge_memory.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > Reviewed-by: Jason Gunthorpe So I'll tentatively take this with the amended commit message, unless there's objection. Thanks, -- Peter Xu