From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D6E4C3DA4A for ; Wed, 14 Aug 2024 15:20:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E993D6B0082; Wed, 14 Aug 2024 11:20:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E49D26B0083; Wed, 14 Aug 2024 11:20:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D11376B0085; Wed, 14 Aug 2024 11:20:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B6D0C6B0082 for ; Wed, 14 Aug 2024 11:20:10 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 38221410A9 for ; Wed, 14 Aug 2024 15:20:10 +0000 (UTC) X-FDA: 82451211780.07.F09760D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf28.hostedemail.com (Postfix) with ESMTP id 5BAB0C001A for ; Wed, 14 Aug 2024 15:20:08 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hwzuGb4R; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf28.hostedemail.com: domain of dakr@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dakr@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723648796; a=rsa-sha256; cv=none; b=BRANyNcW6EkAh4ADAbpt+S9w2YxlO0prleDDCSr/cKFJ7TZv6mk9tLSKWzvaSg2OVr9Cfa 0d7F5cQ/jckVeOoC9jIonrqhikLkR3lNLqTvdyt0CX+NkLr1rKI4kauyePKbjzhmwnVJqp b5id/e29d3pt26eMlAWuBXxXnHV93E4= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hwzuGb4R; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf28.hostedemail.com: domain of dakr@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dakr@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723648796; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TzyhMkz1LhrMPb3z/GPShbkU8O8u1yiTzm58zCdnIAc=; b=U3xqZSHYoYuY9DaAYdRCGImXCfhLL6t4I7rn1knXJmzOs/ZViFkcaPi5VyKUXz6ldiN1Gy mPpi+HSNRGECWBYUs7DBhrhVql2VVsObdzRbHnxmuYGQZZOzT66ZICm7LfL8GGSAOPBGVo E60DmPmXDCICJmPlg4B0FkYCBj9s74A= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 46E1961AC8; Wed, 14 Aug 2024 15:20:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03B85C116B1; Wed, 14 Aug 2024 15:20:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723648807; bh=Rj0Ty5Riptip5Jd6/pl5u26hdJH9Oacy9vcIguusznY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hwzuGb4RYXXSBBwDYYQ3d26EADzhf+ugxhNL103SL+RZj7UIOG9khQhOYi+pW3aOT qZcw0NR4y0Kw4cBsAcYXpqWesVbytbZrkpWNwbEkeTtli59pH87TC660QZipopc1/4 ufTLRjFfd5bVY8CAYBUpI/S8ToCqmsnO/U1zLUK5hRWnQNhRaIYnU9U9Y2RzAWQVZx YpHJDN9ahuE+yOZWFX3BzTeAZqLs/EqK2QDltCotWcVMVMc6LbbJojCZKohrx3LHwG gRdRlko+D2WJC3W7FJz3iFsaEaTccPbGrA1lOF1RWAuiZQ9yOG58waHK+yDTh5yVNu PNVG/RWB6/0Dw== Date: Wed, 14 Aug 2024 17:19:58 +0200 From: Danilo Krummrich To: Miguel Ojeda Cc: Alice Ryhl , ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@samsung.com, akpm@linux-foundation.org, daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v5 04/26] rust: alloc: implement `Allocator` for `Kmalloc` Message-ID: References: <20240812182355.11641-1-dakr@kernel.org> <20240812182355.11641-5-dakr@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 5BAB0C001A X-Rspamd-Server: rspam01 X-Stat-Signature: woxzup4czt6qn33q65rxzt83ruanwqrj X-HE-Tag: 1723648808-583598 X-HE-Meta: U2FsdGVkX1+e0Tq0NNnAVw4V5FIMSCkVAr0yYusRK0KoViuuG/z8EpEgFZPNI7QjcBBuijZGcRxWPhyKRrO6XChJ8odR2691RyHkXjZ+yOw8rO93ZTsMCgWOmDC/CI7FHK1efXVmqtLMgYFexHtE6qAAI5NnLbuvalj1wtSR4uuy4D/7gmOuL/92ThNBeUbJfq4UGGjrYBhmse0KD5vOZ0lsULekvUGNNjnmln3PfzYfLPQyVqQCgZBsD3GLW+qQf9wrIF8/IhS4HxFALAbvmThQe6Gk0Ksp8diENdRsSjzaqRFkC+un0842QyBB4uiF0IHAI93g568aBliV8SNot5BR0UJrC48977Kmqj05ROMsNm03C11kg2VBRwI6YBA4iUYNGkRvrGZDGWi2pczPQKOLYqv9GqcHsZH9Q0xAeTBlJSIOX1ewLgV/hkXgJOYEFjA3uvZYqmSdfkDVOzGerigo93sC9UUMGcnVUxgchFBhr3/eNnZT0t4HgB0fYKayYUUcD/K9aLcTJZoNB8KyGimCof7HNlQUV5WyVvJHWAeWDMq2HXeBuAUq7rIn3TkrS+e2rfBX5tvwsr0B9+RN9aO9IYr0FgkjEm7Z/nPAq47tDNLb9JcKnAr2E3ghgK28qJd8wvJ3GCtX5bLhIxpg9sS4HeQySPA0V8xRDEZx5o2SbcF9ZGdPbDfcY8Z2kjCL4ukDaS5tDnl9JfFS31q9uUN9Gwa6s4rIaIkbsm6tIPbHKuHw/ge4OR1Kmaf9LaIoPYgmlnHgJqLimZurjDkvkMxoZFYLKvEhBHVgO+A6y1irZwk/y7ocOd3vAoLx4KCpmHaxCOaBcVge1MG0DCyK/QzgxX5hZbuMMWvqaaqFOrBxjs6rrtm+9Bys4M5ofdzvzczhjq1ekdp3jCcRpmaIzmVePPuOKoEh60OmZw4zAmGF3xT9gA3MRLBlTpCVSoX5SvZD4AYcpvUiPiVmTew L+hRnO2U B5ykkG9jLrWVmQrc5IuJTgfSQC0ebnLtmUkIrx+KUZotX7A1F9OGqY+IfGvh+Avpz3tb/JS6zQXT0oCw+5kBeI6rxZKv7mUbJgJ3M+zDi2iGl2NLwnZIgmhwNAvzPkDYVjmezu2nweJ9hTRedQv/jamdxhnQbWqXwszcrivBrRocGhK5K2erxWO1koSIIWq0+Nn5cVG6vKNOBe226Qn95NbJ1zW9tVpFBGU+BMTb2qvAmhiy02jN/t+Ze9KyI3+C/bqRynkQsUHflrGsXtaC864UbqpLFMX7DmtCXQhTRnvlvpFYKwA8OUBU4N6keeDM/JwO1RJEtfhysUhFGFkhiJH2UPz7cmcUy3xCFmapdqkP8A2aNR4Bc50COxA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 14, 2024 at 05:03:21PM +0200, Miguel Ojeda wrote: > On Wed, Aug 14, 2024 at 4:00 PM Danilo Krummrich wrote: > > > > If we keep them, we'd consequently also need to add them for vrealloc() and > > kvrealloc(). But again, they don't do anything for us, and hence are more > > misleading than helpful IMO. > > In general, they could do something (e.g. `noreturn`), perhaps in the future. Indeed, and I think once they're honored we should add them again. It's just that I think as long as compiler attributes aren't honored, we should not have them in the first place to avoid confusion about whether they do or do not have any effect. > > Apart from being potentially misleading, do we gain something by > removing them? It's not so much that I want to remove them for krealloc(), it's that I don't want to intentionally add them for the vrealloc() and kvrealloc() helpers, knowing that they don't do anything (yet). And I think it's even more confusing if the krealloc() helper has those compiler attributes, but the vrealloc() and kvrealloc() helpers do not. > I guess simplicity in the file, but it is also simpler > to keep them aligned to the C side (which I guess is Alice's point), > and avoids having to keep track of what could have a present or future > impact in `bindgen`. > > Cheers, > Miguel >