From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45F68C52D7B for ; Wed, 14 Aug 2024 13:36:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 59F646B0082; Wed, 14 Aug 2024 09:36:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 54EB16B0083; Wed, 14 Aug 2024 09:36:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3FAF36B0085; Wed, 14 Aug 2024 09:36:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 205376B0082 for ; Wed, 14 Aug 2024 09:36:32 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9AB0240FD8 for ; Wed, 14 Aug 2024 13:36:31 +0000 (UTC) X-FDA: 82450950582.06.BDBBBBF Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id DA23E4001F for ; Wed, 14 Aug 2024 13:36:28 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=VcJxRaaX; spf=pass (imf01.hostedemail.com: domain of dakr@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723642517; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EamJJF3jzmY/aDFJNSVUuefmc2NhFO0s8nXCk43om+g=; b=7B0mgv3J6yv9qpqHmKU/9khiG/IRehg79iLXA9KKFpU4v4IXvRXN+c0yIyWwdIby6gEO+Y 6G2MG48m1VwmhfLsHHMEs0hEXXrLAUJb+QdVAyVsBUYrCPMGqJbhMWyqHeOEKmu0B4g5Cp nrliSRPtHmkV16Q5vGQ7pYc3tSmgRrc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723642517; a=rsa-sha256; cv=none; b=AEwIT7UBelsFHmEEJ336D4eTpdCQVmbHvpfp9Z5TayEi6KdrrdtTOAOgsYsmDJsoTXotvm CQtU7rF9vRD7Ib0ppZc1S2JrqMRdkfakcVBV5/66NXcVxNakxbT/mjtImOUnf7VnC+5CP+ waaF0tFUDcG10obuuL+lXhnLm7OGsR0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=VcJxRaaX; spf=pass (imf01.hostedemail.com: domain of dakr@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B8C6461986; Wed, 14 Aug 2024 13:36:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6F5AC32786; Wed, 14 Aug 2024 13:36:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723642587; bh=6tnhxY9G9+UJBXYcSgog9jSluJDuRzIzD3yGkv90H6k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VcJxRaaXjB340O42WzVrf1BF1Oia0r4FIw3tzbo0OnZ0AOhNqAzoLWF1Hv8cw+VKd hl4PEG0MzqlTNQTxUj//jNKOZamK/1W2hifDbyT3fwZFm19r6yngsAtEU4+DmzJgQ2 3KGIdSZ4q2h0qU1iNUV2G6chXfNpoBUNDq13ZYwXvYaVrtwHYbH0HQB6pzm+++LRhR T5zako2jV2WbP3kkvFxYxCjc7ZixFZ/POel4P1DGYdOhQkvmjC7ApyedyBCMCChuwR nHzukmIhfniXAiFUknhrZtY17waN3Fq5E/yVioUJn/KfX0FHh50Yxj4WdMbQU2zviv 9D75A4RcFbyIQ== Date: Wed, 14 Aug 2024 15:36:19 +0200 From: Danilo Krummrich To: Alice Ryhl Cc: ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@samsung.com, akpm@linux-foundation.org, daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v5 04/26] rust: alloc: implement `Allocator` for `Kmalloc` Message-ID: References: <20240812182355.11641-1-dakr@kernel.org> <20240812182355.11641-5-dakr@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: DA23E4001F X-Stat-Signature: jue35mbyq9hizh86t9to8kf8azs5kwaf X-HE-Tag: 1723642588-621642 X-HE-Meta: U2FsdGVkX19QCQ+20REAc1EIc/nbpw9Gbj5lspCzHf157NvpSrsmezoM7FFiyvxUB8BzscL2/v8z7hmJ3wfIUMjCp590SmuPHUPrpY2DdCnCBenpLYARplQlml5+oG0C0fjlLrOZGvfsTyAZb3jaXHORzKYQjpkQxuCX+HOHQf7IG6eRFljjk7XsKsaiXNEO7NIJFrSTNOQLe6OWl8TFCGVAoi4h/KBD7GrhENKcYTEX0qYm8Sk2gpGxjQXQXfwQsqC7s+TovOep3AlXCbNLFjvcNveo48IS6ZgpLSjj/PrTJ1WgxF//P834EULzpVB8GJTjNNQgkA+n/H0OK3/D7o1qPKG4Lf+l1wJQZqB5qvLYiMMs+t9YeVzHqLSCGdC3h60UDzbw5Og8iapB97WBJcXEOx/AdA6br1lZbe/SlTFdiHB0o8Pm81u6warXRMMYfy94mmuHw6s+pUhPrsUqXumdEf6wpl2oXEMJYpGQ5zUH2vwIJu6GNZ55JkU9lZxow4UERdVoJdAsA9ggjQsMKGjWbIgn88AErBZLIiDCLgJLU0E3WiYCkKYl3ygichZFYe7ozz+/vrUReflpQTlmTYpazsjZyksB6kdRuod9e4HiOZLsi3qLElm0qX3DbC8yRn0RNWupJURe4dJZF9NVkdvSw3wb5lgJCnsFAArmOWSteOnXqEpTUYn4tNvgfHlpLwrIJmav3pFQJo2nR4e2mhU/e30c5GDDWO7SrmTYF19PNOdVogkd/PnBfgJp8WihdBu7EgOzFpoFHLFus0aSLDG5BK1IIlhxMomZL5wNI9pu86Sx7YpRvUFyhBWBcnq+7TsU+3y7SyEp7yZknnq4F2phChbRdZTkbvtcejHj5oo1TrXPcA9iuZCKvSVlrrFB/FJuOZR/dyH+WAMoY3zR1xZgjVGoymzllq0WgR6VLRAT/JD+9vG60Y0ZgegclrxHMS4RCJSkhC1FREYbEx/ NakpPkn4 ZO0Zb0Tf6GfOvjfccXQp1NGPowN7BOuW8CkVyVqOn92Jvv8Cab0zma4asfeSD1KK+EhaPUzbKFi89AqarbSAGUfaIL3dT9ehJJA1vnD6iuOAfTH4HSXzDTV0VsuPucWCM+Y0pPlw+d7Ql/Q95pORbWuF6ynxNXDex674MUPkfAJBMNB6J+4VpdmvxJQ/6lUhOmUKH3hYSijQxoPmX0GMd4mo2YTwOKZFwwxbYNFRkFwvTPD3F2s5G4wokwjMRJSDPwFI2Lz3mtwPzKdwZFiDN5pg5ekk8phwAwapM4CRJh0ChtuJ15dMtol+nT4xJpocj38Not5kRgABfNoOwNaDa5pNl89QfTAghm1rlqTCUkVta1brUMUNRss1OLp5Q/5JPyGNg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 14, 2024 at 09:51:34AM +0200, Alice Ryhl wrote: > On Mon, Aug 12, 2024 at 8:24 PM Danilo Krummrich wrote: > > > > Implement `Allocator` for `Kmalloc`, the kernel's default allocator, > > typically used for objects smaller than page size. > > > > All memory allocations made with `Kmalloc` end up in `krealloc()`. > > > > It serves as allocator for the subsequently introduced types `KBox` and > > `KVec`. > > > > Signed-off-by: Danilo Krummrich > > --- > > rust/helpers.c | 3 +- > > rust/kernel/alloc.rs | 2 +- > > rust/kernel/alloc/allocator.rs | 63 +++++++++++++++++++++++++++++++++- > > 3 files changed, 64 insertions(+), 4 deletions(-) > > > > diff --git a/rust/helpers.c b/rust/helpers.c > > index 92d3c03ae1bd..9f7275493365 100644 > > --- a/rust/helpers.c > > +++ b/rust/helpers.c > > @@ -193,8 +193,7 @@ void rust_helper_init_work_with_key(struct work_struct *work, work_func_t func, > > } > > EXPORT_SYMBOL_GPL(rust_helper_init_work_with_key); > > > > -void * __must_check __realloc_size(2) > > -rust_helper_krealloc(const void *objp, size_t new_size, gfp_t flags) > > +void *rust_helper_krealloc(const void *objp, size_t new_size, gfp_t flags) > > { > > return krealloc(objp, new_size, flags); > > } > > Why are the various annotations on this helper being removed? rust_helper_krealloc() is only called from Rust, hence neither __must_check nor __realloc_size() should have any effect. I also do not apply them in subsequent commits for the vrealloc() and kvrealloc() helpers for this reason and removed them here for consistency. > This deserves an explanation in the commit message. I can also add a separate commit for that. > > Alice >