From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA362C3DA4A for ; Wed, 14 Aug 2024 12:16:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F03C6B009A; Wed, 14 Aug 2024 08:16:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A01D6B009B; Wed, 14 Aug 2024 08:16:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3682F6B009D; Wed, 14 Aug 2024 08:16:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 181626B009A for ; Wed, 14 Aug 2024 08:16:48 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D5FAFA80A7 for ; Wed, 14 Aug 2024 12:16:47 +0000 (UTC) X-FDA: 82450749654.27.69F1AEE Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf10.hostedemail.com (Postfix) with ESMTP id B2F7EC0025 for ; Wed, 14 Aug 2024 12:16:44 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=a5Vsb4nK; dmarc=none; spf=none (imf10.hostedemail.com: domain of BATV+7d512743472334ac444c+7661+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+7d512743472334ac444c+7661+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723637793; a=rsa-sha256; cv=none; b=WQLbMh6B9I0Pf4H0eywF8rvTOzadfV0SOGGJm7Tlo/jjQ8/7HRT3qIBxqdNWZ7ThqDz1oI /fcvfNNPkdvsZAX/FzGNozlI6CnxfdKHQkl+qh0qLZTNAKN3D+oWQAko3UYvpWNL1bVmjz uvLc9GKNZsaGI9l9INGNz7MOFPW9xRo= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=a5Vsb4nK; dmarc=none; spf=none (imf10.hostedemail.com: domain of BATV+7d512743472334ac444c+7661+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+7d512743472334ac444c+7661+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723637793; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fwrrqi59D8+gyaVDxw+e4glai5gQB/boHoF93Oean/s=; b=0SyHSLqRKXFBvk5U7ysBHTSs7/UIJAhaNnkbLV3sYRtmfJ9HvBCUVriEYecsNtBAwNkG4Y u3H+usE5jeJG4t8hQnFN/X0WqMjobX/2VpeS+A789p3x45CdYsiAGm2YKFlD1EOyJlyp5x EGVYuYpmffTVjWKgI2jZu4rMumhswa0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fwrrqi59D8+gyaVDxw+e4glai5gQB/boHoF93Oean/s=; b=a5Vsb4nKZCkCLSWJc4DKosJAcD fq1STNAyLp/GsplezQyiXkheoWHZivKw1ZWUbfKoDNk/SGDUV2pexYYBTKc815KiNmXFhs5k1Neno KD0DTgCfTUi4zh3dxcubMsfycGqVSv/gWbQBerZ8NcuEWQ1Xiz0Oxfd2kDBdiAv18auP0ml5v41PL 2dYAUcMfMTOigg5gPpPLfNDHk7Curhj/6YOxgESiLX3teiad4nALIpskfeFIau8j4SYhcW3WiNjSK UIY1HtnpVMvxzn6tW3YI1nmVlix4IgmHcVnQJ6JRK1SKIHVNks2DE6LszjcFzGGGm0MiUoyI0EIol W6HLIPLA==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1seCve-00000006tkh-0ev7; Wed, 14 Aug 2024 12:16:38 +0000 Date: Wed, 14 Aug 2024 05:16:38 -0700 From: Christoph Hellwig To: Alistair Popple Cc: Thomas Gleixner , Christoph Hellwig , Max Ramanouski , x86@kernel.org, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, linux-kernel@vger.kernel.org, jniethe@nvidia.com, jhubbard@nvidia.com, linux-mm@kvack.org Subject: Re: [PATCH v2] x86/ioremap: Use is_ioremap_addr() in iounmap() Message-ID: References: <20240812203538.82548-1-max8rr8@gmail.com> <878qwzpfbi.ffs@tglx> <87le0zmhdp.fsf@nvdebian.thelocal> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87le0zmhdp.fsf@nvdebian.thelocal> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Queue-Id: B2F7EC0025 X-Rspamd-Server: rspam01 X-Stat-Signature: t3x5s13j9hp6omyiw3nstqakj4jjbhyy X-HE-Tag: 1723637804-651744 X-HE-Meta: U2FsdGVkX18fV7/kl5pqp+ru2HLJN5SYSNublWOXMrgC2p0KvNlxpl0cZc1WKgiLFNr2ABtuGvDA3Z1YAlpD+wVPwRiD746pCIkFa6ZBJO7DseRES3b9lRuqQkQ5AmOOui8miyRwbbH6y0B26FM62E53GlUtetsZu0AFkCz8D7nxIZ25GzQdet3bHb9WxfWtnIWWin1r1/3Db4PQ5HdOUeyI4Usl470RxchA3XbEe2GKtHX1mGZnObI1HZC9iQZP/4gMmtzCUB9Sx2H7OrxuGHiM51qN6r4dXKcDjPY02CdSE87zz1PdXg6xFFL6/R1GoRf1DAqMCNTmLY53O50m8IFIJqCv7jdyzG9pIs1qdOaKiTXtWmTqXof1NyqhRZMIPfGgPEO5FCvi1SRBAO/DDCWCcXkKLKTX+zo/vIaMGlc+xRxS6fqgmpd2lhlotwd9DlmAv7mzsjWzCuQ5Njqaa781CAyszNN0S59ysB0EILy3bXPg5moLQ/R/txFBmgw2ZxXTHRunoEUhI0BQXvnbjQRZyCxwJOlmq5gC5BNyy9AhDNCy+sXKbn21V4crbzhYZHj0F24mNsxj1GT5gM9tF04ox9gqsjrgEi5SR6IQat7taVpkdY7lLvxataTCIsh6yjjLW5Wz2TEsOKzabZyvWhzG/yBIxsW9KF6swZkfNPX7tNDakrnbPnMKJ1uPlfGHxeE+Av5DZd/c4+hABvSAx8UO3B121Iv91VssLlNjy1MZjpErO5sPNweAJbVo2TFqkyOtX5uMMJ6fNeh4ZU64r4JMv6t9IbUdWJjEs+Q+QHhX6hno5+9V813Hcq0PHWVhWDKWS08337CVdBTczjsNozu5GyDeVfoF721X7jMMOBQUAiud3uANjsnWfShzBL0oSEL0e5wbZ5+eFL6FVi76ZQ1S9k+SXrQzYKzCwsZtP12VZYO9I7ByQ6Lq33uFCZb6Pb5cILL0ZS/2hIgNP+r GZ16lj7i tJeDv2Q8bLQd8XwUOy0TwYzWsa9wkRtF8iUZF3Lh5+HR/URFQc9A/pEAXrrJ227VjHrdYX0iDJh4SsyCeiel1trvwB042Jr65sKKVOs3WUi/lmCXtSIVv1rtLF3ncZEeuVbwJeZQkM5QeD5BbkyTKRwgQQlraANKr5bN2V4QyjZAAWdkzMSnoMr8E1jnULeZO890mYf/0p+brUlcsF9TpUgVkW+EgFRC6qpfcpFAgpDviidqE05OQ5YUhPQBaFpAhN52j1AR0BaDOFyoAkLny9oGb/0X57Ty3DNhRRRWPMejrlnSoGE3vlAtW/NHc1rtR9PhObpp2YwISysqF1mqRU3r/DT/knoJyZI4s4kUdZidTbOcsoQfT6/3nKnWuhGply/FevXEr1M/gHJYVzKLyW3iShgrBHn4PUUd2rXH8PHLHftCaENVaVD9HXo73FiL/VaGpsUsXyxc7j8Yze1mk7y5GbkjT1ikeP6TKi+LmX9CLR/yRACtFZ+YNvMaKRTmPlfl0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 14, 2024 at 10:08:23PM +1000, Alistair Popple wrote: > I would tend to agree and had the same thought when we found this. At > least some kind of message (WARN_ON, WARN_ON_ONCE, printk, etc) would > have made the issue we were debugging much more obvious. FWIW I have > tested running with a WARN_ON() there and it never fired except in the > bug scenario. Various architectures had either an early ioremap variant that got silently ignored here, or magic carveout that don't get remapped at all. None of this should currently apply to x86, though.