From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0492C3DA4A for ; Wed, 14 Aug 2024 13:48:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 842B66B0082; Wed, 14 Aug 2024 09:48:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F2606B0083; Wed, 14 Aug 2024 09:48:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B9C66B0089; Wed, 14 Aug 2024 09:48:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 45ED46B0082 for ; Wed, 14 Aug 2024 09:48:44 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D23A2140F75 for ; Wed, 14 Aug 2024 13:48:43 +0000 (UTC) X-FDA: 82450981326.17.069AE1A Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf13.hostedemail.com (Postfix) with ESMTP id 73A692001E for ; Wed, 14 Aug 2024 13:48:41 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=NXvRYYgh; spf=pass (imf13.hostedemail.com: domain of dakr@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723643286; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AyL1+qgzPH3azVTMEwopLi9KpGL8V7wUQzWryyRbVMg=; b=z02+h/kgVXRcEqWIzQLBXT4GGSFG5ioHgxKltNf7GrcJP/QQliAfmGsYFiN/jdyUf8vQUa TUI0dW92OaZ4xkSAX0+Y8i4y8B53KTFxLLUUSPHG1xG22JISvAxicGctboOgO/bhy7X2eq Vns6JKqEbsm6HnDybjqPiyz4fxUxTmQ= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=NXvRYYgh; spf=pass (imf13.hostedemail.com: domain of dakr@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723643286; a=rsa-sha256; cv=none; b=RtGcEKssHsDpghCdsoeOFedQ930XMaL0cyBMnY2oXMjqZmH9HzqDyUIdbE/4Q4DRgurCnC hFv1a3gv/2hadUWK3f+LCdM7pZ03R3cOEpivHi2bKR8Lw/kPF8c8R+V/ycfwl1BGTqET4F 9RKBz3blKrj6DZXNNHU9/7PFbW8Y2Qg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id E5EE6CE19A2; Wed, 14 Aug 2024 13:48:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5402EC116B1; Wed, 14 Aug 2024 13:48:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723643316; bh=uOgqJRsL4yJHH/Z/VgtjBcKE0By86FrGg4AHt6bS2JY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NXvRYYghvwBedjenwahVRJkrRV3Wn4K8smA3XuPMQ4v+EYmciTVARi/T5NLFDTi/E 4oGpX5bFyxXTrR+cI0MlndPGA6JtZguHiQ78LH/KcE4CQzfe15MOlQPyAGFYNSw38J zg2QRkas1DOSPL76H80GhBMeLxawd4gNonujw5SlIl8LJmiR40HClqJr0vfnmD92ak PWPAHThr/ZwD3FA8UP6E18w7eYOQKmfqoUGbkabWWAhIVoG7KKd7PqX2lGLdOYOGYR /2NGC34e8m0pkZo7O1RO9SG8P0o+mrAYbth5zwg5fOIMmQt0AqHyhCEu77pzQnNbJa CFbfDn3WfZqjw== Date: Wed, 14 Aug 2024 15:48:27 +0200 From: Danilo Krummrich To: Alice Ryhl Cc: ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@samsung.com, akpm@linux-foundation.org, daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v5 04/26] rust: alloc: implement `Allocator` for `Kmalloc` Message-ID: References: <20240812182355.11641-1-dakr@kernel.org> <20240812182355.11641-5-dakr@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 73A692001E X-Stat-Signature: 89pqyu1ewinwqtiod4aqq6wrgx8kkdx9 X-HE-Tag: 1723643321-560263 X-HE-Meta: U2FsdGVkX1/LXH36+u0K5rEpyf+O0SYNK+dZaGaVtUPpUbcXyAWPNjKzqlBorGJMh/nM+axLORnYTGCzH5K+4cFGU71a0cbebD5JGfeBdMANzAmINJUMYjnOEQHvSVpCCSLXmSMbHK5+Ayds9Y34RH7F9OrafCNkr0ChXffYgKQY5fq+VF6mnNex33lk5/pACtNnKbds01kdUupe8qzMovDNaxforg7T6f/lakYnFNmI/vfK/r7IsR50oH/LK8zOOgo7/gz4oY/vG11SiVdE9+/K6oPnYb+dfz4goks8nV1IMQXDsycPctaVTO3hQaPMj84oQV81N97K/VzNaTPkeRlTXTE6clGrsOMua3Ip9GgTSoxjQ8z7bEglHAvtVMIh5tazZgeQoB/maAHp1D5kk/veCTGg58Duqr+JYwKH6qgpYj7TZOsj9qKPdR8/6QwpMG6uqehbJZtjIWKnrHrKGb2W3hDzEAh93ZufGMNiXAEBsYs3EdPluaAeW4ZHmYUc9iTTOI2+EPO5DSkUsyqaGJb5KyQmyuFY5aM0qX07pe8aEmMuFVP7xvq5gTW9AQzon65DECk8BKr8c7nJCoq3mczQ+iYIhyTLo3Xj42asQPC9Jg2l1VkNz9Yj9WYX9acZCrJ3sr4xOKqZkC2jXOTBZ+lZgKTc3CR7xhH9wI68mpiTn9QBY+GP9d3Ji+LrMXAAjPXyqfn6VnQTxFfiPxCbBvCwmNj2XL4sIg19EMjFGG81BngyY6VFP3Ey71WlZs7I6IG+A8E6l7bnvy7toiM9ld9tk4uKmyMj/HCBVbK0wKndchRsmobkf5QEJtSa4hMWQRC2H0Spde4RLnYeaOoQbz5zNwS6h5VixDAqrMbjLQo2SaE2WXImr77I0iTKBOdxPV7C7bDuEdg+3xDllPl/mNry2xjy2e4v1x25K2xm/IkiHFvfHIcfU2vboxMMcLThqJH9kPqNWWhZoXLZPUh kXUwPWZU grrDar5A/K2kcQApl+R4tfJZ8eh3Dkx5Xpby59vwSyg0gg0Wr0pDWyekb3LhUsaAaSXf9KuGw+TMTHItgop+yC1jAcfPlyKbhtIN7/hlSJ9QU6IO0pzpI95IkfxbqNmcqHjt5UjZTQHvVzItoKZ/8X89EDDoTAbcp+vAv3s+UoF5ercEnkb6y+KM4g37mHVvyDNMAW5a9aO9EDIFBWt3l7WUqrMuSZOSwd0OpQz1bVI0469tUvfR9n0vnsc0f2oTQX/kNPcetGudI6A/d+r5W3tYFqUE1wWRa8cxhThoATKODPOe7BnaAYfMzVoRwgziV/uey+IBf5kPskiuwaABnbAbnWaDF1Q8eSlTPmDCTZLuLBA944Xkr0V6xSw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 14, 2024 at 03:44:56PM +0200, Alice Ryhl wrote: > On Wed, Aug 14, 2024 at 3:36 PM Danilo Krummrich wrote: > > > > On Wed, Aug 14, 2024 at 09:51:34AM +0200, Alice Ryhl wrote: > > > On Mon, Aug 12, 2024 at 8:24 PM Danilo Krummrich wrote: > > > > > > > > Implement `Allocator` for `Kmalloc`, the kernel's default allocator, > > > > typically used for objects smaller than page size. > > > > > > > > All memory allocations made with `Kmalloc` end up in `krealloc()`. > > > > > > > > It serves as allocator for the subsequently introduced types `KBox` and > > > > `KVec`. > > > > > > > > Signed-off-by: Danilo Krummrich > > > > --- > > > > rust/helpers.c | 3 +- > > > > rust/kernel/alloc.rs | 2 +- > > > > rust/kernel/alloc/allocator.rs | 63 +++++++++++++++++++++++++++++++++- > > > > 3 files changed, 64 insertions(+), 4 deletions(-) > > > > > > > > diff --git a/rust/helpers.c b/rust/helpers.c > > > > index 92d3c03ae1bd..9f7275493365 100644 > > > > --- a/rust/helpers.c > > > > +++ b/rust/helpers.c > > > > @@ -193,8 +193,7 @@ void rust_helper_init_work_with_key(struct work_struct *work, work_func_t func, > > > > } > > > > EXPORT_SYMBOL_GPL(rust_helper_init_work_with_key); > > > > > > > > -void * __must_check __realloc_size(2) > > > > -rust_helper_krealloc(const void *objp, size_t new_size, gfp_t flags) > > > > +void *rust_helper_krealloc(const void *objp, size_t new_size, gfp_t flags) > > > > { > > > > return krealloc(objp, new_size, flags); > > > > } > > > > > > Why are the various annotations on this helper being removed? > > > > rust_helper_krealloc() is only called from Rust, hence neither __must_check nor > > __realloc_size() should have any effect. > > > > I also do not apply them in subsequent commits for the vrealloc() and > > kvrealloc() helpers for this reason and removed them here for consistency. > > > > > This deserves an explanation in the commit message. > > > > I can also add a separate commit for that. > > I think your change would be more obviously correct if you keep them. As in generally, or just for this patch? Generally, I don't think we should indicate compiler checks that actually are never done. For this patch, yes, it's probably better to separate it. > > Alice >