From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7540BC3DA4A for ; Wed, 14 Aug 2024 04:29:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C9BC6B0082; Wed, 14 Aug 2024 00:29:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 07A466B0083; Wed, 14 Aug 2024 00:29:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EAB636B0085; Wed, 14 Aug 2024 00:29:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CE0D46B0082 for ; Wed, 14 Aug 2024 00:29:02 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3E50D1C212F for ; Wed, 14 Aug 2024 04:29:02 +0000 (UTC) X-FDA: 82449570924.08.42E1042 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf25.hostedemail.com (Postfix) with ESMTP id 9980CA0010 for ; Wed, 14 Aug 2024 04:29:00 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=NhD32DZC; dmarc=none; spf=none (imf25.hostedemail.com: domain of BATV+7d512743472334ac444c+7661+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+7d512743472334ac444c+7661+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723609728; a=rsa-sha256; cv=none; b=Lu9diamgbS5ECBnsNGZjzxKCa+bgPMGRZ6tJsmUJrBBvClgkpWFvbRQ6wYB67ocA0i+XlR LMrqiA/arVweOh+nSwUqHuqj+RWLG94jercNhQZYUCelVgP9c5u1e3ks9GEyHJtMudq50P 4IYjgHAB1N2vWzK8Fp1fiYfiiT/KC8I= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=NhD32DZC; dmarc=none; spf=none (imf25.hostedemail.com: domain of BATV+7d512743472334ac444c+7661+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+7d512743472334ac444c+7661+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723609728; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JJT/QYYv5cHtmW1x6ENpvX6XEnhbv7o4FA8VLiTScJw=; b=D+GoYZn7Lr3AFm05xbZ17n6I4kyENjVQ88u3Qkw/d8ML6U+Vld6a5obLg/+4/MRwZy/ax6 Ro1FsHypONOq9UNJM84ZuzsK3+hTT4SjPxNR8yTMA9S7rkCB3rhTsrt0xQWPNwlT3aERL4 wv3sC2bKCzY/tqZ8xv+gXeAiLXWu5b4= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=JJT/QYYv5cHtmW1x6ENpvX6XEnhbv7o4FA8VLiTScJw=; b=NhD32DZCJVfd03hecvO+gTrQ30 J5UR09AXTGRevc4534q2YT1pTYc1EOd5zVZSzIeAnYUe0z0/pr3p2kROzDKw6hg7q5nA+h0h4SbIC rVPDEfPXtUwuBvXgj1gnbP/Rva10p/syIOpK64rl2cVDesXuNX1/yjeGvrojDB4hCdyVjFlJZ1G5w ZbzYFwHuNd35FzpHdtQDyI5ETj22d+vbvIjA2LWQknF4olt5abjImlMMrJE6HGJJB5jN5BntnZuH/ JikBnxfJXAlh6Xqkt6MKjyfE2LeHsHV2PCTkGPrQiEcp2arAQNYTsRYUTsvI32ijVXeu5WBD3dOiJ T3Rh7zXA==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1se5d1-00000005hSL-3ZcC; Wed, 14 Aug 2024 04:28:55 +0000 Date: Tue, 13 Aug 2024 21:28:55 -0700 From: Christoph Hellwig To: Max Ramanouski Cc: x86@kernel.org, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, linux-kernel@vger.kernel.org, jniethe@nvidia.com, jhubbard@nvidia.com, linux-mm@kvack.org, tglx@linutronix.de Subject: Re: [PATCH v2] x86/ioremap: Use is_ioremap_addr() in iounmap() Message-ID: References: <20240812203538.82548-1-max8rr8@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240812203538.82548-1-max8rr8@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Queue-Id: 9980CA0010 X-Rspamd-Server: rspam01 X-Stat-Signature: cpterb3nhnmhmdww45p658xhphfkwcz5 X-HE-Tag: 1723609740-882528 X-HE-Meta: U2FsdGVkX1/DzlelmawH+4opmMI0+1DTAL5L0GkylMzQetnCaUiL1VXQnuU7jz6v4OPHC3Z5+C1GrnU3Hn81bDv0RkCvcdg6pXfpERXBUuhyYN0G8aJjYN8CFAc9D5/RdrmLLYy8RspdrAHAcKw4X9z+2UoisMy8z3uN5uovDj2yZH5S5fDCpoijpKd+6jDXVpBcKQem/ad3TtXvs7aWZQljFvdIwk6E+cVXltInyoPXtxtN8YxWCckSQHJBjJtiYdgnyH7uXyqgQ8KYboh+IWlQwyzwZhxNivWZXd87EtpZVWzoNSdMlkva+HYUW6i4IqN4KQQKChKEbduCCKoj4p+dgl2auD7vrDhtlwV8G6oVJddWfxeVEpmfU9mdunoNN+4i5QDYtLTEjRppElPHObObTzw39uvyh3q24vQgob2ryS0R+50R9dF5PYwLgESgrglx3pShYkScLnM9WHtfXP9AcdXzb0cToVH3KjAzT7ilcX6Xy334b546oNoY0AN/okSSMDJcPUAYp20zI+OFJ0k0hqMKBJSDLYliyPcPb1ROupYZN94QvLD/GWqRCQ7iC4uYgDmaajGelKJ6h9GzT3TeA6aZrEW2WPs1PHpUU8PsXDz/Tnzzwj6KlOtmQvxbxFza2jv1EL0c/xMV07VrqWUFClxs8Bl+c2TnZLIrB4XIdD6GYaFAjtlRHZH6FYLSoGQEBhQ+H4fh0Y6fEPBUkgYFlyjnb5NkERAMX5HFP+MPNdypP0hm/H37XjjOESZs4MeMIc+pZWPZ/Px+KEGjbkJ5ljIQ3MjDcaOb6bQXoW8akXu2gXoe9pAhkRn9LHNTNHaemNR7PQaffGOoRyjAVRK/1rFYukGHnTmE+LwP0TM7VpTA5QChhOfO7t34D4jki701Fjg6jXVUjjrTNPSBkTcoYpWzy6VextyR2KTvCktccWHBDaIb6fGwhFz0dBtj/xF0xXsB8YfP+VTnFra cMandziY uc/DvcM7lwfeJWoRcm0ThNL5dA5moUkbghyLkclZQxWWk7miIQjKYWR+kE8MkxPDVxXT4UytFZSb1MLojHdA3uRQFMFChL/dV/lFxl1qwkXaZT0dDA4uKQhxZZPP80fFzhblYF7ijxHWUXO/9EGvnA3dryO1Ve/bZ9llPyKxWm+DraoG8a0QPO2IXInfUvmFfl0ThZCaZIXns+qj86pz6hJm5pM8ok6yyKEgHcqRiwpTt+uijTZ3lr1QGEvT+kwQqT8MQPHMh9FmgfVFfXnlBnnh6bIHgmnc3uDT2z8vQDAntalFbX7zllRua8TvLlOkOviB/CFyIpEjbSv8ZZuMZg5NzvAplVIk9LGwUKP7lAbkZphDb5smtzyQ+oMHJKO9Zr5sIRQsidmjJq5KjH1txZlZBQh968ajxqf2JeqppHYT+f8qxymAjU8kNb6NE7qIs0WuLcCe89GbaT5zRwu5SA9EPNtZPPZPdMG/9Ei+A4pkA0I8agfelvUlUBXjavL+hz0JWBdK2+1D2SaAbmX/HuRqI91bmLaEuPM9shFMLGQZEFJlQzWZ0tYAqfg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Modulo the fixes discussion (and any commit log adjustments related to that), is_ioremap_addr is the right interface to check for an ioremap address. So for the actual code change: Reviewed-by: Christoph Hellwig