From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AF83C52D7B for ; Tue, 13 Aug 2024 15:05:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9779F6B009A; Tue, 13 Aug 2024 11:05:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 927E96B009E; Tue, 13 Aug 2024 11:05:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7EFE76B009F; Tue, 13 Aug 2024 11:05:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 60ABF6B009A for ; Tue, 13 Aug 2024 11:05:44 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0992E120957 for ; Tue, 13 Aug 2024 15:05:44 +0000 (UTC) X-FDA: 82447546608.10.D9E450D Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) by imf29.hostedemail.com (Postfix) with ESMTP id 717CD120034 for ; Tue, 13 Aug 2024 15:05:40 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=p4MXnoHx; dmarc=none; spf=pass (imf29.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.175 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723561528; a=rsa-sha256; cv=none; b=GWQaNXLBWxjrlPoZxWZBZZ5Zt5EiIc0jRBaQ7Odxq3QztaSqCa2bR1yLium7lE8xMhHd3N AgsjCAmUxNaq1BRlz9ESf9LmjZYKWiUqM/ezEOxobMKHtZf3WComn2Nt6BqxvqOAHabZCy lTt7Oqbthcb1S9yDUkIUfPbwq/KnpXw= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=p4MXnoHx; dmarc=none; spf=pass (imf29.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.175 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723561528; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pYs7Ta4Zm2a3hPTeSnJ0k+jDcgZQaPBsRaL7CGQPOBQ=; b=ZMnx4NxxgyLmHkyS2P+EMuDqgDXT2mpniHuARGy5LXw97Rq6CEYFZCt6oMmXY6lfqJ5OwC fy+MWrIS5JR/xlabfHeTg/2jfHGXFwxbdkMixZcoN7tskg8Wex7IGuIa9LyFyWjw6+AST8 VkQzqMnzsB9Ydydi8RzfJ3iBYaAT4Ag= Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-7a1e0ff6871so312549285a.2 for ; Tue, 13 Aug 2024 08:05:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1723561539; x=1724166339; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pYs7Ta4Zm2a3hPTeSnJ0k+jDcgZQaPBsRaL7CGQPOBQ=; b=p4MXnoHxa9DvSRNJXnf+SZ+K6n7N8jlEfHFOOlSqPzqW13QKAwHOzzBSl+iCnZN+VC jqCehZLPg/zxt2a5u/zJBQ1e0zVaSwle3cBPt+PL5bPKWqa4QHSzfZK107Yq1/UY4puT uD6WzHr5txy7LyFAkKnWhq8EdjpTW3ZN3CoQfwZs9TPFxkBtkfnPLpVLw1s8dvD0e9IO 6729nxnFpVyLNjFZZVBjhIVJ72H2U+5xMtdkAaHtwf0WpWfMAV8yrnz4V7jFeX0uCPGO iCscTI+mri7ogqkDAMXKZaPzoFH3QgQspsznraU2gSs7cng0v3E0pNEpJUXww5D0JSt/ WPLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723561539; x=1724166339; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pYs7Ta4Zm2a3hPTeSnJ0k+jDcgZQaPBsRaL7CGQPOBQ=; b=snp7tzXFdPs2ivYOZQPtzQDfhWKD/6TY1qcD2jUn0UDNgS40LMFY/tfv8ESvSc5xnh 8Ij8gA8mus4UCoF6XYElvTLGrXS1FwnOqJyjPPd3sOflNhMa5xq4XXXPFt003CYV1OyY 13k2lLoarrEFSl7ui1puE6YAyEdAd9juoWwtUcl4ulSCDXlxxOfmkSCAuqshb5Vt3/4u /SbvLOAdYakNxSuKJnqxG36fU/gHpH/oBDyEgj34AhQYHqYAVhdGQu67ng40OewMQ1xU +TDBT0xYfF2zKnSzd2ZErtqiL4C24bzb0GVZIBJo2EFRp5vT6mOUuju9QVTu6erzklT5 5XVA== X-Gm-Message-State: AOJu0YzTEjDPq6tdKoAp3GyaobkY+A5j7eB++su0IoKVv2NF+voIz/4E 8Ky/dlup950ZyDSayGNVo7CYli7odoXc8W4J/dWwS3kWXZU1/z0nUV/aI9vXIgo= X-Google-Smtp-Source: AGHT+IFH+gLddjFM066hijJSO2Z2gYXco+N0rUMiyHbjSDAltpgxWELBKXwJv0zTm+vcE/lafXohNw== X-Received: by 2002:a05:620a:2a14:b0:79f:776:a9f2 with SMTP id af79cd13be357-7a4e15d7405mr439024885a.56.1723561539322; Tue, 13 Aug 2024 08:05:39 -0700 (PDT) Received: from PC2K9PVX.TheFacebook.com (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7a4c7e05595sm346423885a.122.2024.08.13.08.05.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Aug 2024 08:05:38 -0700 (PDT) Date: Tue, 13 Aug 2024 11:04:59 -0400 From: Gregory Price To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, david@redhat.com, ying.huang@intel.com, nphamcs@gmail.com, nehagholkar@meta.com, abhishekd@meta.com Subject: Re: [PATCH 0/3] mm,TPP: Enable promotion of unmapped pagecache Message-ID: References: <20240803094715.23900-1-gourry@gourry.net> <20240808162011.0492099266ac47e7b84eacd0@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240808162011.0492099266ac47e7b84eacd0@linux-foundation.org> X-Rspam-User: X-Rspamd-Queue-Id: 717CD120034 X-Rspamd-Server: rspam01 X-Stat-Signature: 7g4gc7koxjttg98sam1r8t6oabfpp5q7 X-HE-Tag: 1723561540-562412 X-HE-Meta: U2FsdGVkX18aPRTBrnn5VE54gKJxF7KkWej+cWIxmkOV7+QW4BB4YqYX3cDPKYlKKFDWPPGrWV8CIO5oHGjmRuA97F50u3caa90IkYaRzr7d6qfCs4WrNYpCwNEHKCrvH1O5opbXOoI7G8Q1who8ypgZgojZ/9Ltkg+sAkmsHv2Xv1X/7mpBG+Bs7xsFr3iUJ4ZE/hX5oUIViXCGzvKWe8ScHIwBRSgVwJkLll2iJOvq48t21fcnBPWd1k/ZlWSZ8y0j/aet1L9j9py6Wf5nlZTRd+zyFT361midcrSw4NFklVAbqc6VeJUyydDcwmbC9hUhzPZephNnxKVmaGksjROBTNohaeGoLJiYKsEVFXHAZr6ITyD26yES33myd8Q8GQYkU6vsKfla2fVYqTfi1qLF8EQHUc1Hk51966376RBBGffdM+ZLXl/HJg3WaLGUKK5+ldjPwYYohjMIMDwHfQZe2JUDeadLhZlPQX+/xlrrmbOQVmAwKfJnBfb4XZZv1p2xvU409DLbdP+5bBLMYSfVONBlJx5tBmOCDtEFn82yRHHFAdhi+0mB5ljFdTjwmaKzHrcH9XJQG8Dq6DU4niElhPnkQIT8+HveGNOxG+ItZKauARUNgMBlLkJxxIjIAROV+VcmbuoZ3ruK9MAkkl4afNA6/Mdulubj4Z/qpNTYBHftJcJmiBQLQ/X+tsjrgE442Ps5S8xgvPy/vMSgxYGyNwmXZui7jUiNjvia5BaIXlfuCVQwBlIrsVYgIrox3b6RTSvHReNBaCxo1UxjsmcQnZY+vU5KKQT72PCshA5bzcbKykRws6yv8HJvqGd/BJ1DBfjdmmiVR+z8zVM5Uf2rqldkpEjm5iEEcFg5BFuXu0bOb9VNv/671m0D2qpA4bsjgXv49XRCSRLufWY4q203ty6XhXauFabtszd1zIoePukb7y8zPazOPQeAoA9jxDtg61/vJQBG3FPV1uf DfNVEoDx v/dxO6yDEDXIWTEgCOZJR5B7B6g8PWhYmJVH950HRMyBTIDmg3FwZAKqu1HGmkOJLMd/3k45yn3nyp3ZuewQFSulzVohgIp0nvoKsEULFSsfq9/4PKXwG9oATnallFCpZFScoGR2zcKBCZYCBMuCNY+Xnekk7di8MTg7Un9tLp7jbgac1Ht2chQlwJtiRzt8RCLaYjPpyFohIASbzMz9LABESVt7raSSjgE6MgH4D0wm9ojz/X2QkRurhUpmcG0kOAe4gsD6A8dAf4wMx333hXpnvQNXNvDbx/9KuQu1T/fCP8UkWxaQW8jgp70hQkaQXX5IX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 08, 2024 at 04:20:11PM -0700, Andrew Morton wrote: > On Sat, 3 Aug 2024 05:47:12 -0400 Gregory Price wrote: > > > Unmapped pagecache pages can be demoted to low-tier memory, but > > they can only be promoted if a process maps the pages into the > > memory space (so that NUMA hint faults can be caught). This can > > cause significant performance degradation as the pagecache ages > > and unmapped, cached files are accessed. > > It would be helpful to share some testing results so the magnitude of > this degradation can be understood. Apologies, this should have been an RFC - testing results forthcoming. > > What is the potential downside to this change? The local node now gets > stuffed full of pagecache and other things get evicted? > That is one possible degenerate case if there exists a large amount of free memory in the local node. We're testing it now against TPP demotion logic, but the expectation should be that if the local node is already pressured the pagecache would be trapped on CXL until TPP frees up local node pages. > > This patch series enables the pagecache to request a promotion of > > a folio when it is accessed via the pagecache. > > > > We add a new `numa_hint_page_cache` counter in vmstat to capture > > information on when these migrations occur.