From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6381BC3DA7F for ; Tue, 13 Aug 2024 00:52:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C48A26B009F; Mon, 12 Aug 2024 20:52:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF9096B00A0; Mon, 12 Aug 2024 20:52:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC0546B00A1; Mon, 12 Aug 2024 20:52:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8EA156B009F for ; Mon, 12 Aug 2024 20:52:06 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 07FC2804CF for ; Tue, 13 Aug 2024 00:52:06 +0000 (UTC) X-FDA: 82445395452.13.B55C078 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by imf22.hostedemail.com (Postfix) with ESMTP id 63D30C0006 for ; Tue, 13 Aug 2024 00:52:03 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=CVqiywA5; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf22.hostedemail.com: domain of ak@linux.intel.com has no SPF policy when checking 192.198.163.7) smtp.mailfrom=ak@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723510267; a=rsa-sha256; cv=none; b=Z3dcxnbRWSa9S3ZoPN5pIWb4SlsSV+2CrSCfTKOgM4KF5wuMVN+PocgCmF4Ir64K9j4Vs5 4NSqZd/+BFkCewHD2ZJVvjR01ZIDaqt99TOYRP37TWs6pcxEyAGvVtfrXJj24wQzjly4qK exd7q87MXd0gBFTiFCOLjqeUsrao/kE= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=CVqiywA5; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf22.hostedemail.com: domain of ak@linux.intel.com has no SPF policy when checking 192.198.163.7) smtp.mailfrom=ak@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723510267; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mOFAPXNnjAU+pAoWj2lZma60M8pJPI6AUmhBkIXope0=; b=WIG4a5Ccbaes+CKJC2h/MX8e0hDrx6HmM3mjiuZnIRzslTGOBpiFc1HakzvysqjE+cEdHe A28PA4MAKXJOq1OBbxZiIaqrVqyHbAe/oGPQKp3+nmaeFlfsckW4R+dyua6vLO0vPTY4dI RQ4vi8CFyb54hDUUw3c9JsVj9vFOCj8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1723510324; x=1755046324; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=d/Aryoz0Lafm8CF1eAjXQtm5vquj+UBZ29XRVxr9V0k=; b=CVqiywA5nuY4yvcCG7HM2ooIGsquaK+0gaZH/rtgeVByQ4YlFOX6/zPd FsS8hSUZzdEw8XTrhEAODyOiPHbqQ9OILY3RGadL9UJLagxv3UGtPUAJq 5ayVqDLyNZYl98v36rsYsiM3GcD1Nk+3h/ByiPqfbmEmbb1u8P4cd4GWF zf99JRSwRRxjcgIfrErmQLiIvCBcrjT2/CyQPqWhvcJrCuuwkkfpQVOLj e5enAgrMKP809GRbLYuv/ZwotTw3fJ04PAwS1Iy1Ke3rdNNsCE+mF7JwT Ck76V3akCP8afKAqq7PE/N2jNnFYSSpmIhOZj1s2GMPu6gSfsNEcl5L9g w==; X-CSE-ConnectionGUID: a+VCf6Y2Tu2ztyWAf4G+LQ== X-CSE-MsgGUID: Xpi96lYVSgO/0L06QQp7bA== X-IronPort-AV: E=McAfee;i="6700,10204,11162"; a="47054925" X-IronPort-AV: E=Sophos;i="6.09,284,1716274800"; d="scan'208";a="47054925" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Aug 2024 17:52:02 -0700 X-CSE-ConnectionGUID: bXTSqLZ8QxGfl/VLt+XTNg== X-CSE-MsgGUID: PhRyyA1jTveb1w25hrwHnA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,284,1716274800"; d="scan'208";a="62643654" Received: from tassilo.jf.intel.com (HELO tassilo) ([10.54.38.190]) by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Aug 2024 17:52:01 -0700 Date: Mon, 12 Aug 2024 17:52:00 -0700 From: Andi Kleen To: Andrii Nakryiko Cc: bpf@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, adobriyan@gmail.com, shakeel.butt@linux.dev, hannes@cmpxchg.org, osandov@osandov.com, song@kernel.org, jannh@google.com, linux-fsdevel@vger.kernel.org, willy@infradead.org, stable@vger.kernel.org Subject: Re: [PATCH v5 bpf-next 01/10] lib/buildid: harden build ID parsing logic Message-ID: References: <20240813002932.3373935-1-andrii@kernel.org> <20240813002932.3373935-2-andrii@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240813002932.3373935-2-andrii@kernel.org> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 63D30C0006 X-Stat-Signature: q7giq4ufxf89wt6z1s3446zo17d5mhjd X-Rspam-User: X-HE-Tag: 1723510323-937273 X-HE-Meta: U2FsdGVkX192vnsZFzhrYx32mCODbb76XihNMjwxV3Cdp2jK49cy38t5yxL3xkXyOHBPfIGEJIKoKFoWMnjH7h+DUYAJkpO1uwLBUsupRFBA3TM55C3G38qO31CAY13KNozYrSx2ID2UlSPFMkZDGqY+QyCAMn590IPggLaihAFpAe7hWqD2nS0mNgu4ctmBSDbyIDTilxaLjdE3+8asbAcNdpdukPjYvR3kzAr/1vlDw0B8sk5ULlGAjIUxk0qkaHd2v36ft5n6hkZZM2EfXCWqOtCWUB12B5tUSsKvWHzXh6iJZX9VOxOoEs4qJ5qlfIOZDlbM/AM9SJVrn5MPmDddBipRRI+9w9P8r9UEPIRUqxaBtHVIV1TJIH1m/P7v5/4ybTb1Wu3pYLCzmzCGzC9QH7rgnt+2j6JsfzFOjRCDrGtvjdJLkS8By7/bUvA8Zuzyk/xF2iAznJX1HJS4kUzLXd6yFfkJ8XQe0IybE8q7RoGXT0VxCLTqVoEsYyYP0yNgba8d8SogQlL+K91yVnEa4fkuK0Dp/VzADGrbKAHnhXmPsv6I4oI669Yp1wUoZXKxes+A4JvItrkCK5rPV4JTUtL1P2N9W/4UdX375/YyX58fnup7W5uYXEwqnFN1zx4wgQeRT65YqizTSPiM272Wl6aOnAT2S/0heb35KBwgf5MOBRKzegoZHyDY4Nw+RDdMiLyn/cpzyJ+QkepyeAhhNi2At+vhZUrO0fC9pzsNFXyy8663ThwR/03q4R5U7rmBkLc04tN9kd/xrISDZwyYf/1uH3P7Om85B19jK+Idl4I6fYLGh5D4xOcaVRZo01A6ICptNACXcU6KrUnuSQ+MMcYUF/+ueoN0QWWjv3lSq6JWAUTBolz0eQ023qq9UO17VKPVQOP4iTwZGtU7shmPqPSErFM1PQnqk5MvI+uTiFYAHh+nl7oi9VkvFzzSRu0ciL+CnmQfeW5rA1n SZhyU4OV EmxE6y5GZJC6gt7E2/yUkK8IF7eYh/mqbBxla7gNyGt1qvVkPzKEknoTAA98864O/gFR0MFUZFTH5/oimorm9AmCbGWnH0fW42t8N5VFeZc4H18qNeDBHlbWVxTainMAuNHtKmjNoU7F6G02AcAo+TLtrPcFYBsbrDvpBrvPDiZJZHURxyhHIl97K/g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > @@ -152,6 +160,10 @@ int build_id_parse(struct vm_area_struct *vma, unsigned char *build_id, > page = find_get_page(vma->vm_file->f_mapping, 0); > if (!page) > return -EFAULT; /* page not mapped */ > + if (!PageUptodate(page)) { > + put_page(page); > + return -EFAULT; > + } That change is not described. As I understand it might prevent reading previous data in the page or maybe junk under an IO error? Anyways I guess it's a good change. Reviewed-by: Andi Kleen -Andi