From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD217C52D7C for ; Mon, 12 Aug 2024 17:47:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0AE2F6B0083; Mon, 12 Aug 2024 13:47:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 037B16B008A; Mon, 12 Aug 2024 13:47:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF3526B008C; Mon, 12 Aug 2024 13:47:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BEB006B0083 for ; Mon, 12 Aug 2024 13:47:44 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6A20980255 for ; Mon, 12 Aug 2024 17:47:44 +0000 (UTC) X-FDA: 82444326048.11.CF27B27 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 4D3EF80021 for ; Mon, 12 Aug 2024 17:47:42 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="L/ulFIQT"; spf=pass (imf02.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723484769; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E1ofoLxp3v9N9kOKPS4vF+5E/Ihl5ZKLAS+ztCOSQ6U=; b=gT7Xs7EbHndz4JXavuSUH1YpxToUQuOxbixS6A3ux2myiOpynCur/C8komeZqYjpjfzFDm CtLslsaSTZfB0oW11o/6PGfDTgQjo7imzes+ksbisiNSmPUIoW3UEu6m6e00SMxV43VW4v G+E3/WxChZi0Lx3NtxGeIqxlyiVjq/g= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="L/ulFIQT"; spf=pass (imf02.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723484769; a=rsa-sha256; cv=none; b=Vty7wmM7ZjSYxNwpnMZsYqcpXQ9EVmQ4ntPPqhd8nwMUdNOVRnl2F9A3t99ceAI3YoSDfs /0xT6M9UpLRpbonmHrgbWu3m7UIL+YDbrsZxXoqgqq+QRnNONhEqFO8kvrRg/MfAqiZg7L Y5WtfZg1NRaODhdB/rWauXZCegBFvtQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723484861; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=E1ofoLxp3v9N9kOKPS4vF+5E/Ihl5ZKLAS+ztCOSQ6U=; b=L/ulFIQTKbblcJRGHoS8AIR1zuZHUSMilxUQtCfyZGpIBLXDCjP97W1Sp/gBUWqLkOPx3e k7T40E353DxuuthmSEtwTy+3AUYZ8iIiS1Jq1ZgNGZvrcFPJBIh04a+l2WTO8aRYPC+OrU XjxXlz0S1dmnlvcP/pcLPvSdadAwlPA= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-614-69sU3nWwOc-AszA9WMCXPw-1; Mon, 12 Aug 2024 13:47:39 -0400 X-MC-Unique: 69sU3nWwOc-AszA9WMCXPw-1 Received: by mail-vk1-f198.google.com with SMTP id 71dfb90a1353d-4f51750bf08so208975e0c.1 for ; Mon, 12 Aug 2024 10:47:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723484858; x=1724089658; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=E1ofoLxp3v9N9kOKPS4vF+5E/Ihl5ZKLAS+ztCOSQ6U=; b=onaqvxAr7CvEQfHJS2UI9vt5zhQhcoE99RElG21ZscTFIy9DGbEXXzletmXJr21Hm0 wjr/KSgsfa+hdXP6QCzCdwfv/J+0Pn8u036dMhabLPgbg1wmuc8oyS9uxFAV5+kWvl/r ELfoqBlPJq+8JmpumUf+roOk+xisz+mDVfuIpaQPOZdNNe7NKA2gfVBqUlBr6o3a4zyl lTHMvZhJIyCCyhH1QxWp4nVU31S0WkYZwgUZwBbKB6QrUEvOMBgpXls5RAzILil00yZJ usEYHaUPjPaRWBNwzRmmofoI2FXltfQwNyNciVP0ldOXx31inPAxNqyOAAdHqywQMgaU kKgw== X-Forwarded-Encrypted: i=1; AJvYcCXymrIIYMTq2SRs1lAWOEE+CHmUTxMjA25z3ol+YpwgWgDBsYyC7kdJfZ6fRi4f8GkQ23NvsbVZNw==@kvack.org X-Gm-Message-State: AOJu0Yzo2cgNOgV7Uo5OS766ETxZXj8NwDmj67s6rJDUHovfnIIqwD8O ivspa7VJnE2qVA9GzV62M0OzUpHJ+y8rQpRC1idzdY00auvuq27rRhnKT2YpsPg4M+RiVOzud2D LDwbllxyvnXfs9i29b1Hplp6FyZ3q6Sf/ao2xsvXNsGpodS7e X-Received: by 2002:a05:6102:26ce:b0:493:bb70:940 with SMTP id ada2fe7eead31-4974399f57fmr795431137.2.1723484858456; Mon, 12 Aug 2024 10:47:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG7jmM8bUGT9xUj4x1h0ExmS602EAdMtMjszbitwdc1aRSXvgBoY3SBo0Dp410qEwslG0IOIg== X-Received: by 2002:a05:6102:26ce:b0:493:bb70:940 with SMTP id ada2fe7eead31-4974399f57fmr795410137.2.1723484857962; Mon, 12 Aug 2024 10:47:37 -0700 (PDT) Received: from x1n (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7a4c7e05658sm266933085a.121.2024.08.12.10.47.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Aug 2024 10:47:37 -0700 (PDT) Date: Mon, 12 Aug 2024 13:47:34 -0400 From: Peter Xu To: kernel test robot Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Andrew Morton , Linux Memory Management List Subject: Re: [akpm-mm:mm-unstable 206/222] arch/x86/include/asm/pgtable.h:1420:10: error: invalid output size for constraint '+q' Message-ID: References: <202408111850.Y7rbVXOo-lkp@intel.com> MIME-Version: 1.0 In-Reply-To: <202408111850.Y7rbVXOo-lkp@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 4D3EF80021 X-Stat-Signature: swuake8z94drx5yzus1qmkwhfda77111 X-Rspam-User: X-HE-Tag: 1723484862-416116 X-HE-Meta: U2FsdGVkX193WGCqlzpKU648+ovYNVti6a12ezbEfkja5ojHkcnRZ99OkD3D2GGwaP1fF2H2PPO6sINW+VbddHaRIOt8JbdFLJn11Ip2mVkyeG+Yj2hLqy3QWWdRo9JbxFS5SougVQ5MiZ2l+ADEPvr8SYtC9JVYfgz9B8fxVnc/mgA4b20RQCAfHHFIXazB5QlqcimRsK9OEOLCr+wUaXA6Qk+LiOsE2Flnzrw3CjmpWslvji0FqMRR1Ykcky/I1HZYv09l9LdSnyf/7cWfZbvCGGblHXCJ4VsFDF9UtlTd4Yi5f3Vf4CgYlDyB37+GysuuBpxjS0bQFzEu2wfB4zrX03p0BCrpjupAN0MxJohHgm5r0xmh4dkLkzo56KvzLIRxH0OLHzfBOwmHaZLuxQWR7ZPFkezLQctST0ARFrvcjkesPa2McTHEy31nXYUNJkRq+E3DjilVDIB0DkP0cyqEq+ybnhzxYZPzz0AmI00pOUio6o1bXpbe3MvWGmqwicD4bF1m5YZyrpbpPm/mPzo2wmwP3fvBQCVhEri3El16HZf/SL5wsfldV2Vw23FnRLE6SUal0m2So/QQDhxrdD5nZ7NxuYGiRW51hsV4ic1fAuYf+ecApHsF+fz0/8ehf0bwMnGZu/w4cldqglpSCnpnom2OqcJCspTALmg84h5iLclMVaXHLQONFboAn1JZTpSHkt5irMQJlAH987NVeUhdOz86FEEQxs1i8hsW4uDoGW2YsU+tc+wJqfiTZaFl+XXIoRWDPU3xXQ6DR4YnlV0otEkhnVYMRS92Pe6QQSdscLSLMD5hF+e0c5YWLV/e9kdY9XN1HIfxiWMNY6VoBi5SYAzAjm4j12mXI+/XQ6wZNHpORB7g2UOPml+rB4JbpWQg5UMAhI4CuRltPope8c9NthS/iQS4kXZHR0egTDVN2BiGIA/6q7cRL1P6OPB9fWiIMK3A6gOlgoFzcgC d6B13Si6 610oayAlTH9GWp/nVyMeARTHALy+M/aB5SXWlxglRfnqXrscjIPFDPBeD9p16gXg3+Q3qrtt+PoNRZvYoMoIDh1yTTPWa7g3LgeEzL3JbnIap4nM2hQfXLO94AoMGbn+NcLfaqPbPg+f2fQJoo7pJO8l3J+RX9IYO5jENpv+EPHlbbVuArTQfX4Rwv26SbFOEnfHFdAQcDap8bHy/zgsmbIOoJuEJj4pBVDHSYpCikwGRGoeUlQE8kmO1OUNUaiyZgf2V8Lcyymv+JLhT09JaJPb5dnUlL2GnBe1098UyGx4wIfSJf0/5uAQPA8UH4T1rPYLJEDnBBHsE3eOOZoSui2GeO9nDe6+mlI3S5m9uELloY8+jtsE7PaOS8CoOdlaVRKBOC8QMq8j39py1na8Znq1+smZX1R81DzNacMBCVClv5Jq3Xh3AgQNSd3nlb4chorN/nzgHw3NqU79cyvmWh5uY/Tbqm5Lsd9BTmaUaPaky0C96LVf5BXObrF3mFOOEPP9d174rL1Ztw2vzSSGhvM5vNcvmWBq3Wtr4vKKzt7PPRAyTkheMm0XsY/56nK6paATUPaw/zMnNiJCVIayy+f9jtpS0mochLrF+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Aug 11, 2024 at 06:14:39PM +0800, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-unstable > head: 7d7894afcca68b40bfca49f4d1303167d224919e > commit: a5c1d6b162e7568305f50186568d6e033ad6d81f [206/222] mm/x86: add missing pud helpers > config: i386-randconfig-002-20240811 (https://download.01.org/0day-ci/archive/20240811/202408111850.Y7rbVXOo-lkp@intel.com/config) > compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1) > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240811/202408111850.Y7rbVXOo-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202408111850.Y7rbVXOo-lkp@intel.com/ > > All errors (new ones prefixed by >>): > > In file included from arch/x86/kernel/asm-offsets.c:14: > In file included from include/linux/suspend.h:5: > In file included from include/linux/swap.h:9: > In file included from include/linux/memcontrol.h:13: > In file included from include/linux/cgroup.h:17: > In file included from include/linux/fs.h:33: > In file included from include/linux/percpu-rwsem.h:7: > In file included from include/linux/rcuwait.h:6: > In file included from include/linux/sched/signal.h:9: > In file included from include/linux/sched/task.h:13: > In file included from include/linux/uaccess.h:12: > In file included from arch/x86/include/asm/uaccess.h:17: > In file included from arch/x86/include/asm/tlbflush.h:16: > >> arch/x86/include/asm/pgtable.h:1420:10: error: invalid output size for constraint '+q' > 1420 | return xchg(pudp, pud); > | ^ > include/linux/atomic/atomic-instrumented.h:4758:2: note: expanded from macro 'xchg' > 4758 | raw_xchg(__ai_ptr, __VA_ARGS__); \ > | ^ > include/linux/atomic/atomic-arch-fallback.h:12:18: note: expanded from macro 'raw_xchg' > 12 | #define raw_xchg arch_xchg > | ^ > arch/x86/include/asm/cmpxchg.h:78:27: note: expanded from macro 'arch_xchg' > 78 | #define arch_xchg(ptr, v) __xchg_op((ptr), (v), xchg, "") > | ^ > arch/x86/include/asm/cmpxchg.h:48:19: note: expanded from macro '__xchg_op' > 48 | : "+q" (__ret), "+m" (*(ptr)) \ > | ^ > 1 error generated. > make[3]: *** [scripts/Makefile.build:117: arch/x86/kernel/asm-offsets.s] Error 1 shuffle=3464415616 > make[3]: Target 'prepare' not remade because of errors. > make[2]: *** [Makefile:1193: prepare0] Error 2 shuffle=3464415616 > make[2]: Target 'prepare' not remade because of errors. > make[1]: *** [Makefile:224: __sub-make] Error 2 shuffle=3464415616 > make[1]: Target 'prepare' not remade because of errors. > make: *** [Makefile:224: __sub-make] Error 2 shuffle=3464415616 > make: Target 'prepare' not remade because of errors. > > > vim +1420 arch/x86/include/asm/pgtable.h > > 1414 > 1415 static inline pud_t pudp_establish(struct vm_area_struct *vma, > 1416 unsigned long address, pud_t *pudp, pud_t pud) > 1417 { > 1418 page_table_check_pud_set(vma->vm_mm, pudp, pud); > 1419 if (IS_ENABLED(CONFIG_SMP)) { > > 1420 return xchg(pudp, pud); > 1421 } else { > 1422 pud_t old = *pudp; > 1423 WRITE_ONCE(*pudp, pud); > 1424 return old; > 1425 } > 1426 } > 1427 It's a bit weird that the build won't fail if with gcc, but only trigger this if with clang. The issue reported here seems to be real, where it's still the i386 PAE config and pud here should be u64. We may need below to fix it: ===========8<============ diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h index 1e463c9a650f..4c2d080d26b4 100644 --- a/arch/x86/include/asm/pgtable.h +++ b/arch/x86/include/asm/pgtable.h @@ -1436,6 +1436,7 @@ static inline pmd_t pmdp_establish(struct vm_area_struct *vma, } #endif +#ifdef CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD static inline pud_t pudp_establish(struct vm_area_struct *vma, unsigned long address, pud_t *pudp, pud_t pud) { @@ -1448,6 +1449,7 @@ static inline pud_t pudp_establish(struct vm_area_struct *vma, return old; } } +#endif #define __HAVE_ARCH_PMDP_INVALIDATE_AD extern pmd_t pmdp_invalidate_ad(struct vm_area_struct *vma, ===========8<============ I'll squash this when I repost the whole 1g pud series soon (with quite a few commit message enhancements, and English fixes). Thanks, -- Peter Xu