From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1EF8C3DA7F for ; Mon, 12 Aug 2024 06:38:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 316496B008C; Mon, 12 Aug 2024 02:38:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A0256B0092; Mon, 12 Aug 2024 02:38:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1684C6B0098; Mon, 12 Aug 2024 02:38:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EB9A26B008C for ; Mon, 12 Aug 2024 02:38:15 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9AAE280682 for ; Mon, 12 Aug 2024 06:38:15 +0000 (UTC) X-FDA: 82442638950.09.CFE1B6B Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf08.hostedemail.com (Postfix) with ESMTP id 46849160025 for ; Mon, 12 Aug 2024 06:38:13 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=MBSJz0mG; spf=none (imf08.hostedemail.com: domain of BATV+1668c479149319e18fad+7659+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+1668c479149319e18fad+7659+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723444639; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ulRAiGkS5n4S+P7CQGT1jtN5nIy1RM3sOKQEtCLBjro=; b=jVwJhNEWDZeFFA1qJkoCvnu/R3MpL9xumSOj5bwU0tuyQBfW6Jk2wHNSrkmq906SzmrXx7 HScCR2nqfUEX9eTM0NJowS3C1LrZpoCHMKIcwloSCSj/y/7C6FIHCVbhrMeWDNmF7yVvYv 9K8SgNNs+cX0eCFAbrOuOj611AigT5k= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=MBSJz0mG; spf=none (imf08.hostedemail.com: domain of BATV+1668c479149319e18fad+7659+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+1668c479149319e18fad+7659+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723444639; a=rsa-sha256; cv=none; b=DBO7bWGW2hiUlTOxOK+xlZdFtcCB0K75XIeaHPv14c2gNf/Dz+5iabBGN75WOhfPnKnFY3 nrqRljcaFpO6Lun/HGzYa8JeMkCkNffTG7c2nqgfgHwh0LhA0a3v62UVDeGvsZuOVvs4tj 3WLUARgD6ObSxhaK8kX5fz1Tz1sFKT0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ulRAiGkS5n4S+P7CQGT1jtN5nIy1RM3sOKQEtCLBjro=; b=MBSJz0mGNUK08tYYjvzkweF6Es yQokYQStOm/bZB1vzTHzdYvytJW5+Uo5W76I5bkgf9QBXSUG4NctY4BfQV+8W1vU3K6z1w7cQsdSQ ITkLPJDQWSVuFYIffaZ1j8bZ8hHFRDiI32orZk+0NkX8DRh2hij1UtCUU0d2Fs/G8JokSwGR9HC9j y39H3gcx15Ll3UzRW5hfDCSbeeeejkwILKUAEuQpsurgTs7+hQKi6bb1NX2VlqXfodrybZgD3UOkR eWNumbUhIZwY8M90ygU+3cwF0eiZs8oazutm8F6pC202ITESlBqOnSvtYfaAhUd8jiEE6JThBALcr OmUwIMUA==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdOh1-0000000H2sT-0g43; Mon, 12 Aug 2024 06:38:11 +0000 Date: Sun, 11 Aug 2024 23:38:11 -0700 From: Christoph Hellwig To: Greg Kroah-Hartman Cc: Martin Oliveira , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Artemy Kovalyov , Jason Gunthorpe , Leon Romanovsky , Logan Gunthorpe , Michael Guralnik , Mike Marciniszyn , Shiraz Saleem , Tejun Heo , John Hubbard , Dan Williams , David Sloan Subject: Re: [PATCH v5 1/4] kernfs: add a WARN_ON_ONCE if ->close is set Message-ID: References: <20240808183340.483468-1-martin.oliveira@eideticom.com> <20240808183340.483468-2-martin.oliveira@eideticom.com> <2024080933-jazz-supernova-9f3a@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2024080933-jazz-supernova-9f3a@gregkh> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: 1ew74fanuogoihwzpzpquho76hb8g3ys X-Rspam-User: X-Rspamd-Queue-Id: 46849160025 X-Rspamd-Server: rspam02 X-HE-Tag: 1723444693-239426 X-HE-Meta: U2FsdGVkX1/DddJ2gtVUf5lsycX7yFGPvySGMEwNTXOR9d1GnBq9BJ16VoUHcZQGlJBn0kwORc4wLI9zIrsmlArQOSAl12OgUeprt1w/JLarD4pb9ACZLbOT5nOcZjrw32G4V9XApqfW+wQCg5jJLjqYDt9O0yP+/ijvJijBXrndOZQIWXZpETLHCF59pajdtZABMN3wcbya8fWsB6baFA9A4DPfs192qHYHw1oHXTajObacB3ZewyNgRdP7WORDpQOFkPfKhPdFCdRd+WW81j8qZbJwGNwrapZPD6GOLr4h5h864THV624qPQ1/mn5nuATGnVHDS8sqhnDX2LJY62E57ESdJ0He2YHbUuDASYKccjz7jEOLteAitvcyfV2MFVoKfb3kQZbuKoRPXBeInLb4t25AuXy+p/BrN1s0xKFyYnDVpdkRNsAra+GME9frMSkRY2Xm/q8t3msjtYV5ZBvEPMPsuG5KIdhr5kdeXY4s1gMzgqsyx6Uw8Jt7FCPPqpIownRccK/LI2JjX6z3jfy/v1ODrbH28jOCTU0nEcz/56EzjFrn3mN3I93aIzuSy9zOaEJ5n0l11RuruStPty0/gXGbvdvnD0qAB75x95rcztng9zF21vMY89mSy/jOL40yePlJyATmWQwOpHgP4lpZlNKQ++oEhjYgk9PoldnSceXf+V0do5MmUvBYx6gJ8iloclaEioUCXcbZkOEV6fVgey1P1dwVbDoLVJOaOT663VuXc4ONLKpqABOlZkSCN+8Nkq7XOzpVm+hlylQEfeDoktxKDFvOmMnSnuw/uPL0ODLlrZHu8qtES2Wx3NMGvdPhugzRxTR05UNzeh0QL1HZlfd3N6GQu5085qYeQjS+FAIMUyeBK2b+Utk6h/Q9wGVdOi8xJYPv2Vzdnm52eY1nEGUyXsdAGWKCynCdqd0ZjD41suminrSPbgxgoCwDUF2WZQ7+7nqOVOmD6or uH7eHCiT mhcKe4OlXXOq0vcRQMDmeDGvkx/CmCNkNfnIP25wwd7wCkDL2riBeVN0TeDQVJ80EKlw+UpX9lLtfIDYW4C5jcBIBXkR9U/EYT+l9ZiQePKSeuhrxzJRz45Cq116lz2X8X0uxKz43VYYJkF5D04Ib1U9NLSegFQsy88pLVYmdY1eGREobZyWawaNELatbTblQS9PWdP7eflWfm3kgyuhwtUD8x/uV4Y0cY4srAJwrr/r+DwGY5QavBRMaWlnQ1/IoNzFOpzhHqU37d+leS74tu7f2eoxHI2lDx1DUngbk9/1okKoRKUloSj9eEgNcXoDOmE2as7fpG3T+ynrHDGZXP8HSC6BFntU1oM1puowIneCHDR2MZ6HZH5//bc07PeSPiZPT/EKQqb6IHIrvqD1uS/UXnIIeESam1HD97J4VkxkWnWv7wqIYLHGy99c76FckRzOiWA9sMLil1rqiFMTXAvzKPr1j8/pKYFYj5L7feUlMaxYMHikrlCDjSv+2KuMtAKK9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Aug 09, 2024 at 07:37:49AM +0200, Greg Kroah-Hartman wrote: > > * It is not possible to successfully wrap close. > > * So error if someone is trying to use close. > > */ > > - if (vma->vm_ops && vma->vm_ops->close) > > + if (WARN_ON_ONCE(vma->vm_ops && vma->vm_ops->close)) > > So you just rebooted a machine that hits this, loosing data everywhere. > Not nice :( Huh. if you are stupid enough to set panic_on_warn you get to keep the pieces. And our file systems are reliable to not use data on an unclean shutdown anyway. Pleaee stop these BS arguments.