From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBF62C52D7C for ; Mon, 12 Aug 2024 06:15:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E7B06B0082; Mon, 12 Aug 2024 02:15:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 596906B009A; Mon, 12 Aug 2024 02:15:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 45E336B009E; Mon, 12 Aug 2024 02:15:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 26D426B0082 for ; Mon, 12 Aug 2024 02:15:08 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BFAF0A7D03 for ; Mon, 12 Aug 2024 06:15:07 +0000 (UTC) X-FDA: 82442580654.14.669AEEC Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf04.hostedemail.com (Postfix) with ESMTP id 8128C4000C for ; Mon, 12 Aug 2024 06:15:05 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=gLzEqPXO; dmarc=none; spf=none (imf04.hostedemail.com: domain of BATV+1668c479149319e18fad+7659+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+1668c479149319e18fad+7659+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723443229; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xg7KmYffqZBLpF30epvwg0Mu05bAAH+x/ZEjiAYXFjo=; b=P9xyxWn4eJwB9GilvkrvrT9jLSLduL3WQaeniQoAvgu5acO5+yQV9Sc6baeuT0NB9ZgXwd 2xxF0Q/ZufUKXbDIWg3H7Th+GrfQlGFnkO4Z/WPbH3eQLFrQ6viJ/J1GXQpGTIsBhEp3Bm X3ceKGZmf79Gwu8RS/WBqP7lzjY1J2c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723443229; a=rsa-sha256; cv=none; b=S7aQTlGyAABwLyBPhox329Hm4tnUwHv41L4iQoAYr8Dvbh+LFo8GdjfW4i4t0p6sts8kV+ /FEKjl8DCU53pfdHz43U3Fvouv7BuOGE0MdsobOqAB6g+MeVgNYhTT2eihaFP8wvqO7lUy B70a8b057Zt+EGTHDsc9keI6a+S9IxM= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=gLzEqPXO; dmarc=none; spf=none (imf04.hostedemail.com: domain of BATV+1668c479149319e18fad+7659+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+1668c479149319e18fad+7659+infradead.org+hch@bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xg7KmYffqZBLpF30epvwg0Mu05bAAH+x/ZEjiAYXFjo=; b=gLzEqPXOi98HdUP3XYk+tpLNJE 3qSsOiFZezC5a6NrAzXgY0Il4il3ryTNfS64dAFOuy71pwRtYmWcwj8gs+9Qd4cqvklH0h+35heBO fhCacW3DFketHD0mdqs5gCb980cI/Vr0wNsSa/1CIqvtJs2Qp1r3a/hRhiWMRlKasWaNc0RhsVU8q ZpK65kgwSH0hxTrxyWy0ktGkJCHHICUs/NqAke7KzVeme55R6/q+cOfrRZmu//sJJ1YxHr3b+vly0 u/rtp7OleHvaRVGemr1emVnfR0CiBOnQqaCJnl+RNZe7smkZ6R96QnMFpGJgrOr6c2U/PH0H1/Crx 7YbNTN+A==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdOKa-0000000GyyG-284i; Mon, 12 Aug 2024 06:15:00 +0000 Date: Sun, 11 Aug 2024 23:15:00 -0700 From: Christoph Hellwig To: Alistair Popple Cc: Max Ramanouski , x86@kernel.org, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, linux-kernel@vger.kernel.org, jniethe@nvidia.com, jhubbard@nvidia.com, linux-mm@kvack.org, tglx@linutronix.de Subject: Re: [PATCH 1/1] x86/ioremap: Use is_vmalloc_addr in iounmap Message-ID: References: <20230810100011.14552-1-max8rr8@gmail.com> <87wmkr4jgj.fsf@nvdebian.thelocal> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87wmkr4jgj.fsf@nvdebian.thelocal> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8128C4000C X-Stat-Signature: teucc4dzntsb5b49zhwm9cwijhuaijcr X-Rspam-User: X-HE-Tag: 1723443305-741656 X-HE-Meta: U2FsdGVkX1/53O779B7IwRPWrzSg8JCMKE4wyxmtSvwWBLuxsnqUayaLZK6FJNpr2p7h4AQmiH1AMNWYgRngWSGga12H1KvF0gQYDPaCpibGxKOGWs8lcSJq30tSYxfENIjGI2v0l2KlftfiLmiIghQMDlKyDLJttDut9p8BUYG0zc12MMN+roTBrAKgvUkBOBuNwxd2+dTtzsPfNyiMJFg28XJTz/gPVgABwHiVZFUsi87S69mI0IdDxeQyA31gVCjMpGnnPFpEqPGBjpIH+QEQJPdFNAnk485B9S4bBeWa6O4gNieo/pumaaWX5/qiNukoN7RXYqOL82VvYVhhMwMh9j7oQppWMtHak+vYH2PqHO3gA9loKgbnKwrUxNsz9w37C5++HuE0xxwlP6HJPjfwi58+JPqDfHo3KY4PkRcUHVbPDzX1EMHe55bsmrcweGAO8T9xy0qm7CeHV61gloZWE93ED7nPn6WZc1BMUlkCHeLIQTLydOaNXzw2msqtczNLYxReCA6+2i9FL+/qGCynevEs9BZ0AgtX6qPjq0RaEMUzawvY8GfsqHhNCdRCyezCUIRq3pE/roDQornFn942FB6SFdPkvav8k2m/FFt0jnfZ+yEPyxe5fNMqOH//ajLLZYsydBqpwNHgeQN88Q9qQDF3StUZLMLxC3SoxwAD0R2OEZ6xmXYX9A/lEz+HA5OqRBRooQAkR1Ovq23yjfsxxVwk5eTCbhgBbpqne9wn6FyuvYI5U4/uW8aduJWT/G9G53wXgNwBwNkQbhZfl326wi6lYkdTLZ9xzYORrgtuJzV6XWg9y5Vni5QPGnlDVj3qwi7P7r8pSUqjTozcewqyZfAYpe2BVXZnEILrDIg9zWxR4DM496BHIftUNkwPPpJnelRHugElC57edcz6i7ThAZqmTvLFeDuDaabTnrVQW93RHUEO5Dn93dvMQbl8ZYDDmdtsEyxxi9O0+ki j6FX41/F CmP3JvPOQDVlXeUYF8sWdwnYdl88fXeWX/SN0q3MY3i1NjXHywOpxpa1A/5WtQn24581fBkVWcBvJ3huWc7BDqnWdWK7C+mfkpoz1Z6wlS2aTZuq4NfXUq3DaUS5ZGV1oF3BQEOW8XSRIU0Mp6d5qjUlRv3g4fYtK1+L4cAhxft9IuapPHi56evTnVVpwdjD1y1KGKBM3Q8CFpkBpPv3vpwrYI1UALQdyY4X2IfaBTLc5MV65bNSZjI1BYLLNmyW91wQcxj1STAMzmxM84DUbaKeKMrzwGqmCUQipvBDosx/1QYKjxlOlmQifX60UfQ/pikldnzCe4STyB+L/C9kG8Qjya4EGFAof6j7f82Klo9Cwc3nwLV+zmIqX4zR8R1xeSKkXPpywIPKkL7tsIqK2zRXTn1JztAk1kxl1+/Bv9ctEbf74N1xA5bZdss1fmSx72MAM1aO3zDhsyuDBUgSTIPvmuH6s5qxoe7dlpQoaHhWG33wnmOzpHhF5U0XAzflBdvjY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: (Somehow I can't find the original in my inbox, so replying here). The correct helper to use is is_ioremap_addr, as in the generic iounmap implementation. This won't matter for x86 currently, but it clearly documents what the code is doing. More long term, but I really hate how x86 is not using more of the generic ioremap code. kmsan_iounmap_page_range should really move to generic_iounmap, as should memtype_free after adding a properly stubbed out API for it. With that x86 iounmap would just contain a hook for the magic ISA region, the mmio trace call and then call into generic_ioremap and we'd get rid of these open coded checks.