From: Christoph Hellwig <hch@infradead.org>
To: Alistair Popple <apopple@nvidia.com>
Cc: Max Ramanouski <max8rr8@gmail.com>,
x86@kernel.org, dave.hansen@linux.intel.com, luto@kernel.org,
peterz@infradead.org, linux-kernel@vger.kernel.org,
jniethe@nvidia.com, jhubbard@nvidia.com, linux-mm@kvack.org,
tglx@linutronix.de
Subject: Re: [PATCH 1/1] x86/ioremap: Use is_vmalloc_addr in iounmap
Date: Sun, 11 Aug 2024 23:15:00 -0700 [thread overview]
Message-ID: <ZrmoZKI1UHRRln7j@infradead.org> (raw)
In-Reply-To: <87wmkr4jgj.fsf@nvdebian.thelocal>
(Somehow I can't find the original in my inbox, so replying here).
The correct helper to use is is_ioremap_addr, as in the generic
iounmap implementation. This won't matter for x86 currently, but
it clearly documents what the code is doing.
More long term, but I really hate how x86 is not using more of the
generic ioremap code. kmsan_iounmap_page_range should really move
to generic_iounmap, as should memtype_free after adding a properly
stubbed out API for it.
With that x86 iounmap would just contain a hook for the magic
ISA region, the mmio trace call and then call into generic_ioremap
and we'd get rid of these open coded checks.
next parent reply other threads:[~2024-08-12 6:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230810100011.14552-1-max8rr8@gmail.com>
[not found] ` <87wmkr4jgj.fsf@nvdebian.thelocal>
2024-08-12 6:15 ` Christoph Hellwig [this message]
[not found] ` <87le17yu5y.ffs@tglx>
[not found] ` <66b4eb2a62f6_c1448294b0@dwillia2-xfh.jf.intel.com.notmuch>
[not found] ` <877ccryor7.ffs@tglx>
[not found] ` <66b4f305eb227_c144829443@dwillia2-xfh.jf.intel.com.notmuch>
[not found] ` <66b4f4a522508_c1448294f2@dwillia2-xfh.jf.intel.com.notmuch>
[not found] ` <87zfpmyhvr.ffs@tglx>
[not found] ` <66b523ac448e2_c1448294ec@dwillia2-xfh.jf.intel.com.notmuch>
[not found] ` <87seve4e37.fsf@nvdebian.thelocal>
[not found] ` <66b59314b3d4_c1448294d3@dwillia2-xfh.jf.intel.com.notmuch>
[not found] ` <87zfpks23v.ffs@tglx>
[not found] ` <87o75y428z.fsf@nvdebian.thelocal>
[not found] ` <87ikw6rrau.ffs@tglx>
[not found] ` <87frr9swmw.ffs@tglx>
[not found] ` <87bk1x42vk.fsf@nvdebian.thelocal>
[not found] ` <87sev8rfyx.ffs@tglx>
[not found] ` <87le10p3ak.ffs@tglx>
2024-08-13 22:29 ` x86/kaslr: Expose and use the end of the physical memory address space Thomas Gleixner
2024-08-14 0:26 ` Alistair Popple
2024-08-14 14:33 ` Dan Williams
2024-08-15 16:11 ` Kees Cook
2024-08-15 22:48 ` Max R
2024-08-16 9:42 ` David Hildenbrand
2024-09-22 22:31 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZrmoZKI1UHRRln7j@infradead.org \
--to=hch@infradead.org \
--cc=apopple@nvidia.com \
--cc=dave.hansen@linux.intel.com \
--cc=jhubbard@nvidia.com \
--cc=jniethe@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=max8rr8@gmail.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox