From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72784C52D7B for ; Sun, 11 Aug 2024 16:35:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7D9726B008A; Sun, 11 Aug 2024 12:35:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7893A6B0092; Sun, 11 Aug 2024 12:35:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 677C86B0095; Sun, 11 Aug 2024 12:35:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4A1096B008A for ; Sun, 11 Aug 2024 12:35:57 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B2E041203C0 for ; Sun, 11 Aug 2024 16:35:56 +0000 (UTC) X-FDA: 82440516312.25.79FE926 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf14.hostedemail.com (Postfix) with ESMTP id 6CB60100007 for ; Sun, 11 Aug 2024 16:35:53 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LkVZGXG2; spf=pass (imf14.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723394120; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0rwci/evZRdN9FZU2KOxquvK1BGrlD4o4JUwSwTlN8I=; b=RuFZD7aovIRjzEuL+BjPou+MXAqK/xyrJAdRGBjeGhyqj/GAVQ37MK99LDaBFC2tn1xtSx mubByDriIv8DsbqW2tm0RjZGj9AtTlM85Ng+ZDWADOQPrwrd8nNhTQKkO9gNdkj2ve72GC F0t6QzmIaRGsP7zjSomSKJsXL+Tyes8= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LkVZGXG2; spf=pass (imf14.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723394120; a=rsa-sha256; cv=none; b=Jo/WNwkzlGKgahBeSD4OdSXZCv3lZMyn9OGiRh3CvD0qUn/ZAkhoqVs4XSzqMxLZmcFSj9 J5F33WlqJAeEI2R7+O6bL4J4g0kMy6Dpm3TreA5IKQXrSBjfJdkbsTaHXQE0uV3JYFCnxa J8nmAYXh7eNxCwIYapZTxOdpZgG+XH4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 16D32CE0B0A; Sun, 11 Aug 2024 16:35:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30118C4AF0D; Sun, 11 Aug 2024 16:35:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723394148; bh=JWC3mgdz2ktAtm0H6Q0A+PYoh4dsi333CkWUpefiwTs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LkVZGXG2B04KEwhASYe0vn0UbubvJskcdiZ48Fj381Pat/uHAGPW+1QGjUAXyGKai 9HdQ9PTWMNPaFKVmWhvRu5mWX0xT/qyz2f3hrWTdEiRcbsq9ETalzizQdCx7wiKmN3 7Tx3PCNS4p4pOvtlnF3Sp6ONa5s6t4wR4pfiTHNdXOn3hWjdxE90BArYS60SOJte7M rTZI010lgwijCgyLuBu2w5tNZGjO5PUBlsW/a10DvWiRH7sCNzjF5kDVjOr5dFOcSq DVbL3MTse1AwAUPExKhC8/As3AJ7PIsygcZ1Y7t1WJszPayTZYRDnTIdawBKhSvJow goti7KOisr8Gw== Date: Sun, 11 Aug 2024 19:33:30 +0300 From: Mike Rapoport To: Muhammad Usama Anjum Cc: Andrew Morton , Shuah Khan , Paul Walmsley , Palmer Dabbelt , Albert Ou , James Bottomley , kernel@collabora.com, stable@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH] selftests: memfd_secret: don't build memfd_secret test on unsupported arches Message-ID: References: <20240809075642.403247-1-usama.anjum@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240809075642.403247-1-usama.anjum@collabora.com> X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 6CB60100007 X-Stat-Signature: 9utaaef5i9785tkeebd48k4cwghkpko5 X-HE-Tag: 1723394153-689385 X-HE-Meta: U2FsdGVkX19LlTXufqJhb1+31nDHQ8gwOcPCUD6zgihd1B9eT+C30LwyeEFEi8GyKO7Dy7O9IZcI4BHesc+t+jlW1Ya/yp2aWUwG9izs1me2+OqF3wjX6x/Gy4t2lBI6G0jpNm8u69UcRl7q/9SaKqcoNOeG9GBatiiEDqz3KQfkrqA8YmvWFgYPqafLNc3nxePOJjTCs3rZnjnhzX1w2wIXDZ76jVgufkUC7OFWf1MInhpJurnHJeIxVVrWyGmq2U63N7DstGj82bgke+T0T/l3wuN8Jot9RG22GSxF6IZpq6dAbxOqdzTwJSHIjU6JVxaCtDCCyI8zw3yAbtIY+7+0zH84OhgzsQsgOeL2aZQaii+/0C2lELap/KO8f2VyXQSsMcWANL/Rl1mXCTJKHCF7FyIeLvZ9PKH5zmEHi0pzROdGKckYGaCHXvjVaCbbMHArom3WOYiZYMQ6FaIURWHFRf73L0g7AUvh78882f8a3f+zSYOvDBHV91ikLWjo2S/omRDyaXGXhEcptezKMy2rCSzkG1jjDre32S+gGUT5e/iRPTmWdrdHgHEt3BZA+Du66RVoboEjIuwLEH3o6tVAgRjuAN2cxyBmOocq4a3LGR/js9w8OZ5aScnwK3uGmxOhFF9SZpGWGDHGQ7uDa+VoNSqOQYm6y8Cvs+rX6T8SIUGDve7MZt/O2ZK79oxf8ktwungnPyGqVoQoz74ptOqTY+o+b9P7f2cElCl04F+eslPhSL+iNs/Jj53GqQHc71o874u/Rd1AgjEfQ/2HzCsBButAp6X0QfwqnqWjxNo4pgZi/z+1ZHa7RaP8J8kqxTXaRCzjfrsHx7XR1QYaHJiouajcYb/jodHuRBqFtnJVL4o8IALzYdTFOLIDRQzruOZYtMt8uHA6B+x06V2XiQ+0OFHc84fxCN2+kgAe6h+qveBeNb36mHLXT/TIdWRf5j8yhBp+mS7Qi4D7OL9 gWmPzGJg /+Pvs/k1qhcDaZiSv87Hffu6iRBcW5lnV3bQ/82lQzRORgelpamScxpuqGngltd4mObdo2v8vQx/qNYI3BTeCA/ZRbLmlOwEP710FWYhwNVOwmfS51VkVnJvnGqJ3ib6cIopJpG5LYaG1np2s1w9/G5ScvhnsxnJlssbWDgR8aosZVTpuKzqJAdpMSfaU5gMYr/4xoZ2TVS0KHKwVzT+sWIRTov54scC59Nd4G20qBU/F7WOsQWK6ggAvLjLsC8NEDYMCdcD5xtzKYAcMWKy7eVsk7DKfm1LwCx0knLVXlXPU8Y9HwuQWdc41wwK09ePgtjxyWTnzy5Mg1Z1QWAmd0i+BniVKPPm2/KXSzl+fp3IZwM1mt/I3YE+Hlz/acfMenI49 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Aug 09, 2024 at 12:56:42PM +0500, Muhammad Usama Anjum wrote: > [1] mentions that memfd_secret is only supported on arm64, riscv, x86 > and x86_64 for now. It doesn't support other architectures. I found the > build error on arm and decided to send the fix as it was creating noise > on KernelCI. Hence I'm adding condition that memfd_secret should only be > compiled on supported architectures. > > Also check in run_vmtests script if memfd_secret binary is present > before executing it. > > [1] https://lore.kernel.org/all/20210518072034.31572-7-rppt@kernel.org/ > Cc: stable@vger.kernel.org > Fixes: 76fe17ef588a ("secretmem: test: add basic selftest for memfd_secret(2)") > Signed-off-by: Muhammad Usama Anjum Acked-by: Mike Rapoport (Microsoft) > --- > tools/testing/selftests/mm/Makefile | 2 ++ > tools/testing/selftests/mm/run_vmtests.sh | 3 +++ > 2 files changed, 5 insertions(+) > > diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/mm/Makefile > index 1a83b70e84535..4ea188be0588a 100644 > --- a/tools/testing/selftests/mm/Makefile > +++ b/tools/testing/selftests/mm/Makefile > @@ -53,7 +53,9 @@ TEST_GEN_FILES += madv_populate > TEST_GEN_FILES += map_fixed_noreplace > TEST_GEN_FILES += map_hugetlb > TEST_GEN_FILES += map_populate > +ifneq (,$(filter $(ARCH),arm64 riscv riscv64 x86 x86_64)) > TEST_GEN_FILES += memfd_secret > +endif > TEST_GEN_FILES += migration > TEST_GEN_FILES += mkdirty > TEST_GEN_FILES += mlock-random-test > diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh > index 03ac4f2e1cce6..36045edb10dea 100755 > --- a/tools/testing/selftests/mm/run_vmtests.sh > +++ b/tools/testing/selftests/mm/run_vmtests.sh > @@ -374,8 +374,11 @@ CATEGORY="hmm" run_test bash ./test_hmm.sh smoke > # MADV_POPULATE_READ and MADV_POPULATE_WRITE tests > CATEGORY="madv_populate" run_test ./madv_populate > > +if [ -x ./memfd_secret ] > +then > (echo 0 | sudo tee /proc/sys/kernel/yama/ptrace_scope 2>&1) | tap_prefix > CATEGORY="memfd_secret" run_test ./memfd_secret > +fi > > # KSM KSM_MERGE_TIME_HUGE_PAGES test with size of 100 > CATEGORY="ksm" run_test ./ksm_tests -H -s 100 > -- > 2.39.2 > -- Sincerely yours, Mike.