From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B464BC52D7C for ; Fri, 9 Aug 2024 17:17:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4FF5C6B00A2; Fri, 9 Aug 2024 13:17:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4AF4E6B00A3; Fri, 9 Aug 2024 13:17:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3503C6B00A4; Fri, 9 Aug 2024 13:17:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 180AF6B00A2 for ; Fri, 9 Aug 2024 13:17:00 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5378A121168 for ; Fri, 9 Aug 2024 17:16:59 +0000 (UTC) X-FDA: 82433362158.02.EF2D2DB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 4450F4001F for ; Fri, 9 Aug 2024 17:16:57 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=H0R343Y1; spf=pass (imf07.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723223752; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lWgHfye1k/eUTN9Ag8F85Wjlr482Lhi/qRRDj/XILyk=; b=hc+ajmrPz0eAejMlxawdElJvPCa0xwyYRamEtkBeMmejHV0dQBInCSUc1MJXLI5g/59rGo o6Op9eOwtpjNGWTSzRiZ/xI1dkxT0cALhcc2+UPWKSoW6n624efhK8xrbroRjtxcGEbU3H xNIDxP9klqvbn+IStnWf9CBPiEz/sqs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723223752; a=rsa-sha256; cv=none; b=Z83xefjVkdAiB7W/OSXm3Td1BZORv8sMV3AGCi3EuZCXZ6371GHm9UmMNR9MQqORTdRhnY jn5h+7mO87/1a2x9X1gQykscNtBAneIKhohGIBMdEtMhtBB+NvJHoj7pSHQNi5k6FZCIok u2WJqsFTx+0CXhJr8C2JBl9wYG41RWI= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=H0R343Y1; spf=pass (imf07.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723223816; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lWgHfye1k/eUTN9Ag8F85Wjlr482Lhi/qRRDj/XILyk=; b=H0R343Y1aHyDraPca5cdvnNajStH/XGQAV96Hve4VMYD+26N/OaAzV8bu64zRErx9OJPZF RRzI6Z9pI1VAmuT/hSY+lmlTkuCcjZGSzJ0iwJKnYnb2v3TuchPzWaIAq47lf8hhj1wxd5 s5GeQqxwG91l8Jxlu4Drku8XQgGk/DE= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-630-ms8VIvj_M1i485IjuM0Vtg-1; Fri, 09 Aug 2024 13:16:55 -0400 X-MC-Unique: ms8VIvj_M1i485IjuM0Vtg-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6b79c5c972eso2686386d6.1 for ; Fri, 09 Aug 2024 10:16:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723223815; x=1723828615; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lWgHfye1k/eUTN9Ag8F85Wjlr482Lhi/qRRDj/XILyk=; b=LnXSaPFZagBgxyT9LMI/PgEA4IW4OG6Ayc2OGYquHmKpkO/rd6XYZTsv+Nz5leBte+ WZ046LbtQv5EvDva3bmWsGsGXLYRluA43rCm/AnApOIT2X5D2QMCfh1EgOh199eodK9a pFptLaN0Csmn7bWhI8mquKkX6KFw2T1UagIIb2Vu0xseBBxQg4f4ughV9wfWoA2aNYpU 1RoaKvhndzURaXiSqW+FC6l+XiqziHWo6v50dBJcxNs/qPK1LesqQRBC1HNOg4hoqCQp qKmCR6zXRxWhBGoz0XynKS6KsROMRJ+s5RUssBXUT0D74ZhlCM8LmmMCCsESBhiweys8 UfWg== X-Gm-Message-State: AOJu0Yw2AQ3/VRmWvr66C+SmiMGrE5XG9N6/GaWvoz+3x5IwJQ9pyBhp S4Jx2YbibAkrj6pbzdEkpXtBFhILky7VNnaut+R/SPgPHFR49C7XE8aGu6+r7e6BzzaO5qNhQN0 9/4En6b02bwUe3VYGZUq38xtP9H8nIvBaAMWIVmJCskd/CqVO X-Received: by 2002:a05:620a:1925:b0:79e:fc87:b4fe with SMTP id af79cd13be357-7a4c1780209mr131242185a.1.1723223814894; Fri, 09 Aug 2024 10:16:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IESBrnT/S4Eke81ioq4DZsO1LgixDYHAiPo//Jt33fK/EQNoj7Ue5Q/Gq+QoNJZ6zQNfyAuHg== X-Received: by 2002:a05:620a:1925:b0:79e:fc87:b4fe with SMTP id af79cd13be357-7a4c1780209mr131240785a.1.1723223814512; Fri, 09 Aug 2024 10:16:54 -0700 (PDT) Received: from x1n (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7a3785d06fesm281331985a.1.2024.08.09.10.16.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Aug 2024 10:16:54 -0700 (PDT) Date: Fri, 9 Aug 2024 13:16:51 -0400 From: Peter Xu To: David Hildenbrand Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sean Christopherson , Oscar Salvador , Jason Gunthorpe , Axel Rasmussen , linux-arm-kernel@lists.infradead.org, x86@kernel.org, Will Deacon , Gavin Shan , Paolo Bonzini , Zi Yan , Andrew Morton , Catalin Marinas , Ingo Molnar , Alistair Popple , Borislav Petkov , Thomas Gleixner , kvm@vger.kernel.org, Dave Hansen , Alex Williamson , Yan Zhao Subject: Re: [PATCH 01/19] mm: Introduce ARCH_SUPPORTS_HUGE_PFNMAP and special bits to pmd/pud Message-ID: References: <20240809160909.1023470-1-peterx@redhat.com> <20240809160909.1023470-2-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: 4450F4001F X-Stat-Signature: 4y45df9uh5d4yiwwjucwo16ss1xd3rep X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1723223817-524230 X-HE-Meta: U2FsdGVkX1/i2RzOgvykpxHHyLyob/VXdS7oojpire7WVcsQi3VXd/rAQfO7SUvgmIYhqmdVBUCJW31AhQ6/CXRDEjEjpT9Dx9T5gqHVzl7zZoIKLx3G+TCAgqVYMyvXnychKwApMeWDBsEWmEBq4FHL6CUM9+rAaCBjIBUXLOoq4F2b7R59WyLuvMQFiPdH6P4cvCoTkzLc04bnNw5mn8Ql3vK/7djcv6sKr0rHC+ENX8A8lCjdoN3jz5utRjUC53+LxMsyqYZvp6M/CVLO0HQJi5rs7bWylLW0xx4w3+2RZgY0caGE2M7fkDlrdY1DTV9AhZQXSdHy06RVJy6C9HI/MoXIlOhfDqdCV7/8chhP8RUWa4cPHzhWZ4Q+CS5qjKdZAPWl7TugP/shlHQZ8eeiRB6yP1U+XBYDjPnkopJDmLlvrTIN0OdHwyLLrntX5AkWFJ4gvw8uogcHPgU1qk8FaGyWTDllJABiOH4QGaF7Y2ICaXdMmvl8xrrU2qquH6lfxGcTwFzzsRonfvxGMs9uKnlfICrsou0KpSlcxr3Tg7CPW7+FWBvY3y4LZF+ZGV7SVL5n5m94ddLcNH5FF4s3/1pgLSrTfYyhDFToAg3dXtusHkU9KQ+7NeRd1CZZYLVoBmnNFVGmd2NIG908e15yDKEchaTMMkM5CwBCBw0Eb4yeUySxvJYDVqv3q6MSVGpvzjfnotqK19iJ504bfCk+0mRNEm2zSgoHZCsuG1qlu6ZcTDxG/dInZOTRFkyaOPwoShCegQpAqqs/ZaEheOceC38XBqu9rojDlZASFe0sAWBm1PHvzZCgjs9zvNvq8pmxJBgTFSpsLcP/jbsQ9HHPEcp1DT4e1RYKwz/cx/7AiKgDeyIAp/SJE+iH4qnGtEjb0hmJACsMWODnA2gsN4RYvuVQ5Fdf8vhmwXIihDKo4NsIkWAXhtzhcg1cUtQRsO1mECsy/Dm/OJzN/3K N8xrX4rO FJarNfe6u9qdyZHkS1RSukrmPWYHcMhhAot4FGfxprWXnxnkR+lxUCgCpN8VbsZXLsxMpIZ1z21/7C4JAjH/PkdG9GB33cNfA9h23DdoB39moz/JBJlTuoNCNORlG0HMsexv/BJhi5SvU5faQBBb21CHWjy1abGRnu0h4O04eeMR+sgVTJ3LB4UT9nEzk/e1il+ChzVwo8R+E1cVAfeDxErpz9et3vS6+ec5u89tJWGEzCX/Xbi7KCYeKXehBMPFnwhcQdcGnTx+NQQdG+jp3yr3EOEE78EyqYEop11oruA1WMuLiagU1hXrSPbOqEMMpitmqFPBHmVw7OGeF9MY0zzVZJlTg4caaqWJ0pxy1GZup1hIdls3q8SXq8oYinK++ESUEzntv1m6hyHiY1xHwBsrhTOOtItY534FqduLQ+g6otPDWBmmEHahJM7WUlcs64GNEMwOjENI2ob8Q/HESNtAzsneJUaK4NgqDeS7YJHLNsU5g836v8RKw5v3NYcj2vnbG59ckrhcs8uH6lQK+YSMHF6NGMPL7p4dD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Aug 09, 2024 at 06:34:15PM +0200, David Hildenbrand wrote: > On 09.08.24 18:08, Peter Xu wrote: > > This patch introduces the option to introduce special pte bit into > > pmd/puds. Archs can start to define pmd_special / pud_special when > > supported by selecting the new option. Per-arch support will be added > > later. > > > > Before that, create fallbacks for these helpers so that they are always > > available. > > > > Signed-off-by: Peter Xu > > --- > > include/linux/mm.h | 24 ++++++++++++++++++++++++ > > mm/Kconfig | 13 +++++++++++++ > > 2 files changed, 37 insertions(+) > > > > diff --git a/include/linux/mm.h b/include/linux/mm.h > > index 43b40334e9b2..90ca84200800 100644 > > --- a/include/linux/mm.h > > +++ b/include/linux/mm.h > > @@ -2644,6 +2644,30 @@ static inline pte_t pte_mkspecial(pte_t pte) > > } > > #endif > > +#ifndef CONFIG_ARCH_SUPPORTS_PMD_PFNMAP > > +static inline bool pmd_special(pmd_t pmd) > > +{ > > + return false; > > +} > > + > > +static inline pmd_t pmd_mkspecial(pmd_t pmd) > > +{ > > + return pmd; > > +} > > +#endif /* CONFIG_ARCH_SUPPORTS_PMD_PFNMAP */ > > + > > +#ifndef CONFIG_ARCH_SUPPORTS_PUD_PFNMAP > > +static inline bool pud_special(pud_t pud) > > +{ > > + return false; > > +} > > + > > +static inline pud_t pud_mkspecial(pud_t pud) > > +{ > > + return pud; > > +} > > +#endif /* CONFIG_ARCH_SUPPORTS_PUD_PFNMAP */ > > + > > #ifndef CONFIG_ARCH_HAS_PTE_DEVMAP > > static inline int pte_devmap(pte_t pte) > > { > > diff --git a/mm/Kconfig b/mm/Kconfig > > index 3936fe4d26d9..3db0eebb53e2 100644 > > --- a/mm/Kconfig > > +++ b/mm/Kconfig > > @@ -881,6 +881,19 @@ endif # TRANSPARENT_HUGEPAGE > > config PGTABLE_HAS_HUGE_LEAVES > > def_bool TRANSPARENT_HUGEPAGE || HUGETLB_PAGE > > +# TODO: Allow to be enabled without THP > > +config ARCH_SUPPORTS_HUGE_PFNMAP > > + def_bool n > > + depends on TRANSPARENT_HUGEPAGE > > + > > +config ARCH_SUPPORTS_PMD_PFNMAP > > + def_bool y > > + depends on ARCH_SUPPORTS_HUGE_PFNMAP && HAVE_ARCH_TRANSPARENT_HUGEPAGE > > + > > +config ARCH_SUPPORTS_PUD_PFNMAP > > + def_bool y > > + depends on ARCH_SUPPORTS_HUGE_PFNMAP && HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD > > + > > # > > # UP and nommu archs use km based percpu allocator > > # > > As noted in reply to other patches, I think you have to take care of > vm_normal_page_pmd() [if not done in another patch I am missing] and likely > you want to introduce vm_normal_page_pud(). So far this patch may not have direct involvement with vm_normal_page_pud() yet? Anyway, let's keep the discussion there, then we'll know how to move on. Thanks, -- Peter Xu