From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D245FC3DA4A for ; Fri, 9 Aug 2024 12:23:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 38A646B008C; Fri, 9 Aug 2024 08:23:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 33AF36B0092; Fri, 9 Aug 2024 08:23:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 202806B0095; Fri, 9 Aug 2024 08:23:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id F0B7E6B008C for ; Fri, 9 Aug 2024 08:23:55 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7FDC4A0EA1 for ; Fri, 9 Aug 2024 12:23:55 +0000 (UTC) X-FDA: 82432623630.11.A3036E9 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by imf14.hostedemail.com (Postfix) with ESMTP id 7A01D10001C for ; Fri, 9 Aug 2024 12:23:53 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=dwkLqDhp; spf=pass (imf14.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723206168; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u0FoO/uu3owml8B+aDiAdNgR8TEdOerha2mgYrb48hE=; b=bPXZA6tYLQvqaUMgt9jALXy88BwVQqNHecsJ1zo9wKoJ8v8NgF/kaXcbp5ZESwNz+4fBU8 CwXhmt8obpB0Xb+H2AdU15Uwjl8qeZuNKQmVl8bZxiuq9AHK697l9AY7NAxdmP/qlMESgf rDRR2AhdxtEo9ZrbwEpyG4EuCkBEhGk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723206168; a=rsa-sha256; cv=none; b=34auL3Q+ztSHAFER44I6I3j4yLz15km/VwHANa6PFrlf5Srl2u9ly3Vht5nPqM8mxHMXJV 9Pb/b1evaog8HGbW/BD6B7hrGMBsxjY8JC8AKBqw6IbRAeJ/+iOOCU91/N3hQIProEDxlJ L5aC1nMICvpK94nvV75p6qvYbBZlljg= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=dwkLqDhp; spf=pass (imf14.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-5b8c2a611adso2550777a12.1 for ; Fri, 09 Aug 2024 05:23:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1723206232; x=1723811032; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=u0FoO/uu3owml8B+aDiAdNgR8TEdOerha2mgYrb48hE=; b=dwkLqDhpFHRcj5ugisD64wg+JuT/dZv83HK3bHlrfpw29COBD5If/bf1waelwDjh7m gDTXVqHxog/2ec+DkODl4s/9YUVekORtvq2eR5LvGWDdXQznuG3hU0SkGfUKeBAZzaEL 0gpsdQmW5hZM27JoZk9k2pSQinJspTM7q373sd83Sfk3mcUPKGmXMQCQyaZWG7FqHFGC NjbhkGPAXhs3pk5r59Xki2YyIAMCtL7PcHyFZT6lyvnb3HOjWX3Vut3IR58huBhdcE3i 1ER76cKZQuTxohQMLvAhX6h52S6L4ADV3HFNFXbOSN7cSpsEQ+cxINSZa1A45y3kgLaI urww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723206232; x=1723811032; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=u0FoO/uu3owml8B+aDiAdNgR8TEdOerha2mgYrb48hE=; b=JpeJPYt+NZ7nknZ5cU+WEjBzYfkIfjejU8Trh13cY0CXi5UpZQs8KC3trlaDz8TR7/ H9wTrkXZHQjqFu2ygqHl7pH2MRM8mUNxY0tCsf8EKev/fXpzZsAo1dJk1z2n8mYCwn3K r7L8RrCx/SkDAOE1lGY3dvLGTDuNATqyWVmd+QHxOD6vY0iLwTr7tSVITzyRk6FpkGk3 7ABGBtbhvS2ZcDaLOmCfAeZcuuuGdJ53NycJlnpMD5oLK2rwHbFAX43mJtf5bLBAJwvr 0ZQ/7oGshjiE0oS68z/W4P8cjoMp1KVo7eFGdJn8rnwZasE3jSa1l5T9Jcjb4YwxXtI1 CeXw== X-Forwarded-Encrypted: i=1; AJvYcCUmkJ9I27mm+MKgPxXitivc4cjGBIRptLSciSAV3vgNfD5PoUqAN2+Fhf8VghEqvL+ZEcAQj1n91Nsu4TlO9C8jf8k= X-Gm-Message-State: AOJu0YyU8dYq84MFW3MjKkEGsyfYhzF7jSbJnZDlkhG75OIFU84ZpXML C9p7gK/oh4nXS/JWm8ZLT0T+ndp3mLSZCPkNwp67xB5yYxW8q1r1dLM7qE81+ew= X-Google-Smtp-Source: AGHT+IFIe1154CGlnlvVU0+T3yIWXjKE3bqt5wZBs8RFMTHp5RVFAhJ0dgFH4iIDd4JGooeRaV9rjw== X-Received: by 2002:a05:6402:1d4a:b0:5a3:5218:3f91 with SMTP id 4fb4d7f45d1cf-5bd0a63f1b1mr1005990a12.24.1723206231569; Fri, 09 Aug 2024 05:23:51 -0700 (PDT) Received: from localhost (109-81-83-166.rct.o2.cz. [109.81.83.166]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5bbb2c40084sm1465089a12.37.2024.08.09.05.23.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Aug 2024 05:23:51 -0700 (PDT) Date: Fri, 9 Aug 2024 14:23:50 +0200 From: Michal Hocko To: Shakeel Butt Cc: Andrew Morton , Johannes Weiner , Roman Gushchin , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Meta kernel team , cgroups@vger.kernel.org Subject: Re: [PATCH] memcg: protect concurrent access to mem_cgroup_idr Message-ID: References: <20240802235822.1830976-1-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240802235822.1830976-1-shakeel.butt@linux.dev> X-Rspamd-Queue-Id: 7A01D10001C X-Stat-Signature: zx8pz98te85tw3m4xwdmtiy97dopa3gu X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1723206233-966628 X-HE-Meta: U2FsdGVkX19X4X0BqPJuJbBAdcSkjc9iy+/5axddtRz1EWpgp5cblCP3yFcBlullI06wu81CGjiFFWD2xbspPznOZGUxYDu0PlzKx2mndYvtz7qnJbEfPBd191gddu72lTgtjDZBxqIIYo/cH+FZWkC1Guwk6QZXum0YNzdGuzg9wNYalT7ZhMnX85kEHWFdbUfQ7Cvn0x1DkeVfPeK7bf/YWgOE9Ze88kDf9mPtBvJmRuo3vmZcLEruyaTlfgH2a4FS5Co/D9wWenJ3nNtGO2n0dbY8VE/3CE+jWnqyzrhVniDBy81syCqBfHzJyxN4Oa7b5J0tyb92Bk0SC2WFB/2iZVOEW8qikEn0eFN5imdViVB5gKRtfrjECFL5W8ENIzQsCiuFgdVF69F49cCtsWOIlqcn8hGU1Fs90lTj9eS5NpbBpE7u+Q75FjOOhKRLn6WGqa0qm9t2Uxn2cp4AHzbcZVXRJowfbsbAB0QTFG4+VHuKFexrnBFKZKzVfDyH0FbpbFnpK3s8QqZ+/qa0kW+/n1U8V+dwIpwvJs9ZM972FmKs2QjzfEsSMqagaxNn+bYnjngb2xvok8P8+Eaw1eEd9M1AIELf0ytIwmtHRWKXTLf3I4xhabmwL5tRpe5f2NCY+CbqIbsDBSg44yIImxQpNMbVpStW1t+bl4JN+G4rCzWkTFnvJ922aSpLyoWNcIix0y6AH43EPOxnEZJq4eP+8yRzXwf9t64np9Sk1pPFSNHWbe0fd1eoldMovetKBh4V6HdwUr3e9gre4ABsww2+BmOUZiP5dsbPlbiukxH1TabE3SqGXzq8kz0ftQSg9YPaaxjgsPuFf4/g38r6twGzVev/QbDdtOjEmzQ3aFjPFzpC/JXYBbHkMHLx7GKoBbMakzwQJU4M7JWnj8AfKhVPy+prpdH+7WjhkyTXGszNbtr7zPufaRaQPzNGlKpUo+6gC47rDCkhnwumRtc XzMdC9HX Ih7ITzzbOB4RheiOZolSMgtIAsVzqr/CDDaAcW9kgBiCPnt3+KpwYx5LcOfREjjBv4vLg5VZr7UtWKf3xmXTwFAKh0GK6R1qsMiK5nJ1zv8GgOsPj+SwI3XY1HZ3XDnlFquQMGiQS5qaJ1OZpLXVBZ9LpPGLnUIBp3w/KDnWDm1+54AJdjyZx6DnXcc9nmAtHt33R6g5n3ZrkYnOTrAICpwd0iLoxmO6GPW16ge+rVrGUcPGkEBPI9bBfw0cYB3C6y2WMNeEkO1XOlrLE0iE7bn+dfLWjyDPdkrxwo5DpV9GxotJUnxSOjWgDknEGyqpSaBaWvbckgfzL0uSfDtWvMO2ggaTqiruhs85feV9Mmf1ArwbPSVriw6xhkOrRE5k2z1sEpmmAueazxuo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri 02-08-24 16:58:22, Shakeel Butt wrote: > The commit 73f576c04b94 ("mm: memcontrol: fix cgroup creation failure > after many small jobs") decoupled the memcg IDs from the CSS ID space to > fix the cgroup creation failures. It introduced IDR to maintain the > memcg ID space. The IDR depends on external synchronization mechanisms > for modifications. For the mem_cgroup_idr, the idr_alloc() and > idr_replace() happen within css callback and thus are protected through > cgroup_mutex from concurrent modifications. However idr_remove() for > mem_cgroup_idr was not protected against concurrency and can be run > concurrently for different memcgs when they hit their refcnt to zero. > Fix that. > > We have been seeing list_lru based kernel crashes at a low frequency in > our fleet for a long time. These crashes were in different part of > list_lru code including list_lru_add(), list_lru_del() and reparenting > code. Upon further inspection, it looked like for a given object (dentry > and inode), the super_block's list_lru didn't have list_lru_one for the > memcg of that object. The initial suspicions were either the object is > not allocated through kmem_cache_alloc_lru() or somehow > memcg_list_lru_alloc() failed to allocate list_lru_one() for a memcg but > returned success. No evidence were found for these cases. > > Looking more deeper, we started seeing situations where valid memcg's id > is not present in mem_cgroup_idr and in some cases multiple valid memcgs > have same id and mem_cgroup_idr is pointing to one of them. So, the most > reasonable explanation is that these situations can happen due to race > between multiple idr_remove() calls or race between > idr_alloc()/idr_replace() and idr_remove(). These races are causing > multiple memcgs to acquire the same ID and then offlining of one of them > would cleanup list_lrus on the system for all of them. Later access from > other memcgs to the list_lru cause crashes due to missing list_lru_one. > > Fixes: 73f576c04b94 ("mm: memcontrol: fix cgroup creation failure after many small jobs") > Signed-off-by: Shakeel Butt Sorry for being late here. Thanks for catching this up. Acked-by: Michal Hocko Cc: stable is definitely due here as those races are really nasty to debug. Thanks! > --- > mm/memcontrol.c | 22 ++++++++++++++++++++-- > 1 file changed, 20 insertions(+), 2 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index b889a7fbf382..8971d3473a7b 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -3364,11 +3364,28 @@ static void memcg_wb_domain_size_changed(struct mem_cgroup *memcg) > > #define MEM_CGROUP_ID_MAX ((1UL << MEM_CGROUP_ID_SHIFT) - 1) > static DEFINE_IDR(mem_cgroup_idr); > +static DEFINE_SPINLOCK(memcg_idr_lock); > + > +static int mem_cgroup_alloc_id(void) > +{ > + int ret; > + > + idr_preload(GFP_KERNEL); > + spin_lock(&memcg_idr_lock); > + ret = idr_alloc(&mem_cgroup_idr, NULL, 1, MEM_CGROUP_ID_MAX + 1, > + GFP_NOWAIT); > + spin_unlock(&memcg_idr_lock); > + idr_preload_end(); > + return ret; > +} > > static void mem_cgroup_id_remove(struct mem_cgroup *memcg) > { > if (memcg->id.id > 0) { > + spin_lock(&memcg_idr_lock); > idr_remove(&mem_cgroup_idr, memcg->id.id); > + spin_unlock(&memcg_idr_lock); > + > memcg->id.id = 0; > } > } > @@ -3502,8 +3519,7 @@ static struct mem_cgroup *mem_cgroup_alloc(struct mem_cgroup *parent) > if (!memcg) > return ERR_PTR(error); > > - memcg->id.id = idr_alloc(&mem_cgroup_idr, NULL, > - 1, MEM_CGROUP_ID_MAX + 1, GFP_KERNEL); > + memcg->id.id = mem_cgroup_alloc_id(); > if (memcg->id.id < 0) { > error = memcg->id.id; > goto fail; > @@ -3648,7 +3664,9 @@ static int mem_cgroup_css_online(struct cgroup_subsys_state *css) > * publish it here at the end of onlining. This matches the > * regular ID destruction during offlining. > */ > + spin_lock(&memcg_idr_lock); > idr_replace(&mem_cgroup_idr, memcg, memcg->id.id); > + spin_unlock(&memcg_idr_lock); > > return 0; > offline_kmem: > -- > 2.43.5 -- Michal Hocko SUSE Labs