From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33120C52D73 for ; Thu, 8 Aug 2024 22:24:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B738F6B008C; Thu, 8 Aug 2024 18:24:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B237C6B0092; Thu, 8 Aug 2024 18:24:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 99CF16B0095; Thu, 8 Aug 2024 18:24:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 76A176B008C for ; Thu, 8 Aug 2024 18:24:24 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1677DC031C for ; Thu, 8 Aug 2024 22:24:24 +0000 (UTC) X-FDA: 82430508048.01.8B9DF24 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by imf09.hostedemail.com (Postfix) with ESMTP id 6343C140017 for ; Thu, 8 Aug 2024 22:24:21 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=RKVE8I6l; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf09.hostedemail.com: domain of ak@linux.intel.com has no SPF policy when checking 198.175.65.19) smtp.mailfrom=ak@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723155852; a=rsa-sha256; cv=none; b=RXe2bEgpwsxUvTvvosBlM9QrEGOg1JI7jjsUrwacyFKsivIUZxMLftkMLRVeym5c2jG3+O fX+/9vuEmtDzLL+vTfLbdQ+sXj/0jBXnhq3LVakv3ydKYfbG/K6bA7nVJjbYG0QDYtY7dF jh4fLSYDVtK/r9I3YKmA1FAvBpYxutM= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=RKVE8I6l; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf09.hostedemail.com: domain of ak@linux.intel.com has no SPF policy when checking 198.175.65.19) smtp.mailfrom=ak@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723155852; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=o4iH6R1RDp3bcwkBShNadYi9MwTG0WBG4aba/q3dl28=; b=nYyD68dVF+6XJhCv0KQXStGVVMJAuCdWGt9CTT8gDKnexXGWS1QtQAp+t8ybw5PUPtIIpq QxfznEvmyM8vhZGhbALn5Z3G5O45CjwzokcLtRjpLjjBWhPY0hxYDIKwjldL6/laljnDOG Emi8YR47iFeOZ+NIFv5N1uuBb117dF4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1723155861; x=1754691861; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=oGeQ/IZ/BAX6uaFiQyDJ4OD/I2YS3n5wIX4qZL0U+fk=; b=RKVE8I6lnqjvAvc0K/kHH5rlgOhABQuviCZF+AIY61fmtAOJSrHAejG0 o8wrildCu0ZQn0jJnv/plFWE9H5KdQ4UBZUciBS2/LhkwxDFWC53FXKb1 fMyjUJe4ZjZZVPa2aX4yyHid8bKhaY+1AUpOjRY/BzzuW73LadnaMIwZ5 zRKLP8XyC0g636qJ5ug5h9d1SAmu6rkmu/ofKrTrlpGu1ogWoi9Wi9YHb mJP4R2gmi6IpylitRG+tnf/snW7FWlCdSElgEbTkeegFCvKTGt/SMTwe5 PGigQsdyNl0ugs8gqA2LIEqQOez0RthrWjRp+VDBMdkxXSb9O8gzlGISn A==; X-CSE-ConnectionGUID: qTZQJrFPQju2zsd4VBckOA== X-CSE-MsgGUID: BM4OhN3/QCGz4NzIxfJqNA== X-IronPort-AV: E=McAfee;i="6700,10204,11158"; a="21172140" X-IronPort-AV: E=Sophos;i="6.09,274,1716274800"; d="scan'208";a="21172140" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Aug 2024 15:24:19 -0700 X-CSE-ConnectionGUID: xA9RCXOqQ96yXN8YSIP2aQ== X-CSE-MsgGUID: xJKSzS0BQNqlJdF/zHcszw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,274,1716274800"; d="scan'208";a="80601317" Received: from tassilo.jf.intel.com (HELO tassilo) ([10.54.38.190]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Aug 2024 15:24:19 -0700 Date: Thu, 8 Aug 2024 15:24:17 -0700 From: Andi Kleen To: Andrii Nakryiko Cc: bpf@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, adobriyan@gmail.com, shakeel.butt@linux.dev, hannes@cmpxchg.org, osandov@osandov.com, song@kernel.org, jannh@google.com, linux-fsdevel@vger.kernel.org, willy@infradead.org, stable@vger.kernel.org Subject: Re: [PATCH v4 bpf-next 01/10] lib/buildid: harden build ID parsing logic Message-ID: References: <20240807234029.456316-1-andrii@kernel.org> <20240807234029.456316-2-andrii@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240807234029.456316-2-andrii@kernel.org> X-Rspam-User: X-Rspamd-Queue-Id: 6343C140017 X-Rspamd-Server: rspam01 X-Stat-Signature: 1wnujcm9sds56ieo144wgamjim1qxu5b X-HE-Tag: 1723155861-926177 X-HE-Meta: U2FsdGVkX19tYBmQ9NoHM4GBUUfB8cJjt1FiOulS2Z6EmpBfMsmMEYBtxx85Kjp0lQpc67QFlOX0MK6yEp1YVzNDUnt51o06gB1mk7uIwDCnK3EGBddp4Zz0himJ2uJTBigZBctcNkyOdpzpe9ovp4qIcgkWKP9mEjcmtojm5RN3KEEgCKn6OVbR+0bN648DzI24rrxK2SbzznUQ0o4FkK/2X2lUUImbnkwbZKJAQ4zTWjyORSqMHG92V6kU9W0n60N4oREB23AWfVgItxD4/ZxOFu3s3g3+M8IhUfRc5Q6MXJHODJwo1DLS8uBPOTnYPpRaoXLviJTvo6bdHXJSyo9B+cGFPgzwejD+J/as1ZU6NQfNwFXdTLRVXNRnZREw4N5W/AbWwEzkSzUl6u9I48TEbFsZO6qDTf5nnHrSCs8H98nfH2qn6krGWebzg2fVrlvRt9jWnWMK8NgFMehcFnaV0uSFjK2y8C5aH01WId0Asw/Z8pJsXm7vWW6AmnEkaDhDEuekuaBLFQG8dHZWC0GRG2oD9hOVCXc9wqof47ueM87RMdGdT3/bn5s3aZMpJXRvd1ema3pLXQe43cvMwC6PPoyMytBbgK/Nsrg6RYfQw+3F04wTHdcv5VpmNPhGPkiY4XOTXF2mteNqOH8ZP9gkmoyP4P4sZPdkopHGLut3qYLfqE+S9kiJ4Zznb6QM/45tFAyMn8apz7qSJKzMEz7PO0+JQl1tIe2/w0UAC2x33oUX3Qe+QXBcp9G/G0G0DMNsuoxMR94fJCxinEgBMCsb+KX0pkBkeQPO9qkUjQsltBB58Wctl6Du67ofu54DH81LTuRaH7FmQFLAalOxSBL5PpIwv/e1RQrHe7TSC18oaZn53qZ/EhEMh+MDhgUDaKpqYhkWgidxNOsKdMBE0+WjwEmC4h0MakjS9LukG8EUi+9zj7avAqfJtb4lLITOVrp77XQJ/SR/AfMrM5E wYb+FtXT bX1bof91lHiIKgegaxJPt4SehHEtpEj95PA+/YAzrlrdOvhX2sDpBj8RA6WHt6IpNCHllFkbdxFcwetSAYgFPnqZWIxzgMIAFCwH+AKgjC6y+991p79nwkYr/WpIocByWC5qtL3L237CPgDUypBERte5FYuuW/r6zwz7u X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > + name_sz = READ_ONCE(nhdr->n_namesz); > + desc_sz = READ_ONCE(nhdr->n_descsz); > + new_offs = note_offs + sizeof(Elf32_Nhdr) + ALIGN(name_sz, 4) + ALIGN(desc_sz, 4); Don't you need to check the name_sz and desc_sz overflows separately? Otherwise name_sz could be ~0 and desc_sz small (or reversed) and the check below wouldn't trigger, but still bad things could happen. > + if (new_offs <= note_offs /* overflow */ || new_offs > note_size) > + break; -Andi