From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30B03C52D73 for ; Thu, 8 Aug 2024 21:12:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB2F76B008C; Thu, 8 Aug 2024 17:12:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B62526B0092; Thu, 8 Aug 2024 17:12:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A03666B0095; Thu, 8 Aug 2024 17:12:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8039D6B008C for ; Thu, 8 Aug 2024 17:12:28 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 204D814011C for ; Thu, 8 Aug 2024 21:12:28 +0000 (UTC) X-FDA: 82430326776.22.13ED8B9 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by imf04.hostedemail.com (Postfix) with ESMTP id 3436240009 for ; Thu, 8 Aug 2024 21:12:24 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=jlx850jW; spf=pass (imf04.hostedemail.com: domain of alison.schofield@intel.com designates 198.175.65.10 as permitted sender) smtp.mailfrom=alison.schofield@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723151536; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4DKrjinzTOYhOeYV/8Bzs40FonJQxO9rLzZQ8NAvbNU=; b=haeVcF3yzYQe/EBqa3Brn6iNmiQFdc3nsLRkL9DgLU5plH3Eqm3I1yep/K2aGpHO4LYWkW 2KhAaRabFnWeS+1cTshxrzUKMjcz6htP5b0jBdwbhMUatpaoEKwfwvjXYcpP1Hv8lQCCpA pClW+I/o15GztmGHsIq+9fc5teLCdpc= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=jlx850jW; spf=pass (imf04.hostedemail.com: domain of alison.schofield@intel.com designates 198.175.65.10 as permitted sender) smtp.mailfrom=alison.schofield@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723151536; a=rsa-sha256; cv=none; b=FTm/cal1+uNA9d+Gndw40Q4mFjRoTgaWxLFZjimpdbPfkzvoCbXRkEME6oD/tFvm4/DBPX +azHKa5eAjiXcLHMnf/NSrQLqCPvig29k8iJmhmPDPFkVWByai4iK/EP6C1uzKK4hJyGdB zHOd45ijO77qIAavfcClyAyDwVrctt8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1723151546; x=1754687546; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=Vap3umje8kcXqhdxoUlDY+Pkv0QLS2Akuf9ccxkaa/o=; b=jlx850jWZfZ1qCXiRPD4xbGmwdMpe3Mj+5Di9csIbyBCmScljgqRdKas 2bNDRIxeInhzm7yy03z7+us2YbBlR7UKCqT0u89dUlx0bBudDfGTM1ojZ XDTJq4j6ez8D8WR7eshZBlwD/nNx7BWovKAVtKabgWUQjXJF1epgfV3yr Vm8SXgXf7PfrDLGUdFuYRmSZngFP5gWywqm90f/vYCSrwRFujn1Xq5LyS C/Tek+THTv8TDDRcdg+oBvbKRINYb6qMw4qJmN1UIEC1pX+sLdG1kU6WV V2XFGz2WD5I399wTLvTiOrRNH0g+H881f3zhR0nZpG/jwnRsa6e89ifHj w==; X-CSE-ConnectionGUID: SGkVvJORSBCay5Hu8qV6rA== X-CSE-MsgGUID: ZT3b5p6LQAqjEltreSTJtQ== X-IronPort-AV: E=McAfee;i="6700,10204,11158"; a="38763732" X-IronPort-AV: E=Sophos;i="6.09,274,1716274800"; d="scan'208";a="38763732" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Aug 2024 14:12:24 -0700 X-CSE-ConnectionGUID: BzDutUOWSyCFD7hfEA2EIQ== X-CSE-MsgGUID: mEWhHyCeRpm29qPnsqD+5A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,274,1716274800"; d="scan'208";a="62307790" Received: from aschofie-mobl2.amr.corp.intel.com (HELO aschofie-mobl2) ([10.209.12.215]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Aug 2024 14:12:23 -0700 Date: Thu, 8 Aug 2024 14:12:21 -0700 From: Alison Schofield To: Pasha Tatashin Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-cxl@vger.kernel.org, cerasuolodomenico@gmail.com, hannes@cmpxchg.org, j.granados@samsung.com, lizhijian@fujitsu.com, muchun.song@linux.dev, nphamcs@gmail.com, rientjes@google.com, rppt@kernel.org, souravpanda@google.com, vbabka@suse.cz, willy@infradead.org, dan.j.williams@intel.com, yi.zhang@redhat.com, david@redhat.com, yosryahmed@google.com Subject: Re: [PATCH v3 4/4] mm: don't account memmap per-node Message-ID: References: <20240808154237.220029-1-pasha.tatashin@soleen.com> <20240808154237.220029-5-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Stat-Signature: 6u89pqwakjf5hor4kpobdf8ye478awta X-Rspamd-Queue-Id: 3436240009 X-Rspamd-Server: rspam11 X-HE-Tag: 1723151544-313134 X-HE-Meta: U2FsdGVkX19b9rRI2zbFJc8Wp7Qbf+MhV63KVjGstaKjD3w2oyf1tfox5LDgCCn7Ek/Y1QuxApJCJdMrih2g9kCusX++f8gpxW8kcQFVuu/wlMlXTlP7c96IGrsietgk5RpIbEeauSPJ/qjkKPhuL8pSDvHce8RwjsZhnQdOt+lloi73orVs9tLgcX6qclBtdjRTvs8dCExEnbTzXh+MQZyPqBUJGLXoOaa83JHff/BeMV1iq9f5tNU/WCckoGfJ+eT2agPXrwltjf95nV6ex9g8B4vK85R6ZuDR07+kJGMGJbUgkrMcsXJ15Yu9mvl8n8mFmyhia2WREGIwB+3o59JAHkIAmghP5MxLecuZLvvVRWWnxJNoL1HmayMW9BIcZMtrJhxbmV5GaV9CZ8JJeenyg2KGvVcuoK9xJO447symPTpsJQoH3hgzEOV0YfPzsu6d59SiDxIQ+03zZNpGdSYaA6dT0HD6iLfDICrAHbzNxtxv4MP4mhlPvQfhvzQpGUhHDgKLocO4aPak1YcQjziSxka3lb5SZHNVgz2KHA3i/OVh68fJ5ZZsiAMqXEu51NeCUE3RA72cDohXmpTq++kl1t3LjioKGYo28l+CfEZJng0D4kbLycxhQFXKzUGU4ThDah3Y/wLz2ydm1krqmIteI9+hyjP5neIwZTpGZyIT0UyuqgyCbCdp1FdBXwFimadRy1se3Di5o4UqBlcg6y83eJOpGQXkucUaWDRi/01qNnI+FOBLu933ig2TQK4wgD6tDArbcLELQPxTTNfXgfJB03Eb6xcuBp8cANxYZq7FuXF/tzt6IF6iPy8d4tVI25wjcy8pylMfX7BwYZqlT5A7PIkVvEpu/x3NdxZAuD9Mp7izAxAGzFFWI2AdjrPX3yD7aJZ2VQwj4XTDxIy9NtaO6f4y4hCrmITgzlq0EKcRE+kSfcyrn6whHUrPLCRAwTtUzzHuzARhcY+R+8h B2+YnTYO CpyHJ8uvFNf5Q7OaGN3B+AZ8SXlTlz6HbZdot6qo8lu7M3P4/dEutUL5v6D/9emQGkyu/XjiVUqbsLHUtpnHGx0zPTCC5ga1q3U4SFbQg/LdgO/+2e8uZOqA60BG86AWhV6xyUgaI10mHNGu1ho5aWe2vnHBRCz5u1CAmErVuLsCUbBl3X5aJ2De2MyvIBgUAJ0M+/BC+LWbjJs/a/OgSmGjLtthOiv8ya6Ah X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 08, 2024 at 03:05:32PM -0400, Pasha Tatashin wrote: > On Thu, Aug 8, 2024 at 2:55 PM Alison Schofield > wrote: > > > > On Thu, Aug 08, 2024 at 03:42:37PM +0000, Pasha Tatashin wrote: > > > Currently, when memory is hot-plugged or hot-removed the accounting is > > > done based on the assumption that memmap is allocated from the same node > > > as the hot-plugged/hot-removed memory, which is not always the case. > > > > > > In addition, there are challenges with keeping the node id of the memory > > > that is being remove to the time when memmap accounting is actually > > > performed: since this is done after remove_pfn_range_from_zone(), and > > > also after remove_memory_block_devices(). Meaning that we cannot use > > > pgdat nor walking though memblocks to get the nid. > > > > > > > How about directly include the failing cases and user visible impacts as > > reported in the Tags appended below. > > Do you mean adding panic backtraces or repro steps to the commit log? Yes. Perhaps abbreviated but something that makes the connection, like this: ndctl users reported a GPF when trying to destroy a namespace: # ndctl destroy-namespace all -r all -f Segmentation fault dmesg: [] Oops: general protection fault, probably for non-canonical address 0xdffffc0000005650: 0000 [#1] PREEMPT SMP KASAN PTI [] KASAN: probably user-memory-access in range [0x000000000002b280-0x000000000002b287] [] CPU: 26 UID: 0 PID: 1868 Comm: ndctl Not tainted 6.11.0-rc1 #1 [] Hardware name: Dell Inc. PowerEdge R640/08HT8T, BIOS 2.20.1 09/13/2023 [] RIP: 0010:mod_node_page_state+0x2a/0x110 cxl-test users report a GPF when trying to unload the test module: # modrpobe -r cxl-test dmesg [] BUG: unable to handle page fault for address: 0000000000004200 [] #PF: supervisor read access in kernel mode [] #PF: error_code(0x0000) - not-present page [] PGD 0 P4D 0 [] Oops: Oops: 0000 [#1] PREEMPT SMP PTI [] CPU: 0 UID: 0 PID: 1076 Comm: modprobe Tainted: G O N 6.11.0-rc1 #197 [] Tainted: [O]=OOT_MODULE, [N]=TEST [] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 0.0.0 02/06/2015 [] RIP: 0010:mod_node_page_state+0x6/0x90