From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1ED56C3DA4A for ; Thu, 8 Aug 2024 15:49:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B13A46B0105; Thu, 8 Aug 2024 11:49:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A9B826B0106; Thu, 8 Aug 2024 11:49:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8EE816B0107; Thu, 8 Aug 2024 11:49:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6E8436B0105 for ; Thu, 8 Aug 2024 11:49:47 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 210411A1551 for ; Thu, 8 Aug 2024 15:49:47 +0000 (UTC) X-FDA: 82429513614.11.7D601FA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id B5756A0009 for ; Thu, 8 Aug 2024 15:49:43 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=D70cgaII; spf=pass (imf15.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723132119; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c69S7nSyvekSR7azb7NgbUlVdfdg4AICMxtsy48mxj8=; b=TlfVRhCt1HnuX6gKDtg4ziuivWi1XrWxWKM2mpFBB6tfVEC4KaHJgwlissNc72LFVsje7U Z8FdMwDKYbgubIK11b+ji9bL53/WxAr2BOC0AbSt2r7uOpkvcIIdfpb9OvK3aov6/pBmPM LhioV/fzOa1S/gNBpv/b0C8XguCGJdI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723132119; a=rsa-sha256; cv=none; b=nc9rwmXfdfFFp5s/xFzXA6iWKSPITYwW3Hbqb+J3tOj/yCoNQE5xIlWVgyfd8Dr1OVuL22 Ptyw+yetNarXuagMFFUx2IYI5rSYYSwgxVDFTmMsryRzXWbmzvvKlmoLyAAwu7Oedm1xAL Aq+WTHW5M/ogGP7xexNG9omzGgq0sws= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=D70cgaII; spf=pass (imf15.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723132183; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=c69S7nSyvekSR7azb7NgbUlVdfdg4AICMxtsy48mxj8=; b=D70cgaII8XuaXmxLTxmUvi8NcVLoWqFSWqG27Kg2nka2aS/rtt/G0/WbdoGKcbbsv24iJf qHV85TPfO7+2WG3GHUrqZVkcRiar4H94kfqXSfjscvXT/lXQU3mpdjM3U/q6rIRpDu8cvf 5k7Ksls7PU/8lQ4FncBDk+sgETvlkD0= Received: from mail-ot1-f71.google.com (mail-ot1-f71.google.com [209.85.210.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-139-rrJGxU_ZMrOCKqeki7dOGA-1; Thu, 08 Aug 2024 11:49:41 -0400 X-MC-Unique: rrJGxU_ZMrOCKqeki7dOGA-1 Received: by mail-ot1-f71.google.com with SMTP id 46e09a7af769-70961355e75so81285a34.0 for ; Thu, 08 Aug 2024 08:49:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723132180; x=1723736980; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=c69S7nSyvekSR7azb7NgbUlVdfdg4AICMxtsy48mxj8=; b=As6bx57wQWKkJOKnqbTuARUJdp1tNFIKrGRX24bn6QZa3+mkIM2Yih1NuEGusv2JGd gwuneOYwcf9lXl0ZqVgtUHQb+Ho+7zQszIAoc8v4TgrOf83kr9kkKWate2C/PV/L6lTh 03IE8d64zlS+9Cfw/5cmv2BkQLFg5xBL6N1eBDweNIj2k7uODEy5lb80+id9ifc96vSS eHcx/lSH9enwUF4XmuZFarq5WX9KCUKX0OVVcBXhZKAU/Wxg9yuQUWwS4iUaZB6Q0Xlc LZNdzLk9D+WPveHCFw4vnNbtptkYk6QEjypM1PEZSt+R+qUZpuR+6TYxoG0VR5b+QFhb mVxQ== X-Forwarded-Encrypted: i=1; AJvYcCX83COrVn/5TCirKw7g9dXmGKNUsn5PNBDLOhQZ80Ui1QE31nVpbqrqx0fIpxUFAOmQ5SsGdV1aXg==@kvack.org X-Gm-Message-State: AOJu0Yww9Zw+Hc5G/ReF3Gh9I/xp+NdYNsCXj9/fOhVk8x0UfA9quPhk GVfhiKpaldtNIEm38cV+8jIzMUS/h+01XA6LJcILpGk/4+CnibHT83+XWxUMh+dLEABUqrkLv/S TMfCbE3OHim6SfJ4uuWQV7hKnekPMvU9FV1H2FfvWfTz2FtpV X-Received: by 2002:a05:6870:51c7:b0:260:ccfd:b270 with SMTP id 586e51a60fabf-26c58abb4bbmr2302fac.7.1723132180118; Thu, 08 Aug 2024 08:49:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG2v/RUodTRobMhQbY3FEHNXh4Gs9MwrhEqdXluF8KQ8hMZ3OnAtry4aRQGnOXF4AoW7eM3Og== X-Received: by 2002:a05:6870:51c7:b0:260:ccfd:b270 with SMTP id 586e51a60fabf-26c58abb4bbmr2291fac.7.1723132179728; Thu, 08 Aug 2024 08:49:39 -0700 (PDT) Received: from x1n (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7a3785d0b3fsm171313085a.19.2024.08.08.08.49.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Aug 2024 08:49:39 -0700 (PDT) Date: Thu, 8 Aug 2024 11:49:35 -0400 From: Peter Xu To: Thomas Gleixner Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, "Aneesh Kumar K . V" , Michael Ellerman , Oscar Salvador , Dan Williams , James Houghton , Matthew Wilcox , Nicholas Piggin , Rik van Riel , Dave Jiang , Andrew Morton , x86@kernel.org, Ingo Molnar , Rick P Edgecombe , "Kirill A . Shutemov" , linuxppc-dev@lists.ozlabs.org, Mel Gorman , Hugh Dickins , Borislav Petkov , David Hildenbrand , Vlastimil Babka , Dave Hansen , Christophe Leroy , Huang Ying Subject: Re: [PATCH v4 5/7] mm/x86: arch_check_zapped_pud() Message-ID: References: <20240807194812.819412-1-peterx@redhat.com> <20240807194812.819412-6-peterx@redhat.com> <878qx80xy8.ffs@tglx> MIME-Version: 1.0 In-Reply-To: <878qx80xy8.ffs@tglx> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Stat-Signature: q13moco13nymhr7oqbf41pordgckroco X-Rspamd-Queue-Id: B5756A0009 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1723132183-396567 X-HE-Meta: U2FsdGVkX19k0LIlUAkdMjha6ClOeVyI6yO++SN5HCFoAjI9Pf2H9ATn+a6g5khKwQpU34YPDgBcIYyUR3JWDTigtqamzEbVOTo+YHZs98K6C+c0aVkW0GgvIpK9vM+QHhJRJcxT6rqdlvGqxKZEmkr4PkZWKVkJbZZJVsalq0Z3PljIqim6jk0wSKKLKcvrADgbE0IEGIWdycWGxwlLKYdMeo9kMYrp63ftImk6ObpAdsyLLJnk0tM8++GvihNvJU/OmXyF/Ku2m8khMTfwSzmHNS5ShOizW//jyrNYqUhoteqiZRaDbu9dTr2nA049+k2TpCW2F2U0EttgVUNimTHSDNldf1hqaKWBuzS0t2fx03i1Yha8974Z8DdtMM29ZKqv2/29r3iKVzPfwKLj0SeZZIMMYXCDN0RTqVRir74gdkXYteVsi8DfLQuIOnenE/zLGJ540LD0gGkJ6d4bTuRU+DEScGyeJQjYrYKgtV/3hpFSDd4S1pM1RAWQPz6B5miFyDJ6wJkxQPBHiZMSZUdGWR+H33Uw5YXcbhEuqBs9tYMPu5polC/GjPfjy26k1ZuyBfVIYroHnNsqENz03jPY32sNMhqBkULuRlC84lUtqgp8VZEq53vuouEyXOJ6yKOcD9unqO2qeNnKkFnvCFl2LzsVK3LrpvNB6HUmZoq3vVfP6PXx0mv6OK/WzrV2ud/MLATiDD0b/RbKuKCzyyZCBa1ftddpDh5sjwXziPqQB0r17s14zKVtMxUL8qQCDsb2DE/k7HCqbo11PEC4gvgmBT04U3qmzhx1YN/wABtRb7oXC4mq9mD7Pr0IOibFE7camEuSNw6gdk7RdZsyBzpwKQvylkvcF1cXHrwcyuaw9UNlU5+fyhcUUKqQofrv7Zqnyb2h3m/m3kf2TfhOFd2lwl9nCA3ykJF5m464l6/yC+nHsM6U/znElMXn7jaOnjvo4UpPErxQ+76UR81 NLoe8KeW 7jm0ePHxRvp+41PBZ2mwxcXgWTMohHHiV1iJSDhZhpo7jBxf0CsFde7YS31RHOBaOPqvgjbDYS6lUTXA9p3s6MxUWVEDBgNDyBvtDOwPASRDRZevO/2WXEq/N6Gpcb+yOX82qEsHPDI+qkZ85GgaMxzeo+Hj9YwnEin4Bvh8m/pXTwCvIegeZHnzJBiJWt5DzCKN0L+wQjc6v2lKvcvIgspcpXsoCDXOushQaVup7tQy3NLU5zHYmlCdN0lI+kIH3WTO8YhccdzPH/CA/8iTwMt9HL+fuj/YauM5SjIcV4+RQY4Si1f9T8RGye0pljoQQ6C8S8PVUqqk/LkuCHQ4Fcbz87QSBeyJ8UUjdnMgsOXpq1j/sH/xYJmwputXva8164UgBYup9TmMOhnUyCUMsU8kT5Jbi1+Fl+oLr7qw5zDNwtB6EmKs2ArSHKssjRl5pml46k5UoORxb7zloFPH2JTb6ZIAPYv6ybX9ykYJLICU/B3nIBmkn9l1q0k1HKejEvaepN6e5g6dTalo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 08, 2024 at 12:28:47AM +0200, Thomas Gleixner wrote: > On Wed, Aug 07 2024 at 15:48, Peter Xu wrote: > > > Subject: mm/x86: arch_check_zapped_pud() > > Is not a proper subject line. It clearly lacks a verb. > > Subject: mm/x86: Implement arch_check_zapped_pud() > > > > Introduce arch_check_zapped_pud() to sanity check shadow stack on PUD zaps. > > It has the same logic of the PMD helper. > > s/of/as/ Will fix above two. > > > + > > +void arch_check_zapped_pud(struct vm_area_struct *vma, pud_t pud) > > +{ > > + /* See note in arch_check_zapped_pte() */ > > + VM_WARN_ON_ONCE(!(vma->vm_flags & VM_SHADOW_STACK) && > > + pud_shstk(pud)); > > Please get rid of the line break. You have 100 characters. Coding-style.rst still tells me 80 here: The preferred limit on the length of a single line is 80 columns. Statements longer than 80 columns should be broken into sensible chunks, unless exceeding 80 columns significantly increases readability and does not hide information. Maybe this just changed very recently so even not in mm-unstable? I'll fix the two line-wrap in this patch anyway, as I figured these two cases even didn't hit 80.. probably because I used fill-column=75 locally.. But still I'll probably need to figure it out for other spots. Please help me to justify. > > > +} > > diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h > > index 2a6a3cccfc36..2289e9f7aa1b 100644 > > --- a/include/linux/pgtable.h > > +++ b/include/linux/pgtable.h > > @@ -447,6 +447,13 @@ static inline void arch_check_zapped_pmd(struct vm_area_struct *vma, > > } > > #endif > > > > +#ifndef arch_check_zapped_pud > > +static inline void arch_check_zapped_pud(struct vm_area_struct *vma, > > + pud_t pud) > > +{ > > Ditto.. > > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > > index 0024266dea0a..81c5da0708ed 100644 > > --- a/mm/huge_memory.c > > +++ b/mm/huge_memory.c > > Why is a mm change burried in a patch which is named mm/x86? > > It's clearly documented that core changes with the generic fallback come > in one patch and the architecture override in a separate one afterwards. > > Do we write documentation just for the sake of writing it? Hmm if that's the rule, in practise I bet many patches are violating that rule that we merged and whatever patches I used to read.. but I see now, I'll break this patch into two. Personally I'd really still prefer it to be one patch especially when it's only implemented in x86, then I copy x86+mm maintainers all here and it explains why it's there. So please let me know if you think it may still make sense to keep this patch as-is, or I'll split by default. Thanks, -- Peter Xu