From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44FF1C52D71 for ; Thu, 8 Aug 2024 17:19:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 89A4C6B0093; Thu, 8 Aug 2024 13:19:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 847776B0095; Thu, 8 Aug 2024 13:19:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7101B6B0096; Thu, 8 Aug 2024 13:19:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 50D296B0093 for ; Thu, 8 Aug 2024 13:19:09 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 014C2A7FC4 for ; Thu, 8 Aug 2024 17:19:08 +0000 (UTC) X-FDA: 82429738818.13.EF091A5 Received: from mail-oo1-f48.google.com (mail-oo1-f48.google.com [209.85.161.48]) by imf05.hostedemail.com (Postfix) with ESMTP id 1EF2110001A for ; Thu, 8 Aug 2024 17:19:06 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WPIfdNZ+; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.161.48 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723137474; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VZz7vSeeoaz6dXkhrDR8IE/3/HpRTkZcMQ2gtBBIQIM=; b=tj/ZBFfaLevIxrt/DpvAaTSTU6kagRw4/SWDbM5nd/D7vaqdrnk3ciq/UVq+y7m7E3epN/ oVKLZd8rt4ufOyXwG1WfTrRxdDD6iaKiDIo1wx+rUjGQy6/Du0zES6VONh+L+MdKftTojk d0JgO9yEiLoW3U7WJOz5kHthhLKCAFE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723137474; a=rsa-sha256; cv=none; b=v90hPrGY+PnHUp1bYNBmFYqTqDkB82PdPajnyACUV1q2jJJAOBZuYymaWlpKBU01dCXUyY f0RxMW7hIWvoQK4yVmgteK5f/hgUHjj99NWzvKtsXiPVZhiz2+iXsxWNNSprk5baXMfmYu IGpnv/3JzYHPkDPU8o6OF6W72rVAioo= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WPIfdNZ+; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.161.48 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com Received: by mail-oo1-f48.google.com with SMTP id 006d021491bc7-5c661e75ff6so752205eaf.2 for ; Thu, 08 Aug 2024 10:19:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723137546; x=1723742346; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=VZz7vSeeoaz6dXkhrDR8IE/3/HpRTkZcMQ2gtBBIQIM=; b=WPIfdNZ+p58kvv3RTpdFxB10kP4yZfY7lWP9ZuEkIuyaRqEW3Bnn/oUuLMuEKoz1Zx Hl/DMrDk/IiAkBW15gqnB/Fl7rIRpFet093hRMX76hmJTFkadF/SfiwrDenKTp/48vKV iZEcfa/63/pIre4Hy6b0YMKpsFFw9aqe0maMkCEdscT01LDbzEWgrEUqYaFjVgVLn9o6 u3h8TpNP6HFKB6irbAgMeMSrD6TubiuhGWN9M640peLelF/QtbuClp+fgpQwkTlsxN+Z Bz2B9wmjvjCCWonCkcvB99NuOv6Sa7AN2UqWqq1AYUOzIZrg6CSwi0x9uYflxoXmKJnw TzRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723137546; x=1723742346; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VZz7vSeeoaz6dXkhrDR8IE/3/HpRTkZcMQ2gtBBIQIM=; b=wjqJMjjqlQ7l8IDl7hz7BCozQSPE6KIcVWPbVN7QZnAq0gjP7Ll2A4L/6XzNDKqNbh AWf4As8aIUvsF8rKxNShJTnoJesA3bsyOz3Dt5f3PYyJagWh7xdNU0n7/BxYR+a9/pX8 H5qmQUD4ZpuiXZzdOsqX9oT6biczFALE1in5QdYu5bme/mdejECiPATLLjwGbFxQNKhG OiCUONqFlIjztfLoD2ibOfa5U3lsLrjT4ihLJjO+mJvI3FPZeeUxbp3mljMikhZ2mk6p RBg0W44N6PQELQ+qlWOMg7BleKNLXZZ6eSnyQ0yvEp1F8JmItXCxViAuhfML5IZLnbC3 cC8Q== X-Forwarded-Encrypted: i=1; AJvYcCXD5y9gvOHa+afBGnxW5ShQCl5UJxS4uY7skNbbDSgo7hKFi0KlY9in3tTtMlDDvr4BAOIzJOWQm17ZN8Ski08j70Q= X-Gm-Message-State: AOJu0YxcuGsKMltxC8RvStH0pk2BSj0dwSEbssAnrarZJoIeBXxKU9Ly kCrwBEF99F8UPoIQjR4+eHCEikDPkYRW1MEkQXKLk9/NV4kMDStL X-Google-Smtp-Source: AGHT+IGpkO6uGbdUBwRJw5OQikqUXqUieR2xBW7JDvXvfmFNF5jiwvkNbNawxiiuo57CSI6LWluFFg== X-Received: by 2002:a05:6358:5907:b0:1ac:f08a:c701 with SMTP id e5c5f4694b2df-1b15ce81232mr337774855d.0.1723137545971; Thu, 08 Aug 2024 10:19:05 -0700 (PDT) Received: from fan ([2601:646:8f03:9fee:1fa7:f643:a5d2:2c9c]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7b7654bf910sm9983747a12.79.2024.08.08.10.19.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Aug 2024 10:19:05 -0700 (PDT) From: Fan Ni X-Google-Original-From: Fan Ni Date: Thu, 8 Aug 2024 10:19:02 -0700 To: Pasha Tatashin Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-cxl@vger.kernel.org, cerasuolodomenico@gmail.com, hannes@cmpxchg.org, j.granados@samsung.com, lizhijian@fujitsu.com, muchun.song@linux.dev, nphamcs@gmail.com, rientjes@google.com, rppt@kernel.org, souravpanda@google.com, vbabka@suse.cz, willy@infradead.org, dan.j.williams@intel.com, yi.zhang@redhat.com, alison.schofield@intel.com, david@redhat.com, yosryahmed@google.com Subject: Re: [PATCH v3 2/4] mm: don't account memmap on failure Message-ID: References: <20240808154237.220029-1-pasha.tatashin@soleen.com> <20240808154237.220029-3-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240808154237.220029-3-pasha.tatashin@soleen.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 1EF2110001A X-Stat-Signature: qr6nsrfugjrbfto8zs8myxj81z68ex6y X-Rspam-User: X-HE-Tag: 1723137546-820235 X-HE-Meta: U2FsdGVkX18hm0+olaYbB75dfs+zHYZo2yjO/FlPdJYYxv/JX4ASKrE1kF3U8B+8bmVe+W1kzxdFEudLcsFA48/Zi8qtDsm/OZqawyLCGOxuhfZ8PbUaevaHInwfa5tQHcZhYz7622dp3DmzBwH3E8QqBeRCuo9hJS0bXgt4ZqdXIjfQnq5Q/lE/8GHTWNzaCJ77/OD+LZeBOqv1XLW56xx5eiomsooiDf1ScKszxZ7HMh/eZyUEVHBK7ONY/CNMz3MSkKCig74iONaU1UAhZjoX5KTbdBnRloCPs7Mb8BbiaokonDMVrJOoDSBeZMcK0TEyaii5oQfJxrZe+/mksPGu4lYOa9/PUJWkYP1A38ZF+Tz4ti7uiqSajq6DgPct3M1JmW8cwiYweH110g9+700Cx35wKzPidli3Ulj3Hj1XaqBfB9h+MQJR+mSM32PSaqmJRtrmFMbVK82VQfwPdPX4A7QzkpDiZAZil1SiOlxzhYAq/mYq31u7W/DB/rYhbVlHnFMeBlcwtH9yEY9fc0OtWZgo4kTONqRzYA0xTe5flPYeh1Ucg65/8Y/xIhryUwPCPPpQSLgHvs8/tKj6RpivhzcgY/6qrQcVKdScYyHezofymlTLpAK5D+69UtFYlfpbKKiVwNJvzlm75RqH3hltVcl/eeEATvNERDLkiZyxiANsXdYuCaT42B4v1OPWJf1VQWbaxnXXmd8S78AI4nDgagsseQSZu5j6CJ7JEkm33Wc26kUwD+ZRP2sUPEqczxwE9LKy5SSycjLy6RbH0x1lpNzz8/i2zj8BsMcJJDZSI7Bj7ecezcL6gOA4xoQUa9xX6hu5gB5REHMYrsGbOQb+9Ke90TUM0TZKK+Iz9FJyTReowb87I8tRRlL7+OXyWuIvszDabKQWnGP4gditzfQliceEBb7gHFHQ7oBnXV2LLvmkBx0IV9CUouaItbmZgzFnlkb7kOFUeXSKGpd 9sN6xRlN 2uZk2MKi9IeqydWK6W1UgZRDJTFddTuPQ79hQbVtH56umsexCYY9QhVX15g2A0amC84xJbXmzwaWD0ymRI7pFMYBjeWwpolV4pqD3Bl0V+dp+yVC/LoW40xaH2k+lV46odJQg8iS62Bma+seEi51G8MruLLpom2tOhJzPO01EvT01SL+Il6RxQip79XPXHVKY2huuoiqN+59jBUdiad5mtg5EbT1qSeg3NsZrzMncft3bkMlCBSAGsvYK6/o/3AXUvL9D8ZmLs/5LSn5XZ5LfLWARhYRqnEXFERsTnliGWHxxbnz/FKkCqwDV/HDPFVP1GUZ45awPrN4sfJRU0RKRkmhYk/0hXTOUT7AFYHlt0tN/6cT5AY0H9551M7D9nYrtv1+6hKke0k0Xz0QrWqwp+FXEDRKGL51HDumsnJu0YGNuT67Tw/FQ6v75OtsUcN1ZJs6Wj4293VV1nNm27gdTkuZ79keJ0vTsSJJOUFvjiM0vyhWcxZ3evlEhqGx74ecDlYkwt+YiShF1JZ4Oc7eoYyg/Pg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000115, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 08, 2024 at 03:42:35PM +0000, Pasha Tatashin wrote: > When in alloc_vmemmap_page_list() memmap is failed to allocate, do > not account, the memory is going to be release at the function exit. > > Fixes: 15995a352474 ("mm: report per-page metadata information") > Signed-off-by: Pasha Tatashin > --- Reviewed-by: Fan Ni > mm/hugetlb_vmemmap.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c > index fa83a7b38199..70027869d844 100644 > --- a/mm/hugetlb_vmemmap.c > +++ b/mm/hugetlb_vmemmap.c > @@ -392,13 +392,10 @@ static int alloc_vmemmap_page_list(unsigned long start, unsigned long end, > > for (i = 0; i < nr_pages; i++) { > page = alloc_pages_node(nid, gfp_mask, 0); > - if (!page) { > - mod_node_page_state(NODE_DATA(nid), NR_MEMMAP, i); > + if (!page) > goto out; > - } > list_add(&page->lru, list); > } > - > mod_node_page_state(NODE_DATA(nid), NR_MEMMAP, nr_pages); > > return 0; > -- > 2.46.0.76.ge559c4bf1a-goog >