From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D965C52D71 for ; Tue, 6 Aug 2024 15:53:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA9766B0089; Tue, 6 Aug 2024 11:53:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B59876B008A; Tue, 6 Aug 2024 11:53:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A20B56B008C; Tue, 6 Aug 2024 11:53:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 80B426B0089 for ; Tue, 6 Aug 2024 11:53:21 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2585DA5DE8 for ; Tue, 6 Aug 2024 15:53:21 +0000 (UTC) X-FDA: 82422265002.12.52D79A0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf29.hostedemail.com (Postfix) with ESMTP id ED7AB120030 for ; Tue, 6 Aug 2024 15:53:18 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="gj+nG/OG"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of juri.lelli@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=juri.lelli@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722959548; a=rsa-sha256; cv=none; b=2FoyLLogonwUUIZjaCqOD16rRy3zJd9kqO+fapzR96oY1uPTK68BLr0KIvGYrluNrFd4QW AH90EeVQLb7TS0lO/obJXhx/dRhd+6TJNcbDfw3o6abC6zP+M01JDkJ0VSjLwwUH/ytabA xXjvDSNHH1Z+idVoL3Pvkgjwcdn8y+8= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="gj+nG/OG"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of juri.lelli@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=juri.lelli@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722959548; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9UD0Jw05zo3Zj1VI2tYqdujVE+E+8rHDPdQz+qajNaQ=; b=qCsuE5u187XD9kP/xw772Gm3cH7lZ/6kAf66bOQn/uZsAOnrWdOK+IygY1cQSwmTyeiU0e tztCJ6oDUKHQcAyRRMTWVkPICTAzwCA+3uj3gCppqBqk6QPsJECUj8jyqX1ZrXDDsLvakV dCXXwnFvCE7gFRddzqFQ+2NNGwDhALI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722959598; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9UD0Jw05zo3Zj1VI2tYqdujVE+E+8rHDPdQz+qajNaQ=; b=gj+nG/OGWiOMRskiXUhZkQ/yjBMdUJF28jN/EAlIza4geTDQ8ityCAYWa9OuV+8ca+H50b PDcKiqiwq8o4nQb5gYU/PDA0ASQJbjgSjgC79vgADcjbfT6L1hxXbPcphOR2I0QdXNTTrq 9FmGw83o1jI6BZT75FvvL4LhAOxHpDs= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-36-ATk-nVhBPTSEjRvN-8WVpw-1; Tue, 06 Aug 2024 11:53:16 -0400 X-MC-Unique: ATk-nVhBPTSEjRvN-8WVpw-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4280a39ecebso33274945e9.0 for ; Tue, 06 Aug 2024 08:53:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722959595; x=1723564395; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9UD0Jw05zo3Zj1VI2tYqdujVE+E+8rHDPdQz+qajNaQ=; b=uQcZ6WMsPB9BG6sorwParqYhr9ZOsS1GUOlKwDbkqUn2CyYkm07DqdYbq2VH9NOYq1 vZeIBWfPmqlG0ATQobF5+NrCvAYN31hwKgPDgYwQOF+89uTUFcBMLL7G+w/aVXxJzv1i u6X5BlbzwRyqGy0jmnjheMPP3ASPu2Hu2eQoLpozuOjmtSiolg1PNnOLMDgOC90vcT2D Qz1ZipDdcfldN4TqbLUgD/YrXupAhfvOcxuZVvB8obFMFCOyXlLtIeGSY3Y54nNdhe5j 0grDyWwvJs6Bi2d/f/b7n/A0m6Lgza5/9Wicp9+tXFnSs/2obS9cETa2ADuHW91SYVq1 T0oQ== X-Forwarded-Encrypted: i=1; AJvYcCUQlo73/4jxd+zafQxkVe46ul+Q4KKW+e50EoxCZN2tEFsMeGjSPt+uB34YBAL/bZB2wgSBcKm35tve0Z3K8Nt+Jlk= X-Gm-Message-State: AOJu0YxcFx26KXIGhKSfkPhTdlEgforCcCZ0KSYCiMfnYfwEcpjBhqxP MLzC3TLGTVkIhPDr1JlRB/BD9YSWDKlyMlWMIYsgmo8vyZQ8dfuDkouYdu345UpMl0GKGpFG1cL 6btINIxDu5ynlz9pZRc/bf4tbeBTFLNMWwrp8lQT2dOwPcxp6 X-Received: by 2002:a05:600c:4fd5:b0:428:837:7015 with SMTP id 5b1f17b1804b1-428e478cf83mr145934005e9.13.1722959595389; Tue, 06 Aug 2024 08:53:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEIlwrKAD+SBPIAzanZG/6Hiz6wydVc6e2RnpFoDIp1PQtlnWhPYRQw0BqE3UES07bPqhM27A== X-Received: by 2002:a05:600c:4fd5:b0:428:837:7015 with SMTP id 5b1f17b1804b1-428e478cf83mr145933785e9.13.1722959594920; Tue, 06 Aug 2024 08:53:14 -0700 (PDT) Received: from jlelli-thinkpadt14gen4.remote.csb ([151.29.159.67]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36bbd02b15csm13510432f8f.65.2024.08.06.08.53.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Aug 2024 08:53:14 -0700 (PDT) Date: Tue, 6 Aug 2024 17:53:12 +0200 From: Juri Lelli To: Waiman Long Cc: Andrew Morton , Miaohe Lin , Naoya Horiguchi , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Huang Ying , Len Brown Subject: Re: [PATCH] mm/memory-failure: Use raw_spinlock_t in struct memory_failure_cpu Message-ID: References: <20240806142535.1033323-1-longman@redhat.com> MIME-Version: 1.0 In-Reply-To: <20240806142535.1033323-1-longman@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: ED7AB120030 X-Stat-Signature: 7rqic7tj8w6zybhqtszhd5g848cbkia9 X-Rspam-User: X-HE-Tag: 1722959598-502331 X-HE-Meta: U2FsdGVkX18WjM2zXuU4w9TMRuFCGaG+Ssg2jEfEeO4hA5PuY05yG3d/OXtwmUh5LxxLqs64O1lhXQiinI+/GbAkOCgK6it+Twd4/w0istx2Tam97VX4LgVWp3nBGBVjg7jPcAefVhOCw/I3IxCHUsZ8hox7X8eg7Qn03rACTC4RLAhQvxlhuKSlD7rblFTQp9BBei3edQd0LHPIDGXOMZfo5lZTL6GnU3WPTfzEj58V1zJAxKExU0hQONVmKiX3g3tDw1j4lZZf/68DYgc+6TSTDcSBhtNOWX1C+jBJwHSnPT3RGIJdY/nKaVQppxV/0eGWMFs/YNaLUON6qA4dFc3/tyU4hslAeHkFqdA0Oo7M0FWSEq3EAHqnX30BCmFM7GiAwdlRZ+8v/aU58rUNespG4A1Up5yAfZ+ipkZAnqP9B/MiZM3OYKwPLbSdQyrXkq9XgbmJTCVALz5id8vhOeoVqJNjlaSRk0cGyrbea4VdzD2ZJa7Md111ytnuB9t+IqhLng10Q5PnIC4j/Uj/scrYyIVpAeZJkQFJZnhCgMXG+5jnyr7OEXAWK8IQaGyaaY5aorYvDD06YjZ+pcKuX21ng5+vb1wpMfoUWr1171LqC2djLukzoV0xMHJJj3gMJUsxk+bjcjgdnY/0MqcBoDDB0jCHXgA41GIOvVCnCrpViGw+EAPEROkQ8yzTC24vdGKSE3aWJLsZvpm4wFk3inOJpkxsY/sfnnRg/49PFW47DMSgsH0HfyDliJEto29nZNZtW4g3VrTj8ci2LMONbTA2AzHpaJn3KlB1N+gwxyv4Tr0vqEgyphlwqTz1vr9F81TNN4X27mKkff4e4EaxyqGOuhQTo36VtlYbZyCV5QitFdadpMTeuQYkDffrDIShYjD/gS4Gala0dlfOzQJmwd0ACx6hwQTAIGTQZyrnr9jU+Zem8UinH5xd0c6O3vGtxcYkGAApJFwl54A0M/0 TD7LdtWj agaV/Rv0KGFIx18mIUGxbpkWt7KhhMR6tpny0awzK22E+ylnr7T9limfGMw0MJvRFRYewNF6lb6Cjkz9E456Ipnnr+YBYuGyjnxTCMsQhPQiiaf0f7Gw3Fy56VAjO9POgnWgtA1zk3/OKuSKPYJ7TCqXje7LMh4sGbgILuwQWLy9WwLFslcSlPCz/8cDVxN+LqBUAyyefD2Mvip256hC2OVBBwHbHL+evYcfkn3HPqir5pnxNLo8P7cfMzgfhO2UrpiQD3Dwh708dNprZI8QjZbqXH8XldCj03oDl3mYtGZGejvP0GZWfTHtrwBYxs3SYCwMl0dfiaMC+ihGpykfuIDaW3J6IHj7W2AO7hjQLHX+uq0pQ5GR6p+floEwz3ZbTjsUXsdy8QP9OSJIc1vDLul25vUCIOPdWOiPk2vFiIm+J3BR53AFfe/1DMbpdItH3iFofe2d+DZajc00TzLPm626HTGX7vZkZR1loeU8LTV8OSoM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Waimain, On 06/08/24 10:25, Waiman Long wrote: > The memory_failure_cpu structure is a per-cpu structure. Access to its > content requires the use of get_cpu_var() to lock in the current CPU > and disable preemption. The use of a regular spinlock_t for locking > purpose is fine for a non-RT kernel. > > Since the integration of RT spinlock support into the v5.15 kernel, > a spinlock_t in a RT kernel becomes a sleeping lock and taking a > sleeping lock in a preemption disabled context is illegal resulting in > the following kind of warning. > > [12135.732244] BUG: sleeping function called from invalid context at kernel/locking/spinlock_rt.c:48 > [12135.732248] in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 270076, name: kworker/0:0 > [12135.732252] preempt_count: 1, expected: 0 > [12135.732255] RCU nest depth: 2, expected: 2 > : > [12135.732420] Hardware name: Dell Inc. PowerEdge R640/0HG0J8, BIOS 2.10.2 02/24/2021 > [12135.732423] Workqueue: kacpi_notify acpi_os_execute_deferred > [12135.732433] Call Trace: > [12135.732436] > [12135.732450] dump_stack_lvl+0x57/0x81 > [12135.732461] __might_resched.cold+0xf4/0x12f > [12135.732479] rt_spin_lock+0x4c/0x100 > [12135.732491] memory_failure_queue+0x40/0xe0 > [12135.732503] ghes_do_memory_failure+0x53/0x390 > [12135.732516] ghes_do_proc.constprop.0+0x229/0x3e0 > [12135.732575] ghes_proc+0xf9/0x1a0 > [12135.732591] ghes_notify_hed+0x6a/0x150 > [12135.732602] notifier_call_chain+0x43/0xb0 > [12135.732626] blocking_notifier_call_chain+0x43/0x60 > [12135.732637] acpi_ev_notify_dispatch+0x47/0x70 > [12135.732648] acpi_os_execute_deferred+0x13/0x20 > [12135.732654] process_one_work+0x41f/0x500 > [12135.732695] worker_thread+0x192/0x360 > [12135.732715] kthread+0x111/0x140 > [12135.732733] ret_from_fork+0x29/0x50 > [12135.732779] > > Fix it by using a raw_spinlock_t for locking instead. IIUC this is executed to recover a fault condition already, so maybe latencies are of no interest at that point, but I wonder if something like https://elixir.bootlin.com/linux/v6.10.1/source/Documentation/locking/locktypes.rst#L434 would still work and save us from introducing a raw_spinlock? Or maybe the critical section is anyway tiny and we don't care either? Thanks, Juri