From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0107DC531DC for ; Fri, 16 Aug 2024 15:44:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 60C228D0089; Fri, 16 Aug 2024 11:44:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5BCA38D007E; Fri, 16 Aug 2024 11:44:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4AB8C8D0089; Fri, 16 Aug 2024 11:44:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2D6E68D007E for ; Fri, 16 Aug 2024 11:44:21 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C7EA4A9361 for ; Fri, 16 Aug 2024 15:44:20 +0000 (UTC) X-FDA: 82458530280.02.EC21617 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id 9EF6A100003 for ; Fri, 16 Aug 2024 15:44:17 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=o8BVWbV2; dmarc=none; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723822976; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tgmySbRwp3I0v4k+W+elsCxx/kQc/3jwf7sA3HlVR7E=; b=xdLwzGrrdxGVWsCyf88LdfdAEOSmOBYb92QtypuM9nmFt5Cvh+NsD8reC441+uCV2FRS25 fqzBefP40yZjEGNpsvhL+1ad1ttzGaGvZxmZKZXCpP5MNSmprUXwO+ByNry66hRMh91GpX h80uz/HE6WNZe2qmPTikZPwkMUyKwps= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723822976; a=rsa-sha256; cv=none; b=3ZcaUcKaddLbdKv+OpNpOC8shj7PQ0rbq3jbUusFAJgMpRLnwi2KW9P+zdGvSuOJXxiREe V6hKM5/k1hUYMcaAP5VDmf5La/qWAd+eEDO2VA64dsVn3J4tGWmRE4z5of9d9YJhZmYrAO Xqhk0vToPoSmalGhDqlG9160xv1SYAk= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=o8BVWbV2; dmarc=none; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=tgmySbRwp3I0v4k+W+elsCxx/kQc/3jwf7sA3HlVR7E=; b=o8BVWbV2qPTU0QptJvu+e5wG2g vZWxPPmF+etUOMaJeF4OEbn2tBGjPvBT2KkkZ089V9vh4jcBnju0+V6YXMns7tBwJttNpPuN7OYoO /m3b/GT3XBzV4UcktvdRqKOQ7+el+CYIY9Ep3RN0DObJqEKA69Mdw3wid7QfhLTgx8gyXrDLmDHeZ 2++oQtMglbMSXqUsqYTqiPo9gIoSW4xtI8PSWk3HeETkH1RgFcLhBAvrlakOdyziwQrNgJnn5s5XP Ta0lzB8CSVymbMA6oEkMwXcvLg+BkPviW43ai1H5bzTt16qYqUBZ5tZzR63jbxX4/at0nE7VcWA6P iRy0XdJw==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sez7X-00000003lSD-1DSr; Fri, 16 Aug 2024 15:44:07 +0000 Date: Fri, 16 Aug 2024 16:44:07 +0100 From: Matthew Wilcox To: Usama Arif Cc: akpm@linux-foundation.org, linux-mm@kvack.org, hannes@cmpxchg.org, riel@surriel.com, shakeel.butt@linux.dev, roman.gushchin@linux.dev, yuzhao@google.com, david@redhat.com, baohua@kernel.org, ryan.roberts@arm.com, rppt@kernel.org, cerasuolodomenico@gmail.com, corbet@lwn.net, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH v3 4/6] mm: Introduce a pageflag for partially mapped folios Message-ID: References: <20240813120328.1275952-1-usamaarif642@gmail.com> <20240813120328.1275952-5-usamaarif642@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240813120328.1275952-5-usamaarif642@gmail.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9EF6A100003 X-Stat-Signature: xk5hz7bpensgi9zqxoqnecfzn8d7zzy8 X-Rspam-User: X-HE-Tag: 1723823057-165885 X-HE-Meta: U2FsdGVkX1/yIh6a9sTbilL5rE6M9MGg8PNDfNqczARl66pCt7Z3MvHNsJZX/UBtT2JBkDNDZwCN05Y4oGRuEz+gvFgltxTDD/Pzj91jkXVwLh437zgsHCEKSPa90EMtqC+TvP+SGbvy6MCT0vs48bsCCRE7Wy0wo9V/QoC/t9JEowxdBkwpfDqfAWXU3O/jP0hFH6Pkm7nte8zK7ZxF530e0UQ4j0aKqwtdw6ee0cbv6/zP8E0FZkE9Xmf3LXJo0LQ/y4nVZhwvs9lIvHCa5u3loBnn+tMqOra+eAuE4X4f4moV4nRFdP/sulBBLefq1eZy/Xf8CPKqMyzQRO3fSg3vukBHbGsr4QoqdueDtSO1qkdbApireC3DJ5lQesI8PEb9C4WH22/gJDkhgzgEZuyH1NL4H83NEjpfBOJggc38Lef5exH7xvPZNtvi6dK17pNb5Okv7x6sGwXYoXlVr3ou51hM0SZpEng1dttnHPYz5NUMZsHGmJDBDjfCao3IvXumTQTcrHr9QGSHgm936iVon4b+/qj0tJtVjxVUzFbqmOCjPiX9P4xHm77Fwed2bj1d11LKQSBSR5lTZeINaqxrawqfn5l5ld22D063MXznWLnsg483qkZ/bQMIi0GsADW9MOL3ge+rCObcZOofNl4kmh6maRDZ+6zYvTUDfkaihv1BkQK3Cfk1zSHYK7TMSuKFLqTgT87Yec/gFmpYZXWT1OjOEixdwHBE9Jz7/D2brmRSgjPfPClEzJuaWY9MPf9qV1ds18cR4viwjWRnDEGxk8IdZpQIjxSUsVla5QwhmVBKQBO0aOK7dlN7k4qS3RRNlFao7vgxUBHLU+QOaHDVjkcuP1xdoBQ9i/eL1ggRqYPMb4zFS5LrogLcJlY58vl3xsgp2sFuKgG/zbyfMSXvDMgFzi3s1r81i6oPPz73viNohW1Tw3NDrn52iYLol9R3/1vhRYA/ygMKsNd ab+40Tlq uYOZuWCDKP3gTRZDi4gbEtM79jvcUYECzsYOhFGe0KEKL/+L2x7zISG0QbLxfl9SJuRbTDYs26YQM+o1pMOlQAWIx7+v7p7fxh/vKMUJLPIn++DR+DLM8i3jPxcww8risY1xaK6kEDU9X3uRpxiJly481Rv7Z+5iPb4x5w4X8rWEFj/A/pC8lm/nXCdToxzBnfwXqbdvK+eO8ezk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Aug 13, 2024 at 01:02:47PM +0100, Usama Arif wrote: > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > index a0a29bd092f8..cecc1bad7910 100644 > --- a/include/linux/page-flags.h > +++ b/include/linux/page-flags.h > @@ -182,6 +182,7 @@ enum pageflags { > /* At least one page in this folio has the hwpoison flag set */ > PG_has_hwpoisoned = PG_active, > PG_large_rmappable = PG_workingset, /* anon or file-backed */ > + PG_partially_mapped, /* was identified to be partially mapped */ No, you can't do this. You have to be really careful when reusing page flags, you can't just take the next one. What made you think it would be this easy? I'd suggest using PG_reclaim. You also need to add PG_partially_mapped to PAGE_FLAGS_SECOND. You might get away without that if you're guaranteeing it'll always be clear when you free the folio; I don't understand this series so I don't know if that's true or not.