From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC0F3C531DC for ; Fri, 16 Aug 2024 16:11:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55D8D8D008E; Fri, 16 Aug 2024 12:11:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 50D568D007E; Fri, 16 Aug 2024 12:11:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D4FA8D008E; Fri, 16 Aug 2024 12:11:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1FCDE8D007E for ; Fri, 16 Aug 2024 12:11:38 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DBDACA0002 for ; Fri, 16 Aug 2024 16:11:37 +0000 (UTC) X-FDA: 82458599034.13.56F732A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 18AB54001A for ; Fri, 16 Aug 2024 16:11:35 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=B9iG+e7X; spf=pass (imf27.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723824658; a=rsa-sha256; cv=none; b=bWj7Zwgw/CD5URfpEmh6RdupeN1kxQWHnxAQiPMfazvTzowMiCGP6AlMR9P+w+9idf5SlR kYzM0vXkWrjYjCJFP+rp2LVMkXl8xB05LPj/ehdWS4jVKj4KqprBNG0x0Pv/d05zVRYhrR slHCDEFnq2HL6v/4dqwdffoAjfqap6E= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=B9iG+e7X; spf=pass (imf27.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723824658; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AxGBqUeMb4W96mBC2jM2m3uE9NqvD77N4xwdXzOBol8=; b=ND6wRLetMiqKttk+E8zioyrME37CsymMdGv/DtAPaClAjDiGODhgIeFEzHDodk4m5RGcmq PDXbpYKebuKWbCyq1XnWaIohn5p0YsYV5Q+ywoEF24piREMTHA7s/Fb/R3MWk0pnSgNyr0 HCI3QOyBRcja0AGGq8B7es7DazfhQ+Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723824695; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AxGBqUeMb4W96mBC2jM2m3uE9NqvD77N4xwdXzOBol8=; b=B9iG+e7XaZAnWRuEF9KrTgSILSBwpUM7ou8IKpZQAAzXOy5aSZ/ksEjcbg7VErsNrecBM0 QbYAVuK5PwzWjCD1+ZcFEnfxE9D8s3ruEG9oYtEJTbVfR2mIPNaa6t4bP7sKwRiucrgGng iGbhCWXYk9sLeOof0LT3j0vtLfoIDOo= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-190-VUTFbWR6NHSwk2ou4Gbppw-1; Fri, 16 Aug 2024 12:11:29 -0400 X-MC-Unique: VUTFbWR6NHSwk2ou4Gbppw-1 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9CBBF1955D56; Fri, 16 Aug 2024 16:11:26 +0000 (UTC) Received: from localhost (unknown [10.72.112.51]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5BFFA19560A3; Fri, 16 Aug 2024 16:11:23 +0000 (UTC) Date: Sat, 17 Aug 2024 00:11:19 +0800 From: Baoquan He To: Uladzislau Rezki Cc: Hailong Liu , Andrew Morton , Michal Hocko , Barry Song <21cnbao@gmail.com>, Christoph Hellwig , Vlastimil Babka , Tangquan Zheng , stable@vger.kernel.org, Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH v1] mm/vmalloc: fix page mapping if vm_area_alloc_pages() with high order fallback to order 0 Message-ID: References: <20240808122019.3361-1-hailong.liu@oppo.com> <20240815220709.47f66f200fd0a072777cc348@linux-foundation.org> <20240816091232.fsliktqgza5o5x6t@oppo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Stat-Signature: bfcfizoago5uwp4t5j5b9kmqo6xpna1j X-Rspamd-Queue-Id: 18AB54001A X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1723824695-75368 X-HE-Meta: U2FsdGVkX1+s6DCI8b0vkMnSueVeVZZB5LFrkRQgWHO60BoaDbSMWHaPjiPEFBk4SYiXE5njP2Ijz8kWzRkY3dnyfsLB2Vvsgtq1icPwpp/ArxpOEZ4mZcSsGT1Tfy5TDSH+sIv09QU/RGMdb+fJkigQqHlqgv8UnYRZ3EXZx1Y5t1ZrLDzZn4N3kgqFsHnz9DyaXtW9IP649tDBTwlRxG7Hfzg7R+tbX4UrWMC9Vy3WgEgz3vwe308cM34EBvvdMdUmsGC+87GWhH7FWJa3MugZsJuCWoh7t8aD7GKiP4ewx8kEX3wCMvdqF46Y/lmMNPKcsRztR2pHXjvQtLHozwfAr6d8zQ175o47n/4iv30yWUR61Llq0rQdnUDvyIiHJzd4hH0hG51rssy8RPk+MyFMqOJQ4w4ax61kOXk8WHsuuDeOxJ1ekUFMYSPCeJM3m8htlxY3jNb8lXnWELmTAyGKCASu9P2VvhcLF/KnD+fn0J5mprAq4DBIhTDxYQP9hwI+FE/QHWpQop+sEBMNOvT2QcF+kW5YhNY+6yJikffaojmYsCEgnVGKPswVEhMHtX9N39YK77p+zqYrRPEfOKXsJfe2Oc95cCuIUZJe5Eq3AztYIM2FNCieANkW6cCTb1P/Pg+4LNXku9KuytrNLLndcJgbhKaUp9gPVtxn05P6vuZyLftfIMCufnD25JB64+YuCxqyXagaBmJvH1x5Xs+E8I37u8t/tZurHu+4jYxSUMVNwuHl98UINJ+B7S97ZUeYUefI6RAo0FQUarB0b5Hr9GiwUL3J9sHjvvnOCy415GDGMl1dFq9OmkLoxHyy5z7qgR+qXm0qShlNv/QEp8otG9wyuKGzIOHTgI476ysCwHPer8U4ZxRz+m7t6IDl/wDH5ucoOMRrTc2yCtrqdTc0Zf1fhiu11r/7BaiY6dg6vQWhXaA4C6JNsuYYM67mE3vkFpwQH47tENHrOBf 3F9xE3Vn oOUcV5tgwaQQWXyhhbWjgfvkwK8mRjdspq5if3EW+ZG+tNqH1DCpBa1dljAKpS8fsY/LLHs8VuftlZqDdNMEcnv9H3tcxRlETBhsFLXjxksRYLS1KPtejXYwDnEWpdZ8RQ+oiv1j2MsCjr1TzWGm/xV/oW2M24odvQrJBBFkJ1kVXfRQLqZPK+6RxUOMxJ5XZstQ19J8DqiA1JwuAWlzPbT/bbCHSlHlu8g++ZeS+wWDxxr4TC8y6nDDCev0uhEtDYkJziz5UBGfgGA6XEiXLY/P0HI4SaARC9Cgz5+V7z10hklX1InPCrRYtEj9IOtSjKLuBRaCx1KeaupqK2+X8619JD+uW0TLUuxDInMk0GnY9/rFrHHPTKWx/fDwJEJyegZQz7T1TyWKMQvx4odT2ehLROTGMNRz6LgmZFM0hvSIQA35UNoS6cWYu4/cB294+Bzuu2+yHbpWwoPyVrnQX90ldb/m/GtWKOn1e8AIVP5OwK7M9rhG2z5vMEMFgyMQ4wK6j X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08/16/24 at 12:13pm, Uladzislau Rezki wrote: > On Fri, Aug 16, 2024 at 05:12:32PM +0800, Hailong Liu wrote: > > On Thu, 15. Aug 22:07, Andrew Morton wrote: > > > On Fri, 9 Aug 2024 11:41:42 +0200 Uladzislau Rezki wrote: > > > > > > > > > Acked-by: Barry Song > > > > > > > > > > > > because we already have a fallback here: > > > > > > > > > > > > void *__vmalloc_node_range_noprof : > > > > > > > > > > > > fail: > > > > > > if (shift > PAGE_SHIFT) { > > > > > > shift = PAGE_SHIFT; > > > > > > align = real_align; > > > > > > size = real_size; > > > > > > goto again; > > > > > > } > > > > > > > > > > This really deserves a comment because this is not really clear at all. > > > > > The code is also fragile and it would benefit from some re-org. > > > > > > > > > > Thanks for the fix. > > > > > > > > > > Acked-by: Michal Hocko > > > > > > > > > I agree. This is only clear for people who know the code. A "fallback" > > > > to order-0 should be commented. > > > > > > It's been a week. Could someone please propose a fixup patch to add > > > this comment? > > > > Hi Andrew: > > > > Do you mean that I need to send a v2 patch with the the comments included? > > > It is better to post v2. > > But before, could you please comment on: > > in case of order-0, bulk path may easily fail and fallback to the single > page allocator. If an request is marked as NO_FAIL, i am talking about > order-0 request, your change breaks GFP_NOFAIL for !order. In case order-0, bulk_gfp masks off __GFP_NOFAIL, but alloc_gfp doesn't. So alloc_gfp has __GFP_NOFAIL in fallback, it won't be failed by alloc_pages().