From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FBB8C3DA4A for ; Fri, 16 Aug 2024 08:54:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 84FF16B00D9; Fri, 16 Aug 2024 04:54:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7FF966B00DE; Fri, 16 Aug 2024 04:54:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A24C6B00DC; Fri, 16 Aug 2024 04:54:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 49B516B02E1 for ; Fri, 16 Aug 2024 04:54:43 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id AFBBBA1A69 for ; Fri, 16 Aug 2024 08:54:42 +0000 (UTC) X-FDA: 82457498004.22.383B8BD Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by imf18.hostedemail.com (Postfix) with ESMTP id A2AA81C001B for ; Fri, 16 Aug 2024 08:54:40 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=CQ07GBNF; spf=pass (imf18.hostedemail.com: domain of mhocko@suse.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723798408; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3pIkvRgkwngFukvaEgo0ZxKmEDBfWbk9DOS9YQMsLN0=; b=3O9lAo9PzhQadkiLnHjaAntwk95nYMKSeWdZu6bU4tWgWE6uOcJovRR+g+AnLsaexTiTCE qnAPp6aiIizlNIIN+hHAzvERM+ftriKS39gxjHvZIy5T3/L0RSvXr5XMzNUCTqyRwd9c2C 66n4PWZNhLFqWKcFllVKVMQ+RoalFGs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723798408; a=rsa-sha256; cv=none; b=KGr+WAw00449ycQT1o5F8pyHrZpB4ZbcCpAosDgCdkqxTcjftHulk5Qc2P3GLoVrDHWhOv AnMTbiCq22wDCRNFfHJMb6bMx/dlwXh5P7V+mYFTwVXvyhrumwwOLRlYDMfg2CdRhAmqRl JOrlf0LGHGh9hjpvzO7iJxBaT6lruWM= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=CQ07GBNF; spf=pass (imf18.hostedemail.com: domain of mhocko@suse.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-427fc97a88cso13059055e9.0 for ; Fri, 16 Aug 2024 01:54:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1723798479; x=1724403279; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3pIkvRgkwngFukvaEgo0ZxKmEDBfWbk9DOS9YQMsLN0=; b=CQ07GBNFLpUfRTVU3kNer3sJaJdHKGdQ0sXN6mt6PGzy4PYx1gDm+ErWVKre1ROUy3 pmBMNsXfuBDzedpgwlSJQIsWKqieIGMOeDFhTT1Yw0spnrA/xe+wAiYlNu6lj2tXnXb0 pk8YKaLwtOMF67gcsANEjSHVfY9KBP87qowhiuitMolQwmFSPusSdo4x3Vcp+0O6ewPx tZxlWs4au+17htk0ZmgXA08X7otrjH3soh+054MNgSqkJkRN4XSqUwWwhyvFFTWumVcK MZu/8uVYiD7Szax2bDklU8+Oi/lpJXqcETl2VktAdaL6g1vVgUWPPJBmcySUkrw/wtSv 4IJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723798479; x=1724403279; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3pIkvRgkwngFukvaEgo0ZxKmEDBfWbk9DOS9YQMsLN0=; b=YWeCNsP7wsuFRbAVRxcktzrzcsrIgF8f0aviFlOi0ji8G9FtTyxHzIvjgQYCGyMi3p AKvEWBmlVeOs+mHX+JLL1PjUXRMhRoJpR5AryrPuJiwud+zZtXSGkc8v0hygh94HiRzg lrhXCMVYXNr6JwKH7rfP5vs6QQa0IZbeWjTiTWtXKBLKEPZDf0lUpPMEAYjAGZfndeM/ bkP1Fp8tfC7aEeiacA30hXaUog5zAOghCuDYOlhUSAxu6hLfD6g4PYqnNagcZKTUDyVI JPWGism/ueV1YGgI1j1PjML+q/2qPIakAaJmAtOcY16wHNPBwBWovqhxOVYDrpb1SuQ2 W8AA== X-Forwarded-Encrypted: i=1; AJvYcCVYCTf32o/ZMEsDTlhVe3y1fYz7vxa3w6lRgoZrk46VOqKL5TCpyLrYRD/nxIAie8fuolLoamiZ+HT4YxXWEdgOohs= X-Gm-Message-State: AOJu0YxGFz8Vkm1brFPwjiaf3D1zXinnbnFZMIq1WzrztZz2GkF6ooWX 5X1JribDAd5N9buzqyV2FIP8WKA/SXD3rR2n2sZiIAuU3dYQDvjbnr5b6UDhSiI= X-Google-Smtp-Source: AGHT+IHFi3KoFe2Nw7CAeOaBuufog4mitm27hUgU2VeSa6AqOuxlI8alCK6Rl3A58UW0OSu7uY9gmw== X-Received: by 2002:a05:600c:4e8a:b0:426:623f:34ae with SMTP id 5b1f17b1804b1-429ed794d8amr12813275e9.16.1723798478880; Fri, 16 Aug 2024 01:54:38 -0700 (PDT) Received: from localhost (109-81-92-77.rct.o2.cz. [109.81.92.77]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-429dec83d2asm71008715e9.0.2024.08.16.01.54.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Aug 2024 01:54:38 -0700 (PDT) Date: Fri, 16 Aug 2024 10:54:37 +0200 From: Michal Hocko To: Christoph Hellwig Cc: Yafang Shao , Andrew Morton , viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, david@fromorbit.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Kent Overstreet Subject: Re: [PATCH] mm: document risk of PF_MEMALLOC_NORECLAIM Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: A2AA81C001B X-Stat-Signature: snqidis8y4pqq78nr4a5npb751pf47zk X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1723798480-327844 X-HE-Meta: U2FsdGVkX18nJV2sKUHWT3QMpsOKtFlzyJUb3PHytKgRb7D4DedpoFUYTeog6x5ttO9UElNsPHl5gr5XwV99MbVKw+vsc8AbIXPCmZx8/4bh5CwAamlXA3AXTEGuNnGV20BBywWrflUiTpmY7hJoFAc7Hqj6Nupd8zG35rq7R97t1rrbuYSu326WvLjHHvkbeZpIewjBRbzbwwVWZUU0B5czFt/Qt6a0TIGEwQCG8R3gGZ/Y/ncdHBtiTO05+R0PwZWKIi+cqyN5Rmf0a628MyplPzAp2Fgg98ary6GKFq6JYQMIyBzAsvfA8hEWJaC0KKWCCJIyQvhulrdYmA4+/NwbRQmM1kF57vU0yV41xCrW/7cQMTPrOgIB/sQe16W7rfEWC/RjkxKe4aNG0fVYbtpE5E6vP+8TdHwiVPMFl2OY1kL4FL9Zzl8WAtS933in4v28vLRwilPP24Xhdiw2T+PTBCr0HLMIxYamdfcthImgHGpyIwus/Kkrz+fIYSecMSbZ2ykUjQzD6nhpcQ0QXKBTwIkf7J8UJTlYGIvXA12KkX5GipqFW1qjBemFoJXq7y5RecQFun17WrLNH8/M6DGipsblp/YdG55lLlAgBsa1Nw8EVjCXMSCumOpTXTO2QJ52Qx54NgYkjgWw0fOj80E+aT38C/f0GFCaphbTSbaHxLv6sFLkbw54l/nUEHF8vwn+xAB1vT20hTJyu+IszGydFCcSdNusF2o3x5lZuQW3gFU4BwrZeUiDYXdql/2JUcqqfeko2wrmTh9wLxiCQPoYplVL7OE4lG5fBwOcA5O1YLuu5T/VSDky/4H+H4JPSpUAP6crCOI7XgQmJNH63Ynk0q6eZ2aehEEiUQ97kKULiARCLmnZX6AKAioDI/k7m5A6Ov7X+0q6kSDjO9FR0zv5/8UIbVxTqIeaSbwsPiwAdKzgSN/wlHlQ1IL8BOl9Q0qjripLtFodAMJTILO TkR6SMo2 A70Q5PGC3ovS4dlg2IJXzpJTm/C/rQ3c6gJcqVZf/SJnq3ypqkgWAr4axmNbTEzBloU4MgA/XCO4Q2w5VjTU8NbpC71QprTf+WtLiqmb3OvAWTMSufeHB1QE/vhx7eKNqqhf04n6vBqy8V8noaqUS3eqGaQ+NsfpKtiEdYkenpAAd0Hw8Nn783AaLzYpiOdryUUs3VmC3bbcBqkrH3RuG3hGr+X0EFmMYdnIDIGF9+EQx3elm1dqFhghRF3rETe1VdXN3nfPuFFKX/PnzIAO5Ld7U4uhWUA/ujRPFhZ2ZPsbsRlMpARUuxBQWAAZo3JHTpETNj9SXe+j8IL2nEQ+xqSA/EI7s5zN9Aw7il+41Gl5YUd9zUXs6sN1FCPtAAHYhMmGCL8vttIktOIaZOR87Mq9w2D670JCBTfcy85PU/mJl8LCbTGC4fjbBU0ApXr6dVv1jUyupVNBjqQUWTmfu5tKAcZgyP2HeKcIYCy0JQgvujrPFXtKjiSw2HmZCV/2dKGw13jYnniPtn0LCPQ2dpS1IvTPALdFZSRbLatvACxLZEZ0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri 16-08-24 01:22:37, Christoph Hellwig wrote: > On Fri, Aug 16, 2024 at 10:17:54AM +0200, Michal Hocko wrote: > > Andrew, could you merge the following before PF_MEMALLOC_NORECLAIM can > > be removed from the tree altogether please? For the full context the > > email thread starts here: https://lore.kernel.org/all/20240812090525.80299-1-laoar.shao@gmail.com/T/#u > > I don't think that's enough. We just need to kill it given that it was > added without ACKs and despite explicit earlier objections to the API. Yes, I think we should kill it before it spreads even more but I would not like to make the existing user just broken. I have zero visibility and understanding of the bcachefs code but from a quick look at __bch2_new_inode it shouldn't be really terribly hard to push GFP_NOWAIT flag there directly. It would require inode_init_always_gfp variant as well (to not touch all existing callers that do not have any locking requirements but I do not see any other nested allocations. So a very quick and untested change would look as follows: --- diff --git a/fs/bcachefs/fs.c b/fs/bcachefs/fs.c index 15fc41e63b6c..7a55167b9133 100644 --- a/fs/bcachefs/fs.c +++ b/fs/bcachefs/fs.c @@ -231,9 +231,9 @@ static struct inode *bch2_alloc_inode(struct super_block *sb) BUG(); } -static struct bch_inode_info *__bch2_new_inode(struct bch_fs *c) +static struct bch_inode_info *__bch2_new_inode(struct bch_fs *c, gfp_t gfp) { - struct bch_inode_info *inode = kmem_cache_alloc(bch2_inode_cache, GFP_NOFS); + struct bch_inode_info *inode = kmem_cache_alloc(bch2_inode_cache, gfp); if (!inode) return NULL; @@ -245,7 +245,7 @@ static struct bch_inode_info *__bch2_new_inode(struct bch_fs *c) mutex_init(&inode->ei_quota_lock); memset(&inode->ei_devs_need_flush, 0, sizeof(inode->ei_devs_need_flush)); - if (unlikely(inode_init_always(c->vfs_sb, &inode->v))) { + if (unlikely(inode_init_always_gfp(c->vfs_sb, &inode->v), gfp)) { kmem_cache_free(bch2_inode_cache, inode); return NULL; } @@ -258,12 +258,10 @@ static struct bch_inode_info *__bch2_new_inode(struct bch_fs *c) */ static struct bch_inode_info *bch2_new_inode(struct btree_trans *trans) { - struct bch_inode_info *inode = - memalloc_flags_do(PF_MEMALLOC_NORECLAIM|PF_MEMALLOC_NOWARN, - __bch2_new_inode(trans->c)); + struct bch_inode_info *inode = __bch2_new_inode(trans->c, GFP_NOWARN | GFP_NOWAIT); if (unlikely(!inode)) { - int ret = drop_locks_do(trans, (inode = __bch2_new_inode(trans->c)) ? 0 : -ENOMEM); + int ret = drop_locks_do(trans, (inode = __bch2_new_inode(trans->c, GFP_NOFS)) ? 0 : -ENOMEM); if (ret && inode) { __destroy_inode(&inode->v); kmem_cache_free(bch2_inode_cache, inode); @@ -328,7 +326,7 @@ __bch2_create(struct mnt_idmap *idmap, if (ret) return ERR_PTR(ret); #endif - inode = __bch2_new_inode(c); + inode = __bch2_new_inode(c, GFP_NOFS); if (unlikely(!inode)) { inode = ERR_PTR(-ENOMEM); goto err; diff --git a/fs/inode.c b/fs/inode.c index 86670941884b..95fd67a6cac3 100644 --- a/fs/inode.c +++ b/fs/inode.c @@ -153,7 +153,7 @@ static int no_open(struct inode *inode, struct file *file) * These are initializations that need to be done on every inode * allocation as the fields are not initialised by slab allocation. */ -int inode_init_always(struct super_block *sb, struct inode *inode) +int inode_init_always(struct super_block *sb, struct inode *inode, gfp_t gfp) { static const struct inode_operations empty_iops; static const struct file_operations no_open_fops = {.open = no_open}; @@ -230,14 +230,14 @@ int inode_init_always(struct super_block *sb, struct inode *inode) #endif inode->i_flctx = NULL; - if (unlikely(security_inode_alloc(inode))) + if (unlikely(security_inode_alloc(inode, gfp))) return -ENOMEM; this_cpu_inc(nr_inodes); return 0; } -EXPORT_SYMBOL(inode_init_always); +EXPORT_SYMBOL(inode_init_always_gfp); void free_inode_nonrcu(struct inode *inode) { diff --git a/include/linux/fs.h b/include/linux/fs.h index fd34b5755c0b..5c613a89718b 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -3027,7 +3027,12 @@ extern loff_t default_llseek(struct file *file, loff_t offset, int whence); extern loff_t vfs_llseek(struct file *file, loff_t offset, int whence); -extern int inode_init_always(struct super_block *, struct inode *); +extern int inode_init_always(struct super_block *, struct inode *, gfp_t); +static inline int inode_init_always(struct super_block *, struct inode *) +{ + return inode_init_always_gfp(GFP_NOFS); +} + extern void inode_init_once(struct inode *); extern void address_space_init_once(struct address_space *mapping); extern struct inode * igrab(struct inode *); diff --git a/include/linux/lsm_hooks.h b/include/linux/lsm_hooks.h index a2ade0ffe9e7..b08472d64765 100644 --- a/include/linux/lsm_hooks.h +++ b/include/linux/lsm_hooks.h @@ -150,6 +150,6 @@ extern struct lsm_info __start_early_lsm_info[], __end_early_lsm_info[]; __used __section(".early_lsm_info.init") \ __aligned(sizeof(unsigned long)) -extern int lsm_inode_alloc(struct inode *inode); +extern int lsm_inode_alloc(struct inode *inode, gfp_t gfp); #endif /* ! __LINUX_LSM_HOOKS_H */ diff --git a/include/linux/security.h b/include/linux/security.h index 1390f1efb4f0..7c6b9b038a0d 100644 --- a/include/linux/security.h +++ b/include/linux/security.h @@ -336,7 +336,7 @@ int security_dentry_create_files_as(struct dentry *dentry, int mode, struct cred *new); int security_path_notify(const struct path *path, u64 mask, unsigned int obj_type); -int security_inode_alloc(struct inode *inode); +int security_inode_alloc(struct inode *inode, gfp_t gfp); void security_inode_free(struct inode *inode); int security_inode_init_security(struct inode *inode, struct inode *dir, const struct qstr *qstr, @@ -769,7 +769,7 @@ static inline int security_path_notify(const struct path *path, u64 mask, return 0; } -static inline int security_inode_alloc(struct inode *inode) +static inline int security_inode_alloc(struct inode *inode, gfp_t gfp) { return 0; } diff --git a/security/security.c b/security/security.c index 8cee5b6c6e6d..8634d3bee56f 100644 --- a/security/security.c +++ b/security/security.c @@ -660,14 +660,14 @@ static int lsm_file_alloc(struct file *file) * * Returns 0, or -ENOMEM if memory can't be allocated. */ -int lsm_inode_alloc(struct inode *inode) +int lsm_inode_alloc(struct inode *inode, gfp) { if (!lsm_inode_cache) { inode->i_security = NULL; return 0; } - inode->i_security = kmem_cache_zalloc(lsm_inode_cache, GFP_NOFS); + inode->i_security = kmem_cache_zalloc(lsm_inode_cache, gfp); if (inode->i_security == NULL) return -ENOMEM; return 0; @@ -1582,9 +1582,9 @@ int security_path_notify(const struct path *path, u64 mask, * * Return: Return 0 if operation was successful. */ -int security_inode_alloc(struct inode *inode) +int security_inode_alloc(struct inode *inode, gfp_t gfp) { - int rc = lsm_inode_alloc(inode); + int rc = lsm_inode_alloc(inode, gfp); if (unlikely(rc)) return rc; -- Michal Hocko SUSE Labs