From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64635C52D7C for ; Fri, 16 Aug 2024 02:09:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA4CD8D0032; Thu, 15 Aug 2024 22:09:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E54E28D002B; Thu, 15 Aug 2024 22:09:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D1C7C8D0032; Thu, 15 Aug 2024 22:09:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B362B8D002B for ; Thu, 15 Aug 2024 22:09:03 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6344E41798 for ; Fri, 16 Aug 2024 02:09:03 +0000 (UTC) X-FDA: 82456475766.07.375BCE4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 8882A100013 for ; Fri, 16 Aug 2024 02:09:01 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="eiEb/azW"; spf=pass (imf05.hostedemail.com: domain of ming.lei@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=ming.lei@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723774104; a=rsa-sha256; cv=none; b=BVkkfGmH5d8CK2X8BRRQLToDog0P+SGx9CbpuUzhq2TRcN1OPBIdRqdXwdwqYhyvmy8Rlj 0gs1plkAmy3L1/T5WzOqTZ/PjlDK0aCOG+O89KJUdTzcBxnPcfhnOmG9NWyHI2o0UNcyag Z3NIT8C9hABUJDGzDkPu3VABDtIawLw= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="eiEb/azW"; spf=pass (imf05.hostedemail.com: domain of ming.lei@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=ming.lei@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723774104; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k0dkX5rwoUCSxrn4K90HMgNl/sebHqvy2KVfSB0T9VU=; b=OS3+w8qOW/ZT2R7sadAfd9B8mZCGLW3M1zI9sNoIwHjFjcoLpEUGAx0gnhOWjqM8tKI4N1 vioxcVLCSRsxaBoB7+GcxJcTxEWO5igTQXomV5sdr2/mUinQDurXCP2+hmG98Mu4eMjC6c QwnjyEfVzl9s6R/iZMTuc+kq8Hel++g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723774140; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k0dkX5rwoUCSxrn4K90HMgNl/sebHqvy2KVfSB0T9VU=; b=eiEb/azWuCAWx6zw0O6QGjqKPdZQuKFkZplgI9xmo90x6ikDawjDTZXSg86Ce0NPa3r+Db xhOMducr/EQ1n7XJcEJePr4MZ25kdDuK+foV1iTSfR4ayYPivrm5QxcRQ8/iIKDeZbt6ax w9PHW7dEtyrZSmYX+Ds1/yHAUtDeI7M= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-1-ycEoSGZ3MCiD50Rp6op7hQ-1; Thu, 15 Aug 2024 22:08:54 -0400 X-MC-Unique: ycEoSGZ3MCiD50Rp6op7hQ-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D02AE1955BF4; Fri, 16 Aug 2024 02:08:52 +0000 (UTC) Received: from fedora (unknown [10.72.116.112]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6DD741955F21; Fri, 16 Aug 2024 02:08:47 +0000 (UTC) Date: Fri, 16 Aug 2024 10:08:42 +0800 From: Ming Lei To: Pavel Begunkov Cc: Jens Axboe , io-uring@vger.kernel.org, Conrad Meyer , linux-block@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC 5/5] block: implement io_uring discard cmd Message-ID: References: <6ecd7ab3386f63f1656dc766c1b5b038ff5353c2.1723601134.git.asml.silence@gmail.com> <4d016a30-d258-4d0e-b3bc-18bf0bd48e32@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Stat-Signature: 7p1pgxdpofmuac8gu3phqdo96x69jm93 X-Rspamd-Queue-Id: 8882A100013 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1723774141-565359 X-HE-Meta: U2FsdGVkX1/mxZ4fgB/Lm3XZuZxTGlagpttGqz4ktUN4dggnDTfyiJOgxDzkriA36CQwRBG1DHcqkoResq3qCs16nCleMzLbofV6Kse7OGx4YdZxIC9oJKPfDhvnwn8W19BRiFVOb1BJb9+WoBoppvPfhgog/DiIL7aJd94vcVjucCU+lgJa7vlLofGcwzslafS1s1HxPVvTCku7Iq0Z6B2NfyL0f9Koq3tTwV1GUf4tZeCsY1kCtiHZCrthB6FtleDQG6uwYZM9E1fdy/ep4l5wga9hwl8pWai43nJqJ/CLVYudSdUBFDpPy6jNWKLfK+onoIKaWwsFsd7BoQhxEA8G99+3fDOh6KvmUTuJyv1dwjG9VEBSo797RUgNF4z7LRgOJ1URZQqJRv7Rkazc5QA+YjbEUviAXHw0GEM7JCojlBO3woLkMdZOP3vbw8FP3tjX3clQw7CjJt246jEp19FbfVEh4ZbTfeFc3YnvVqKGPqXdkntklqiVNAnCsYZX9ozTglm7EmdjnNM4Yk5jYm5X11p4AOlxZX3zNRTXjTwJjx+3Pl3jeCSmnVHeBxVvNew/48MPvPxcCRjqSVsbbOGwsARApnvAia3vrF8R2UQQDxhdp6CVShoRZDeexM87HgccsrTUbXCSR80AcThs8TrKSscnWSLGrf6nXEJT/DosUaFXr2acdrjYGG+FzhubZ+FqPQYLdTUTqzQaHjnlhkf/Zy2df+x5PrtHu4SowWtbbJNsKaIgrwpyiYBHrN1G91LPOEDAmqOyfkJvV+WM7xGE7EUcXxptwUv7etKeiidabozjdKYYRAS2e/lNI5DH8PQ/vJnyM9+GgYA4OduADcu1JXE2sYe5k1e5tcTBcULNloqSPHAvR1E9pM4Qx1npy6C8pc4RrlrMWMTBciVKGDQnpedIjLgbrumyt8nX63qIEfQDG1tyXid86ZqeFqbYJ95uIiUUGcq3jPIEOOE +84ghdLZ H6hi6BRq+7VxZhziLVMhYMpw0OA/4m+68d8LHmNSDA5mzrXp8/J/4PBm5GzSccmX8/msYn9vjt271ms3/xE4WKFq+ccaQO4zdsCTyf8TmmaQTvfFgfbzTmZYp1cGmoO4unabStFiu4HxU1g+Vpyq0UdHusDw/eN3Lp8OrJn0Cx1YlAdY7O1vBxbapXMntOlXQrQPERP+4uNt0WMVr+FGw+o5JB5b1cbz5Pqznkl3vycpwcNwWEzKr5LdrL/5pcpd5G6LDRWjh4/40OFrxxGlzlViW7Jf579MOesxDM2FnzVJZE5YqIkys4OIidNDEC9XBxxjHw4wVr9Af8pHMjTXDLYzxw14eVkS9L/CfXNuqbXISdbpCn77ZGTWzqqDVCvMzy1tE3cBhZia6BAxoXdpI9RbhE0Wl0moGzaadVUmvS78P9BNGZ4EpvWTxvSnLqYJx/p+7ojYhzX78vwVcNIQ2FS0Qy8c7otfBvgKJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Aug 16, 2024 at 02:59:49AM +0100, Pavel Begunkov wrote: > On 8/16/24 02:45, Ming Lei wrote: > > On Thu, Aug 15, 2024 at 07:24:16PM -0600, Jens Axboe wrote: > > > On 8/15/24 5:44 PM, Ming Lei wrote: > > > > On Thu, Aug 15, 2024 at 06:11:13PM +0100, Pavel Begunkov wrote: > > > > > On 8/15/24 15:33, Jens Axboe wrote: > > > > > > On 8/14/24 7:42 PM, Ming Lei wrote: > > > > > > > On Wed, Aug 14, 2024 at 6:46?PM Pavel Begunkov wrote: > > > > > > > > > > > > > > > > Add ->uring_cmd callback for block device files and use it to implement > > > > > > > > asynchronous discard. Normally, it first tries to execute the command > > > > > > > > from non-blocking context, which we limit to a single bio because > > > > > > > > otherwise one of sub-bios may need to wait for other bios, and we don't > > > > > > > > want to deal with partial IO. If non-blocking attempt fails, we'll retry > > > > > > > > it in a blocking context. > > > > > > > > > > > > > > > > Suggested-by: Conrad Meyer > > > > > > > > Signed-off-by: Pavel Begunkov > > > > > > > > --- > > > > > > > > block/blk.h | 1 + > > > > > > > > block/fops.c | 2 + > > > > > > > > block/ioctl.c | 94 +++++++++++++++++++++++++++++++++++++++++ > > > > > > > > include/uapi/linux/fs.h | 2 + > > > > > > > > 4 files changed, 99 insertions(+) > > > > > > > > > > > > > > > > diff --git a/block/blk.h b/block/blk.h > > > > > > > > index e180863f918b..5178c5ba6852 100644 > > > > > > > > --- a/block/blk.h > > > > > > > > +++ b/block/blk.h > > > > > > > > @@ -571,6 +571,7 @@ blk_mode_t file_to_blk_mode(struct file *file); > > > > > > > > int truncate_bdev_range(struct block_device *bdev, blk_mode_t mode, > > > > > > > > loff_t lstart, loff_t lend); > > > > > > > > long blkdev_ioctl(struct file *file, unsigned cmd, unsigned long arg); > > > > > > > > +int blkdev_uring_cmd(struct io_uring_cmd *cmd, unsigned int issue_flags); > > > > > > > > long compat_blkdev_ioctl(struct file *file, unsigned cmd, unsigned long arg); > > > > > > > > > > > > > > > > extern const struct address_space_operations def_blk_aops; > > > > > > > > diff --git a/block/fops.c b/block/fops.c > > > > > > > > index 9825c1713a49..8154b10b5abf 100644 > > > > > > > > --- a/block/fops.c > > > > > > > > +++ b/block/fops.c > > > > > > > > @@ -17,6 +17,7 @@ > > > > > > > > #include > > > > > > > > #include > > > > > > > > #include > > > > > > > > +#include > > > > > > > > #include "blk.h" > > > > > > > > > > > > > > > > static inline struct inode *bdev_file_inode(struct file *file) > > > > > > > > @@ -873,6 +874,7 @@ const struct file_operations def_blk_fops = { > > > > > > > > .splice_read = filemap_splice_read, > > > > > > > > .splice_write = iter_file_splice_write, > > > > > > > > .fallocate = blkdev_fallocate, > > > > > > > > + .uring_cmd = blkdev_uring_cmd, > > > > > > > > > > > > > > Just be curious, we have IORING_OP_FALLOCATE already for sending > > > > > > > discard to block device, why is .uring_cmd added for this purpose? > > > > > > > > > > Which is a good question, I haven't thought about it, but I tend to > > > > > agree with Jens. Because vfs_fallocate is created synchronous > > > > > IORING_OP_FALLOCATE is slow for anything but pretty large requests. > > > > > Probably can be patched up, which would involve changing the > > > > > fops->fallocate protot, but I'm not sure async there makes sense > > > > > outside of bdev (?), and cmd approach is simpler, can be made > > > > > somewhat more efficient (1 less layer in the way), and it's not > > > > > really something completely new since we have it in ioctl. > > > > > > > > Yeah, we have ioctl(DISCARD), which acquires filemap_invalidate_lock, > > > > same with blkdev_fallocate(). > > > > > > > > But this patch drops this exclusive lock, so it becomes async friendly, > > > > but may cause stale page cache. However, if the lock is required, it can't > > > > be efficient anymore and io-wq may be inevitable, :-) > > > > > > If you want to grab the lock, you can still opportunistically grab it. > > > For (by far) the common case, you'll get it, and you can still do it > > > inline. > > > > If the lock is grabbed in the whole cmd lifetime, it is basically one sync > > interface cause there is at most one async discard cmd in-flight for each > > device. > > > > Meantime the handling has to move to io-wq for avoiding to block current > > context, the interface becomes same with IORING_OP_FALLOCATE? > > Right, and agree that we can't trylock because we'd need to keep it > locked until IO completes, at least the sync versions does that. > > But I think *invalidate_pages() in the patch should be enough. That's > what the write path does, so it shouldn't cause any problem to the > kernel. As for user space, that'd be more relaxed than the ioctl, > just as writes are, so nothing new to the user. I hope someone with > better filemap understanding can confirm it (or not). I may not be familiar with filemap enough, but looks *invalidate_pages() is only for removing pages from the page cache range, and the lock is added for preventing new page cache read from being started, so stale data read can be avoided when DISCARD is in-progress. Thanks, Ming